[PATCH 11/12] qla2xxx: Add new FW dump template entry types

From: Joe Carnuccio This patch adds new firmware dump template entries for ISP27XX firmware dump. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 191 +--- drivers/scsi/qla2xxx/qla_tmpl.h | 26 +- 2

[PATCH 12/12] qla2xxx: Update driver version to 10.00.00.14-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 537098e8f1c1..0690dac24081 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v2 04/12] qla2xxx: Check for FW started flag before aborting

For FC-NVMe, if the fw_started flag is not set or fcport is deleted, then do not send Abort command Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c

[PATCH v2 07/12] qla2xxx: Prevent SysFS access when chip is down

From: Quinn Tran Prevent user from sending commands through SysFS while FW is not running or reset is in progress. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/qla2xxx

[PATCH v2 01/12] qla2xxx: Fix LUN discovery if loop id is not assigned yet by firmware

ned-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 8307eac796a2..cdf57eb643b3 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/dr

[PATCH v2 00/12] qla2xxx: Misc bug fixes for the driver

sed in patch #7 Thanks, Himanshu Anil Gurumurthy (1): qla2xxx: Add support for setting port speed Darren Trapp (1): qla2xxx: Add First Burst support for FC-NVMe devices Himanshu Madhani (5): qla2xxx: Fix LUN discovery if loop id is not assigned yet by firmware qla2xxx: Fix unload when N

[PATCH v2 05/12] qla2xxx: Prevent multiple ADISC commands per session

From: Quinn Tran add check to allow 1 discovery command per session to be sent. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers

[PATCH v2 08/12] qla2xxx: Add workqueue to delete fcport from bsg sp->free().

From: Joe Carnuccio This patch adds workqueue mechanism for deleting fcport via BSG interface. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 18 +- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_os.c | 11

[PATCH v2 02/12] qla2xxx: Add First Burst support for FC-NVMe devices

From: Darren Trapp Add Support for First Burst for FC-NVMe protocol. This feature requires First Burst support in the firmware. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 4 drivers/scsi/qla2xxx/qla_init.c | 6 ++ drivers/scsi

[PATCH v2 03/12] qla2xxx: Fix unload when NVMe devices are configured

This patch fixes driver unload issue when FC-NVMe devices are configured. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx

[PATCH v2 10/12] qla2xxx: Fix code indentation for qla27xx_fwdt_entry

This patch fixes following checkpatch ERROR ERROR: space prohibited before that ',' (ctx:WxW) No change is functionality due to this patch. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 46 - 1 file changed, 23 inserti

[PATCH v2 06/12] qla2xxx: Add support for setting port speed

-off-by: Anil Gurumurthy Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 103 drivers/scsi/qla2xxx/qla_def.h | 6 +++ drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_init.c | 9

[PATCH v2 12/12] qla2xxx: Update driver version to 10.00.00.14-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 537098e8f1c1..0690dac24081 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v2 09/12] qla2xxx: Move marker request behind QPair

From: Quinn Tran current code hard code marker request to use request and response queue 0. This patch make use of the qpair as the path to access the request/response queues. It allows marker to be place on any hardware queues. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH v2 11/12] qla2xxx: Add new FW dump template entry types

From: Joe Carnuccio This patch adds new firmware dump template entries for ISP27XX firmware dump. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 191 +--- drivers/scsi/qla2xxx/qla_tmpl.h | 26 +- 2

Re: [PATCH] Move debug messages before sending srb preventing panic

/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -660,14 +660,14 @@ int qla24xx_async_notify_ack(scsi_qla_host_t *vha, fc_port_t *fcport, sp->u.iocb_cmd.u.nack.ntfy = ntfy; sp->done = qla2x00_async_nack_sp_done; - rval = qla2x00_start_sp(sp); - if (rval != QLA_SUCCESS) - goto done_free_sp; - ql_dbg(ql_dbg_disc, vha, 0x20f4, "Async-%s %8phC hndl %x %s\n", sp->name, fcport->port_name, sp->handle, c); + rval = qla2x00_start_sp(sp); + if (rval != QLA_SUCCESS) + goto done_free_sp; + return rval; done_free_sp: -- 1.8.3.1 Thanks for the patch. Looks good. Acked-By: Himanshu Madhani

Re: [PATCH v2 06/12] qla2xxx: Add support for setting port speed

Hi Bart, On 2/13/19, 4:55 PM, "Bart Van Assche" wrote: On Wed, 2019-02-13 at 10:53 -0800, Himanshu Madhani wrote: > static ssize_t > +qla2x00_sysfs_set_port_speed(struct file *filp, struct kobject *kobj, > +struct bin_attribute *bin_attr, char *buf,

Re: [EXT] Re: [PATCH v2 08/12] qla2xxx: Add workqueue to delete fcport from bsg sp->free().

Hi Bart, On 2/13/19, 4:57 PM, "Bart Van Assche" wrote: External Email -- On Wed, 2019-02-13 at 10:53 -0800, Himanshu Madhani wrote: > + ha->free_fcport = create_workqueue("free_fcpo

Re: [PATCH][V2] scsi: qla2xxx: remove redundant null check on pointer sess

_send_term_exchange(ha->base_qpair, NULL, &prm->tm_iocb2, 1, 0); -- 2.20.1 Thanks for the Patch. Looks good Acked-by: Himanshu Madhani

[PATCH v3 09/11] qla2xxx: Fix code indentation for qla27xx_fwdt_entry

This patch fixes following checkpatch ERROR ERROR: space prohibited before that ',' (ctx:WxW) No change is functionality due to this patch. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 46 - 1 file changed, 23 inserti

[PATCH v3 10/11] qla2xxx: Add new FW dump template entry types

From: Joe Carnuccio This patch adds new firmware dump template entries for ISP27XX firmware dump. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 191 +--- drivers/scsi/qla2xxx/qla_tmpl.h | 26 +- 2

[PATCH v3 07/11] qla2xxx: Prevent SysFS access when chip is down

From: Quinn Tran Prevent user from sending commands through SysFS while FW is not running or reset is in progress. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/qla2xxx

[PATCH v3 06/11] qla2xxx: Add support for setting port speed

-off-by: Anil Gurumurthy Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 89 + drivers/scsi/qla2xxx/qla_def.h | 6 +++ drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_init.c | 9

[PATCH v3 00/11] qla2xxx: Misc bug fixes for the driver

as not acquired and not released in patch #7 Thanks, Himanshu Anil Gurumurthy (1): qla2xxx: Add support for setting port speed Darren Trapp (1): qla2xxx: Add First Burst support for FC-NVMe devices Himanshu Madhani (5): qla2xxx: Fix LUN discovery if loop id is not assigned yet by fi

[PATCH v3 01/11] qla2xxx: Fix LUN discovery if loop id is not assigned yet by firmware

ned-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 8307eac796a2..cdf57eb643b3 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/dr

[PATCH v3 02/11] qla2xxx: Add First Burst support for FC-NVMe devices

From: Darren Trapp Add Support for First Burst for FC-NVMe protocol. This feature requires First Burst support in the firmware. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 4 drivers/scsi/qla2xxx/qla_init.c | 6 ++ drivers/scsi

[PATCH v3 05/11] qla2xxx: Prevent multiple ADISC commands per session

From: Quinn Tran add check to allow 1 discovery command per session to be sent. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers

[PATCH v3 11/11] qla2xxx: Update driver version to 10.00.00.14-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 537098e8f1c1..0690dac24081 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH v3 08/11] qla2xxx: Move marker request behind QPair

From: Quinn Tran current code hard code marker request to use request and response queue 0. This patch make use of the qpair as the path to access the request/response queues. It allows marker to be place on any hardware queues. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH v3 04/11] qla2xxx: Check for FW started flag before aborting

For FC-NVMe, if the fw_started flag is not set or fcport is deleted, then do not send Abort command Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c

[PATCH v3 03/11] qla2xxx: Fix unload when NVMe devices are configured

This patch fixes driver unload issue when FC-NVMe devices are configured. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx

[PATCH] qla2xxx: Avoid PCI IRQ affinity mapping when multiqueue is not supported.

pci_alloc_irq_vectors() call instead of pci_alloc_irq_affinity(). Fixes: f664a3cc17b7d ("scsi: kill off the legacy IO path") Cc: sta...@vger.kernel.org #4.19 Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- Hi Martin, This patch fixes issue, if BLK-MQ is enabled, driver wi

Re: qla2xxx init warning with blk_mq at drivers/pci/msi.c:1273 pci_irq_get_affinity+0xf4/0x120

Hi Meelis, On 2/12/19, 6:37 PM, "Ming Lei" wrote: External Email On Wed, Feb 13, 2019 at 5:36 AM Meelis Roos wrote: > > > I tested todays 5.0.0-rc5-00358-gdf3865f on my sparcs and a couple of servers that have qla2xxx > > FC adapter gave me this warning:

Re: [PATCH] qla2xxx: Fix panic in qla_dfs_tgt_counters_show

[i]; + if (!qpair) + continue; qla_core_sbt_cmd += qpair->tgt_counters.qla_core_sbt_cmd; core_qla_que_buf += qpair->tgt_counters.core_qla_que_buf; qla_core_ret_ctio += qpair->tgt_counters.qla_core_ret_ctio; Looks Good. Acked-by: Himanshu Madhani -- 1.8.3.1

Re: [PATCH 3/4] scsi: qla2xxx: avoid printf format warning

(ql_dbg_tgt + ql_dbg_verbose, vha, 0xe023, "%s: sg[%x] (phys=%llx sglen=%x) ldma_sg_len: %x dif_bundl_len: %x ldma_needed: %x\n", - __func__, i, sg_phys(sg), sglen, ldma_sg_len, + __func__, i, (u64)sg_phys(sg), sglen, ldma_sg_len, difctx->dif_bundl_len, ldma_needed); while (sglen) { -- 2.20.0 Looks good Acked-by: Himanshu Madhani

[PATCH 02/14] qla2xxx: Remove FW default template

From: Joe Carnuccio This patch removed FW default template as there will never be case where the default template would be invoked. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 2 - drivers/scsi/qla2xxx/qla_init.c | 94

[PATCH 06/14] qla2xxx: Correctly report max/min supported speeds

From: Joe Carnuccio This patch fixes reported speed for min_link and max_supported speed. Also rename SysFS nodes link_speed and max_supported to be consistent with {min|max}_suuported_speed. Signed-off-by: Joe Carnuccio Signed-off-by: Mike Hernandez Signed-off-by: Himanshu Madhani

[PATCH 03/14] qla2xxx: Fix routine qla27xx_dump_{mpi|ram}().

From: Joe Carnuccio This patch fixes qla27xx_dump_{mpi|ram} api for ISP27XX Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 166 - 1 file changed, 81 insertions(+), 85 deletions(-) diff --git a/drivers

[PATCH 11/14] qla2xxx: Simplification of register address used in qla_tmpl.c

From: Joe Carnuccio Reduce stack space on each fwdt routine by eliminating local variable reg. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 75 - 1 file changed, 29 insertions(+), 46 deletions

[PATCH 01/14] qla2xxx: Add fw_attr and port_no SysFS node

From: Joe Carnuccio This patch adds new SysFS node to display firmware attributes and port number Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/scsi

[PATCH 12/14] qla2xxx: Add 28xx flash primary/secondary status/image mechanism

-off-by: Joe Carnuccio Signed-off-by: Mike Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 34 - drivers/scsi/qla2xxx/qla_bsg.c | 42 + drivers/scsi/qla2xxx/qla_bsg.h | 11 ++ drivers/scsi/qla2xxx/qla_def.h | 63 +--- drivers/scsi/qla2xxx

[PATCH 00/14] qla2xxx: Add support for ISP28XX (Gen7) adapter

new feature. Patch 12 adds support for Primary/Secondary firmware images in the flash. Patch 13 adds capability for secure flash update for ISP28XX (Gen7) adapter. Please consider this series for 5.2/scsi-queue branch at your earliest convenience. Thanks, Himanshu Himanshu Madhani (1): qla2xxx

[PATCH 10/14] qla2xxx: Correction and improvement to fwdt processing

From: Joe Carnuccio This patch cleans up and fixes firmware dump template processing. These changes are added to support newer features for ISP27XX/ISP28XX. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 51

[PATCH 14/14] qla2xxx: Update driver version to 10.01.00.15-k

This version Includes support for ISP28XX Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 0690dac24081..0f8cca27c183

[PATCH 09/14] qla2xxx: Update flash read/write routine

From: Joe Carnuccio This patch made following changes to flash access routines - updated return type for read_optrom - use void instead of uint32_t * for buffer parameter in read and write optrom routines - Fix flash/nvram addressing. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu

[PATCH 13/14] qla2xxx: Secure flash update support for ISP28XX

From: Michael Hernandez This patch adds support for Secure flash update with ISP28xx Signed-off-by: Michael Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 31 +++- drivers/scsi/qla2xxx/qla_fw.h | 8 + drivers/scsi/qla2xxx/qla_gbl.h | 22 ++- drivers

[PATCH 04/14] qla2xxx: Add Device ID for ISP28XX

From: Joe Carnuccio This patch adds PCI device ID ISP28XX for Gen7 support. Also signature determination for primary/secondary flash image for ISP27XX/28XX is aded as part of Gen7 support. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 30

[PATCH 08/14] qla2xxx: Add support for multiple fwdump templates/segments

From: Joe Carnuccio This patch adds multipe firmware dump template and segments support for ISP27XX/28XX. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 3 +- drivers/scsi/qla2xxx/qla_def.h | 9 +- drivers/scsi/qla2xxx/qla_gbl.h | 2

[PATCH 05/14] qla2xxx: Add Serdes support for ISP28XX

From: Joe Carnuccio This patch adds SysFS node for serdes_version and also cleans up port_speed display. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 43 +-- drivers/scsi/qla2xxx/qla_def.h | 4 ++- drivers/scsi

[PATCH 07/14] qla2xxx: Cleanups for NVRAM/Flash read/write path

. - Simplify ql_dump_buffer() interface usage. - Add endianizers to 27xx firmware image validator. - fixes compiler warnings for big endian architecture. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 6 +- drivers/scsi/qla2xxx/qla_dbg.c

[PATCH v2 07/14] qla2xxx: Cleanups for NVRAM/Flash read/write path

. - Simplify ql_dump_buffer() interface usage. - Add endianizers to 27xx firmware image validator. - fixes compiler warnings for big endian architecture. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani qla2xxx: Fix sparse warnings in qla_tmpl.c Signed-off-by: Himanshu Madhani

[PATCH v2 12/14] qla2xxx: Add 28xx flash primary/secondary status/image mechanism

-off-by: Joe Carnuccio Signed-off-by: Mike Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 34 - drivers/scsi/qla2xxx/qla_bsg.c | 42 + drivers/scsi/qla2xxx/qla_bsg.h | 11 ++ drivers/scsi/qla2xxx/qla_def.h | 63 +--- drivers/scsi/qla2xxx

[PATCH v2 06/14] qla2xxx: Correctly report max/min supported speeds

From: Joe Carnuccio This patch fixes reported speed for min_link and max_supported speed. Also rename SysFS nodes link_speed and max_supported to be consistent with {min|max}_suuported_speed. Signed-off-by: Joe Carnuccio Signed-off-by: Mike Hernandez Signed-off-by: Himanshu Madhani

[PATCH v2 08/14] qla2xxx: Add support for multiple fwdump templates/segments

From: Joe Carnuccio This patch adds multipe firmware dump template and segments support for ISP27XX/28XX. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 3 +- drivers/scsi/qla2xxx/qla_def.h | 9 +- drivers/scsi/qla2xxx/qla_gbl.h | 2

[PATCH v2 11/14] qla2xxx: Simplification of register address used in qla_tmpl.c

From: Joe Carnuccio Reduce stack space on each fwdt routine by eliminating local variable reg. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 75 - 1 file changed, 29 insertions(+), 46 deletions

[PATCH v2 09/14] qla2xxx: Update flash read/write routine

From: Joe Carnuccio This patch made following changes to flash access routines - updated return type for read_optrom - use void instead of uint32_t * for buffer parameter in read and write optrom routines - Fix flash/nvram addressing. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu

[PATCH v2 13/14] qla2xxx: Secure flash update support for ISP28XX

From: Michael Hernandez This patch adds support for Secure flash update with ISP28xx Signed-off-by: Michael Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 31 +++- drivers/scsi/qla2xxx/qla_fw.h | 8 + drivers/scsi/qla2xxx/qla_gbl.h | 22 ++- drivers

[PATCH v2 05/14] qla2xxx: Add Serdes support for ISP28XX

From: Joe Carnuccio This patch adds SysFS node for serdes_version and also cleans up port_speed display. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 43 +-- drivers/scsi/qla2xxx/qla_def.h | 4 ++- drivers/scsi

[PATCH v2 10/14] qla2xxx: Correction and improvement to fwdt processing

From: Joe Carnuccio This patch cleans up and fixes firmware dump template processing. These changes are added to support newer features for ISP27XX/ISP28XX. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 43

[PATCH v2 02/14] qla2xxx: Remove FW default template

From: Joe Carnuccio This patch removed FW default template as there will never be case where the default template would be invoked. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 2 - drivers/scsi/qla2xxx/qla_init.c | 94

[PATCH v2 04/14] qla2xxx: Add Device ID for ISP28XX

From: Joe Carnuccio This patch adds PCI device ID ISP28XX for Gen7 support. Also signature determination for primary/secondary flash image for ISP27XX/28XX is aded as part of Gen7 support. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 30

[PATCH v2 00/14] qla2xxx: Add support for ISP28XX (Gen7) adapter

ngs for patch #7, #8, #9 Thanks, Himanshu Himanshu Madhani (1): qla2xxx: Update driver version to 10.01.00.15-k Joe Carnuccio (12): qla2xxx: Add fw_attr and port_no SysFS node qla2xxx: Remove FW default template qla2xxx: Fix routine qla27xx_dump_{mpi|ram}(). qla2xxx: Add Device ID

[PATCH v2 01/14] qla2xxx: Add fw_attr and port_no SysFS node

From: Joe Carnuccio This patch adds new SysFS node to display firmware attributes and port number Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/scsi

[PATCH v2 14/14] qla2xxx: Update driver version to 10.01.00.15-k

This version Includes support for ISP28XX Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 0690dac24081..0f8cca27c183

[PATCH v2 03/14] qla2xxx: Fix routine qla27xx_dump_{mpi|ram}().

From: Joe Carnuccio This patch fixes qla27xx_dump_{mpi|ram} api for ISP27XX Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 166 - 1 file changed, 81 insertions(+), 85 deletions(-) diff --git a/drivers

[PATCH v3 00/14] qla2xxx: Add support for ISP28XX (Gen7) adapter

nel warnings for patch #7 and #8. Changes from v1 -> v2 o Fixed 0-day kernel warnings for patch #7, #8, #9. Thanks, Himanshu Himanshu Madhani (1): qla2xxx: Update driver version to 10.01.00.15-k Joe Carnuccio (12): qla2xxx: Add fw_attr and port_no SysFS node qla2xxx: Remove FW default te

[PATCH v3 02/14] qla2xxx: Remove FW default template

From: Joe Carnuccio This patch removed FW default template as there will never be case where the default template would be invoked. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 2 - drivers/scsi/qla2xxx/qla_init.c | 94

[PATCH v3 03/14] qla2xxx: Fix routine qla27xx_dump_{mpi|ram}().

From: Joe Carnuccio This patch fixes qla27xx_dump_{mpi|ram} api for ISP27XX Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 166 - 1 file changed, 81 insertions(+), 85 deletions(-) diff --git a/drivers

[PATCH v3 05/14] qla2xxx: Add Serdes support for ISP28XX

From: Joe Carnuccio This patch adds SysFS node for serdes_version and also cleans up port_speed display. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 43 +-- drivers/scsi/qla2xxx/qla_def.h | 4 ++- drivers/scsi

[PATCH v3 06/14] qla2xxx: Correctly report max/min supported speeds

From: Joe Carnuccio This patch fixes reported speed for min_link and max_supported speed. Also rename SysFS nodes link_speed and max_supported to be consistent with {min|max}_suuported_speed. Signed-off-by: Joe Carnuccio Signed-off-by: Mike Hernandez Signed-off-by: Himanshu Madhani

[PATCH v3 04/14] qla2xxx: Add Device ID for ISP28XX

From: Joe Carnuccio This patch adds PCI device ID ISP28XX for Gen7 support. Also signature determination for primary/secondary flash image for ISP27XX/28XX is aded as part of Gen7 support. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 30

[PATCH v3 14/14] qla2xxx: Update driver version to 10.01.00.15-k

This version Includes support for ISP28XX Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 0690dac24081..0f8cca27c183

[PATCH v3 09/14] qla2xxx: Update flash read/write routine

From: Joe Carnuccio This patch made following changes to flash access routines - updated return type for read_optrom - use void instead of uint32_t * for buffer parameter in read and write optrom routines - Fix flash/nvram addressing. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu

[PATCH v3 12/14] qla2xxx: Add 28xx flash primary/secondary status/image mechanism

-off-by: Joe Carnuccio Signed-off-by: Mike Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 34 - drivers/scsi/qla2xxx/qla_bsg.c | 42 + drivers/scsi/qla2xxx/qla_bsg.h | 11 ++ drivers/scsi/qla2xxx/qla_def.h | 63 +--- drivers/scsi/qla2xxx

[PATCH v3 10/14] qla2xxx: Correction and improvement to fwdt processing

From: Joe Carnuccio This patch cleans up and fixes firmware dump template processing. These changes are added to support newer features for ISP27XX/ISP28XX. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 43

[PATCH v3 13/14] qla2xxx: Secure flash update support for ISP28XX

From: Michael Hernandez This patch adds support for Secure flash update with ISP28xx Signed-off-by: Michael Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 31 +++- drivers/scsi/qla2xxx/qla_fw.h | 8 + drivers/scsi/qla2xxx/qla_gbl.h | 22 ++- drivers

[PATCH v3 08/14] qla2xxx: Add support for multiple fwdump templates/segments

From: Joe Carnuccio This patch adds multipe firmware dump template and segments support for ISP27XX/28XX. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 3 +- drivers/scsi/qla2xxx/qla_def.h | 9 +- drivers/scsi/qla2xxx/qla_gbl.h | 2

[PATCH v3 01/14] qla2xxx: Add fw_attr and port_no SysFS node

From: Joe Carnuccio This patch adds new SysFS node to display firmware attributes and port number Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/scsi

[PATCH v3 07/14] qla2xxx: Cleanups for NVRAM/Flash read/write path

. - Simplify ql_dump_buffer() interface usage. - Add endianizers to 27xx firmware image validator. - fixes compiler warnings for big endian architecture. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani qla2xxx: Fix sparse warnings in qla_tmpl.c Signed-off-by: Himanshu Madhani

[PATCH v3 11/14] qla2xxx: Simplification of register address used in qla_tmpl.c

From: Joe Carnuccio Reduce stack space on each fwdt routine by eliminating local variable reg. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 75 - 1 file changed, 29 insertions(+), 46 deletions

[PATCH v4 00/14] qla2xxx: Add support for ISP28XX (Gen7) adapter

day kernel warnings for patch#7 Changes from v2 -> v3 o Fixed more 0-day kernel warnings for patch #7 and #8. Changes from v1 -> v2 o Fixed 0-day kernel warnings for patch #7, #8, #9. Thanks, Himanshu Himanshu Madhani (1): qla2xxx: Update driver version to 10.01.00.15-k Joe Carnuccio (12):

[PATCH v4 04/14] qla2xxx: Add Device ID for ISP28XX

From: Joe Carnuccio This patch adds PCI device ID ISP28XX for Gen7 support. Also signature determination for primary/secondary flash image for ISP27XX/28XX is aded as part of Gen7 support. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 30

[PATCH v4 05/14] qla2xxx: Add Serdes support for ISP28XX

From: Joe Carnuccio This patch adds SysFS node for serdes_version and also cleans up port_speed display. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 43 +-- drivers/scsi/qla2xxx/qla_def.h | 4 ++- drivers/scsi

[PATCH v4 06/14] qla2xxx: Correctly report max/min supported speeds

From: Joe Carnuccio This patch fixes reported speed for min_link and max_supported speed. Also rename SysFS nodes link_speed and max_supported to be consistent with {min|max}_suuported_speed. Signed-off-by: Joe Carnuccio Signed-off-by: Mike Hernandez Signed-off-by: Himanshu Madhani

[PATCH v4 03/14] qla2xxx: Fix routine qla27xx_dump_{mpi|ram}().

From: Joe Carnuccio This patch fixes qla27xx_dump_{mpi|ram} api for ISP27XX Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 166 - 1 file changed, 81 insertions(+), 85 deletions(-) diff --git a/drivers

[PATCH v4 14/14] qla2xxx: Update driver version to 10.01.00.15-k

This version Includes support for ISP28XX Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 0690dac24081..0f8cca27c183

[PATCH v4 01/14] qla2xxx: Add fw_attr and port_no SysFS node

From: Joe Carnuccio This patch adds new SysFS node to display firmware attributes and port number Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/scsi

[PATCH v4 10/14] qla2xxx: Correction and improvement to fwdt processing

From: Joe Carnuccio This patch cleans up and fixes firmware dump template processing. These changes are added to support newer features for ISP27XX/ISP28XX. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 43

[PATCH v4 09/14] qla2xxx: Update flash read/write routine

From: Joe Carnuccio This patch made following changes to flash access routines - updated return type for read_optrom - use void instead of uint32_t * for buffer parameter in read and write optrom routines - Fix flash/nvram addressing. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu

[PATCH v4 11/14] qla2xxx: Simplification of register address used in qla_tmpl.c

From: Joe Carnuccio Reduce stack space on each fwdt routine by eliminating local variable reg. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 71 - 1 file changed, 27 insertions(+), 44 deletions

[PATCH v4 13/14] qla2xxx: Secure flash update support for ISP28XX

From: Michael Hernandez This patch adds support for Secure flash update with ISP28xx Signed-off-by: Michael Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 31 +++- drivers/scsi/qla2xxx/qla_fw.h | 8 + drivers/scsi/qla2xxx/qla_gbl.h | 22 ++- drivers

[PATCH v4 08/14] qla2xxx: Add support for multiple fwdump templates/segments

From: Joe Carnuccio This patch adds multipe firmware dump template and segments support for ISP27XX/28XX. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 3 +- drivers/scsi/qla2xxx/qla_def.h | 9 +- drivers/scsi/qla2xxx/qla_gbl.h | 2

[PATCH v4 12/14] qla2xxx: Add 28xx flash primary/secondary status/image mechanism

-off-by: Joe Carnuccio Signed-off-by: Mike Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 34 - drivers/scsi/qla2xxx/qla_bsg.c | 42 + drivers/scsi/qla2xxx/qla_bsg.h | 11 ++ drivers/scsi/qla2xxx/qla_def.h | 63 +--- drivers/scsi/qla2xxx

[PATCH v4 07/14] qla2xxx: Cleanups for NVRAM/Flash read/write path

. - Simplify ql_dump_buffer() interface usage. - Add endianizers to 27xx firmware image validator. - fixes compiler warnings for big endian architecture. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani qla2xxx: Fix sparse warnings in qla_tmpl.c Signed-off-by: Himanshu Madhani

[PATCH v4 02/14] qla2xxx: Remove FW default template

From: Joe Carnuccio This patch removed FW default template as there will never be case where the default template would be invoked. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gbl.h | 2 - drivers/scsi/qla2xxx/qla_init.c | 94

[PATCH 0/2] qla2xxx: fixes for qla2xxx

Hi Martin, These are couple bug fixes for system crash and Target discovery failure for qla2xxx driver. Please apply them to 5.1/scsi-fixes branch at your earliest convenience. Thanks, Himanshu Himanshu Madhani (1): qla2xxx: Fix NULL pointer crash due to stale CPUID Quinn Tran (1

[PATCH 1/2] qla2xxx: Fix FC-AL connection target discovery

arget discovery with Local loop") Cc: sta...@vger.kernel.org # 5.0+ Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_in

[PATCH 2/2] qla2xxx: Fix NULL pointer crash due to stale CPUID

[ 70.327335] CR2: 0040 Fixes: 9cf2bab630765 ("block: kill request ->cpu member") Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c i

Re: [PATCH 2/2] qla2xxx: Fix NULL pointer crash due to stale CPUID

Hi Ewan, On 3/18/19, 6:36 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Ewan D. Milne" wrote: On Fri, 2019-03-15 at 15:04 -0700, Himanshu Madhani wrote: > This patch fixes crash due to NULL pointer derefrence because > CPU pointer is not set and used by

Re: [EXT] Re: [PATCH v4 09/14] qla2xxx: Update flash read/write routine

On 3/19/19, 11:26 PM, "Nathan Chancellor" wrote: External Email -- On Tue, Mar 12, 2019 at 11:08:18AM -0700, Himanshu Madhani wrote: > From: Joe Carnuccio > > This patch mad

<    1   2   3   4   5   6   7   8   9   10   >