the update of the cached command room has been
> simplified and also protected using a spin lock which is held until the
> MMIO is complete. This ensures the command room is properly consumed by
> the same thread. Update of cached value also takes into account the
> current thread con
Acked-by: Matthew R. Ochs
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
g
>
> The resolution to this problem is to have the reset handler drain all
> outstanding user space initiated ioctls before proceeding. It is safe
> to drain after the state has been changed to STATE_RESET. Also since
> drain_ioctls() was static, it had to be moved up a bit to be before
he future to
> support various device specific functions.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t; is removed in the PCI remove path, notification code will
> wait for shutdown processing to complete.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@v
sh which is
> only used if CXL_EEH isn't defined (i.e. never).
>
> Suggested-by: Ian Munsie
> Signed-off-by: Andrew Donnellan
Acked-by: Matthew R. Ochs
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...
ash cards").
>
> As a fix, shutdown notification should only occur when the AFU is mapped.
>
> Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards")
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
--
To unsubscribe fro
> On Jul 21, 2016, at 3:44 PM, Uma Krishnan wrote:
>
> Adding myself as a cxlflash maintainer.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to major
alongside the modifications.
The series is based upon 4.8-rc1, intended for 4.9, and is bisectable.
Matthew R. Ochs (6):
cxlflash: Avoid mutex when destroying context
cxlflash: Cache owning adapter within context
cxlflash: Add kref to context
cxlflash: Transition to application close model
reference as the sole parameter, another means
is needed to derive the owning adapter.
As a remedy, the owning adapter reference is saved off within the
context during initialization.
Signed-off-by: Matthew R. Ochs
---
drivers/scsi/cxlflash/superpipe.c | 1 +
drivers/scsi/cxlflash/superpipe.h | 1 +
2
bug injection.
To improve code comprehension and better protect against future bugs, add
explicit reference counting to contexts and migrate the context removal
code to the kref release handler.
Inspired-by: Al Viro
Signed-off-by: Matthew R. Ochs
---
drivers/scsi/cxlflash/superpipe.c | 87
Update the block library link in the API documentation.
Signed-off-by: Matthew R. Ochs
---
Documentation/powerpc/cxlflash.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/powerpc/cxlflash.txt
b/Documentation/powerpc/cxlflash.txt
index f4c1190..6d9a2ed
these context management paths are superfluous.
This commit removes the obtaining of the context mutex in the context
initialization routine and assumes the mutex is not held in the context
free path.
Inspired-by: Al Viro
Signed-off-by: Matthew R. Ochs
---
drivers/scsi/cxlflash/superpipe.c | 26
responsible for the
close following the cleanup (detach) of a context. The documentation
is also updated to reflect this change in behavior.
Inspired-by: Al Viro
Signed-off-by: Matthew R. Ochs
---
Documentation/powerpc/cxlflash.txt | 42 +++---
drivers/scsi/cxlflash/superpipe.c | 71
-by: Matthew R. Ochs
---
drivers/scsi/cxlflash/superpipe.c | 26 +-
drivers/scsi/cxlflash/superpipe.h | 1 -
2 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/cxlflash/superpipe.c
b/drivers/scsi/cxlflash/superpipe.c
index b3bb90d..c91fe6f
lization with enqueue
> operations, move to only a single lock that is used for enqueueing
> regardless of the queueing model.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
se to the
> caller.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
avoid this situation, context reset failures will be escalated to a host
> reset operation. This will be done asynchronously to allow the acting
> thread to return to the user with a failure.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
single command to better reflect that the entire
> queue associated with the context is impacted by the reset.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
gt; can be retried.
>
> Once the card has been quiesced, the hardware send queue lock is acquired
> to prevent any data movement while the pending commands are processed.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
reflect behavior in the event of an AFU sync
> failure.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
s
> encountered. Additionally, it does not allow for commands to be properly
> retried.
>
> In order to avoid this problem and to better handle error path command
> cleanup, introduce a linked list for each hardware queue that tracks
> pending commands.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
d abort requests.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
Hi Hannes,
We actually just reworked these paths in a series that
was pulled in on Monday. While testing, I came across a
bug in that series and was planning on sending out a fix
for it. I'll include some patches that will ease the burden
of incorporating your EH updates for cxlflash.
Many thanks
This small series fixes a recently injected double free and also includes
two patches to refactor the host and reset handlers to ease the burden of
making this driver compatible with an updated SCSI EH framework.
This series is intended for 4.13 and is bisectable.
Matthew R. Ochs (3):
cxlflash
associated CDB. This
is not necessary as the SCSI command is simply the messenger in
these scenarios.
Refactor the debug prints in the host and reset handlers to only
present information that is applicable given the function scope.
Signed-off-by: Matthew R. Ochs
---
drivers/scsi/cxlflash/main.c
a nice side effect, this will ease the
burden of converting caller routines to be based solely off of a SCSI
device reference.
Signed-off-by: Matthew R. Ochs
---
drivers/scsi/cxlflash/main.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers
ement interface")
Signed-off-by: Matthew R. Ochs
---
drivers/scsi/cxlflash/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index 7a787b6..455564f 100644
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash/main.c
@@ -92
-by: Dan Carpenter
Good catch Dan!
Acked-by: Matthew R. Ochs
> On Aug 15, 2017, at 3:18 PM, Christophe JAILLET
> wrote:
>
> 'rc' is known to be 0 at this point.
> If 'create_context()' fails, returns -ENOMEM instead of 0 which means
> success.
>
> Signed-off-by: Christophe JAILLET
Yep, that's a bug.
Acked-by: Matthew R. Ochs
r IO failure.
>
> To fix the issue, clear the ioasc before queuing any command.
>
> Fixes: 479ad8e9d48c ("scsi: cxlflash: Remove zeroing of private command
> data")
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
On Thu, Jan 04, 2018 at 05:33:48PM +1100, Andrew Donnellan wrote:
> On 04/01/18 09:54, Uma Krishnan wrote:
> >In the event of a command failure, cxlflash returns the failure to the
> >upper layers to process. After processing the error, when the command is
> >queued again, the private command struc
On Wed, Jan 03, 2018 at 04:54:25PM -0600, Uma Krishnan wrote:
> Convert cxl-specific pointers to generic cookies to facilitate future
> enhancements.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
On Wed, Jan 03, 2018 at 04:55:04PM -0600, Uma Krishnan wrote:
> Adapter context creation can return either NULL or an error pointer.
> Updating the check condition to reflect this.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
On Tue, Feb 20, 2018 at 07:56:35PM +1100, Michael Ellerman wrote:
> Vaibhav Jain writes:
>
> > The cxlflash driver uses "Asynchronous SCSI scanning" enabled by
> > CONFIG_SCSI_SCAN_ASYNC. Without this enabled the modprobe of cxlflash
> > module gets hung with following backtrace:
> >
> > Call Tra
eries and agree that the OpenCXL terminology
should be consistent throughout the kernel.
So...contingent upon a V2 with OpenCXL references being replaced by OCXL:
Acked-by: Matthew R. Ochs
>
> Matthew R. Ochs (1):
> cxlflash: Avoid clobbering context control register value
>
> U
evice state and yield to any active reset or probing threads.
>
> Signed-off-by: Uma Krishnan
Looks good!
Acked-by: Matthew R. Ochs
ing command list
> before freeing the buffer.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
lem, a boolean will indicate if the hardware queue is
> ready to process interrupts or not. This can be evaluated in the interrupt
> handler before proessing an interrupt.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
The uapi header file listed in the cxlflash stanza has a typo.
Removed the trailing 's' from the filename.
Reported-by: Joe Perches
Signed-off-by: Matthew R. Ochs
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
ind
> On Apr 13, 2017, at 1:27 AM, Andrew Donnellan
> wrote:
>
> On 13/04/17 05:14, Uma Krishnan wrote:
>> From: "Matthew R. Ochs"
>>
>> An EEH during probe can lead to a crash as the recovery thread races
>> with the probe thread. To avoid this i
y
> embedded in the AFU. This will be transitioned to a dynamic allocation in a
> later series to improve the memory footprint of the driver.
>
> Signed-off-by: Uma Krishnan
Looks good!
Acked-by: Matthew R. Ochs
" [drivers/scsi/cxlflash/cxlflash.ko] undefined!
> ERROR: ".irq_poll_disable" [drivers/scsi/cxlflash/cxlflash.ko] undefined!
> ERROR: ".irq_poll_init" [drivers/scsi/cxlflash/cxlflash.ko] undefined!
>
> Fixes: cba06e6de403 ("scsi: cxlflash: Implement IRQ polling for RRQ
> processing")
> Signed-off-by: Guenter Roeck
Acked-by: Matthew R. Ochs
ondition
> that can lead to the Oops above.
>
> During a device reset, the AFU should not be unmapped until all the active
> send threads quiesce. An atomic counter, cmds_active, is currently used to
> track internal AFU commands and quiesce during reset. This same counter can
> als
bug issues that involve command
> tracking, the abundance of data can overwrite other useful data in the
> log. The best option available is to limit the messages that should
> serve most of the common use cases.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
, leading
> to the hang.
>
> To support the current design point of holding the semaphore on the
> ioctl() paths, the release fop should acquire it before invoking any
> ioctl services.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
On Fri, May 11, 2018 at 02:05:51PM -0500, Uma Krishnan wrote:
> The new header file, backend.h, that was recently added is missing
> the include guards. This commit adds the guards.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
f
> to avoid compilation errors.
>
> Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
On Tue, May 22, 2018 at 11:15:08AM -0700, Kees Cook wrote:
> This removes the unused sense buffer in read_cap16() and write_same16().
>
> Signed-off-by: Kees Cook
Looks good.
Acked-by: Matthew R. Ochs
anks for catching this Cedric!
Acked-by: Matthew R. Ochs
401 - 452 of 452 matches
Mail list logo