Re: [linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-11 Thread Mark Brown
On Tue, Mar 11, 2014 at 10:06:59PM +0100, Carlo Caione wrote: > On Tue, Mar 11, 2014 at 07:29:40PM +, Mark Brown wrote: > > With the above code the driver will return an error and never get as far > > as registering the regulator. > I agree, but if I register the regulators without having the

Re: [linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-11 Thread Carlo Caione
On Tue, Mar 11, 2014 at 07:29:40PM +, Mark Brown wrote: > On Tue, Mar 11, 2014 at 08:24:11PM +0100, Carlo Caione wrote: > > On Mon, Mar 03, 2014 at 10:56:16AM +0900, Mark Brown wrote: > > > > > + regulators = of_find_node_by_name(np, "regulators"); > > > > + if (!regulators) { > >

Re: [linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-11 Thread Mark Brown
On Tue, Mar 11, 2014 at 08:24:11PM +0100, Carlo Caione wrote: > On Mon, Mar 03, 2014 at 10:56:16AM +0900, Mark Brown wrote: > > > + regulators = of_find_node_by_name(np, "regulators"); > > > + if (!regulators) { > > > + dev_err(&pdev->dev, "regulators node not found\n"); > > > + re

Re: [linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-11 Thread Carlo Caione
On Mon, Mar 03, 2014 at 10:56:16AM +0900, Mark Brown wrote: > > + np = of_node_get(pdev->dev.parent->of_node); > > + if (!np) > > + return 0; > > + > > + regulators = of_find_node_by_name(np, "regulators"); > > + if (!regulators) { > > + dev_err(&pdev->dev, "regulato

Re: [linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-09 Thread Carlo Caione
On Sun, Mar 09, 2014 at 07:51:48AM +, Mark Brown wrote: > On Sat, Mar 08, 2014 at 12:43:04PM +0100, Carlo Caione wrote: > > On Fri, Mar 7, 2014 at 7:22 PM, Maxime Ripard > > > On Sat, Mar 01, 2014 at 05:45:51PM +0100, Carlo Caione wrote: > > > >> + return platform_driver_register(&axp20x_r

Re: [linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-08 Thread Mark Brown
On Sat, Mar 08, 2014 at 12:43:04PM +0100, Carlo Caione wrote: > On Fri, Mar 7, 2014 at 7:22 PM, Maxime Ripard > > On Sat, Mar 01, 2014 at 05:45:51PM +0100, Carlo Caione wrote: > >> + return platform_driver_register(&axp20x_regulator_driver); > > I thought the AXP was only connected through I2

Re: [linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-08 Thread Carlo Caione
On Fri, Mar 7, 2014 at 7:22 PM, Maxime Ripard wrote: > On Sat, Mar 01, 2014 at 05:45:51PM +0100, Carlo Caione wrote: >> +static struct platform_driver axp20x_regulator_driver = { >> + .probe = axp20x_regulator_probe, >> + .remove = axp20x_regulator_remove, >> + .driver = { >> +

[linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-07 Thread Maxime Ripard
On Sat, Mar 01, 2014 at 05:45:51PM +0100, Carlo Caione wrote: > +static struct platform_driver axp20x_regulator_driver = { > + .probe = axp20x_regulator_probe, > + .remove = axp20x_regulator_remove, > + .driver = { > + .name = "axp20x-regulator", > + .

Re: [linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-04 Thread Carlo Caione
On Mon, Mar 3, 2014 at 2:56 AM, Mark Brown wrote: > On Sat, Mar 01, 2014 at 05:45:51PM +0100, Carlo Caione wrote: > >> index d59c826..0cef101 100644 >> --- a/arch/arm/configs/sunxi_defconfig >> +++ b/arch/arm/configs/sunxi_defconfig >> @@ -69,3 +69,4 @@ CONFIG_NFS_FS=y >> CONFIG_ROOT_NFS=y >> CO

[linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

2014-03-02 Thread Mark Brown
On Sat, Mar 01, 2014 at 05:45:51PM +0100, Carlo Caione wrote: > index d59c826..0cef101 100644 > --- a/arch/arm/configs/sunxi_defconfig > +++ b/arch/arm/configs/sunxi_defconfig > @@ -69,3 +69,4 @@ CONFIG_NFS_FS=y > CONFIG_ROOT_NFS=y > CONFIG_NLS=y > CONFIG_PRINTK_TIME=y > +CONFIG_REGULATOR_AXP20