Re: [PATCH 1/7] phy: exynos-usb2: add vbus regulator support

Hello, On 2015-08-27 11:54, Kishon Vijay Abraham I wrote: On Tuesday 25 August 2015 11:42 AM, Krzysztof Kozlowski wrote: On 25.08.2015 14:47, Marek Szyprowski wrote: Hello, On 2015-08-21 14:44, Kishon Vijay Abraham I wrote: On Friday 21 August 2015 06:08 PM, Marek Szyprowski wrote: Exynos

[PATCH v4 01/32] usb: dwc2: host: don't clear hprt0 status bits when exiting hibernation

From: Gregory Herrero When entering hibernation hprt0 must be read using dwc2_read_hprt0(). Otherwise, any set hprt0 status bits will be cleared when restoring hprt0 on exit from hibernation. Signed-off-by: Gregory Herrero Signed-off-by:

[PATCH v4 00/32] usb: dwc2: various bug fixes

Hi, This series consists of various bug fixes for both host and gadget sides. All patches are verified on dwc2 v3.0a with dedicated fifos. It would be good to get some Tested-bys for other platforms. It is based on testing/next branch in Felipe's git. Hi Felipe, I see that you have already

[PATCH v4 03/32] usb: dwc2: host: add flag to reflect bus state

From: Gregory Herrero lx_state must be used to reflect controller power state only and not bus state. Thus add a flag to track state during bus suspend. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab

[PATCH v4 04/32] usb: dwc2: host: enter hibernation during bus suspend

From: Gregory Herrero Disable controller power and enter hibernation when usb bus is suspended. A phy driver is required to disable the power of the controller and detect remote-wakeup or disconnection since the controller will not be able to detect these in this

[PATCH v4 02/32] usb: dwc2: host: create a function to handle port_resume

From: Gregory Herrero port resume sequence may be used in different places. Create a function to handle it. Make hprt0 read-modify-write atomic and clear HPRT0_SUSP for both writes as it is a "read, write-set, and self-clear (R_WS_SC)" bit. Since the lock is released

[PATCH v4 08/32] usb: dwc2: host: resume only if bus is suspended

From: Gregory Herrero Port can be resumed in bus_resume callback. In this case, there is no need to drive resume a second time when hcd ask for it. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab

[PATCH v4 09/32] usb: dwc2: host: reset frame number after suspend

From: Gregory Herrero Frame number is reset in hardware after exiting hibernation. Thus, reset frame_number and ensure qh are queued with correct sched_frame. Otherwise, qh->sched_frame may be too high compared to current frame number (which is 0). This can delay

[PATCH v4 14/32] usb: dwc2: host: wait 3ms for controller stabilization

From: Gregory Herrero Some high speed mass storage devices fail to enumerate with following error: Cannot enable port %i. Maybe the USB cable is bad? This happens only when the device is plugged while the controller is in hibernation state. After exiting

[PATCH v4 11/32] usb: dwc2: host: add disconnect interrupt to host only interrupts

GINTSTS.DisconnInt is host only interrupt and should be disable after dwc2_disable_host_interrupts is called. Signed-off-by: Mian Yousaf Kaukab Tested-by: Robert Baldyga Tested-by: Dinh Nguyen Tested-by: John Youn

[PATCH v4 13/32] usb: dwc2: host: clear pending interrupts prior hibernation

From: Gregory Herrero If an interrupt rises during hibernation process, dwc2 will assert interrupt line to interrupt controller. If interrupt is level sensitive, interrupt handler will be called in a loop because dwc2 will not be able to clear it while controller is

[PATCH v4 12/32] usb: dwc2: host: disable interrupt during stop

From: Gregory Herrero Disable host interrupts before synchronising dwc2 irq. So that interrupts are not generated once controller is stopped. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab

[PATCH v4 15/32] usb: dwc2: host: correctly dump urb isochronous descriptors

From: Gregory Herrero Print urb->iso_frame_desc.status after it has been updated using dwc2_hcd_urb_get_iso_desc_status(). Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab Tested-by: Robert Baldyga

[PATCH v4 06/32] usb: dwc2: host: avoid resetting lx_state to L3 during disconnect

From: Gregory Herrero When a device is disconnected, lx_state must not be changed since the device may be disconnected whereas controller is still powered. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab

[PATCH v4 07/32] usb: dwc2: host: ignore wakeup interrupt if hibernation supported

From: Gregory Herrero If hibernation is supported, resume of devices will be handled in bus_resume callback. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab Tested-by: Robert Baldyga

[PATCH v4 05/32] usb: dwc2: host: update hcd and lx_state during start/stop callbacks

From: Gregory Herrero During hcd initialization, hardware accessible flag and lx_state must be reset to the working state since controller is powered at this stage. Same logic applied for stop callback. Signed-off-by: Gregory Herrero

[PATCH v4 16/32] usb: dwc2: host: use correct frame number during qh init

From: Gregory Herrero On first qh initialization, hsotg->frame_number is not corresponding to reality. So read it from host controller to get correct value. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab

[PATCH v4 18/32] usb: dwc2: gadget: ensure lx_state corresponds to current state

From: Gregory Herrero Correctly update lx_state on gadget connection and disconnection. When usb cable is disconnected, lx_state must be updated to L3 as controller could be in power off state. When usb cable is connected, lx_state must be updated to L0 as controller

[PATCH v4 10/32] usb: dwc2: host: disconnect hcd prior stopping it

From: Gregory Herrero In case controller is asked to stop while devices are connected, disconnect all devices and clean up before stopping. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab

[PATCH v4 23/32] usb: dwc2: gadget: abort core init if core_reset fails

From: Gregory Herrero No point of continue with initialization if core is not in a sane state. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab Tested-by: Robert Baldyga

[PATCH v4 30/32] usb: dwc2: gadget: exit hibernation before power down

From: Gregory Herrero When disconnecting cable, controller will detect a suspend condition and enter partial power down. If vbus_session is called by the phy driver during hibernation, make sure controller exit hibernation before it is accessed. Signed-off-by:

[PATCH v4 24/32] usb: dwc2: gadget: ignore stall check for ep0

dwc2_hsotg_start_req starts a request only if endpoint is not stalled. Ignore this check for ep0 as core will clear DOEPCTL0.Stall after sending stall handshake. Prepare instead for receiving next setup packet. Signed-off-by: Mian Yousaf Kaukab Tested-by: Robert Baldyga

[PATCH v4 25/32] usb: dwc2: gadget: print complete setup packet

wIndex field was missing. Also print in natural order instead of Req first, so that its easier to compare for example against bus analyzer logs. Signed-off-by: Mian Yousaf Kaukab Tested-by: Robert Baldyga Tested-by: Dinh Nguyen

[PATCH v4 26/32] usb: dwc2: gadget: stop current transfer on dequeue

If the request being dequeued is already started, disable endpoint to stop the transfer and then call dwc2_hsotg_complete_request(). Endpoint will be re-enabled on next call to dwc2_hsotg_start_req(). Signed-off-by: Mian Yousaf Kaukab Tested-by: Robert Baldyga

[PATCH v4 19/32] usb: dwc2: gadget: initialize op_state for peripheral only configuration

ID status change interrupt will not be handled in peripheral only configuration. So initialize op_state during gadget init. Signed-off-by: Mian Yousaf Kaukab Tested-by: Robert Baldyga Tested-by: Dinh Nguyen

[PATCH v4 20/32] usb: dwc2: force dr_mode in case of configuration mismatch

If dual role configuration is not selected, check and force dr_mode based on the selected configuration. Signed-off-by: Mian Yousaf Kaukab Tested-by: Robert Baldyga Tested-by: Dinh Nguyen Tested-by: John Youn

[PATCH v4 17/32] usb: dwc2: host: kill remaining urbs using -ECONNRESET status

From: Gregory Herrero On a disconnect, dwc2 will kill all remaining urbs from qh list. urbs are given back to hcd with -ETIMEDOUT status. Some usb device driver, like mass storage, will unlink all urbs using usb_hcd_unlink_urb when receiving a negative status different

[PATCH v4 21/32] usb: dwc2: gadget: don't modify pullup state in host mode

From: Gregory Herrero Modifying the pullup state during host mode trig a new enumeration of attached device. Thus, avoid modifying pullup in host mode. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab

[PATCH v4 27/32] usb: dwc2: gadget: kill ep0 requests before reinitializing core

Make sure there are no requests pending on ep0 before reinitializing core. Otherwise, dwc2_hsotg_enqueue_setup will fail afterwards. Also, take hsotg->lock before calling dwc2_hsotg_core_init_disconnected() from dwc2_conn_id_status_change() as dwc2_hsotg_complete_request() expect lock to be held.

[PATCH v4 32/32] usb: dwc2: exit hibernation on session request

Controller enters hibernation through suspend interrupt on disconnection. On connection, session request interrupt is generated. dwc2 must exit hibernation and restore state from this interrupt before continuing. In host mode, exit from hibernation is handled by bus_resume function.

[PATCH v4 28/32] usb: dwc2: gadget: only reset core after addressed state

There is a 200ms guard period to avoid unnecessary resets of the dwc2 ip. This delay sometimes prove to be too large when usbcv is run with an ehci host. dwc2 only needs to be reset after addressed state. Change the logic to reset ip after addressed state. Signed-off-by: Mian Yousaf Kaukab

[PATCH v4 22/32] usb: dwc2: gadget: set op_state in vbus_session call

From: Gregory Herrero Some device may have external id pin control enabled, so op_state will not be set on id pin interrupt change. Thus, ensure op_state is set to peripheral during vbus detection. Signed-off-by: Gregory Herrero

[PATCH v4 31/32] usb: dwc2: gadget: handle reset interrupt before endpoint interrupts

If system is loaded, reset, enum-done and setup interrupts can occur at the same time. Current interrupt handling sequence will handle setup packet's interrupt before handling reset interrupt. Which will break the enumeration process. Correct sequence is to handle reset, enum-done and then any

[PATCH v4 29/32] usb: dwc2: gadget: unmask idstschng interrupt only if controller supports it

From: Gregory Herrero idstschng interrupt should not be used when id pin control is external. This is already handled on dwc2 host part. Fix it on gadget part as well. Signed-off-by: Gregory Herrero Signed-off-by: Mian Yousaf Kaukab

[PATCH] net: usb: asix: Fix crash on skb alloc failure

If asix_rx_fixup_internal() fails to allocate rx->ax_skb, it will return but not clear rx->size. rx points to driver private data. A later call assumes that nonzero size means ax_skb was allocated and passes a null ax_skb to skb_put. Changed allocation failure return to clear size first. Found

Re: [PATCH v8 0/3] usb: xhci-platform: Configure 64-bit DMA mask if the platform is capable

On Thu, Sep 17, 2015 at 11:19 AM, Duc Dang wrote: > The xhci platform driver does not work with system that only supports > 64-bit DMA as it requests 32-bit DMA mask during driver initialization. > This patch set addresses this issue and also adds XHCI-compliant USB > Controller

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On Wed, 30 Sep 2015, Luis de Bethencourt wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify > that a buffer allocation failed. Since the error number is propagated, > the caller will get a -EPERM which is the wrong error condition. Generally I agree that the more

[PATCH v7 0/2] Allow USB devices to remain runtime-suspended when sleeping

Hi, this is v7 of an attempt to make it easier for devices to remain in runtime PM when the system goes to sleep, mainly to reduce the time spent resuming devices. For this, we interpret the absence of all PM callback implementations as it being safe to do direct_complete, so their ancestors

[PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Since the error number is propagated, the caller will get a -EPERM which is the wrong error condition. Also, the smatch tool complains with the following warning: hiddev_connect() warn:

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On Wed, Sep 30, 2015 at 10:56:26AM +0100, Luis de Bethencourt wrote: > On 30/09/15 10:52, Luis de Bethencourt wrote: > > The driver is using -1 instead of the -ENOMEM defined macro to specify > > that a buffer allocation failed. Since the error number is propagated, > > the caller will get a

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On 30/09/15 10:52, Luis de Bethencourt wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify > that a buffer allocation failed. Since the error number is propagated, > the caller will get a -EPERM which is the wrong error condition. > > Also, the smatch tool complains

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On 30/09/15 11:04, Sudip Mukherjee wrote: > On Wed, Sep 30, 2015 at 10:56:26AM +0100, Luis de Bethencourt wrote: >> On 30/09/15 10:52, Luis de Bethencourt wrote: >>> The driver is using -1 instead of the -ENOMEM defined macro to specify >>> that a buffer allocation failed. Since the error number

[PATCH v7 2/2] USB / PM: Allow USB devices to remain runtime-suspended when sleeping

Have dev_pm_ops.prepare return 1 for USB devices and ports so that USB devices can remain runtime-suspended when the system goes to a sleep state, if their wakeup state is correct and they have runtime PM enabled. Signed-off-by: Tomeu Vizoso ---

Re: [PATCH v2 02/12] usb: gadget: amd5536udc: fix error path

On Tue, Sep 22, 2015 at 10:19:46AM -0500, Felipe Balbi wrote: > On Tue, Sep 22, 2015 at 08:29:52PM +0530, Sudip Mukherjee wrote: > > On Tue, Sep 22, 2015 at 08:12:29PM +0530, Sudip Mukherjee wrote: > > > On Tue, Sep 22, 2015 at 09:37:45AM -0500, Felipe Balbi wrote: > > > > On Tue, Sep 22, 2015 at

Re: Problems with printk logs and my driver

On 2015-09-29 18:11, Eric Curtin wrote: On 25 September 2015 at 16:45, Austin S Hemmelgarn wrote: On 2015-09-25 08:02, Jiri Kosina wrote: On Fri, 25 Sep 2015, Felipe Tonello wrote: Maybe a better description on Kconfig and/or comments on source code it's enough. I

Re: [PATCH v11] Added forgotten parameter description for authorized attribute in usb.h

Hi what does this error mean? Should I correct it? Best regards Stefan Am Dienstag, den 29.09.2015, 10:42 +0800 schrieb kbuild test robot: > Hi Stefan, > > [auto build test results on v4.3-rc3 -- if it's inappropriate base, please > ignore] > > reproduce: make htmldocs > > All warnings

Re: Issues with USB Bluetooth Dongle

On Wed, Sep 30, 2015 at 09:06:45PM +0530, Anil Nair wrote: > Hi All, > > I have a USB Bluetooth Dongle it detects but i am unable to use it, > Cannot pair with any mobile device or send any file. > > I am using "Ubuntu 14.04 64-bit" with kernel version "3.13.0-65-generic" > > Here is the output

Re: [PATCH v11] Added forgotten parameter description for authorized attribute in usb.h

On Wed, Sep 30, 2015 at 11:51:15PM +0200, Stefan Koch wrote: > Hi > > what does this error mean? > > Should I correct it? You already did :) I think it was an error as the test-bot ran your patch against a "clean" tree, not my usb tree. All should be good now that I have merged your patch

[UVC][4.x][USB] Logitech QuickCam 9000 - Stability problems device disconnects/fails to reset

Hello kernel devs, I've been noticing stability problems with my USB webcam, it used to be just bogus volume warning notice but now I have to unplug/plugin, unplug and sometimes it works, sometimes not. It seems to work less now. It used to be lesser of a problem in eariler 4.x but now in

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote: > On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote: > > this (and the other helper below) could be macros just fine. > > They could, but they shouldn't. Inlines are always preferable over > function-like macros. says

Re: [PATCH 00/16] ARM: at91: PMC driver rework

Stephen, all, Please disregard 01/16 and 02/16 as they are already in clk-next. On 30/09/2015 at 18:10:53 +0200, Alexandre Belloni wrote : > Hi, > > This patch set is a cleanup that properly separate drivers needing to access > the > PMC (PM and USB) from the clock driver by exposing the PMC

Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

On Wed, Sep 30, 2015 at 11:04:54AM -0500, Felipe Balbi wrote: > On Wed, Sep 23, 2015 at 09:22:48PM +0530, Sudip Mukherjee wrote: > > On Mon, Sep 21, 2015 at 04:40:57PM +0530, Sudip Mukherjee wrote: > > > On Sun, Sep 20, 2015 at 11:15:28AM -0500, Felipe Balbi wrote: > > > > On Sat, Sep 19, 2015 at

Re: [PATCH v3 00/32] usb: dwc2: various bug fixes

On Tue, Sep 29, 2015 at 12:07:58PM +0200, Mian Yousaf Kaukab wrote: > Hi, > This series consists of various bug fixes for both host and gadget > sides. All patches are verified on dwc2 v3.0a with dedicated fifos. > It would be good to get some Tested-bys for other platforms. > > It is based on

Re: [PATCH v3 20/32] usb: dwc2: force dr_mode in case of configuration mismatch

On Tue, Sep 29, 2015 at 09:58:56PM +0300, Sergei Shtylyov wrote: > On 09/29/2015 01:08 PM, Mian Yousaf Kaukab wrote: > > >If dual role configuration is not selected, check and force dr_mode > >based on the selected configuration. > > > >Signed-off-by: Mian Yousaf Kaukab

Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

On Wed, Sep 30, 2015 at 06:11:08PM +0200, Alexandre Belloni wrote: > Use regmap to access the PMC to avoid using at91_pmc_read and > at91_pmc_write. > > Signed-off-by: Alexandre Belloni can I take this through my tree or does it have any dependences with

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

On Wed, Sep 30, 2015 at 12:20:46PM -0400, Tejun Heo wrote: > On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote: > > On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote: > > > On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote: > > > > this (and the other helper

Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

Le 30/09/2015 18:24, Sudip Mukherjee a écrit : > On Wed, Sep 30, 2015 at 11:04:54AM -0500, Felipe Balbi wrote: >> On Wed, Sep 23, 2015 at 09:22:48PM +0530, Sudip Mukherjee wrote: >>> On Mon, Sep 21, 2015 at 04:40:57PM +0530, Sudip Mukherjee wrote: On Sun, Sep 20, 2015 at 11:15:28AM -0500,

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

On Wed, Sep 30, 2015 at 11:32:19AM -0500, Felipe Balbi wrote: > On Wed, Sep 30, 2015 at 12:20:46PM -0400, Tejun Heo wrote: > > On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote: > > > On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote: > > > > On Sun, Sep 27, 2015 at

Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

Le 30/09/2015 18:31, Felipe Balbi a écrit : > On Wed, Sep 30, 2015 at 06:11:08PM +0200, Alexandre Belloni wrote: >> Use regmap to access the PMC to avoid using at91_pmc_read and >> at91_pmc_write. >> >> Signed-off-by: Alexandre Belloni > > can I take this

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

On Wed, Sep 30, 2015 at 12:35:38PM -0400, Tejun Heo wrote: > On Wed, Sep 30, 2015 at 11:32:19AM -0500, Felipe Balbi wrote: > > On Wed, Sep 30, 2015 at 12:20:46PM -0400, Tejun Heo wrote: > > > On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote: > > > > On Mon, Sep 28, 2015 at 03:35:14PM

Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

On Wed, Sep 30, 2015 at 06:39:03PM +0200, Nicolas Ferre wrote: > Le 30/09/2015 18:31, Felipe Balbi a écrit : > > On Wed, Sep 30, 2015 at 06:11:08PM +0200, Alexandre Belloni wrote: > >> Use regmap to access the PMC to avoid using at91_pmc_read and > >> at91_pmc_write. > >> > >> Signed-off-by:

Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

On Wed, Sep 23, 2015 at 09:22:48PM +0530, Sudip Mukherjee wrote: > On Mon, Sep 21, 2015 at 04:40:57PM +0530, Sudip Mukherjee wrote: > > On Sun, Sep 20, 2015 at 11:15:28AM -0500, Felipe Balbi wrote: > > > On Sat, Sep 19, 2015 at 10:42:58PM +0530, Sudip Mukherjee wrote: > > > > While building

Re: [PATCH v2 20/32] usb: dwc2: force dr_mode in case of configuration mismatch

On Tue, Sep 29, 2015 at 10:07:56AM +, Kaukab, Yousaf wrote: > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Monday, September 28, 2015 10:43 PM > > To: Kaukab, Yousaf > > Cc: linux-usb@vger.kernel.org; ba...@ti.com; john.y...@synopsys.com; > > Herrero,

Re: [PATCH v3 1/2] usb: gadget: loopback: fix: Don't share qlen and buflen between instances

On Thu, Sep 24, 2015 at 07:10:53PM +0200, Krzysztof Opasiak wrote: > > > On 09/24/2015 06:51 PM, Felipe Balbi wrote: > >On Thu, Sep 24, 2015 at 05:19:12PM +0200, Robert Baldyga wrote: > >>On 09/22/2015 08:40 PM, Krzysztof Opasiak wrote: > >>>Each instance of loopback function may have different

Re: [PATCH v3 2/2] usb: gadget: loopback: Fix looping back logic implementation

On Tue, Sep 22, 2015 at 08:40:23PM +0200, Krzysztof Opasiak wrote: > Since: > > commit e0857ce58e8658657f5f12fe25272b93cfeb16aa this should be something like: Since commit e0857ce58e86 (" ") > ("usb: gadget: loopback: don't queue requests to bogus endpoints") > > Loopback function is not

[PATCH 00/16] ARM: at91: PMC driver rework

Hi, This patch set is a cleanup that properly separate drivers needing to access the PMC (PM and USB) from the clock driver by exposing the PMC as a syscon. This also allows to implement a fix for preempt-rt. Currently, at91 platform are crashing when using preempt-rt because the irq handler are

[PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

Use regmap to access the PMC to avoid using at91_pmc_read and at91_pmc_write. Signed-off-by: Alexandre Belloni --- Cc: Felipe Balbi Cc: linux-usb@vger.kernel.org drivers/usb/gadget/udc/atmel_usba_udc.c | 20 ++--

Re: [PATCH v3 2/2] usb: gadget: loopback: Fix looping back logic implementation

On Wed, Sep 30, 2015 at 11:11:52AM -0500, Felipe Balbi wrote: > On Tue, Sep 22, 2015 at 08:40:23PM +0200, Krzysztof Opasiak wrote: > > Since: > > > > commit e0857ce58e8658657f5f12fe25272b93cfeb16aa > > this should be something like: > > Since commit e0857ce58e86 (" ") > > > ("usb: gadget:

Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

On Thu, Sep 24, 2015 at 11:18:01AM -0500, Rob Herring wrote: > On Thu, Sep 24, 2015 at 4:26 AM, Subbaraya Sundeep Bhatta > wrote: > > Hi Peter, > > > >> -Original Message- > >> From: Peter Chen [mailto:peter.c...@freescale.com] > >> Sent: Thursday,

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

On Wed, Sep 30, 2015 at 11:19:25AM -0500, Felipe Balbi wrote: > On Mon, Sep 28, 2015 at 03:35:14PM +0200, Christoph Hellwig wrote: > > On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote: > > > this (and the other helper below) could be macros just fine. > > > > They could, but they

Issues with USB Bluetooth Dongle

Hi All, I have a USB Bluetooth Dongle it detects but i am unable to use it, Cannot pair with any mobile device or send any file. I am using "Ubuntu 14.04 64-bit" with kernel version "3.13.0-65-generic" Here is the output of dmesg, [ 2920.744043] usb 3-1: new full-speed USB device number 3

Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

On Wed, Sep 30, 2015 at 06:34:28PM +0200, Nicolas Ferre wrote: > Le 30/09/2015 18:24, Sudip Mukherjee a écrit : > > On Wed, Sep 30, 2015 at 11:04:54AM -0500, Felipe Balbi wrote: > >> On Wed, Sep 23, 2015 at 09:22:48PM +0530, Sudip Mukherjee wrote: > >>> On Mon, Sep 21, 2015 at 04:40:57PM +0530,

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

On Wed, Sep 30, 2015 at 11:43:01AM -0500, Felipe Balbi wrote: > Seems like there are *ton* of uses of container_of() wrapped within a simple > macro. What convention are you talking about, again ? The convention of using inline functions over macros when possible. We don't do that all the time

Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

Hi, On 30/09/2015 at 11:31:02 -0500, Felipe Balbi wrote : > On Wed, Sep 30, 2015 at 06:11:08PM +0200, Alexandre Belloni wrote: > > Use regmap to access the PMC to avoid using at91_pmc_read and > > at91_pmc_write. > > > > Signed-off-by: Alexandre Belloni >

Re: [PATCH 15/16] usb: gadget: atmel: access the PMC using regmap

On 30/09/2015 at 18:59:17 +0200, Alexandre Belloni wrote : > Hi, > > On 30/09/2015 at 11:31:02 -0500, Felipe Balbi wrote : > > On Wed, Sep 30, 2015 at 06:11:08PM +0200, Alexandre Belloni wrote: > > > Use regmap to access the PMC to avoid using at91_pmc_read and > > > at91_pmc_write. > > > > > >

Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

Le 30/09/2015 18:53, Sudip Mukherjee a écrit : > On Wed, Sep 30, 2015 at 06:34:28PM +0200, Nicolas Ferre wrote: >> Le 30/09/2015 18:24, Sudip Mukherjee a écrit : >>> On Wed, Sep 30, 2015 at 11:04:54AM -0500, Felipe Balbi wrote: On Wed, Sep 23, 2015 at 09:22:48PM +0530, Sudip Mukherjee wrote: