Since commit 855ed04a3758b205e84b269f92d26ab36ed8e2f7 ("usb: gadget:
udc-core: independent registration of gadgets and gadget drivers") gadget
drivers can not assume that UDC drivers are already available on their
initialization. This broke the HACK, which was used in gadgetfs driver,
to get UDC
Hi,
Oliver Neukum writes:
>> Oliver Neukum writes:
>> >> > The API to user space. That is the point. We cannot break user space.
>> >> > Once this sysfs API is upstream we are stuck with it.
>> >>
>> >> yeah, in fact I have been wondering if sysfs is the
Hi,
John Youn writes:
>>> +static int dwc3_gadget_set_xfer_resource(struct dwc3 *dwc, struct dwc3_ep
>>> *dep);
>>> +
>>> +/**
>>> + * dwc3_gadget_start_config - Configure EP resources
>>> + * @dwc: pointer to our controller context structure
>>> + * @dep: endpoint that
John Youn writes:
> On 2/17/2016 12:39 AM, Felipe Balbi wrote:
>>
>> Hi,
>>
>> John Youn writes:
>>> Enable SuperSpeedPlus by programming the DCFG.speed and after
>>> enumerating, set gadget->speed appropriately.
>>>
>>> Signed-off-by: John Youn
This happens also with older kernel versions (3.x, etc.):
A small LCD display (ID 1908:0102 GEMBIRD) connected to USB is used for
some years now. Computer (and display) runs always (24 hours/day).
'lcd4linux' is used to update the displays contents.
This works fine - but it fails after 1-2 days.
This series contains two fixes for the host in Descriptor DMA mode.
v3:
* Added tested-bys
* Minor rewrite of commit message (typos, grammar)
v2:
* Resend with proper e-mails
Tang, Jianqiang (1):
usb: dwc2: host: fix the data toggle error in full speed descriptor
dma
Vardan Mikayelyan
From: Vardan Mikayelyan
Fixes memory manipulation issues and makes Host DDMA bulk transfers
work.
dwc2_process_non_isoc_desc() must return non zero value ONLY when
failure happens in one of the queued descriptors. After receiving
non zero value the caller must stop
From: Tang, Jianqiang
There will be a data toggle error for full speed bulk-out transfers. The
data toggle bit is saved in the qh for non-control transfers, it is
wrong to check the qtd in that case.
John Youn:
* Added WARN() to warn on improper usage of the
Hi all,
I'm not entirely sure when this started. I noticed it for the first
time last month when I replaced my PC, but I then checked a second PC I
have connected to another monitor of the same type and I saw the exact
same behaviour, so it's clearly been happening for longer than that.
I've
This avoids a harmless randconfig warning I get when USB_NET_CDC_SUBSET
is enabled, but all of the more specific drivers are not:
drivers/net/usb/cdc_subset.c:241:2: #warning You need to configure some
hardware for this driver
The current behavior is clearly intentional, giving a warning when
a
On Wed, 2016-02-17 at 21:37 +0300, Sergei Shtylyov wrote:
> > @@ -492,6 +494,20 @@ static void uas_tmf_cmplt(struct urb *urb)
> > if (status < 0) {
> > devinfo->deathrow = NULL;
> > complete(>deathknell);
> > + switch (status) {
> > + case
On 2/17/2016 5:51 AM, B, Ravi wrote:
> Hi John
>
>
>> Fixes: aebda6187181 ("usb: dwc3: Reset the transfer resource index on
>> SET_INTERFACE")
>> Cc: # v3.2+
>> Reported-by: Ravi Babu
>> Signed-off-by: John Youn
>> ---
>
>> Hi
On Tue, Feb 9, 2016 at 10:31 PM, Heikki Krogerus
wrote:
> Hi,
>
> The OS, or more precisely the user space, needs to be able to control
> a few things regarding USB Type-C ports. The first thing that must be
> allowed to be controlled is the data role. USB Type-C
On 2/17/2016 12:39 AM, Felipe Balbi wrote:
>
> Hi,
>
> John Youn writes:
>> Enable SuperSpeedPlus by programming the DCFG.speed and after
>> enumerating, set gadget->speed appropriately.
>>
>> Signed-off-by: John Youn
>> ---
>>
On Wed, Feb 17, 2016 at 10:42:37AM -0800, Victor Dodon wrote:
> The US_DEBUGPX macro uses printk without specifying a kernel log level, so
> the default kernel log level is used, which may not match LOGLEVEL_DEBUG
> used in usb_stor_dbg. Remove the macro and use usb_store_dbg instead.
>
>
On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote:
> Hi,
>
> The OS, or more precisely the user space, needs to be able to control
> a few things regarding USB Type-C ports. The first thing that must be
> allowed to be controlled is the data role. USB Type-C ports will
> select the data
On Wed, Feb 17, 2016 at 12:14 PM, Sergei Shtylyov
wrote:
> On 02/16/2016 11:05 PM, Rob Herring wrote:
>
> + - mentor,power : Specifies the maximum current in milliamperes the
> controller can
> + supply in host mode.
Still a no
The US_DEBUGPX macro uses printk without specifying a kernel log level, so
the default kernel log level is used, which may not match LOGLEVEL_DEBUG
used in usb_stor_dbg. Remove the macro and use usb_store_dbg instead.
Signed-off-by: Victor Dodon
--
Changes in v2:
-
Hello.
On 02/17/2016 07:10 PM, Dave Penkler wrote:
When the device is disconnected poll waiters were not being woken.
Fixes issue in commit eb6b92ecc0f9412623ab1584ddd8389b371638d4 reported
scripts/checkpatch.pl now enforces certain commit citing format, yours
doesn't match it, not only
Hello.
On 02/17/2016 06:50 PM, Oliver Neukum wrote:
A reset based on usb_reset_device() will reset the whole
host, not just a bus. We should use the correct entry.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 33 +++--
1 file
Keith Packard writes:
> Yup, with a few minor fixes to pass the right arguments:
Argh. Just after hitting 'send', I noticed that I'd not moved the URB
deallocation out of the way when merging the first patch in this
series. That means the driver won't build with only the
On 02/16/2016 11:05 PM, Rob Herring wrote:
+ - mentor,power : Specifies the maximum current in milliamperes the
controller can
+ supply in host mode.
Still a no for me. Looks like this just sets hcd->power_budget. This
property may not be a regulator, but ultimately the value depends on
Oliver Neukum writes:
> On Tue, 2016-02-16 at 11:09 -0800, Keith Packard wrote:
>> I could be convinced that the driver should be using a different path
>> through the USB stack that would allow a signal to wake up while
>> waiting
>> for the URB to complete, but this patch at
Hello.
On 02/16/2016 10:53 PM, Rob Herring wrote:
This adds DT support for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver.
Signed-off-by: Petr Kulhavy
---
.../devicetree/bindings/usb/da8xx-usb.txt | 47
++
1 file changed, 47 insertions(+)
Arnd Bergmann writes:
> Ok, so I guess what this means is that ixp4xx (or xscale in general)
> implements its big-endian mode by adding a byteswap on its DRAM
> and PCI interfaces in be32 mode, rather than by changing the behavior of
> the load/store operations (as be8 mode does)
On 17.02.2016 07:19, Andy Lutomirski wrote:
On Tue, Feb 16, 2016 at 6:33 PM, Greg Kroah-Hartman
wrote:
On Tue, Feb 16, 2016 at 10:01:13AM -0800, Andy Lutomirski wrote:
I get some warnings at boot on all kernels I've tried. On 4.5-rc4, I see:
...
[1.061036]
When the device is disconnected poll waiters were not being woken.
Fixes issue in commit eb6b92ecc0f9412623ab1584ddd8389b371638d4 reported
by Oliver Neukum
Signed-off-by: Dave Penkler
---
drivers/usb/class/usbtmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
On Wednesday 17 February 2016 17:08:27 Felipe Balbi wrote:
>
> Hi,
>
> Arnd Bergmann writes:
> > ixp4xx and pxa25x both use this driver and provide a slightly
> > different set of register definitions for it. Aside from that,
> > the definition in the ixp4xx-regs.h header
Use a TMF_ABORT_TASK TMF_IU in the abort handler,
to deal with commands we need to get rid of.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/usb/storage/uas.c
If we succeed, we should report that.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index d388e78..31ff1a0 100644
---
We need to give up on this TMF to have a free tag
again.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 167 ++
1 file changed, 110 insertions(+), 57 deletions(-)
diff --git a/drivers/usb/storage/uas.c
UAS uses a shared tag space. We reserve tag #1 for management.
That leaves us with an offset of 2.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git
If we go into the reset_resume() code path, the device
cannot report on the result of a TMF. We must forget
about the request at the host level.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 1 +
1 file changed, 1 insertion(+)
diff --git
A reset based on usb_reset_device() will reset the whole
host, not just a bus. We should use the correct entry.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 33 +++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git
First evaluate, then notify the consumer.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index d2d9244..d789227 100644
---
Hans, do you like the approach. I added patch#15 to fix
the bug you pointed out.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Simple evaluation of the response uis result codes
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 80 ++-
1 file changed, 65 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/storage/uas.c
A successful TMF means that the URBs for a command must be killed.
Also fixes sleeping with a spinlock.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 35 ---
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git
This maps a device reset to a RESET LOGICAL UNIT
and sends the TMF. Also factor out common code with abort handling.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/uas.c
Issue a TASK_ABORT iu to the device and wait for it
to complete.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 1b901c8..e69ef2b 100644
---
This just allocates the structures.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 44b096c..13e6313 100644
---
A reset in progress obsoletes all TMFs.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index e69ef2b..4c1d6c3 100644
--- a/drivers/usb/storage/uas.c
+++
Make sure we consider a command abort only if the device confirms
that.
Signed-off-by: Oliver Neukum
---
drivers/usb/storage/uas.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index acd2034..d388e78 100644
Hi,
Arnd Bergmann writes:
> ixp4xx and pxa25x both use this driver and provide a slightly
> different set of register definitions for it. Aside from that,
> the definition in the ixp4xx-regs.h header conflicts with the
> on in the pxa27x device driver when compile-testing that:
>
On 17.02.2016 15:58, Felipe Balbi wrote:
Hi,
Petr Kulhavy writes:
This adds two functions to get DT properties "mentor,power" and "dr_mode":
musb_get_power() and musb_mode musb_get_mode()
Signed-off-by: Petr Kulhavy
seems like I don't have patch 1/5. After
On Tue, 2016-02-16 at 11:09 -0800, Keith Packard wrote:
> I could be convinced that the driver should be using a different path
> through the USB stack that would allow a signal to wake up while
> waiting
> for the URB to complete, but this patch at least avoids needing to
> wait
> for a huge read
Hi,
Petr Kulhavy writes:
> This adds two functions to get DT properties "mentor,power" and "dr_mode":
> musb_get_power() and musb_mode musb_get_mode()
>
> Signed-off-by: Petr Kulhavy
seems like I don't have patch 1/5. After fixing Sergei's comments,
please
Hi,
Vegard Nossum writes:
> On 02/08/2016 01:15 PM, Marek Szyprowski wrote:
>> Gadgetfs driver called usb_gadget_unregister_driver unconditionally, even
>> if it didn't register it earlier due to other failures. This patch fixes
>> this.
>>
>> Reported-by: Vegard
On Wed, Feb 17, 2016 at 03:36:46PM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Heikki Krogerus writes:
> > On Wed, Feb 17, 2016 at 11:36:52AM +0100, Oliver Neukum wrote:
> >> On Wed, 2016-02-17 at 12:29 +0200, Felipe Balbi wrote:
> >> > Hi,
> >> >
> >> > Oliver
Hi,
Heikki Krogerus writes:
> Hi John,
>
>> Hi Heikki,
>>
>> The properties are now set using your patch.
>>
>> However I get a use-after-free error when I unload the driver:
>
> OK. I need to prepare proper fixes for the fwnode handling, but I
> think these
Hi,
Heikki Krogerus writes:
> This should allow the core driver to drop handling of
> platform data and expect the platform specific details to
> always come from properties.
>
> Signed-off-by: Heikki Krogerus
> Cc: Huang Rui
Hi
Vishal Thanki writes:
> Hi,
>
> On Tue, Feb 9, 2016 at 3:51 PM, Vishal Thanki wrote:
>> On Mon, Feb 08, 2016 at 08:44:19PM +0200, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Vishal Thanki writes:
>>> > It is vanilla
Hi,
Li Yang writes:
> On Mon, Feb 8, 2016 at 3:18 AM, Ramneek Mehresh
> wrote:
>> Hi Balbi,
>>
>> A kind reminder for the below request. Please let me know if any changes are
>> required on my side.
>
> You are still using the obsolete email
On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote:
> 1. connected - Connection status of the connector
> 2. alternate_mode - The current Alternate Mode
> 3. alternate_modes - Lists all Alternate Modes the connector supports
> 4. partner_alt_modes - Lists partner's Alternate Modes when
On Wed, 2016-02-17 at 15:34 +0200, Felipe Balbi wrote:
> Hi,
>
> Oliver Neukum writes:
> >> > The API to user space. That is the point. We cannot break user space.
> >> > Once this sysfs API is upstream we are stuck with it.
> >>
> >> yeah, in fact I have been wondering if
Hi John
>Fixes: aebda6187181 ("usb: dwc3: Reset the transfer resource index on
>SET_INTERFACE")
>Cc: # v3.2+
>Reported-by: Ravi Babu
>Signed-off-by: John Youn
>---
>Hi Ravi,
>Could you verify that it works with your test
Hi,
Heikki Krogerus writes:
> On Wed, Feb 17, 2016 at 11:36:52AM +0100, Oliver Neukum wrote:
>> On Wed, 2016-02-17 at 12:29 +0200, Felipe Balbi wrote:
>> > Hi,
>> >
>> > Oliver Neukum writes:
>> > > On Wed, 2016-02-17 at 09:58 +0200, Heikki
Hi,
Oliver Neukum writes:
>> > The API to user space. That is the point. We cannot break user space.
>> > Once this sysfs API is upstream we are stuck with it.
>>
>> yeah, in fact I have been wondering if sysfs is the best interface to
>
> That is the discussion we must have.
Hello.
On 2/17/2016 2:02 AM, John Youn wrote:
From: Tang, Jianqiang
There will be data toggle error happen for full speed buld-out transfer.
Bulk-out?
The data toggle bit is saved in qh for non-control transfers, it is wrong
to check the qtd for that case.
On Wed, Feb 17, 2016 at 11:36:52AM +0100, Oliver Neukum wrote:
> On Wed, 2016-02-17 at 12:29 +0200, Felipe Balbi wrote:
> > Hi,
> >
> > Oliver Neukum writes:
> > > On Wed, 2016-02-17 at 09:58 +0200, Heikki Krogerus wrote:
> > >> On Tue, Feb 16, 2016 at 02:39:47PM +0100, Oliver
On Tue, Feb 16, 2016 at 10:43 PM, Anil Nair wrote:
> Hi,
>
> On Wed, Feb 17, 2016 at 12:00 PM, Greg KH wrote:
>> On Wed, Feb 17, 2016 at 11:47:56AM +0530, Anil Nair wrote:
>>> Hi All,
>>>
>>> I would like to contribute to Linux USB kernel but i
A typo of j for i led to a logic bug. To rule out future
confusion, the variable names are made meaningful.
Signed-off-by: Oliver Neukum
CC: sta...@vger.kernel.org
---
drivers/usb/core/hub.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Hi,
On Wed, Feb 17, 2016 at 4:10 PM, Oliver Neukum wrote:
> On Wed, 2016-02-17 at 16:09 +0530, Anil Nair wrote:
>> What did you mean by " Do you have any hardware
>> with unsupported features?"
>> If could clarify that would be great.
>
> For example I have a very old scanner
On Monday 15 February 2016 15:35:18 Andrzej Hajda wrote:
>
> Andrzej Hajda (7):
> netfilter: fix IS_ERR_VALUE usage
> MIPS: module: fix incorrect IS_ERR_VALUE macro usages
> drivers: char: mem: fix IS_ERROR_VALUE usage
> atmel-isi: fix IS_ERR_VALUE usage
> serial: clps711x: fix
On Wed, 2016-02-17 at 16:09 +0530, Anil Nair wrote:
> What did you mean by " Do you have any hardware
> with unsupported features?"
> If could clarify that would be great.
For example I have a very old scanner which features a
"Scan now" button. That would need an input driver. That
kind of
Hi,
Anil Nair writes:
> On Wed, Feb 17, 2016 at 4:03 PM, Oliver Neukum wrote:
>> On Wed, 2016-02-17 at 15:17 +0530, Anil Nair wrote:
>>> Hi,
>>>
>>> What about this "Kernel Janitors project" ?
>>>
>>> https://code.google.com/archive/p/kernel-janitors/
>>
On Wed, 2016-02-17 at 12:29 +0200, Felipe Balbi wrote:
> Hi,
>
> Oliver Neukum writes:
> > On Wed, 2016-02-17 at 09:58 +0200, Heikki Krogerus wrote:
> >> On Tue, Feb 16, 2016 at 02:39:47PM +0100, Oliver Neukum wrote:
> >> > Yes, but we need an API. We can't keep adding to it.
On Wed, Feb 17, 2016 at 4:03 PM, Oliver Neukum wrote:
> On Wed, 2016-02-17 at 15:17 +0530, Anil Nair wrote:
>> Hi,
>>
>> What about this "Kernel Janitors project" ?
>>
>> https://code.google.com/archive/p/kernel-janitors/
>
> Always an option.
> I suggest you start by learning.
On Wednesday 17 February 2016 09:36:37 Krzysztof Hałasa wrote:
> Arnd Bergmann writes:
>
> > ixp4xx is really special in that it performs hardware swapping for
> > internal devices based on CPU endianess but not on PCI devices.
>
> Again, IXP4xx does not perform hardware (nor any
On Wed, 2016-02-17 at 15:17 +0530, Anil Nair wrote:
> Hi,
>
> What about this "Kernel Janitors project" ?
>
> https://code.google.com/archive/p/kernel-janitors/
Always an option.
I suggest you start by learning. Read the skeleton
driver. Do you understand it? Do you have any hardware
with
Hi,
Oliver Neukum writes:
> On Wed, 2016-02-17 at 09:58 +0200, Heikki Krogerus wrote:
>> On Tue, Feb 16, 2016 at 02:39:47PM +0100, Oliver Neukum wrote:
>> > On Tue, 2016-02-16 at 11:22 +0200, Heikki Krogerus wrote:
>> > > > That question has not been answered. It would be
On Tue, Feb 16, 2016 at 03:01:33PM -0800, John Youn wrote:
> Sorry, messed up the emails. V2 is just a resend with e-mails fixed up.
>
> This series contains two fixes for the host in Descriptor DMA mode.
>
> v2:
> * Resend with proper e-mails
>
> Tang, Jianqiang (1):
> usb: dwc2: host: fix
Hi,
What about this "Kernel Janitors project" ?
https://code.google.com/archive/p/kernel-janitors/
On Wed, Feb 17, 2016 at 12:13 PM, Anil Nair wrote:
> Hi,
>
> On Wed, Feb 17, 2016 at 12:00 PM, Greg KH wrote:
>> On Wed, Feb 17, 2016 at
Hello Rob,
On 16.02.2016 21:05, Rob Herring wrote:
On Fri, Feb 12, 2016 at 11:24 AM, Petr Kulhavy wrote:
I understand your point that the description should be generic.
However the USB 2.0 specification does not define any relation between the
bMaxPower provided by the device
On Wed, 2016-02-17 at 11:38 +0800, Peter Chen wrote:
> I remembered you agreed with using outer loop counter (i) as the quit
> condition.
Hi,
thank you very much. A typo that is almost impossible to catch.
I'll submit a patch to fix this.
Thanks
Oliver
--
To
On Wed, 2016-02-17 at 09:58 +0200, Heikki Krogerus wrote:
> On Tue, Feb 16, 2016 at 02:39:47PM +0100, Oliver Neukum wrote:
> > On Tue, 2016-02-16 at 11:22 +0200, Heikki Krogerus wrote:
> > > > That question has not been answered. It would be awkward for the OS
> > > > to find itself in the slave
Hi Mathias,
Thanks for your time.
On 02/16/2016 10:19 PM, Mathias Nyman wrote:
> Hi
>
> Most of my concerns are due to the early printk restrictions.
> As you say in the documentation:
> "Keep in mind that things such as interrupt, system memory, DMA memory,
> PCI configure space access, etc.,
Hi,
John Youn writes:
> Enable SuperSpeedPlus by programming the DCFG.speed and after
> enumerating, set gadget->speed appropriately.
>
> Signed-off-by: John Youn
> ---
> drivers/usb/dwc3/gadget.c | 8
> 1 file changed, 8 insertions(+)
>
Arnd Bergmann writes:
> ixp4xx is really special in that it performs hardware swapping for
> internal devices based on CPU endianess but not on PCI devices.
Again, IXP4xx does not perform hardware (nor any other) swapping for
registers of on-chip devices. The registers are
79 matches
Mail list logo