Now that usb_endpoint_maxp() only returns the lowest
11 bits from wMaxPacketSize, we can remove the &
operation from this driver.
Cc: Ashwini Pahuja
Cc:
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/bdc/bdc_ep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
Now that usb_endpoint_maxp() only returns the lowest
11 bits from wMaxPacketSize, we can remove the &
operation from this driver.
Cc: Peter Chen
Cc:
Signed-off-by: Felipe Balbi
---
drivers/usb/chipidea/udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/chipid
We have introduced a helper to calculate multiplier
value from wMaxPacketSize. Start using it.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/fusb300_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fusb300_udc.c
b/drivers/usb/gadget/udc/f
We have introduced a helper to calculate multiplier
value from wMaxPacketSize. Start using it.
Cc: Nicolas Ferre
Cc:
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc
Now that usb_endpoint_maxp() only returns the lowest
11 bits from wMaxPacketSize, we can remove the &
operation from this driver.
Cc: Laurent Pinchart
Cc: Mauro Carvalho Chehab
Cc:
Acked-by: Laurent Pinchart
Signed-off-by: Felipe Balbi
---
drivers/media/usb/uvc/uvc_video.c | 2 +-
1 file cha
Now that usb_endpoint_maxp() only returns the lowest
11 bits from wMaxPacketSize, we can remove the &
operation from this driver.
Cc: Greg Kroah-Hartman
Cc:
Acked-by: Greg Kroah-Hartman
Signed-off-by: Felipe Balbi
---
drivers/usb/core/devices.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
We have introduced a helper to calculate multiplier
value from wMaxPacketSize. Start using it.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/udc/gr_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c
ind
DWC3 can tell us which phase of a setup transfer
we're getting into. Let's decode it from the event
to make it easier to debug.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/core.h | 1 +
drivers/usb/dwc3/debug.h | 13 +
2 files changed, 14 insertions(+)
diff --git a/drivers/us
Removing some trace prints which were made redundant
when we started decoding events and TRBs completely
within their respective trace points.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/ep0.c| 17 +
drivers/usb/dwc3/gadget.c | 43 +---
Link State Change events are only needed for
debugging and to apply certain workarounds on known
errata. Let's save a few cycles by disabling these
events completely on working revisions of the core.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/gadget.c | 4 +++-
1 file changed, 3 insertions
usb_endpoint_maxp() returns wMaxPacketSize in its
raw form. Without taking into consideration that it
also contains other bits reserved for isochronous
endpoints.
This patch fixes one occasion where this is a
problem by making sure that we initialize
ep->maxpacket only with lower 10 bits of the va
No Response Update Transfer is a special type of
Update Transfer command which can be used whenever
we're not relying on XferNotReady to prepare
transfers. With this, we don't need to wait for
CMDACT to be cleared and issue further commands to
the endpoint straight away.
Let's start using this ver
Hi guys,
Sorry for the patch bomb, but I wanted to make sure everyoby knows which
patches are already queued up for the next window. They are still
sitting in my testing/next branch, so I can still change any of them.
Please make sure to go through each one of them. This very branch has
been test
ep->mult is supposed to be set to Isochronous and
Interrupt Endapoint's multiplier value. This value
is computed from different places depending on the
link speed.
If we're dealing with HighSpeed, then it's part of
bits [12:11] of wMaxPacketSize. This case wasn't
taken into consideration before.
In case of High-Speed, High-Bandwidth endpoints, we
need to tell DWC3 that we have more than one packet
per interval. We do that by setting PCM1 field of
Isochronous-First TRB.
Cc:
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/gadget.c | 13 +++--
1 file changed, 11 insertions(+), 2
The cmd argument we pass to
dwc3_send_gadget_ep_cmd() could contain extra
arguments embedded. When checking for StartTransfer
command, we need to make sure to match only lower 4
bits which contain the actual command and ignore the
rest.
Reported-by: Janusz Dziedzic
Signed-off-by: Felipe Balbi
--
There might be situations where a Start Transfer
command might fail, if that ever happens, instead of
simply removing the request from our list, we should
give the request back to the gadget driver,
otherwise we might eventually starve it from requests.
Signed-off-by: Felipe Balbi
---
drivers/us
According to USB Specification 2.0 table 9-4,
wMaxPacketSize is a bitfield. Endpoint's maxpacket
is laid out in bits 10:0. For high-speed,
high-bandwidth isochronous endpoints, bits 12:11
contain a multiplier to tell us how many
transactions we want to try per uframe.
This means that if we want an
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
testing/next
head: 43f960528708df4edd74d176266f611b0e127772
commit: 43f960528708df4edd74d176266f611b0e127772 [82/82] usb: dwc3: pci: call
_DSM for suspend/resume
config: arm-multi_v7_defconfig (attached as .config)
compiler:
On Tue, Oct 25, 2016 at 11:34:40AM +0200, Linus Walleij wrote:
> Good work on this patch, nice that it got merged.
>
> I was just thinking that as an add-on, you may want to name
> the gpio lines so they have meaningful names in userspace
> when you use this with the chardev (I have reasons to bel
Hi,
Joseph Kogut writes:
> Well, after comparing the kernel log from both systems, it seems that
> the device controller simply isn't being enumerated by the kernel for
> some reason.
>
> Here's the relevant section from the Android kernel:
>
> <6>[0.612857] PCI host bridge to bus :00
>
101 - 121 of 121 matches
Mail list logo