Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-13 Thread Johan Hovold
On Wed, Dec 13, 2017 at 12:32:47PM +0100, Ladislav Michl wrote: > On Wed, Dec 13, 2017 at 12:16:05PM +0100, Johan Hovold wrote: > > On Mon, Dec 11, 2017 at 01:44:57PM +0100, Ladislav Michl wrote: > > > On Mon, Dec 11, 2017 at 12:52:46PM +0100, Johan Hovold wrote: > > > > On Mon, Dec 11, 2017 at 12:

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-13 Thread Ladislav Michl
On Wed, Dec 13, 2017 at 12:16:05PM +0100, Johan Hovold wrote: > On Mon, Dec 11, 2017 at 01:44:57PM +0100, Ladislav Michl wrote: > > On Mon, Dec 11, 2017 at 12:52:46PM +0100, Johan Hovold wrote: > > > On Mon, Dec 11, 2017 at 12:32:49PM +0100, Ladislav Michl wrote: > > > > On Mon, Dec 11, 2017 at 11:

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-13 Thread Johan Hovold
On Mon, Dec 11, 2017 at 01:44:57PM +0100, Ladislav Michl wrote: > On Mon, Dec 11, 2017 at 12:52:46PM +0100, Johan Hovold wrote: > > On Mon, Dec 11, 2017 at 12:32:49PM +0100, Ladislav Michl wrote: > > > On Mon, Dec 11, 2017 at 11:10:35AM +0100, Johan Hovold wrote: > [snip] > > > > I'm afraid I don't

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-11 Thread Ladislav Michl
On Mon, Dec 11, 2017 at 12:52:46PM +0100, Johan Hovold wrote: > On Mon, Dec 11, 2017 at 12:32:49PM +0100, Ladislav Michl wrote: > > On Mon, Dec 11, 2017 at 11:10:35AM +0100, Johan Hovold wrote: [snip] > > > I'm afraid I don't consider this an improvement. I prefer using gotos > > > for error paths,

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-11 Thread Johan Hovold
On Mon, Dec 11, 2017 at 12:32:49PM +0100, Ladislav Michl wrote: > On Mon, Dec 11, 2017 at 11:10:35AM +0100, Johan Hovold wrote: > > On Mon, Dec 11, 2017 at 12:09:19AM +0100, Ladislav Michl wrote: > > > Make status handling in bulk in callback function more compact, > > > which renders goto pointles

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-11 Thread Ladislav Michl
On Mon, Dec 11, 2017 at 11:10:35AM +0100, Johan Hovold wrote: > On Mon, Dec 11, 2017 at 12:09:19AM +0100, Ladislav Michl wrote: > > Make status handling in bulk in callback function more compact, > > which renders goto pointless. > > > > Signed-off-by: Ladislav Michl > > --- > > drivers/usb/seri

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-11 Thread Johan Hovold
On Mon, Dec 11, 2017 at 12:09:19AM +0100, Ladislav Michl wrote: > Make status handling in bulk in callback function more compact, > which renders goto pointless. > > Signed-off-by: Ladislav Michl > --- > drivers/usb/serial/ti_usb_3410_5052.c | 36 > ++- > 1 file

[PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-10 Thread Ladislav Michl
Make status handling in bulk in callback function more compact, which renders goto pointless. Signed-off-by: Ladislav Michl --- drivers/usb/serial/ti_usb_3410_5052.c | 36 ++- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/drivers/usb/serial/ti_us