RE: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-10-21 Thread Sriram Dash
>From: Stephen Boyd [mailto:sb...@codeaurora.org] >On 10/21, Bjorn Andersson wrote: >> hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating >> coherent memory on behalf of ci_hdrc driver. But as the ci_hdrc is >> instantiated manually it will not have any dma_mem or dma_ops >> assigned,

Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-10-21 Thread Bjorn Andersson
On Fri 21 Oct 10:38 PDT 2016, Stephen Boyd wrote: > On 10/21, Bjorn Andersson wrote: > > hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent > > memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated > > manually > > it will not have any dma_mem or dma_ops as

Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-10-21 Thread Stephen Boyd
On 10/21, Bjorn Andersson wrote: > hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent > memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated > manually > it will not have any dma_mem or dma_ops assigned, which makes the > dma_alloc_coherent() fail on some p

[RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-10-21 Thread Bjorn Andersson
hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated manually it will not have any dma_mem or dma_ops assigned, which makes the dma_alloc_coherent() fail on some platforms (e.g. arm64). This patch solves thi

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-24 Thread Peter Chen
On Tue, Mar 08, 2016 at 07:40:08PM -0800, Bjorn Andersson wrote: > On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrote: > > On Wed, Mar 2, 2016 at 4:59 PM, Li Yang wrote: > >> On Mon, Feb 22, 2016 at 4:07 PM, Bjorn Andersson > >> wrote: > >>> On Mon 22 Feb 02:03 PST 2016, Srinivas Kandagatla wrote: >

RE: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-20 Thread Rajesh Bhagat
lkml ; Srinivas Kandagatla > ; linux-arm-msm m...@vger.kernel.org>; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT > > On Thu, Mar 17, 2016 at 04:52:55PM +0100, Arnd Bergmann wrote: > > On Monday 14 March 2016 18:51

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-19 Thread Russell King - ARM Linux
On Fri, Mar 18, 2016 at 09:54:14AM +0800, Peter Chen wrote: > Although I don't know what kinds of bugs it may have, it may be > met before, otherwise, why most of platform drivers need to call > dma_set_coherent_mask or dma_coerce_mask_and_coherent explicitly See Documentation/DMA-API.txt, specifi

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-19 Thread Arnd Bergmann
On Monday 14 March 2016 18:51:08 Peter Chen wrote: > On Wed, Mar 09, 2016 at 05:16:50PM -0600, Li Yang wrote: > > On Tue, Mar 8, 2016 at 9:40 PM, Bjorn Andersson > > wrote: > > > On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrote: > > >> On Wed, Mar 2, 2016 at 4:59 PM, Li Yang wrote: > > >>> On Mon,

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-19 Thread Peter Chen
On Thu, Mar 17, 2016 at 04:52:55PM +0100, Arnd Bergmann wrote: > On Monday 14 March 2016 18:51:08 Peter Chen wrote: > > On Wed, Mar 09, 2016 at 05:16:50PM -0600, Li Yang wrote: > > > On Tue, Mar 8, 2016 at 9:40 PM, Bjorn Andersson > > > wrote: > > > > On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrot

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-19 Thread Arnd Bergmann
On Friday 18 March 2016 09:54:14 Peter Chen wrote: > > > > I don't think it's a very widespread problem, there are only very few > > developers that intentionally use this method, and some use the > > platform_device_register_full() call to create a device with a known > > mask, which is generally

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-14 Thread Peter Chen
On Wed, Mar 09, 2016 at 05:16:50PM -0600, Li Yang wrote: > On Tue, Mar 8, 2016 at 9:40 PM, Bjorn Andersson > wrote: > > On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrote: > >> On Wed, Mar 2, 2016 at 4:59 PM, Li Yang wrote: > >>> On Mon, Feb 22, 2016 at 4:07 PM, Bjorn Andersson > >>> wrote: >

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-09 Thread Li Yang
On Tue, Mar 8, 2016 at 9:40 PM, Bjorn Andersson wrote: > On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrote: >> On Wed, Mar 2, 2016 at 4:59 PM, Li Yang wrote: >>> On Mon, Feb 22, 2016 at 4:07 PM, Bjorn Andersson >>> wrote: On Mon 22 Feb 02:03 PST 2016, Srinivas Kandagatla wrote: > >>>

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-08 Thread Bjorn Andersson
On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrote: > On Wed, Mar 2, 2016 at 4:59 PM, Li Yang wrote: >> On Mon, Feb 22, 2016 at 4:07 PM, Bjorn Andersson >> wrote: >>> On Mon 22 Feb 02:03 PST 2016, Srinivas Kandagatla wrote: >>> On 22/02/16 05:32, Bjorn Andersson wrote: >On certai

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-08 Thread Li Yang
On Wed, Mar 2, 2016 at 4:59 PM, Li Yang wrote: > On Mon, Feb 22, 2016 at 4:07 PM, Bjorn Andersson > wrote: >> On Mon 22 Feb 02:03 PST 2016, Srinivas Kandagatla wrote: >> >>> >>> >>> On 22/02/16 05:32, Bjorn Andersson wrote: >>> >On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-02 Thread Li Yang
On Mon, Feb 22, 2016 at 4:07 PM, Bjorn Andersson wrote: > On Mon 22 Feb 02:03 PST 2016, Srinivas Kandagatla wrote: > >> >> >> On 22/02/16 05:32, Bjorn Andersson wrote: >> >On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set >> >to be able to do DMA allocations, so use the of_d

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-02-22 Thread Peter Chen
On Mon, Feb 22, 2016 at 02:07:50PM -0800, Bjorn Andersson wrote: > On Mon 22 Feb 02:03 PST 2016, Srinivas Kandagatla wrote: > > > I'm still puzzled to why the chipidea lives as a child device of the msm > device; but as this is a rather common structure I believe this still > needs to be figured

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-02-22 Thread Bjorn Andersson
On Mon 22 Feb 02:03 PST 2016, Srinivas Kandagatla wrote: > > > On 22/02/16 05:32, Bjorn Andersson wrote: > >On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set > >to be able to do DMA allocations, so use the of_dma_configure() helper > >to populate the dma properties and ass

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-02-22 Thread Srinivas Kandagatla
On 22/02/16 05:32, Bjorn Andersson wrote: On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set to be able to do DMA allocations, so use the of_dma_configure() helper to populate the dma properties and assign an appropriate dma_ops. Signed-off-by: Bjorn Andersson --- driv

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-02-21 Thread Bjorn Andersson
On Sun 21 Feb 22:02 PST 2016, Peter Chen wrote: > On Sun, Feb 21, 2016 at 09:32:13PM -0800, Bjorn Andersson wrote: > > On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set > > to be able to do DMA allocations, so use the of_dma_configure() helper > > to populate the dma propert

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-02-21 Thread Peter Chen
On Sun, Feb 21, 2016 at 09:32:13PM -0800, Bjorn Andersson wrote: > On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set > to be able to do DMA allocations, so use the of_dma_configure() helper > to populate the dma properties and assign an appropriate dma_ops. > > Signed-off-by

[PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-02-21 Thread Bjorn Andersson
On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set to be able to do DMA allocations, so use the of_dma_configure() helper to populate the dma properties and assign an appropriate dma_ops. Signed-off-by: Bjorn Andersson --- drivers/usb/chipidea/core.c | 4 1 file change