Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-09-16 Thread Heikki Krogerus
On Tue, Sep 16, 2014 at 12:07:00PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 15 September 2014 05:36 PM, Heikki Krogerus wrote: > > On Fri, Sep 12, 2014 at 07:41:56PM +0530, Kishon Vijay Abraham I wrote: > I don't think create lookup should be in host init. If it's dt boot, the

Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-09-15 Thread Kishon Vijay Abraham I
Hi, On Monday 15 September 2014 05:36 PM, Heikki Krogerus wrote: > On Fri, Sep 12, 2014 at 07:41:56PM +0530, Kishon Vijay Abraham I wrote: I don't think create lookup should be in host init. If it's dt boot, the binding should be in dt data or for other boot modes the bindig should be >

Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-09-15 Thread Heikki Krogerus
On Fri, Sep 12, 2014 at 07:41:56PM +0530, Kishon Vijay Abraham I wrote: > >> I don't think create lookup should be in host init. If it's dt boot, the > >> binding should be in dt data or for other boot modes the bindig should be > >> done > >> in the board file. This just seems hacky to me. > > >

Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-09-12 Thread Kishon Vijay Abraham I
Hi, On Friday 12 September 2014 07:19 PM, Heikki Krogerus wrote: > On Thu, Sep 11, 2014 at 08:31:19PM +0530, Kishon Vijay Abraham I wrote: >>> @@ -60,22 +59,33 @@ int dwc3_host_init(struct dwc3 *dwc) >>> goto err1; >>> } >>> >>> + phy_create_lookup(dwc->usb2_generic_phy, "usb2-

Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-09-12 Thread Heikki Krogerus
On Thu, Sep 11, 2014 at 08:31:19PM +0530, Kishon Vijay Abraham I wrote: > > @@ -60,22 +59,33 @@ int dwc3_host_init(struct dwc3 *dwc) > > goto err1; > > } > > > > + phy_create_lookup(dwc->usb2_generic_phy, "usb2-phy", > > + dev_name(&xhci->dev)); > > + phy_c

Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-09-11 Thread Kishon Vijay Abraham I
Hi, On Thursday 21 August 2014 05:03 PM, Heikki Krogerus wrote: > On some platforms a PHY may need to be handled also in the > host controller driver. Exynos5420 SoC requires some "PHY > tuning" based on the USB speed. This patch delivers dwc3's > PHYs to the xhci platform device when it's created

[PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

2014-08-21 Thread Heikki Krogerus
On some platforms a PHY may need to be handled also in the host controller driver. Exynos5420 SoC requires some "PHY tuning" based on the USB speed. This patch delivers dwc3's PHYs to the xhci platform device when it's created. Signed-off-by: Heikki Krogerus Tested-by: Vivek Gautam Acked-by: Fel