Re: [PATCH 02/30] usb: dwc2: Update DMA descriptor structure

2016-11-09 Thread John Youn
On 11/9/2016 4:18 AM, David Laight wrote: > From: John Youn >> Sent: 08 November 2016 22:30 > ... Also make it __packed. >>> >>> why are you making it packed? Does it _have_ to be packed? If it must, >>> why wasn't it before? >> >> We want to guarantee that it reflects the exact descriptor str

RE: [PATCH 02/30] usb: dwc2: Update DMA descriptor structure

2016-11-09 Thread David Laight
From: John Youn > Sent: 08 November 2016 22:30 ... > >> Also make it __packed. > > > > why are you making it packed? Does it _have_ to be packed? If it must, > > why wasn't it before? > > We want to guarantee that it reflects the exact descriptor structure > in memory, so probably yes. It was over

Re: [PATCH 02/30] usb: dwc2: Update DMA descriptor structure

2016-11-08 Thread John Youn
On 11/8/2016 1:14 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> From: Vahram Aharonyan >> >> Rename DMA descriptor structure from dwc2_hcd_dma_desc to dwc2_dma_desc >> as it is applies to both host and gadget. >> >> Also make it __packed. > > why are you making it packed? Does it _h

Re: [PATCH 02/30] usb: dwc2: Update DMA descriptor structure

2016-11-08 Thread Felipe Balbi
Hi, John Youn writes: > From: Vahram Aharonyan > > Rename DMA descriptor structure from dwc2_hcd_dma_desc to dwc2_dma_desc > as it is applies to both host and gadget. > > Also make it __packed. why are you making it packed? Does it _have_ to be packed? If it must, why wasn't it before? Also,