On Tue, Aug 18, 2015 at 01:27:31AM -0400, Raphaël Beamonte wrote:
> 2015-08-18 0:24 GMT-04:00 Sudip Mukherjee :
> >> + netdev_err("[Sendconfigpkt]Get Timed out\n");
> > This will not compile. you can not just replace printk with
> > netdev_*, you need to mention a net_de
> From: Linus Walleij
>
> This switches the BCMA GPIO driver to use GPIOLIB_IRQCHIP to
> handle its interrupts instead of rolling its own copy of the
> irqdomain handling etc.
>
> Signed-off-by: Linus Walleij
> Signed-off-by: Hauke Mehrtens
Thanks, applied to wireless-drivers-next.git.
Kall
> From: Miaoqing Pan
>
> MAC/BB name is"" if the MAC/BB is unknown.
>
> Signed-off-by: Miaoqing Pan
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
> From: Eliad Peller
>
> Sync the driver statistics acx and debugfs representation
> with the current fw api.
>
> Signed-off-by: Eliad Peller
Thanks, 2 patches applied to wireless-drivers-next.git:
c48276cbbeae wl18xx: update statistics acx and debugfs files
fc645df09392 wl18xx: add diversit
> rt2500usb_validate_eeprom() read data up to 0x6e (EEPROM_CALIBRATE_OFFSET)
> but only 0x6a bytes has been allocated and read from the eeprom.
>
> This lead to out-of-bound accesses and invalid values for
> EEPROM_BBPTUNE_R17 and EEPROM_CALIBRATE_OFFSET.
>
> Change the EEPROM_SIZE to 0x6e in or
> CC [M] drivers/net/wireless/mwl8k.o
> drivers/net/wireless/mwl8k.c: In function âmwl8k_bss_info_changedâ:
> drivers/net/wireless/mwl8k.c:3290:2: warning: âap_mcs_ratesâ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> memcpy(cmd->mcs_set, mcs_rates, 16);
> ^
>
> I change three things about below.
>
> 1. remove pci interface check routine in rtl92c_enable_interrupt
> because rtl8192cu chipset is always usb interface.
>
> 2. rename rtl92c_xxx_interrupt to rtl92cu_xxx_interrupt.
> rtl92c_xxx_interrupt functions can only be handled rtl8192cu chipset.
>
>
> I remove duplicated routines which related rtl92cu_set_hw_reg().
>
> 1. rtl92c_set_qos() and HW_VAR_AC_PARAM routine are similar code.
> so i replace code with rtlpriv->cfg->ops->set_hw_reg().
>
> 2. rtl92c_set_mac_addr() and 'HW_VAR_ETHER_ADDR' case at
> rtl92cu_set_hw_reg() routine are simil
> rtl92c_set_xxx_filter is same routine with rtl92cu_set_hw_reg.
> so i remove those functions that are rtl92c_set_xxx_filter.
> (rtl92c_get_xxx_filter is also same reason.)
> also i add code updating struct rtl_mac member variable in the
> rtl92cu_set_hw_reg.
> after that, no more _update_mac_set
Emmanuel Grumbach writes:
> On Fri, Aug 14, 2015 at 6:54 PM, Johannes Berg
> wrote:
>> Hi,
>>
>> And, in addition to the fix before, I have a -next pull request. It's
>> actually quite big since I hadn't wanted to send one just before my
>> vacation.
>>
>> Let me know if there are any issues.
>>
2015-08-18 0:24 GMT-04:00 Sudip Mukherjee :
>> + netdev_err("[Sendconfigpkt]Get Timed out\n");
> This will not compile. you can not just replace printk with
> netdev_*, you need to mention a net_device.
You're right! I'm making a lot of mistakes. It seems I called the m
On Mon, Aug 17, 2015 at 07:06:40PM -0400, Raphaël Beamonte wrote:
> Signed-off-by: Raphaël Beamonte
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
> drivers/staging/wilc1000/linux_wlan.c| 8
> drivers/staging/wilc1000/linux_wlan_common.h | 28
> ++--
Hello Dan.
On 2015년 08월 13일 23:49, Dan Carpenter wrote:
On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote:
+static u32 get_id_from_handler(tstrWILC_WFIDrv *handler)
+{
+ u32 id;
+
+ if (!handler)
+ return 0;
+
+ for (id = 0; id < NUM_CONCURRENT_IFC; id++)
On Mon, Aug 17, 2015 at 07:12:47PM -0400, Raphaël Beamonte wrote:
> The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't
> take care of possible memory leaks and subsequent bugs when it was failing
> after succeeding some allocations. This patch corrects this behavior.
>
> Signe
2015-08-17 15:41 GMT-04:00 Arend van Spriel :
> Probable MACRO_WILC_BUFFER should be MALLOC_WILC_BUFFER here.
Good catch!
> There is really no need to print an error message here. kmalloc will blurb
> enough info when it fails.
Ok!
> So these buffers are globals? So does this driver support mul
The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8
drivers/staging/wilc1000/linux_wlan_common.h | 28 ++--
drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-
drivers/sta
From: Johannes Berg
Date: Fri, 14 Aug 2015 17:54:36 +0200
> And, in addition to the fix before, I have a -next pull request. It's
> actually quite big since I hadn't wanted to send one just before my
> vacation.
>
> Let me know if there are any issues.
Pulled, thanks Johannes.
--
To unsubscribe
From: Johannes Berg
Date: Fri, 14 Aug 2015 13:20:26 +0200
> I'm back from vacation, and found a single bugfix waiting. It's in this
> pull request, but I'm not quite up to speed as to what's happening with
> the release. If it goes in, great; if not I've already tagged it with
> Cc stable anyway.
On Mon, Aug 17, 2015 at 03:28:29PM -0400, Raphaël Beamonte wrote:
> It was just a wrapper around kfree(), so call that instead.
Someone else already did this, sorry.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.ke
On Mon, Aug 17, 2015 at 03:28:27PM -0400, Raphaël Beamonte wrote:
> Signed-off-by: Raphaël Beamonte
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
> drivers/staging/wilc1000/linux_wlan.c| 8
> drivers/staging/wilc1000/linux_wlan_common.h | 28
> ++--
On Mon, Aug 17, 2015 at 10:44:31PM +0900, Chaehyun Lim wrote:
> This patch uses -EINVAL for invalid argument checking instead of using
> WILC_ERRORREPORT with WILC_INVALID_ARGUMENT.
>
> Signed-off-by: Chaehyun Lim
> ---
> drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
> 1 file changed, 2 ins
On Mon, Aug 17, 2015 at 10:44:29PM +0900, Chaehyun Lim wrote:
> The macros inside wilc_osconfig.h are not referenced anywhere,
> so just delete it.
>
> Signed-off-by: Chaehyun Lim
And I did this one also, again, sorry, I hadn't seen your email yet.
greg k-h
--
To unsubscribe from this list: sen
On Mon, Aug 17, 2015 at 10:44:28PM +0900, Chaehyun Lim wrote:
> The macros in wilc_log.h are not referenced anywhere, so just delete it.
Oops, I just did this same thing before I saw your email, sorry about
that.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless
On 08/17/2015 09:28 PM, Raphaël Beamonte wrote:
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
Probable MACRO_WILC_BUFFER should be MALLOC_WILC_BUFFER here.
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. Th
Hi,
Following comments from Dan Carpenter, please find the following
revised patches.
Raphaël
Raphaël Beamonte (5):
staging: wilc1000: remove void function return statements that are not
useful
staging: wilc1000: use pr_* instead of printk
staging: wilc1000: remove DECLARE_WILC_BUFFER
It was just a wrapper to initialize a variable. Initialize it
directly instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers/st
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8
drivers/staging/wilc1000/linux_wlan_common.h | 28 ++--
drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-
drivers/sta
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/host_interface.c| 4
drivers/staging/wilc1000/linux_wlan.c| 1 -
drivers/staging/wilc1000/wilc_exported_buf.c | 4 +---
drivers/staging/wilc1000/wilc_wlan.c | 3 ---
drivers/staging/wilc1000/wilc_wlan_cfg.c
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c
It was just a wrapper around kfree(), so call that instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers/staging/wilc1000/wilc_
On Mon, Aug 17, 2015 at 01:59:44PM -0400, Raphaël Beamonte wrote:
> 2015-08-17 13:47 GMT-04:00 Dan Carpenter :
> >> - printk("[Sendconfigpkt]Get Timed out\n");
> >> + pr_debug("[Sendconfigpkt]Get Timed out\n");
> >
> >
> > Possibly pr_err()?
>
2015-08-17 13:47 GMT-04:00 Dan Carpenter :
>> - printk("[Sendconfigpkt]Get Timed out\n");
>> + pr_debug("[Sendconfigpkt]Get Timed out\n");
>
>
> Possibly pr_err()?
Yep. My mistake. I'll do the same for Set Timed Out also!
>> -
On Mon, Aug 17, 2015 at 12:08:36PM -0400, Raphaël Beamonte wrote:
> Signed-off-by: Raphaël Beamonte
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
> drivers/staging/wilc1000/linux_wlan.c| 8 +++
> drivers/staging/wilc1000/linux_wlan_common.h | 32
> ++---
On Mon, Aug 17, 2015 at 12:08:34PM -0400, Raphaël Beamonte wrote:
> It was just a wrapper around kfree(), so call that instead.
>
> Signed-off-by: Raphaël Beamonte
> ---
> + kfree(exported_g_tx_buf);
> + exported_g_tx_buf = NULL;
No need to add these new NULL assignments. The module is
On Mon, Aug 17, 2015 at 12:08:35PM -0400, Raphaël Beamonte wrote:
> The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
> take care of possible memory leaks and subsequent bugs when it was failing
> after succeeding some allocations. This patch corrects this behavior.
>
> Signed
Hi,
The first 3 patches of the following 5 are aimed to simplify the
wilc_exported_buf.c macros as well as correct a potential memory
leak from the use of the MALLOC_WILC_BUFFER one.
The next 2 patches are correcting two kind of checkpatch warning
reports in different files of the wilc1000 driver
It was just a wrapper around kfree(), so call that instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers/staging/wilc100
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8 +++
drivers/staging/wilc1000/linux_wlan_common.h | 32 ++--
drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-
drivers/stag
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/host_interface.c| 4
drivers/staging/wilc1000/linux_wlan.c| 1 -
drivers/staging/wilc1000/wilc_exported_buf.c | 2 --
drivers/staging/wilc1000/wilc_wlan.c | 3 ---
drivers/staging/wilc1000/wilc_wlan_cfg.c |
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c
It was just a wrapper to initialize a variable. Initialize it
directly instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers
On 08/17/2015 06:11 AM, Sven Eckelmann wrote:
> Hi,
>
> On Friday 10 April 2015 16:32:29 Ben Greear wrote:
>> First, thanks to everyone that helped me with questions,
>> QCA/Tieto's upstream patches, etc.
>>
>> This needs more testing, but it appears to at least mostly work.
>>
>> I am using this
Vasanthakumar Thiagarajan writes:
> WMI 10.4 uses the same command interface as QCA988X for addba/delba
> debug wmi commands. Fill wmi_10_4_ops table with the functions used
> for QCA988X for these commands.
>
> With this change, the following debugfs entries can be used to
> configure the aggreg
Raja Mani writes:
> Existing phyerr event handlers directly uses phyerr header format
> (ie, struct wmi_phyerr and struct wmi_phyerr_event) in the code
> exactly on how firmware packs it. This is the problem in 10.4 fw
> specific phyerr event handling where it uses different phyerror
> header for
Nicholas Mc Guire writes:
> Return type of wait_for_completion_timeout is unsigned long not int.
> As remain is exclusively used for wait_for_completion_timeout here its
> type is simply changed to unsigned long.
>
>
> API conformance testing for completions with coccinelle spatches are being
> u
2015-08-17 5:08 GMT-04:00 Dan Carpenter :
> Pull it in one indent level... But actually this macro has a return in
> the middle of it, so it just introduces bugs all over the place like
> eating cookies in bed. We should just delete it instead.
You're right!
I'll clean those macro up and send a
Michal Kazior writes:
> Apparently it's not safe to install both pairwise
> and groupwise keys on AP vdevs as it can cause
> traffic to stop working in some multi-vif
> (WPA+WEP) cases.
>
> Fixes: ce90b27128c2 ("ath10k: fix multiple key static wep with ibss")
> Signed-off-by: Michal Kazior
Than
On 17 August 2015 at 10:01, Arend van Spriel wrote:
> On 08/16/2015 05:10 PM, Rafał Miłecki wrote:
>>
>> On 16 August 2015 at 08:55, Arend van Spriel wrote:
>>>
>>> This series comprises of following changes:
>>> - support NVRAM loading for bcm47xx platform.
>>> - revise announced interface combi
On Mon, Aug 17, 2015 at 10:44:30PM +0900, Chaehyun Lim wrote:
> WILC_ErrNo is replaced by s32, then WILC_ErrNo typedef is removed.
>
s32 is a weirdo type. You should only specify the number of bit when it
is something required by the hardware. Just use int.
regards,
dan carpenter
--
To unsubs
Michal Kazior writes:
> Vif's vdev_id is used as queue number. However due
> to the tx pausing design in ath10k it was possible
> for a new interface to be created with its tx
> queue stopped (via ieee80211_stop_queues). This
> could in turn leave the interface inoperable until
> ath10k_mac_tx_un
Vasanthakumar Thiagarajan writes:
> There are three WMI_CHAN_INFO events reported per channel
> in QCA99X0 firmware. First one is a notification at the begining
> of the channel dwell time with cmd_flag as CHAN_INFO_START(cmd_flag = 0),
> second one is a notification at the end of the dwell time
This patch uses -EINVAL for invalid argument checking instead of using
WILC_ERRORREPORT with WILC_INVALID_ARGUMENT.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqu
WILC_ErrNo is replaced by s32, then WILC_ErrNo typedef is removed.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_errorsupport.h | 2 --
drivers/staging/wilc1000/wilc_msgqueue.c | 12 ++--
drivers/staging/wilc1000/wilc_msgqueue.h | 8
drivers/staging/wil
The macros in wilc_log.h are not referenced anywhere, so just delete it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_log.h | 47 ---
drivers/staging/wilc1000/wilc_oswrapper.h | 2 --
2 files changed, 49 deletions(-)
delete mode 100644 drivers
The macros inside wilc_osconfig.h are not referenced anywhere,
so just delete it.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_osconfig.h | 9 -
drivers/staging/wilc1000/wilc_oswrapper.h | 1 -
2 files changed, 10 deletions(-)
delete mode 100644 drivers/staging/wilc100
Michal Kazior writes:
> Once HTT Tx queue got full offchannel queue was
> stopped and never woken up again. This broke, e.g.
> P2P. This could be reproduced after running a lot
> of traffic enough to saturate 100% of the driver
> Tx queue and then trying to send offchannel
> traffic.
>
> Fixes: 9
Hi,
On Friday 10 April 2015 16:32:29 Ben Greear wrote:
> First, thanks to everyone that helped me with questions,
> QCA/Tieto's upstream patches, etc.
>
> This needs more testing, but it appears to at least mostly work.
>
> I am using this 4.0 related kernel. I think only the last 3 patches
> a
On Sun, Aug 16, 2015 at 01:30:12AM -0400, Raphaël Beamonte wrote:
> #define MALLOC_WILC_BUFFER(name, size) \
> - exported_ ## name = kmalloc(size, GFP_KERNEL);\
> - if (!exported_ ## name) { \
> - printk("fail to alloc: %s memory\n", exported_ ## name); \
> -
+ Rafael
On 08/17/2015 09:29 AM, Johannes Berg wrote:
On Mon, 2015-08-17 at 09:48 +0800, Fu, Zhonghui wrote:
The suspend/resume timing of wiphy device and related devices will be
ensured by their parent/child relationship. So, enabling wiphy device
to suspend/resume asynchronously does not cha
On 08/16/2015 05:10 PM, Rafał Miłecki wrote:
On 16 August 2015 at 08:55, Arend van Spriel wrote:
This series comprises of following changes:
- support NVRAM loading for bcm47xx platform.
- revise announced interface combinations and validate against it.
- new debugfs entry for msgbuf protocol l
On Mon, 2015-08-17 at 09:48 +0800, Fu, Zhonghui wrote:
>
> The suspend/resume timing of wiphy device and related devices will be
> ensured by their parent/child relationship. So, enabling wiphy device
> to suspend/resume asynchronously does not change any dependency. It
> can only take advanta
62 matches
Mail list logo
