Re: Problem with brcmfmac removing extra interface

2016-05-06 Thread Rafał Miłecki
On 23 March 2016 at 20:13, Rafał Miłecki wrote: > On 23 March 2016 at 11:44, Arend Van Spriel > wrote: >> On 23-3-2016 9:47, Rafał Miłecki wrote: >>> On 22 March 2016 at 21:24, Arend van Spriel >>> wrote: On 22-3-2016 7:36, Rafał Miłecki wrote: > Hi, any ideas / help regarding this issu

Re: [PATCH v2] ath10k: release pre_cal_file while unloading driver

2016-05-06 Thread Valo, Kalle
Rajkumar Manoharan writes: > Failing to release pre_cal_file caldata on deinit causes memory leak. > > Fixes: b131129d9657 ("ath10k: fix calibration init sequence of qca99x0") > Signed-off-by: Rajkumar Manoharan Applied, thanks. -- Kalle Valo-- To unsubscribe from this list: send the line "un

Re: [PATCH v2 1/4] ath10k: add pdev bss channel info wmi definitions

2016-05-06 Thread Valo, Kalle
Rajkumar Manoharan writes: > Add WMI definitions for pdev bss channel information request and > event. > > Signed-off-by: Rajkumar Manoharan Applied, thanks. -- Kalle Valo-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.ke

Re: [PATCH] ath10k: Move spectral related structures under ath10k debugfs

2016-05-06 Thread Valo, Kalle
Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > Spectral related structures are accessed / modified only if ath10k > debugfs is enabled, so it makes more sense to move them under > ATH10K_DEBUGFS > > Signed-off-by: Mohammed Shafi Shajakhan Applied, thanks. -- Kalle Valo

Re: [PATCH v2] ath10k: remove VHT capabilities from 2.4GHz

2016-05-06 Thread Valo, Kalle
Kalle Valo writes: > From: Johannes Berg > > According to the spec, VHT doesn't exist in 2.4GHz. > > There are vendor extensions to allow a subset of VHT to work > (notably 256-QAM), but since mac80211 doesn't support those > advertising VHT capability on 2.4GHz leads to the behaviour > of repor

Re: [PATCH] ath10k: fix kernel panic, move arvifs list head init before htt init

2016-05-06 Thread Valo, Kalle
writes: > From: Anilkumar Kolli > > It is observed that while loading and unloading ath10k modules > in an infinite loop, before ath10k_core_start() completion HTT > rx frames are received, while processing these frames, > dereferencing the arvifs list code is getting hit before > initilizing th

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Alexander Duyck
On Fri, May 6, 2016 at 11:01 AM, Larry Finger wrote: > On 05/06/2016 12:13 PM, Alexander Duyck wrote: >> >> On Fri, May 6, 2016 at 9:33 AM, Wang YanQing wrote: >>> >>> We can't use kfree_skb in irq disable context, because spin_lock_irqsave >>> make sure we are always in irq disable context, use

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Larry Finger
On 05/06/2016 12:13 PM, Alexander Duyck wrote: On Fri, May 6, 2016 at 9:33 AM, Wang YanQing wrote: We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better than dev_kfree_skb_any

Limiting bit rate on BCM43438

2016-05-06 Thread Tom Harada
Hi, On a Raspberry Pi 3 running Raspbian, I'm finding it impossible to maintain a stable WiFi connection with 802.11n access points using the internal BCM43438 chip. The association is lost quite frequently (as often as twice a minute) and often fails to be recovered. I've tried the usual fix

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Alexander Duyck
On Fri, May 6, 2016 at 9:33 AM, Wang YanQing wrote: > We can't use kfree_skb in irq disable context, because spin_lock_irqsave > make sure we are always in irq disable context, use dev_kfree_skb_irq > instead of kfree_skb is better than dev_kfree_skb_any. > > This patch fix below kernel warning: >

Re: [PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Larry Finger
On 05/06/2016 11:33 AM, Wang YanQing wrote: We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better than dev_kfree_skb_any. This patch fix below kernel warning: [ 7612.095528] --

[PATCH v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Wang YanQing
We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better than dev_kfree_skb_any. This patch fix below kernel warning: [ 7612.095528] [ cut here ] [ 7612.0955

Re: [PATCH] Fix kernel oops in failed chip_attach

2016-05-06 Thread Kalle Valo
Christian Daudt writes: > On Fri, May 6, 2016 at 4:53 AM, Kalle Valo wrote: >> Christian Daudt writes: >> >>> When chip attach fails, brcmf_sdiod_intr_unregister is being called >>> but that is too early as sdiodev->settings has not been set yet >>> nor has brcmf_sdiod_intr_register been called

Re: [PATCH] Fix kernel oops in failed chip_attach

2016-05-06 Thread Christian Daudt
On Fri, May 6, 2016 at 4:53 AM, Kalle Valo wrote: > Christian Daudt writes: > >> When chip attach fails, brcmf_sdiod_intr_unregister is being called >> but that is too early as sdiodev->settings has not been set yet >> nor has brcmf_sdiod_intr_register been called. >> Change to use oob_irq_reques

Re: [PATCH] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb in rtl_pci_reset_trx_ring

2016-05-06 Thread Larry Finger
On 05/05/2016 12:19 PM, Wang YanQing wrote: We can't use kfree_skb in irq disable context, because spin_lock_irqsave make sure we are always in irq disable context, use dev_kfree_skb_irq instead of kfree_skb is better than dev_kfree_skb_any. This patch fix below kernel warning: [ 7612.095528] --

Re: [PATCH] Fix regression in Android due to rework .get_station() callback

2016-05-06 Thread Kalle Valo
Jaap Jan Meijer writes: > 2016-05-06 16:12 GMT+01:00 Kalle Valo : >> Jaap Jan Meijer writes: >> >>> Hi Kalle, >>> >>> Op vr 6 mei 2016 12:52 schreef Kalle Valo : >>> >>> >>> This has multiple issues: >>> >>> o Use your full name. >>> o Use prefix "brcmfmac: " in the title. >>> >>>

Re: [PATCH] Fix regression in Android due to rework .get_station() callback

2016-05-06 Thread Jaap Jan Meijer
2016-05-06 16:12 GMT+01:00 Kalle Valo : > Jaap Jan Meijer writes: > >> Hi Kalle, >> >> Op vr 6 mei 2016 12:52 schreef Kalle Valo : >> >> >> This has multiple issues: >> >> o Use your full name. >> o Use prefix "brcmfmac: " in the title. >> >> o I can't find commit f654d13, is the c

[PATCH 2/2] ath10k: Fix survey reporting with QCA4019

2016-05-06 Thread Vasanthakumar Thiagarajan
In QCA4019, cycle counter wraparound in same fashion as QCA988X. When the cycle counter wraparound it resets to 0x7fff. Set has_shifted_cc_wraparound to true for QCA4019 to enable the code path to handle cycle counter wraparound for consistent survey report. Signed-off-by: Vasanthakumar Thiaga

[PATCH 1/2] ath10k: suppress warnings when getting wmi peer_rate_code_list event

2016-05-06 Thread Vasanthakumar Thiagarajan
In 10.4, fw sends WMI PEER_RATECODE_LIST_EVENTID after successful peer_assoc cmd. As of now this event is not of much use and not implemented. Change the debug level and messsage as appropriate to suppress "Unknown eventid: 36898". Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireles

Re: [PATCH] Fix kernel oops in failed chip_attach

2016-05-06 Thread Kalle Valo
Christian Daudt writes: > When chip attach fails, brcmf_sdiod_intr_unregister is being called > but that is too early as sdiodev->settings has not been set yet > nor has brcmf_sdiod_intr_register been called. > Change to use oob_irq_requested + newly created sd_irq_requested > to decide on what t

Re: [PATCH] Fix regression in Android due to rework .get_station() callback

2016-05-06 Thread Kalle Valo
meijjaa writes: > After f654d13 Android is not able to get station signal strength. > To much was removed, this patch brings back the needed functionality. > > Signed-off-by: meijjaa This has multiple issues: o Use your full name. o Use prefix "brcmfmac: " in the title. o I can't find commit

Re: pull request: iwlwifi 2016-05-04

2016-05-06 Thread Kalle Valo
"Grumbach, Emmanuel" writes: > I know it is extremely late in the cycle, but this patch is intended > for 4.6... It fixes a regression I introduced: a P2P specification > violation as mentioned in the commit message. > The patch is rather big in terms of number of lines changed, but the > semanti

Re: Planned Support for BCM 43162 [14e4:43ae] rev 02 ?

2016-05-06 Thread Jan Sobotka
>>You may try: >>sudo su >>rmmod bcma >>echo "14e4 43ae" > /sys/bus/pci/drivers/brcmfmac/new_id >>dmesg | grep brcmfmac Output: [14054.947644] usbcore: registered new interface driver brcmfmac Full command history: root@chobot-lenovo-laptop:~# lsmod | grep bcma root@chobot-lenovo-laptop:~# rmmod

Re: Realtek RTL8723BE wireless card drops connection

2016-05-06 Thread Hin-Tak Leung
The MAINTAINERS file did mention that the appropriate mailing list to use is the linux-wireless one. Using an appropriate list is preferable to e-mailing individuals. Added in the TO:. That card uses the rtlwifi module, so that seems to be Larry's and Chaoming's to look at.

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

2016-05-06 Thread Wei-Ning Huang
On Fri, May 6, 2016 at 12:07 AM, Dan Williams wrote: > > On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote: > > Recent new hardware has the ability to switch between tablet mode and > > clamshell mode. To optimize WiFi performance, we want to be able to > > use > > different power table betw

Re: [PATCHv4 5/5] mac80211: add debug knobs for codel

2016-05-06 Thread Dave Taht
On Thu, May 5, 2016 at 11:33 PM, Michal Kazior wrote: > On 6 May 2016 at 07:51, Dave Taht wrote: >> On Thu, May 5, 2016 at 10:27 PM, Michal Kazior >> wrote: >>> On 5 May 2016 at 17:21, Dave Taht wrote: On Thu, May 5, 2016 at 4:00 AM, Michal Kazior wrote: > This adds a few debug