Re: [PATCH] ath10k: Adjust the RX packet pad offset at QCA99X0 4addr mode

2015-11-20 Thread Mohammed Shafi Shajakhan
Hi Kalle\Yanbo, On Mon, Nov 16, 2015 at 10:57:44PM +0200, Kalle Valo wrote: > "Li, Yanbo" writes: > > >> > +/* The padding bytes's location is different on various > >> > chips */ > >> > +enum ath10k_loc_4addr_pad loc_4addr_pad; > >> > >> I think that loc prefix

[PATCH] ath10k: Enable AP + STA interface combination support for 10.x

2015-11-21 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Enable AP + STA interface combination support for 10.x and this enables Repeater mode testing (with WDS Repeater combinations as well). Fix indentation as well. Based on the suggestions from Michal and Yanbo Li, thanks to them Signed-off-by: Mohammed Shafi

[PATCH v2] ath10k: Fix write permission on few debugfs files

2015-11-24 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Fix write permission for few of the debugfs entries which support write file operations as well. Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/debug.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] ath10k: Remove unnecessary amsdu/ampdu assignment in debugfs

2015-11-30 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan The default values of max_num_amsdu / max_num_amdpu is assigned a default value as part of 'ath10k_core_init_firmware_features' Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/debug.c |2 +- 1 file changed, 1 inser

Re: [PATCH 6/7] ath10k: Enable periodic peer stats update

2016-01-21 Thread Mohammed Shafi Shajakhan
On Thu, Jan 21, 2016 at 02:48:13PM +0200, Kalle Valo wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > Register for 500ms as periodic peer stats update period, > > and parameters like rx_duration that needs to be tracked >

[PATCH 0/2] Peer Stats fixes for rx duration

2016-02-03 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan This is a small patchset that fixes: 1. Updating rx duration per station (part of mac80211 STA debugfs) irrespective user does a cat fw_stats in ath10k debugfs 2. Remove updating peer stats list (which is completely useless) when we recieve periodic update of

[PATCH 1/2] ath10k: Fix updating peer stats rx duration

2016-02-03 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan We are not updating peer stats rx_duration periodically unless the user one polls for fw_stats, this is because we discard the update event since pdev list is empty. Fix this by updating rx duration periodically irrepective of checks for pdev list (irrespective of

[PATCH 2/2] ath10k: Fix pointless update of peer stats list

2016-02-03 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan We periodically receive f/w stats event for updating the rx duration and there is no reason to keep on appending the f/w stats peer list, as this gets completely cleaned up when the user polls for f/w stats {pdev, vdev, peer stats}. Only don't print the wa

Re: [PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

2016-05-09 Thread Mohammed Shafi Shajakhan
Hi Ben, On Fri, Apr 01, 2016 at 02:12:08PM -0700, gree...@candelatech.com wrote: > From: Ben Greear > > Otherwise, the txrx-compl-task may access some bad memory? good to mention when this happens, will be helpful ifsome one recreates the issue and matches your call trace > > Signed-off-by: B

Re: [PATCH v2 3/5] ath10k: Add WARN_ON if we over-write peer-map pointer.

2016-05-10 Thread Mohammed Shafi Shajakhan
Hi Ben, On Fri, Apr 01, 2016 at 02:12:10PM -0700, gree...@candelatech.com wrote: > From: Ben Greear > > Not sure this can happen, but seems like a reasonable sanity > check. [shafi] possibly if the peer is removed and the bit is not cleared in the driver ? when the new peer occupies the slot >

Re: [PATCH 15/21] ath10k: support CT firmware flag.

2016-05-10 Thread Mohammed Shafi Shajakhan
Hi Ben, On Mon, May 09, 2016 at 04:11:09PM -0700, gree...@candelatech.com wrote: > From: Ben Greear > > Add placeholder so CT firmware can more easily co-exist with upstream > kernel. [shafi] nitpick: good to provide an expansion in commit log as well, so that if we can easily figure out in git

[PATCH] ath10k: Reduce warning messages during rx without proper channel context

2016-05-10 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan WARN_ON_ONCE when we receive packets for self peer when mac80211 had not assigned a proper channel context. This scenario happens in QCA4019 when we start the AP via hostapd in background and start it once again in the background without killing the previous

[PATCH] ath10k: Fix 10.4 extended peer stats update

2016-05-10 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan 10.4 'extended peer stats' will be not be appended with normal peer stats data and they shall be coming in separate chunks. Fix this by maintaining a separate linked list 'extender peer stats' for 10.4 and update rx_duration for per station st

Re: [PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

2016-05-10 Thread Mohammed Shafi Shajakhan
> > > >On Fri, Apr 01, 2016 at 02:12:08PM -0700, gree...@candelatech.com wrote: > >>From: Ben Greear > >> > >>Otherwise, the txrx-compl-task may access some bad memory? > > > >good to mention when this happens, will be helpful ifsome one recreates > >the issue and matches your call trace > > The

Re: [PATCH v2 3/5] ath10k: Add WARN_ON if we over-write peer-map pointer.

2016-05-10 Thread Mohammed Shafi Shajakhan
On Tue, May 10, 2016 at 07:41:44AM -0700, Ben Greear wrote: > > > On 05/10/2016 12:12 AM, Mohammed Shafi Shajakhan wrote: > >Hi Ben, > > > >On Fri, Apr 01, 2016 at 02:12:10PM -0700, gree...@candelatech.com wrote: > >>From: Ben Greear > >> &

Re: [PATCH] ath10k: Fix 10.4 extended peer stats update

2016-05-10 Thread Mohammed Shafi Shajakhan
On Tue, May 10, 2016 at 09:34:55AM -0700, Ben Greear wrote: > On 05/10/2016 09:27 AM, Mohammed Shafi Shajakhan wrote: > >From: Mohammed Shafi Shajakhan > > > >10.4 'extended peer stats' will be not be appended with normal peer stats > >data and they shall be c

[PATCH v1] ath10k: Fix 10.4 extended peer stats update

2016-05-10 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan 10.4 'extended peer stats' will be not be appended with normal peer stats data and they shall be coming in separate chunks. Fix this by maintaining a separate linked list 'extender peer stats' for 10.4 and update rx_duration for per station st

Re: [PATCH v3 RESEND 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-05-17 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Fri, May 13, 2016 at 03:13:36PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > Enable support for 'drv_sta_statistics' callback. > > Export rx_duration support if available to cfg80

[PATCH] ath10k: Fix legacy rate packet debug messages

2016-05-17 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Legacy rate packets may not necessarily be having a rx status flag of '0' always, for example management frame have flags like RX_FLAG_ONLY_MONITOR / RX_FLAG_MACTIME_END also set Just check 'VHT' and 'HT' flags are not set , and si

[PATCH 1/2] ath10k: Remove duplicate and unused rx rate flags

2016-05-20 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan All these flags are not used and their use is completely covered by 'ath10k_hw_rate_ofdm', 'ath10k_hw_rate_cck', and RX_PPDU_START_RATE_FLAG Signed-off-by: Mohammed Shafi Shajakhan --- [thanks Michal/Kalle/Vasanth for the first level r

[PATCH 2/2] ath10k: Fix CCK h/w rates for QCA99X0 and newer chipsets

2016-05-20 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan CCK hardware table mapping from QCA99X0 onwards got revised. The CCK hardware rate values are in a proper order wrt. to rate and preamble as below ATH10K_HW_RATE_REV2_CCK_LP_1M = 1, ATH10K_HW_RATE_REV2_CCK_LP_2M = 2, ATH10K_HW_RATE_REV2_CCK_LP_5_5M = 3

Re: [PATCH 1/2] ath10k: add QCA9887 chipset support

2016-05-22 Thread Mohammed Shafi Shajakhan
Hi Sven, On Fri, May 20, 2016 at 04:41:11PM +0200, Sven Eckelmann wrote: > Add the hardware name, revision, firmware names and update the pci_id > table. > > QA9887 HW1.0 is supposed to be similar to QCA988X HW2.0 . Details about > he firmware interface are currently unknown. > > Signed-off-by:

Re: [PATCH 1/2] ath10k: add QCA9887 chipset support

2016-05-22 Thread Mohammed Shafi Shajakhan
On Mon, May 23, 2016 at 11:52:11AM +0530, Mohammed Shafi Shajakhan wrote: > Hi Sven, > > On Fri, May 20, 2016 at 04:41:11PM +0200, Sven Eckelmann wrote: > > Add the hardware name, revision, firmware names and update the pci_id > > table. > > > > QA9887 HW1.0 is

[PATCH] ath10k: Fix error while writing 'simulate_fw_crash' debugfs

2016-05-26 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Fix invalid argument error while writing 'simulate_fw_crash', though the funcionality is working fine we get an error 'invalid argument' because 'count' value is not returned properly (no reason to reduce the count value for removing

[PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-05-27 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan 10.4 'extended peer stats' will be not be appended with normal peer stats data and they shall be coming in separate chunks. Fix this by maintaining a separate linked list 'extender peer stats' for 10.4 and update rx_duration for per station st

Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update

2016-05-27 Thread Mohammed Shafi Shajakhan
On Fri, May 27, 2016 at 10:12:45AM +0200, Sven Eckelmann wrote: > On Wednesday 11 May 2016 11:54:30 Mohammed Shafi Shajakhan wrote: > > #else > > -static inline void ath10k_sta_update_rx_duration(struct ath10k *ar, > > -s

Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update

2016-05-31 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Tue, May 31, 2016 at 11:09:38AM +, Valo, Kalle wrote: > "Shajakhan, Mohammed Shafi (Mohammed Shafi)" > writes: > > seems the change got merged in pending branch > > https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=2a872321e07506e339fc1b3ca81a

Re: [PATCH v4] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-05-31 Thread Mohammed Shafi Shajakhan
On Tue, May 31, 2016 at 11:41:08AM +0200, Johannes Berg wrote: > On Thu, 2016-04-07 at 20:00 +0530, Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION'. > > '

Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-05-31 Thread Mohammed Shafi Shajakhan
Hi Kalle, thanks for the review On Tue, May 31, 2016 at 12:18:49PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > 10.4 'extended peer stats' will be not be appended with normal peer stats > > d

Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-06-01 Thread Mohammed Shafi Shajakhan
Hello, On Tue, May 31, 2016 at 06:57:52PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > >> > +void ath10k_sta_update_rx_duration(struct ath10k *ar, > >> > + struct ath10k_fw_stats *stats) > >> >

Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-06-01 Thread Mohammed Shafi Shajakhan
On Wed, Jun 01, 2016 at 01:00:40PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > Hello, > > > > On Tue, May 31, 2016 at 06:57:52PM +, Valo, Kalle wrote: > >> Mohammed Shafi Shajakhan writes: > >> > >> >>

[PATCH v3] ath10k: Fix 10.4 extended peer stats update

2016-06-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan 10.4 'extended peer stats' will be not be appended with normal peer stats data and they shall be coming in separate chunks. Fix this by maintaining a separate linked list 'extender peer stats' for 10.4 and update rx_duration for per station st

[PATCH v2 2/2] ath10k: fix CCK h/w rates for QCA99X0 and newer chipsets

2016-06-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan CCK hardware table mapping from QCA99X0 onwards got revised. The CCK hardware rate values are in a proper order wrt. to rate and preamble as below ATH10K_HW_RATE_REV2_CCK_LP_1M = 1, ATH10K_HW_RATE_REV2_CCK_LP_2M = 2, ATH10K_HW_RATE_REV2_CCK_LP_5_5M = 3

[PATCH v2 1/2] ath10k: remove duplicate and unused rx rate flags

2016-06-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan All these flags are not used and their use is completely covered by 'ath10k_hw_rate_ofdm', 'ath10k_hw_rate_cck', and RX_PPDU_START_RATE_FLAG Signed-off-by: Mohammed Shafi Shajakhan Patchwork-Id: 9129361 Signed-off-by: Kalle Valo --- driv

Re: [PATCH v2 1/2] ath10k: remove duplicate and unused rx rate flags

2016-06-02 Thread Mohammed Shafi Shajakhan
On Thu, Jun 02, 2016 at 01:45:15PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > All these flags are not used and their use is completely > > covered by 'ath10k_hw_rate_ofdm', 'ath10k_

[PATCH v3 1/2] ath10k: remove duplicate and unused rx rate flags

2016-06-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan All these flags are not used and their use is completely covered by 'ath10k_hw_rate_ofdm', 'ath10k_hw_rate_cck', and RX_PPDU_START_RATE_FLAG Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath

[PATCH v3 2/2] ath10k: fix CCK h/w rates for QCA99X0 and newer chipsets

2016-06-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan CCK hardware table mapping from QCA99X0 onwards got revised. The CCK hardware rate values are in a proper order wrt. to rate and preamble as below ATH10K_HW_RATE_REV2_CCK_LP_1M = 1, ATH10K_HW_RATE_REV2_CCK_LP_2M = 2, ATH10K_HW_RATE_REV2_CCK_LP_5_5M = 3

Re: Bug 119151 - [regression] ath10k no longer authenitcates and freezes system

2016-06-02 Thread Mohammed Shafi Shajakhan
On Thu, Jun 02, 2016 at 08:21:41AM -0700, Ben Greear wrote: > On 06/02/2016 07:24 AM, Valo, Kalle wrote: > >Kalle Valo writes: > > > >>there's a regression in ath10k: > >> > >>https://bugzilla.kernel.org/show_bug.cgi?id=119151 > >> > >>Reporter bisected it to this: > >> > >>5c86d97bcc1d42ce7f75685

Re: [PATCH 0/2] ath10k: Add support for QCA9887

2016-06-07 Thread Mohammed Shafi Shajakhan
Hi Sven, On Mon, May 30, 2016 at 01:12:27PM +0200, Sven Eckelmann wrote: > On Friday 27 May 2016 12:44:52 Valo, Kalle wrote: > [...] > > > But maybe I should add that the results with the original AP147 firmware > > > also > > > wasn't better. > > > > That doesn't sound good. Maybe a calibration

Re: [PATCH 0/2] ath10k: Add support for QCA9887

2016-06-07 Thread Mohammed Shafi Shajakhan
Hi Sven, On Tue, Jun 07, 2016 at 06:54:54PM +0200, Sven Eckelmann wrote: > On Tuesday 07 June 2016 20:20:02 Mohammed Shafi Shajakhan wrote: > [...] > > [shafi] it would be helpful if you can share your basic test results (if its > > possible to share). Have you tried to bring u

Re: [PATCH 0/2] ath10k: Add support for QCA9887

2016-06-08 Thread Mohammed Shafi Shajakhan
On Tue, Jun 07, 2016 at 10:41:48PM +0530, Mohammed Shafi Shajakhan wrote: > Hi Sven, > > On Tue, Jun 07, 2016 at 06:54:54PM +0200, Sven Eckelmann wrote: > > On Tuesday 07 June 2016 20:20:02 Mohammed Shafi Shajakhan wrote: > > [...] > > > [shafi] it would be helpf

Re: [PATCH 0/2] ath10k: Add support for QCA9887

2016-06-08 Thread Mohammed Shafi Shajakhan
STBC && (ar->cfg_tx_chainmask > 1)) ht_cap.cap |= IEEE80211_HT_CAP_TX_STBC; if (ar->ht_cap_info & WMI_HT_CAP_RX_STBC) { -- regards, shafi On Wed, Jun 08, 2016 at 06:13:08PM +0530, Mohammed Shafi Shajakhan wrote: > On Tue, Jun 07, 2016 at 10:41:48PM +0530, Moh

[PATCH v2] ath10k: Fix crash during card removal

2016-06-09 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Usually when the firmware crashes we check for the value 'FW_IND_EVENT_PENDING' in 'FW_INDICATOR_ADDRESS' and proceed with disabling the irq and dumping firmware 'crash dump'. Now when the PCI card is unplugged from the device the PCI

[PATCH] ath10k: Remove unneccessary WARN_ON_ONCE in rx during ACS

2016-06-09 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan The below warning message seems to hit occasionally with the following combination (IPQ4019 + ACS scan) where we receive packets as a self peer when hostapd does ACS when we bring up AP mode . ath10k has the below fall back mechanism to fetch current operating

[PATCH] ath10k: Fix a typo in spectral code commments

2016-06-13 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Found this obvious typo while going through the spectral code design in ath10k Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/spectral.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath

[PATCH v4 2/2] ath10k: Remove debugfs support for Per STA total rx duration

2016-06-14 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan cfg80211/nl80211 interface changes for per STA total rx-duration and very basic 'ath10k_sta_statistics' mac80211 callback is implemented to extend support for per station statistics from the driver. Also provision in 'iw dev wlan#N station du

[PATCH v4 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-06-14 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Enable support for 'drv_sta_statistics' callback. Export rx_duration support if available to cfg80211/nl80211 This can also act as a placeholder for any new per STA stats support Signed-off-by: Mohammed Shafi Shajakhan --- [v4] rebased over 'pend

Re: [PATCH v4 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-06-14 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Tue, Jun 14, 2016 at 01:58:25PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > Enable support for 'drv_sta_statistics' callback. > > Export rx_duration support if available to cfg80

[PATCH] ath10k: Enable beacon loss detection support for 10.4

2016-06-16 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Enable beacon loss detection support for 10.4 by handling roam event. With this change QCA99X0 station is able to detect beacon loss when the AP is powered off Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/wmi.c | 4 1 file

[PATCH] ath10k: Disable TX_STBC for tx chainmask of 1

2016-06-16 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Disable TX_STBC for both HT and VHT if the devices tx chainmask is '1' TX_STBC is required only for devices with tx_chainmask > 1. This fixes a ping failure for QCA9887 (1x1) in HT/VHT mode Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net

Re: [PATCH] ath10k: Fix a typo in spectral code commments

2016-06-16 Thread Mohammed Shafi Shajakhan
On Thu, Jun 16, 2016 at 11:59:59AM -0400, Bob Copeland wrote: > On Tue, Jun 14, 2016 at 11:03:54AM +0530, Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > Found this obvious typo while going through the spectral > > code design in ath10k >

[PATCH v2] ath10k: Fix some typo in spectral code commments

2016-06-16 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Found this obvious typo while going through the spectral code design in ath10k Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/spectral.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath

Re: Bug with: ath10k: enable parsing per station rx duration for 10.4?

2016-06-20 Thread Mohammed Shafi Shajakhan
and I somehow screwed up when rebasing [shafi] i will check this and get back to you by end of day. regards, shafi > > > Author: Mohammed Shafi Shajakhan 2016-03-16 > 05:43:34 > Committer: Kalle Valo 2016-04-04 07:02:47 > Parent: 47771902a9beb23859805721f1d98d

Re: Bug with: ath10k: enable parsing per station rx duration for 10.4?

2016-06-21 Thread Mohammed Shafi Shajakhan
On Tue, Jun 21, 2016 at 07:10:28AM -0700, Ben Greear wrote: > > > On 06/20/2016 10:18 PM, Mohammed Shafi Shajakhan wrote: > >Hi Ben, > > > >thanks for reporting ... > > > >On Mon, Jun 20, 2016 at 04:06:52PM -0700, Ben Greear wrote: > >>I'

[PATCH 2/2] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later

2016-06-23 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan For chipsets like QCA99X0, IPQ4019 and later we are not getting proper NULL func status (always acked/successs !!) when hostapd does a PROBE_CLIENT via nullfunc frames when the station is powered off abruptly (inactive timer probes client via null func after the

[PATCH 1/2] ath10k: Replace warning with an error message if HTT op version is unset

2016-06-23 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Print an ath10k error message rather a call trace when HTT op version is not found from firmware META data (IE). This should be sufficient to figure out what went wrong. Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1

Re: [PATCH 2/2] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later

2016-06-25 Thread Mohammed Shafi Shajakhan
Hello Ben, On Thu, Jun 23, 2016 at 10:12:01AM -0700, Ben Greear wrote: > On 06/23/2016 09:40 AM, Mohammed Shafi Shajakhan wrote: > >From: Mohammed Shafi Shajakhan > > > >For chipsets like QCA99X0, IPQ4019 and later we are not getting proper > >NULL func status (alw

Re: [PATCH 2/2] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later

2016-06-27 Thread Mohammed Shafi Shajakhan
Hi Michal, thanks for the review .. On Mon, Jun 27, 2016 at 11:27:27AM +0200, Michal Kazior wrote: > On 23 June 2016 at 18:40, Mohammed Shafi Shajakhan > wrote: > > From: Mohammed Shafi Shajakhan > > > > For chipsets like QCA99X0, IPQ4019 and later we are not gett

Re: [PATCH 2/2] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later

2016-06-29 Thread Mohammed Shafi Shajakhan
Hello Michal/ Kalle, On Tue, Jun 28, 2016 at 08:48:38AM +0200, Michal Kazior wrote: > On 27 June 2016 at 16:36, Mohammed Shafi Shajakhan > wrote: > > Hi Michal, > > > > thanks for the review .. > > > > On Mon, Jun 27, 2016 at 11:27:27AM +0200, Michal Kazior

Re: [PATCH v3] ath10k: Fix 10.4 extended peer stats update

2016-06-30 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Thu, Jun 30, 2016 at 10:49:02AM +, Valo, Kalle wrote: > Kalle Valo writes: > > >> @@ -261,6 +263,7 @@ static const struct ath10k_hw_params > >> ath10k_hw_params_list[] = { > >>.board = QCA4019_HW_1_0_BOARD_DATA_FILE, > >>.board_size = QCA

Re: [PATCH v3] ath10k: Fix 10.4 extended peer stats update

2016-06-30 Thread Mohammed Shafi Shajakhan
On Thu, Jun 30, 2016 at 11:09:31AM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > Hi Kalle, > > > > On Thu, Jun 30, 2016 at 10:49:02AM +, Valo, Kalle wrote: > >> Kalle Valo writes: > >> > >> >>

Re: [PATCH 2/2] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later

2016-07-08 Thread Mohammed Shafi Shajakhan
Hi Michal / Kalle / Ben, is this patch is good to go (or) should i re-work ? I had replied to Michal's comment of introducing a new firmware feature flag will not address the issue in older firmware / code. Let me know if i had missed something very obvious. On Tue, Jul 05, 2016 at 08:21:01AM -

[RESEND PATCH v4] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later

2016-07-20 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan For chipsets like QCA99X0, IPQ4019 and later we are not getting proper NULL func status (always acked/successs !!) when hostapd does a PROBE_CLIENT via nullfunc frames when the station is powered off abruptly (inactive timer probes client via null func after the

Re: [PATCH 2/2] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later

2016-07-20 Thread Mohammed Shafi Shajakhan
On Wed, Jul 20, 2016 at 02:22:29PM +0200, Michal Kazior wrote: > On 20 July 2016 at 13:43, Shajakhan, Mohammed Shafi (Mohammed Shafi) > wrote: > > Michal, > > > > Can you please let me know if this change is fine or not ? > > I am waiting infinitely for your reply long time > > Sorry. I was abse

[PATCH] ath10k: Remove driver log suggesting QCA9887 support is experimental

2016-07-27 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Support for QCA9887 is no longer experimental and if there are any issues we need to address them Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k

[PATCH] ath10k: suppress warnings when getting wmi WDS peer event id

2016-08-17 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan 'WMI_10_4_WDS_PEER_EVENTID' is not yet handled/implemented for WDS mode, as of nowsuppress the warning message "Unknown eventid: 36903" Signed-off-by: Mohammed Shafi Shajakhan --- found this issue while running ath10k WDS AP -> ath

Re: [PATCH 3/3] ath10k: Improve logging message.

2016-08-18 Thread Mohammed Shafi Shajakhan
Hi Ben, On Thu, Aug 18, 2016 at 06:26:35PM -0700, gree...@candelatech.com wrote: > From: Ben Greear > > Helps to know the sta pointer. > > Signed-off-by: Ben Greear > --- > drivers/net/wireless/ath/ath10k/mac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/driv

[PATCH v5] ath10k: Fix broken NULL func data frame status for 10.4

2016-08-26 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Older firmware with HTT delivers incorrect tx status for null func frames to driver, but this fixed in 10.2 and 10.4 firmware versions. Also this workaround results in reporting of incorrect null func status for 10.4. Fix this is by introducing a firmware feature

[PATCH] ath10k: Remove unnecessary error code assignment

2016-09-01 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan The error assigned does not seems to be used anywhere, fixes nothing just a small cleanup Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/wmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c

[PATCH] ath10k: Fix cleanup in ath10k_thermal_unregister

2015-10-08 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan First remove the 'cooling_device#n' syslink created for ath10k and then unregsiter from the thermal subsystem(cooling) Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/thermal.c |2 +- 1 file changed, 1 insertion(+),

[PATCH] mac80211: Fix hwflags debugfs file format

2015-10-08 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Commit 30686bf7f5b3 ("mac80211: convert HW flags to unsigned long bitmap") accidentally removed the newline delimiter from the hwflags debugfs file. Fix this by adding back the newline between the HW flags. Signed-off-by: Mohammed Shafi Shajakhan [fix

[PATCH] ath10k: Ignore SWBA event for a vif if its marked for no beacon

2016-09-20 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Ignore processing further in SWBA event scheduled for a vif, if mac80211 has marked the particular vif for stop beaconing and brought the vdev down in 'ath10k_control_beaconing'. This should potentially avoid ath10k warning/error messages while running

[PATCH v4] ath10k: Cleanup calling ath10k_htt_rx_h_unchain

2016-09-27 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan 'ath10k_htt_rx_h_unchain' is need to be called only if the return value from 'ath10k_htt_rx_amsdu_pop' is 1('chained msdu's'), this change makes it more explicit and avoids doing a skb_peek, fetching rx descriptor pointer, checkin

[PATCH] ath10k: Cleanup calling ath10k_htt_rx_h_unchain

2016-09-27 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan 'ath10k_htt_rx_h_unchain' is need to be called only if the return value from 'ath10k_htt_rx_amsdu_pop' is 1('chained msdu's'), this change makes it more explicit and avoids doing a skb_peek, fetching rx descriptor pointer, checkin

[PATCH 0/2] ath10k: Trivial cleanup in HTT tx buffer allocation

2016-10-04 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Pre-requisite cleanup changes for one time tx buffer allocation to avoid contigous DMA tx buffer allocation failure for tx (thanks Vasanth) for long hour stress testing with continuous wifi down/up with multiple vaps in low memory systems. This change also holds

[PATCH 1/2] ath10k: clean up HTT tx buffer allocation and free

2016-10-04 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan cleanup 'ath10k_htt_tx_alloc' by introducing the API's 'ath10k_htt_tx_alloc/free_{cont_txbuf, txdone_fifo} and re-use them whereever needed Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/

[PATCH 2/2] ath10k: Remove extraneous error message in tx alloc

2016-10-04 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Remove extraneous error message in 'ath10k_htt_tx_alloc_cont_frag_desc' as the caller 'ath10k_htt_tx_alloc' already dumps a proper error message Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/htt_tx.c | 4 +--

Re: ath10k: Cleanup calling ath10k_htt_rx_h_unchain

2016-10-04 Thread Mohammed Shafi Shajakhan
On Tue, Oct 04, 2016 at 05:30:17PM +0200, Kalle Valo wrote: > Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > 'ath10k_htt_rx_h_unchain' is need to be called only if the return > > value from 'ath10k_htt_rx_amsdu_pop' i

[PATCH v2] ath10k: Cleanup calling ath10k_htt_rx_h_unchain

2016-10-04 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan 'ath10k_htt_rx_h_unchain' needs to be called only if the return value from 'ath10k_htt_rx_amsdu_pop' is 1('chained msdu's'), this change makes it more explicit and avoids doing a skb_peek, fetching rx descriptor pointer, checkin

Re: [1/2] ath10k: clean up HTT tx buffer allocation and free

2016-10-06 Thread Mohammed Shafi Shajakhan
On Thu, Oct 06, 2016 at 09:31:41AM +0200, Kalle Valo wrote: > Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > cleanup 'ath10k_htt_tx_alloc' by introducing the API's > > 'ath10k_htt_tx_alloc/free_{cont_txbuf, tx

[PATCH v2 2/2] ath10k: Remove extraneous error message in tx alloc

2016-10-06 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Remove extraneous error message in 'ath10k_htt_tx_alloc_cont_frag_desc' as the caller 'ath10k_htt_tx_alloc' already dumps a proper error message Signed-off-by: Mohammed Shafi Shajakhan --- [v2 rebased over top of tree] drivers/net/wireless

[PATCH v2 1/2] ath10k: clean up HTT tx buffer allocation and free

2016-10-06 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan cleanup 'ath10k_htt_tx_alloc' by introducing the API's 'ath10k_htt_tx_alloc/free_{cont_txbuf, txdone_fifo} and re-use them whereever needed Signed-off-by: Mohammed Shafi Shajakhan --- [v2 rebased over top of tree] drivers/net/wireless/ath/

Re: [v2,1/2] ath10k: clean up HTT tx buffer allocation and free

2016-10-12 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Tue, Oct 11, 2016 at 01:36:22PM +0200, Kalle Valo wrote: > Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > cleanup 'ath10k_htt_tx_alloc' by introducing the API's > > 'ath10k_htt_tx_alloc/free_{cont_txbuf, tx

[PATCH] ath10k: Fix failure to send NULL func frame for 10.4

2016-10-12 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan This partially reverts 'commit 2cdce425aa33 ("ath10k: Fix broken NULL func data frame status for 10.4")' Unfortunately this breaks sending NULL func and the existing issue of obtaining proper tx status for NULL function will be fixed. Also upd

[PATCH v3 2/2] ath10k: Remove extraneous error message in tx alloc

2016-10-12 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Remove extraneous error message in 'ath10k_htt_tx_alloc_cont_frag_desc' as the caller 'ath10k_htt_tx_alloc' already dumps a proper error message Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/htt_tx.c |4 +--

[PATCH v3 1/2] ath10k: clean up HTT tx buffer allocation and free

2016-10-12 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan cleanup 'ath10k_htt_tx_alloc' by introducing the API's 'ath10k_htt_tx_alloc/free_{cont_txbuf, txdone_fifo} and re-use them whereever needed Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/at

[PATCH] ath10k: Fix crash during rmmod when probe firmware fails

2016-11-04 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan This fixes the below crash when ath10k probe firmware fails, NAPI polling tries to access a rx ring resource which was never allocated, fix this by disabling NAPI right away once the probe firmware fails BUG: unable to handle kernel NULL pointer dereference at

Re: Break-it testing for wifi

2016-11-21 Thread Mohammed Shafi Shajakhan
Hi Ben, just googled out 'wifi fuzzy testing' and found something relevant as below https://www.blackhat.com/presentations/bh-europe-07/Butti/Presentation/bh-eu-07-Butti.pdf regards, shafi On Mon, Nov 21, 2016 at 08:10:37AM -0800, Ben Greear wrote: > Hello! > > I am thinking about adding some s

Re: Deadlock in hacked 4.9.0-rc6+ kernel.

2016-11-28 Thread Mohammed Shafi Shajakhan
Hi Ben, On Mon, Nov 28, 2016 at 10:52:44AM -0800, Ben Greear wrote: > I ported forward my patch set to the 4.9 kernel, and I am seeing lockups > fairly > often. As always, could be something I added locally, but in case someone > sees > similar, then maybe I can reproduce it quicker and help tr

ath10k: Fix soft lockup during firmware crash/hw-restart

2016-11-29 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan During firmware crash (or) user requested manual restart the system gets into a soft lock up state because of the below root cause. During user requested hardware restart / firmware crash the system goes into a soft lockup state as 'napi_synchronize'

Re: Deadlock in hacked 4.9.0-rc6+ kernel.

2016-11-29 Thread Mohammed Shafi Shajakhan
Hi Ben, On Tue, Nov 29, 2016 at 06:50:33AM -0800, Ben Greear wrote: > > > On 11/28/2016 11:34 PM, Mohammed Shafi Shajakhan wrote: > >Hi Ben, > > > >On Mon, Nov 28, 2016 at 10:52:44AM -0800, Ben Greear wrote: > >>I ported forward my patch set to the

[PATCH v2] ath10k: Fix soft lockup during firmware crash/hw-restart

2016-11-29 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan During firmware crash (or) user requested manual restart the system gets into a soft lock up state because of the below root cause. During user requested hardware restart / firmware crash the system goes into a soft lockup state as 'napi_synchronize'

Re: ath10k: Fix soft lockup during firmware crash/hw-restart

2016-11-29 Thread Mohammed Shafi Shajakhan
AM, Mohammed Shafi Shajakhan wrote: > >From: Mohammed Shafi Shajakhan > > > >During firmware crash (or) user requested manual restart > >the system gets into a soft lock up state because of the > >below root cause. > > > >During user requested hardware r

[PATCH] ath10k: Fix Tx DMA alloc failure during continuous wifi down/up

2016-11-30 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan With maximum number of vap's configured in a two radio supported systems of ~256 Mb RAM, doing a continuous wifi down/up and intermittent traffic streaming from the connected stations results in failure to allocate contiguous memory for tx buffers. This resul

Re: ath10k: Fix soft lockup during firmware crash/hw-restart

2016-11-30 Thread Mohammed Shafi Shajakhan
afi] thanks a lot Ben. > > On 11/29/2016 06:46 AM, Mohammed Shafi Shajakhan wrote: > >From: Mohammed Shafi Shajakhan > > > >During firmware crash (or) user requested manual restart > >the system gets into a soft lock up state because of the > >below root

Re: [PATCH] ath10k: Fix Tx DMA alloc failure during continuous wifi down/up

2016-11-30 Thread Mohammed Shafi Shajakhan
is once this goes fine without any issues regards, shafi > > > > On 30 November 2016 at 01:50, Mohammed Shafi Shajakhan > wrote: > > From: Mohammed Shafi Shajakhan > > > > With maximum number of vap's configured in a two radio supported > > systems o

Re: ath10k firmware crashes in mesh mode on QCA9880

2016-11-30 Thread Mohammed Shafi Shajakhan
Hi, On Tue, Nov 29, 2016 at 11:22:12AM -0800, Benjamin Morgan wrote: > When we try to transmit traffic (ping) between two meshed ath10k > devices running latest lede we keep experiencing ath10k firmware > crashes. This seems to only happen when running in 802.11n/ac mode > but not in 802.11a/g mod

Re: [PATCH v2] ath10k: Fix soft lockup during firmware crash/hw-restart

2016-12-01 Thread Mohammed Shafi Shajakhan
On Thu, Dec 01, 2016 at 10:35:38AM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > During firmware crash (or) user requested manual restart > > the system gets into a soft lock up state because of the > &

Re: ath10k firmware crashes in mesh mode on QCA9880

2016-12-03 Thread Mohammed Shafi Shajakhan
and ath.git Also worth trying this fix in ath10k (once the next firmware version) is available. I will keep you posted. thank you ! > > ~Benjamin > > On 11/30/2016 11:09 PM, Mohammed Shafi Shajakhan wrote: > >Hi, > > > >On Tue, Nov 29, 2016 at 11:22:12AM -0800, Benjami

Re: ath10k firmware crashes in mesh mode on QCA9880

2016-12-03 Thread Mohammed Shafi Shajakhan
https://patchwork.kernel.org/patch/9437519/ (sorry missed this in the previous thread) On Sat, Dec 03, 2016 at 06:13:58PM +0530, Mohammed Shafi Shajakhan wrote: > Hi Benjamin, > > On Fri, Dec 02, 2016 at 05:28:02PM -0800, Benjamin Morgan wrote: > > Just tried 10.2.4.70.58 fi

  1   2   3   >