Re: [PATCH v2] ath: Add support for tracing

2014-09-29 Thread Sujith Manoharan
Kalle Valo wrote: > The current debug printing code in ath10k is something like 100 lines, I > don't see the point of trying to make that common with all ath* drivers. > > In my opinion ath.ko should only have code which used at least two > different drivers (and I consider ath9k.ko and ath9k_htc.

Re: [PATCH v2] ath: Add support for tracing

2014-09-29 Thread Kalle Valo
Sujith Manoharan writes: > Kalle Valo wrote: >> You mean ath_printk() & friends? But that doesn't require tracing code >> to be in ath.ko as well, right? If I understood correctly, trace.c could >> be under ath9k directory and the kconfig option could be >> ATH9K_TRACEPOINTS. >> >> I think it's

Re: [PATCH v2] ath: Add support for tracing

2014-09-29 Thread Sujith Manoharan
Kalle Valo wrote: > You mean ath_printk() & friends? But that doesn't require tracing code > to be in ath.ko as well, right? If I understood correctly, trace.c could > be under ath9k directory and the kconfig option could be > ATH9K_TRACEPOINTS. > > I think it's just misleading and confusing for t

Re: [PATCH v2] ath: Add support for tracing

2014-09-28 Thread Kalle Valo
Sujith Manoharan writes: > Kalle Valo wrote: >> Why add it to ath.ko module? What drivers are going to use this? > > The debug code for ath9k is in ath.ko. You mean ath_printk() & friends? But that doesn't require tracing code to be in ath.ko as well, right? If I understood correctly, trace.c co

Re: [PATCH v2] ath: Add support for tracing

2014-09-28 Thread Sujith Manoharan
Kalle Valo wrote: > Why add it to ath.ko module? What drivers are going to use this? The debug code for ath9k is in ath.ko. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH v2] ath: Add support for tracing

2014-09-28 Thread Kalle Valo
Sujith Manoharan writes: > From: Sujith Manoharan > > Signed-off-by: Sujith Manoharan > --- > drivers/net/wireless/ath/Kconfig | 8 + > drivers/net/wireless/ath/Makefile | 4 +++ > drivers/net/wireless/ath/ath.h| 1 + > drivers/net/wireless/ath/main.c | 3 ++ > drivers/net/wirel

[PATCH v2] ath: Add support for tracing

2014-09-27 Thread Sujith Manoharan
From: Sujith Manoharan Signed-off-by: Sujith Manoharan --- drivers/net/wireless/ath/Kconfig | 8 + drivers/net/wireless/ath/Makefile | 4 +++ drivers/net/wireless/ath/ath.h| 1 + drivers/net/wireless/ath/main.c | 3 ++ drivers/net/wireless/ath/trace.c | 20 +++ drivers/n