Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Emmanuel Grumbach
On Sun, Feb 7, 2016 at 11:08 AM, Felix Fietkau wrote: > On 2016-02-07 08:25, Emmanuel Grumbach wrote: >> On Fri, Feb 5, 2016 at 12:41 PM, Felix Fietkau wrote: >>> Requires software tx queueing support. frag_list support (for zero-copy) >>> is optional. >>> >>>

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
On 2016-02-07 08:25, Emmanuel Grumbach wrote: > On Fri, Feb 5, 2016 at 12:41 PM, Felix Fietkau wrote: >> Requires software tx queueing support. frag_list support (for zero-copy) >> is optional. >> >> Signed-off-by: Felix Fietkau > > Looks nice! > This would

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
On 2016-02-07 12:32, Emmanuel Grumbach wrote: >>> + >>> +static bool ieee80211_amsdu_aggregate(struct ieee80211_sub_if_data >>> *sdata, >>> + struct sta_info *sta, >>> + struct ieee80211_fast_tx *fast_tx,

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
On 2016-02-07 12:56, Emmanuel Grumbach wrote: >>> well.. Yes, you can't assume that you'll have one descriptor for one >>> MSDU payload (unless the driver doesn't advertise SG to the >>> netstack). >> Okay, please make a suggestion describing the exact kinds of limits you >> would need for

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Emmanuel Grumbach
On Sun, Feb 7, 2016 at 12:06 PM, Emmanuel Grumbach wrote: > On Sun, Feb 7, 2016 at 11:08 AM, Felix Fietkau wrote: >> On 2016-02-07 08:25, Emmanuel Grumbach wrote: >>> On Fri, Feb 5, 2016 at 12:41 PM, Felix Fietkau wrote: Requires

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
On 2016-02-07 11:22, Emmanuel Grumbach wrote: > On Sun, Feb 7, 2016 at 12:06 PM, Emmanuel Grumbach > wrote: >> On Sun, Feb 7, 2016 at 11:08 AM, Felix Fietkau wrote: >>> On 2016-02-07 08:25, Emmanuel Grumbach wrote: On Fri, Feb 5, 2016 at 12:41 PM,

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Emmanuel Grumbach
On Sun, Feb 7, 2016 at 12:48 PM, Felix Fietkau wrote: > On 2016-02-07 11:22, Emmanuel Grumbach wrote: >> On Sun, Feb 7, 2016 at 12:06 PM, Emmanuel Grumbach >> wrote: >>> On Sun, Feb 7, 2016 at 11:08 AM, Felix Fietkau wrote: On

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Emmanuel Grumbach
On Sun, Feb 7, 2016 at 1:49 PM, Felix Fietkau wrote: > On 2016-02-07 12:32, Emmanuel Grumbach wrote: + +static bool ieee80211_amsdu_aggregate(struct ieee80211_sub_if_data *sdata, + struct sta_info *sta,

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-06 Thread Emmanuel Grumbach
On Fri, Feb 5, 2016 at 12:41 PM, Felix Fietkau wrote: > Requires software tx queueing support. frag_list support (for zero-copy) > is optional. > > Signed-off-by: Felix Fietkau Looks nice! This would allow us to create aggregates of TCP Acks, the problem is

[RFC v2] mac80211: add A-MSDU tx support

2016-02-05 Thread Felix Fietkau
Requires software tx queueing support. frag_list support (for zero-copy) is optional. Signed-off-by: Felix Fietkau --- include/net/mac80211.h | 14 + net/mac80211/agg-tx.c | 5 ++ net/mac80211/debugfs.c | 2 + net/mac80211/ieee80211_i.h | 1 +