Re: [PATCH 3/3] powerpc/ftrace: simplify prepare_ftrace_return

2014-10-27 Thread Anton Blanchard
Hi Segher, > On Wed, Sep 24, 2014 at 12:33:07PM +1000, Anton Blanchard wrote: > > We are scratching our heads trying to remember details of the issue > > right now. In retrospect we should have linked the gcc bugzilla or > > gcc commit details in the kernel commit message :) > > There have been m

Re: powerc: fix build failure when CONFIG_HUGETLB_PAGE is not set

2014-10-27 Thread Michael Ellerman
On Mon, 2014-27-10 at 14:30:06 UTC, =?utf-8?q?C=C3=A9dric_Le_Goater?= wrote: > CC arch/powerpc/mm/slice.o > In file included from ../arch/powerpc/mm/slice.c:33:0: > ../include/linux/hugetlb.h:141:47: error: expected identifier or ‘(’ > before numeric constant > #define is_hugepage_only_r

Re: [PATCH] ASoC: fsl_asrc: Add reg_defaults for regmap to fix kernel dump

2014-10-27 Thread Nicolin Chen
On Tue, Oct 28, 2014 at 12:19:04AM +, Mark Brown wrote: > On Fri, Oct 24, 2014 at 07:03:57PM -0700, Nicolin Chen wrote: > > Kernel dump (WARN_ON) ocurred during system boot-up inside regmap_write(): > > > > [ cut here ] > > WARNING: CPU: 0 PID: 47 at kernel/locking/lock

Re: [PATCH] Revert "powerpc/powernv: Fix endian bug in LPC bus debugfs accessors"

2014-10-27 Thread Benjamin Herrenschmidt
On Tue, 2014-10-28 at 12:15 +1100, Michael Ellerman wrote: > This reverts commit bf7588a0859580a45c63cb082825d77c13eca357. > > Ben says, "The original code was fine, I think the bug was actually in > the userspace tool I was using (don't worry, nothing on the field uses > that interface yet and I

Re: powerpc: Replace __get_cpu_var uses

2014-10-27 Thread Benjamin Herrenschmidt
On Tue, 2014-10-28 at 09:04 +1100, Michael Ellerman wrote: > On Tue, 2014-10-28 at 08:10 +1100, Benjamin Herrenschmidt wrote: > > On Mon, 2014-10-27 at 10:57 -0500, Christoph Lameter wrote: > > > Ping? We are planning to remove support for __get_cpu_var in the > > > 3.19 merge period. I can move th

[PATCH v2 2/4] CXL: Refactor cxl_load_segment and find_free_sste

2014-10-27 Thread Ian Munsie
From: Ian Munsie This moves the segment table hash calculation from cxl_load_segment into find_free_sste since that is the only place it is actually used. Signed-off-by: Ian Munsie --- drivers/misc/cxl/fault.c | 34 ++ 1 file changed, 18 insertions(+), 16 deleti

[PATCH v2 3/4] powerpc/copro: Use appropriate ESID mask in copro_calculate_slb

2014-10-27 Thread Ian Munsie
From: Ian Munsie This patch makes copro_calculate_slb mask the ESID by the correct mask for 1T vs 256M segments. This has no effect by itself as the extra bits were ignored, but it makes debugging the segment table entries easier and means that we can directly compare the ESID values for duplica

[PATCH v2] CXL: Fix PSL error due to duplicate segment table entries

2014-10-27 Thread Ian Munsie
In certain circumstances the PSL (Power Service Layer, which provides translation services for CXL hardware) can send an interrupt for a segment miss that the kernel has already handled. This can happen if multiple translations for the same segment are queued in the PSL before the kernel has restar

[PATCH v2 4/4] CXL: Fix PSL error due to duplicate segment table entries

2014-10-27 Thread Ian Munsie
From: Ian Munsie In certain circumstances the PSL (Power Service Layer, which provides translation services for CXL hardware) can send an interrupt for a segment miss that the kernel has already handled. This can happen if multiple translations for the same segment are queued in the PSL before th

[PATCH v2 1/4] CXL: Disable secondary hash in segment table

2014-10-27 Thread Ian Munsie
From: Ian Munsie This patch simplifies the process of finding a free segment table entry by disabling the secondary hash. This reduces the number of possible entries in the segment table for a given address from 16 to 8. Due to the large segment sizes we use it is extremely unlikely that the sec

Re: powerpc: Replace __get_cpu_var uses

2014-10-27 Thread Christoph Lameter
On Tue, 28 Oct 2014, Michael Ellerman wrote: > I'm happy to put it in a topic branch for 3.19, or move the definition or > whatever, your choice Christoph. Get the patch merged please. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https:

Re: Warnings reported while building the vanilla kernel on powerpc

2014-10-27 Thread Michael Ellerman
On Mon, 2014-10-27 at 19:03 +0530, Preeti U Murthy wrote: > Hello, > > I noticed the following warnings while building the upstream kernel as of > yesterday. > The commit I checked out at was cac7f2429872d3 : Linux 3.18-rc2. > > Please verify if any of these can be fixed. Patches welcome. chee

Re: [PATCH V3 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-27 Thread Andrew Morton
On Tue, 28 Oct 2014 12:20:29 +1100 Michael Ellerman wrote: > On Mon, 2014-10-27 at 16:06 -0700, Andrew Morton wrote: > > On Sat, 25 Oct 2014 16:14:19 +0530 "Aneesh Kumar K.V" > > wrote: > > > > > Update generic gup implementation with powerpc specific details. > > > On powerpc at pmd level we

Re: [PATCH V3 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-27 Thread Michael Ellerman
On Mon, 2014-10-27 at 16:06 -0700, Andrew Morton wrote: > On Sat, 25 Oct 2014 16:14:19 +0530 "Aneesh Kumar K.V" > wrote: > > > Update generic gup implementation with powerpc specific details. > > On powerpc at pmd level we can have hugepte, normal pmd pointer > > or a pointer to the hugepage dir

[PATCH] Revert "powerpc/powernv: Fix endian bug in LPC bus debugfs accessors"

2014-10-27 Thread Michael Ellerman
This reverts commit bf7588a0859580a45c63cb082825d77c13eca357. Ben says, "The original code was fine, I think the bug was actually in the userspace tool I was using (don't worry, nothing on the field uses that interface yet and I can still fix the tool)." Signed-off-by: Michael Ellerman --- arch

Re: [PATCH] CXL: Fix PSL error due to duplicate segment table entries

2014-10-27 Thread Ian Munsie
Excerpts from Aneesh Kumar K.V's message of 2014-10-28 01:38:41 +1100: > I guess you are missing too many fixes in one patch. > > 1) One cleanup > 2) Fix for masking ea correctly > 3) And fix for not erroring out when a slb is already in the slb cache. ok, I'll split it up > > +/* This finds a f

Re: [PATCH] ASoC: fsl_asrc: Add reg_defaults for regmap to fix kernel dump

2014-10-27 Thread Mark Brown
On Fri, Oct 24, 2014 at 07:03:57PM -0700, Nicolin Chen wrote: > Kernel dump (WARN_ON) ocurred during system boot-up inside regmap_write(): > > [ cut here ] > WARNING: CPU: 0 PID: 47 at kernel/locking/lockdep.c:2744 > lockdep_trace_alloc+0xe8/0x108() Applied, thanks. Plea

Re: CXL: Fix PSL error due to duplicate segment table entries

2014-10-27 Thread Ian Munsie
Excerpts from Michael Ellerman's message of 2014-10-27 17:41:00 +1100: > On Mon, 2014-27-10 at 04:24:35 UTC, Ian Munsie wrote: > > From: Ian Munsie > > > > In certain circumstances the PSL can send an interrupt for a segment > > Define PSL before using it please. ok > > The CXL driver did not

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-27 Thread Jani Nikula
On Wed, 22 Oct 2014, Tomi Valkeinen wrote: > On 18/10/14 00:13, Jani Nikula wrote: >> Documentation/kbuild/kconfig-language.txt warns to use select with care, >> and in general use select only for non-visible symbols and for symbols >> with no dependencies, because select will force a symbol to a

Re: [PATCH V3 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-27 Thread Andrew Morton
On Sat, 25 Oct 2014 16:14:19 +0530 "Aneesh Kumar K.V" wrote: > Update generic gup implementation with powerpc specific details. > On powerpc at pmd level we can have hugepte, normal pmd pointer > or a pointer to the hugepage directory. I grabbed these. It would be better if they were merged in

Re: powerpc: Replace __get_cpu_var uses

2014-10-27 Thread Michael Ellerman
On Tue, 2014-10-28 at 08:10 +1100, Benjamin Herrenschmidt wrote: > On Mon, 2014-10-27 at 10:57 -0500, Christoph Lameter wrote: > > Ping? We are planning to remove support for __get_cpu_var in the > > 3.19 merge period. I can move the definition for __get_cpu_var into the > > powerpc per cpu definit

Re: What is the reel purpose of in_beXX() and out_beXX() fonctions ?

2014-10-27 Thread Benjamin Herrenschmidt
On Mon, 2014-10-27 at 15:05 +, David Laight wrote: > > Unfortunately the functions sometimes contain additional (often > unneeded) > sequencing instructions - the driver may be able to perform multiple > operations between the sequencing instructions. That's in part why some folks are worki

Re: powerpc: Replace __get_cpu_var uses

2014-10-27 Thread Benjamin Herrenschmidt
On Mon, 2014-10-27 at 10:57 -0500, Christoph Lameter wrote: > Ping? We are planning to remove support for __get_cpu_var in the > 3.19 merge period. I can move the definition for __get_cpu_var into the > powerpc per cpu definition instead if we cannot get this merged? Yes, yes, I know, we should me

Re: [PATCH V2 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-27 Thread Andrea Arcangeli
Hi Aneesh, On Mon, Oct 27, 2014 at 11:28:41PM +0530, Aneesh Kumar K.V wrote: > VM_BUG_ON(address & ~HPAGE_PMD_MASK); > if (pmd_trans_huge(*pmdp)) { > pmd = pmdp_get_and_clear(vma->vm_mm, address, pmdp); > } else { The only problematic path that needs IPI is the bel

Re: [PATCH V2 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-27 Thread Aneesh Kumar K.V
Andrea Arcangeli writes: > Hello, > > On Mon, Oct 27, 2014 at 07:50:41AM +1100, Benjamin Herrenschmidt wrote: >> On Fri, 2014-10-24 at 09:22 -0700, James Bottomley wrote: >> >> > Parisc does this. As soon as one CPU issues a TLB purge, it's broadcast >> > to all the CPUs on the inter-CPU bus.

Re: [PATCH] ASoC: fsl-asoc-card: Don't bypass settings if cpu-dai is Master

2014-10-27 Thread Nicolin Chen
On Mon, Oct 27, 2014 at 05:30:31PM +, Mark Brown wrote: > On Fri, Oct 24, 2014 at 04:48:11PM -0700, Nicolin Chen wrote: > > When cpu-dai is the DAI Master (CBM_CFx), it may need some configurations, > > set_sysclk() call for eample, for cpu-dai side in the hw_params(), even if > > the set_bias_

Re: [PATCH] ASoC: fsl-asoc-card: Don't bypass settings if cpu-dai is Master

2014-10-27 Thread Mark Brown
On Fri, Oct 24, 2014 at 04:48:11PM -0700, Nicolin Chen wrote: > When cpu-dai is the DAI Master (CBM_CFx), it may need some configurations, > set_sysclk() call for eample, for cpu-dai side in the hw_params(), even if > the set_bias_level() has already taken care of the codec-dai side. > > So this p

Re: What is the reel purpose of in_beXX() and out_beXX() fonctions ?

2014-10-27 Thread Scott Wood
On Mon, 2014-10-27 at 13:52 +0100, leroy christophe wrote: > Many drivers use in_be16(), in_be32(), out_be16(), out_be32(), etc > to access to registrers in IO mapped memory. > > What is the real purpose of those functions, and are they really needed ? > > ioremap() maps the related areas a

Re: powerpc: Replace __get_cpu_var uses

2014-10-27 Thread Christoph Lameter
Ping? We are planning to remove support for __get_cpu_var in the 3.19 merge period. I can move the definition for __get_cpu_var into the powerpc per cpu definition instead if we cannot get this merged? On Tue, 21 Oct 2014, Christoph Lameter wrote: > > This still has not been merged and now powerp

[PATCH v3 08/47] kernel: Move pm_power_off to common code

2014-10-27 Thread Guenter Roeck
pm_power_off is defined for all architectures. Move it to common code. Have all architectures call do_kernel_power_off instead of pm_power_off. Some architectures point pm_power_off to machine_power_off. For those, call do_kernel_power_off from machine_power_off instead. Acked-by: David Vrabel A

RE: What is the reel purpose of in_beXX() and out_beXX() fonctions ?

2014-10-27 Thread David Laight
From: leroy christophe > Many drivers use in_be16(), in_be32(), out_be16(), out_be32(), etc > to access to registrers in IO mapped memory. > > What is the real purpose of those functions, and are they really needed ? > > ioremap() maps the related areas as GUARDED, which means that accesses

Re: [PATCH] CXL: Fix PSL error due to duplicate segment table entries

2014-10-27 Thread Aneesh Kumar K.V
Ian Munsie writes: > From: Ian Munsie > > In certain circumstances the PSL can send an interrupt for a segment > miss that the kernel has already handled. This can happen if multiple > translations for the same segment are queued in the PSL before the > kernel has restarted the first translation

[PATCH] powerc: fix build failure when CONFIG_HUGETLB_PAGE is not set

2014-10-27 Thread Cédric Le Goater
CC arch/powerpc/mm/slice.o In file included from ../arch/powerpc/mm/slice.c:33:0: ../include/linux/hugetlb.h:141:47: error: expected identifier or ‘(’ before numeric constant #define is_hugepage_only_range(mm, addr, len) 0 ^ ../arch/powerpc/mm

Warnings reported while building the vanilla kernel on powerpc

2014-10-27 Thread Preeti U Murthy
Hello, I noticed the following warnings while building the upstream kernel as of yesterday. The commit I checked out at was cac7f2429872d3 : Linux 3.18-rc2. Please verify if any of these can be fixed. a. lib/cpumask.c: In function ‘cpumask_set_cpu_local_first’: lib/cpumask.c:194:25: warning:

[PATCH] cpuidle/powernv: Fix return value of idle index in fastsleep

2014-10-27 Thread Preeti U Murthy
Commit dcb18694 : Fix ipi on Palmeto added a workaround to disable going into fastsleep on Palmeto boards which was reported to fail to boot when fastsleep was enabled. However it missed returning an idle index. Fix this. There is probably no harm in returning the index of fastsleep although the c

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-27 Thread Tomi Valkeinen
On 27/10/14 13:59, Jani Nikula wrote: >> While doing 'depends on' instead of 'select' is an "easy" fix for this, >> I do dislike it quite a bit. It's a major pain to go around the kernel >> config, trying to find all the dependencies that a particular driver >> wants. If I need fb-foobar, I should

What is the reel purpose of in_beXX() and out_beXX() fonctions ?

2014-10-27 Thread leroy christophe
Many drivers use in_be16(), in_be32(), out_be16(), out_be32(), etc to access to registrers in IO mapped memory. What is the real purpose of those functions, and are they really needed ? ioremap() maps the related areas as GUARDED, which means that accesses can't be speculative. So what is

[PATCH 12/16] arm/iop13xx/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- arch/arm/mach-iop13xx/include/mach/pci.h |4 arch/arm/mach-iop13xx/iq81340mc.c|3 +++ arch/arm/mach-io

[PATCH 16/16] PCI/MSI: Clean up unused MSI arch functions

2014-10-27 Thread Yijing Wang
Now we use MSI controller in all platforms to configure MSI/MSI-X. We can clean up the unused arch functions. Signed-off-by: Yijing Wang Reviewed-by: Lucas Stach --- drivers/pci/msi.c | 90 ++ include/linux/msi.h | 11 -- 2 files changed

[PATCH 15/16] tile/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- arch/tile/include/asm/pci.h |2 ++ arch/tile/kernel/pci_gx.c | 18 -- 2 files changed, 18 insertion

[PATCH 14/16] Sparc/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang Acked-by: David S. Miller --- arch/sparc/kernel/pci.c | 20 ++-- arch/sparc/kernel/pci_impl.h |3 ++

[PATCH 08/16] MIPS/Xlp/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X IRQ. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- arch/mips/include/asm/netlogic/xlp-hal/pcibus.h |1 + arch/mips/pci/msi-xlp.c | 11 +-

[PATCH 05/16] x86/MSI: Remove unused MSI weak arch functions

2014-10-27 Thread Yijing Wang
Now we can clean up MSI weak arch functions in x86. Signed-off-by: Yijing Wang --- arch/x86/include/asm/pci.h |5 + arch/x86/include/asm/x86_init.h |4 arch/x86/kernel/apic/io_apic.c | 21 + arch/x86/kernel/x86_init.c | 24 -

[PATCH 04/16] Irq_remapping/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- drivers/iommu/irq_remapping.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/io

[PATCH 06/16] Mips/MSI: Save MSI controller in pci sysdata

2014-10-27 Thread Yijing Wang
Save MSI controller in pci sysdata, add arch pcibios_msi_controller() to extract out MSI controller. Signed-off-by: Yijing Wang --- arch/mips/include/asm/pci.h |3 +++ arch/mips/pci/pci.c |9 + 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/mips/incl

[PATCH 00/16] Use MSI controller framework to configure MSI/MSI-X

2014-10-27 Thread Yijing Wang
This series is based on "[PATCH 00/10] Save MSI chip in pci_sys_data", https://lkml.org/lkml/2014/10/27/85. This series is the v4 of "Use MSI chip framework to configure MSI/MSI-X in all platforms". I split it out and post it together. v3->new: Some trivial changes in "IA64/MSI: Use MSI controll

[PATCH 10/16] Powerpc/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang Acked-by: Michael Ellerman --- arch/powerpc/include/asm/pci-bridge.h |8 arch/powerpc/kernel/msi.c |

[PATCH 09/16] MIPS/Xlr/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- arch/mips/pci/pci-xlr.c | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/mips

[PATCH 07/16] MIPS/Octeon/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- arch/mips/include/asm/octeon/pci-octeon.h |4 +++ arch/mips/pci/msi-octeon.c| 31

[PATCH 01/16] PCI/MSI: Refactor MSI controller to make it become more common

2014-10-27 Thread Yijing Wang
Now there are a lot of weak arch MSI functions in MSI code. These functions make MSI driver complex. Because people need to know much which arch MSI function should be overrode and which is not. Thierry introduced MSI chip framework to configure MSI/MSI-X irq in arm. MSI chip framework is better th

[PATCH 02/16] x86/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- arch/x86/include/asm/pci.h |4 arch/x86/kernel/apic/io_apic.c | 25 + arch/x86/pci/a

[PATCH 03/16] x86/xen/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang CC: David Vrabel CC: Konrad Rzeszutek Wilk --- arch/x86/pci/xen.c | 45 +++-- 1 fil

[PATCH 13/16] IA64/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- arch/ia64/include/asm/pci.h |3 ++- arch/ia64/kernel/msi_ia64.c | 24 ++-- arch/ia64/pci/pci.c

[PATCH 11/16] s390/MSI: Use MSI controller framework to configure MSI/MSI-X irq

2014-10-27 Thread Yijing Wang
Use MSI controller framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang Acked-by: Sebastian Ott --- arch/s390/include/asm/pci.h |1 + arch/s390/pci/pci.c | 19 +-- 2 fi

[PATCH] powerpc: Remove unused vgacon_remap_base & fix build break

2014-10-27 Thread Michael Ellerman
The build is broken with CONFIG_PPC32=y, CONFIG_FB_VGA16=y and CONFIG_VGA_CONSOLE=n. The problem is that vgacon_remap_base is not defined. It's used in: #define VGA_MAP_MEM(x,s) (x + vgacon_remap_base) Which is used in the vga16fb.c code. Digging down it seems vgacon_remap_base is never ini