Re: [PATCH 12/26] block: remove blk_flush_policy

2024-06-17 Thread Chaitanya Kulkarni
On 6/16/24 23:04, Christoph Hellwig wrote: > Fold blk_flush_policy into the only caller to prepare for pending changes > to it. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Bart Van Assche > Reviewed-by: Damien Le Moal > Reviewed-by: Hannes Reinecke > --- > Looks good. Reviewed-by:

Re: [PATCH 11/26] block: freeze the queue in queue_attr_store

2024-06-17 Thread Chaitanya Kulkarni
On 6/16/24 23:04, Christoph Hellwig wrote: > queue_attr_store updates attributes used to control generating I/O, and > can cause malformed bios if changed with I/O in flight. Freeze the queue > in common code instead of adding it to almost every attribute. > > Signed-off-by: Christoph Hellwig > Re

Re: [PATCH 09/26] virtio_blk: remove virtblk_update_cache_mode

2024-06-17 Thread Chaitanya Kulkarni
On 6/16/24 23:04, Christoph Hellwig wrote: > virtblk_update_cache_mode boils down to a single call to > blk_queue_write_cache. Remove it in preparation for moving the cache > control flags into the queue_limits. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Bart Van Assche > Reviewed-by: Ste

Re: [PATCH 02/26] sd: remove sd_is_zoned

2024-06-17 Thread Chaitanya Kulkarni
On 6/16/24 23:04, Christoph Hellwig wrote: > Since commit 7437bb73f087 ("block: remove support for the host aware zone > model"), only ZBC devices expose a zoned access model. sd_is_zoned is > used to check for that and thus return false for host aware devices. > > Replace the helper with the simp

Re: [PATCH v2 00/14] Introducing TIF_NOTIFY_IPI flag

2024-06-17 Thread K Prateek Nayak
Hello Chenyu, On 6/14/2024 10:01 PM, Chen Yu wrote: On 2024-06-14 at 12:48:37 +0200, Vincent Guittot wrote: On Fri, 14 Jun 2024 at 11:28, Peter Zijlstra wrote: On Thu, Jun 13, 2024 at 06:15:59PM +, K Prateek Nayak wrote: Effects of call_function_single_prep_ipi() ===

Re: [PATCH v2 00/14] Introducing TIF_NOTIFY_IPI flag

2024-06-17 Thread K Prateek Nayak
Hello Vincent, Peter, On 6/16/2024 8:27 PM, Vincent Guittot wrote: On Sat, 15 Jun 2024 at 03:28, Peter Zijlstra wrote: On Fri, Jun 14, 2024 at 12:48:37PM +0200, Vincent Guittot wrote: On Fri, 14 Jun 2024 at 11:28, Peter Zijlstra wrote: Vincent [5] pointed out a case where the idle load k

Re: [PATCH v2 00/14] Introducing TIF_NOTIFY_IPI flag

2024-06-17 Thread K Prateek Nayak
Hello Russell, On 6/15/2024 7:56 PM, Russell King (Oracle) wrote: On Thu, Jun 13, 2024 at 06:15:59PM +, K Prateek Nayak wrote: o Dropping the ARM results since I never got my hands on the ARM64 system I used in my last testing. If I do manage to get my hands on it again, I'll rerun th

Re: [RFC PATCH 2/2] dt-bindings: memory: fsl: replace maintainer

2024-06-17 Thread Shawn Guo
On Tue, Jun 11, 2024 at 10:49:36AM +0200, Krzysztof Kozlowski wrote: > On 04/06/2024 16:22, Michael Walle wrote: > > Li Yang's mail address is bouncing, replace it with Shawn Guo's one. > > > > Signed-off-by: Michael Walle > > --- > > This is marked as an RFC because it is more of a question for

Re: [PATCH v2 00/14] Introducing TIF_NOTIFY_IPI flag

2024-06-17 Thread Vincent Guittot
On Sat, 15 Jun 2024 at 03:28, Peter Zijlstra wrote: > > On Fri, Jun 14, 2024 at 12:48:37PM +0200, Vincent Guittot wrote: > > On Fri, 14 Jun 2024 at 11:28, Peter Zijlstra wrote: > > > > > Vincent [5] pointed out a case where the idle load kick will fail to > > > > run on an idle CPU since the IPI

Re: [PATCH 1/2] dt-bindings: Drop Li Yang as maintainer for all bindings

2024-06-17 Thread Shawn Guo
On Tue, Jun 04, 2024 at 04:22:48PM +0200, Michael Walle wrote: > Remove Li Yang from all device tree bindings because mails to this > address are bouncing. > > Commit fbdd90334a62 ("MAINTAINERS: Drop Li Yang as their email address > stopped working") already removed the entry from the MAINTAINERS

Re: [PATCH] Documentation: Remove the unused "topology_updates" from kernel-parameters.txt

2024-06-17 Thread Jonathan Corbet
Thomas Huth writes: > The "topology_updates" switch has been removed four years ago in commit > c30f931e891e ("powerpc/numa: remove ability to enable topology updates"), > so let's remove this from the documentation, too. > > Signed-off-by: Thomas Huth > --- > Documentation/admin-guide/kernel-p

Re: [PATCH v2] PowerPC: Replace kretprobe with rethook

2024-06-17 Thread Google
On Mon, 17 Jun 2024 18:28:07 +0530 Naveen N Rao wrote: > Hi Abhishek, > > On Mon, Jun 10, 2024 at 11:45:09AM GMT, Abhishek Dubey wrote: > > This is an adaptation of commit f3a112c0c40d ("x86,rethook,kprobes: > > Replace kretprobe with rethook on x86") to PowerPC. > > > > Replaces the kretprobe

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Vlastimil Babka
On 6/17/24 8:54 PM, Paul E. McKenney wrote: > On Mon, Jun 17, 2024 at 07:23:36PM +0200, Vlastimil Babka wrote: >> On 6/17/24 6:12 PM, Paul E. McKenney wrote: >>> On Mon, Jun 17, 2024 at 05:10:50PM +0200, Vlastimil Babka wrote: On 6/13/24 2:22 PM, Jason A. Donenfeld wrote: > On Wed, Jun 12,

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Vlastimil Babka
On 6/17/24 7:04 PM, Jason A. Donenfeld wrote: >>> Vlastimil, this is just checking a boolean (which could be >>> unlikely()'d), which should have pretty minimal overhead. Is that >>> alright with you? >> >> Well I doubt we can just set and check it without any barriers? The >> completion of the las

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Vlastimil Babka
On 6/17/24 8:42 PM, Uladzislau Rezki wrote: >> + >> +s = container_of(work, struct kmem_cache, async_destroy_work); >> + >> +// XXX use the real kmem_cache_free_barrier() or similar thing here > It implies that we need to introduce kfree_rcu_barrier(), a new API, which i > wanted to avoid i

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread Stefan Berger
On 6/17/24 16:05, James Bottomley wrote: On Mon, 2024-06-17 at 15:56 -0400, Stefan Berger wrote: On 6/17/24 15:42, James Bottomley wrote: On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: Fix the following type of error message caused by a missing call to tpm2_sessions_init() in the

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread James Bottomley
On Mon, 2024-06-17 at 15:56 -0400, Stefan Berger wrote: > > > On 6/17/24 15:42, James Bottomley wrote: > > On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: > > > Fix the following type of error message caused by a missing call > > > to > > > tpm2_sessions_init() in the IBM vTPM driver: > >

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread Stefan Berger
On 6/17/24 15:42, James Bottomley wrote: On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: Fix the following type of error message caused by a missing call to tpm2_sessions_init() in the IBM vTPM driver: [    2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4 [    2.

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread James Bottomley
On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: > Fix the following type of error message caused by a missing call to > tpm2_sessions_init() in the IBM vTPM driver: > > [    2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error > 0x01C4 > [    2.987140] ima: Error Communicating to

Re: [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs

2024-06-17 Thread Markus Elfring
I suggest to specify email addresses for message recipients not only in the header field “Cc”. … > +++ b/sound/soc/fsl/lpc3xxx-i2s.c > @@ -0,0 +1,393 @@ … > +static int lpc3xxx_i2s_startup(struct snd_pcm_substream *substream, struct > snd_soc_dai *cpu_dai) > +{ … > + int ret = 0; > + > +

[PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

2024-06-17 Thread Stefan Berger
Fix the following type of error message caused by a missing call to tpm2_sessions_init() in the IBM vTPM driver: [2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4 [2.987140] ima: Error Communicating to TPM chip, result: -14 Fixes: d2add27cf2b8 ("tpm: Add NULL primary

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Paul E. McKenney
On Mon, Jun 17, 2024 at 07:23:36PM +0200, Vlastimil Babka wrote: > On 6/17/24 6:12 PM, Paul E. McKenney wrote: > > On Mon, Jun 17, 2024 at 05:10:50PM +0200, Vlastimil Babka wrote: > >> On 6/13/24 2:22 PM, Jason A. Donenfeld wrote: > >> > On Wed, Jun 12, 2024 at 08:38:02PM -0700, Paul E. McKenney wr

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Uladzislau Rezki
On Mon, Jun 17, 2024 at 07:23:36PM +0200, Vlastimil Babka wrote: > On 6/17/24 6:12 PM, Paul E. McKenney wrote: > > On Mon, Jun 17, 2024 at 05:10:50PM +0200, Vlastimil Babka wrote: > >> On 6/13/24 2:22 PM, Jason A. Donenfeld wrote: > >> > On Wed, Jun 12, 2024 at 08:38:02PM -0700, Paul E. McKenney wr

Re: [PATCH] powerpc/pseries: Whitelist dtl slub object for copying to userspace

2024-06-17 Thread Kees Cook
On Fri, Jun 14, 2024 at 11:08:44PM +0530, Anjali K wrote: > Reading the dispatch trace log from /sys/kernel/debug/powerpc/dtl/cpu-* > results in a BUG() when the config CONFIG_HARDENED_USERCOPY is enabled as > shown below. > > kernel BUG at mm/usercopy.c:102! > Oops: Exception in kernel mo

Re: [PATCH v2] ASoC: fsl: imx-pcm-fiq: add missing MODULE_DESCRIPTION() macro

2024-06-17 Thread Mark Brown
On Sun, 16 Jun 2024 20:52:26 -0700, Jeff Johnson wrote: > With ARCH=arm, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/fsl/imx-pcm-fiq.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Applied to https://git.ke

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Vlastimil Babka
On 6/17/24 6:12 PM, Paul E. McKenney wrote: > On Mon, Jun 17, 2024 at 05:10:50PM +0200, Vlastimil Babka wrote: >> On 6/13/24 2:22 PM, Jason A. Donenfeld wrote: >> > On Wed, Jun 12, 2024 at 08:38:02PM -0700, Paul E. McKenney wrote: >> >> o Make the current kmem_cache_destroy() asynchronously wait fo

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Uladzislau Rezki
On Mon, Jun 17, 2024 at 06:57:45PM +0200, Jason A. Donenfeld wrote: > On Mon, Jun 17, 2024 at 06:42:23PM +0200, Uladzislau Rezki wrote: > > On Mon, Jun 17, 2024 at 06:33:23PM +0200, Jason A. Donenfeld wrote: > > > On Mon, Jun 17, 2024 at 6:30 PM Uladzislau Rezki wrote: > > > > Here if an "err" is

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Jason A. Donenfeld
On Mon, Jun 17, 2024 at 06:38:52PM +0200, Vlastimil Babka wrote: > On 6/17/24 6:33 PM, Jason A. Donenfeld wrote: > > On Mon, Jun 17, 2024 at 6:30 PM Uladzislau Rezki wrote: > >> Here if an "err" is less then "0" means there are still objects > >> whereas "is_destroyed" is set to "true" which is no

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Jason A. Donenfeld
On Mon, Jun 17, 2024 at 06:42:23PM +0200, Uladzislau Rezki wrote: > On Mon, Jun 17, 2024 at 06:33:23PM +0200, Jason A. Donenfeld wrote: > > On Mon, Jun 17, 2024 at 6:30 PM Uladzislau Rezki wrote: > > > Here if an "err" is less then "0" means there are still objects > > > whereas "is_destroyed" is

Re: [PATCH V2 2/3] tools/perf: Use is_perf_pid_map_name helper function to check dso's of pattern /tmp/perf-%d.map

2024-06-17 Thread Athira Rajeev
> On 17 Jun 2024, at 7:29 PM, James Clark wrote: > > > > On 17/06/2024 14:03, Athira Rajeev wrote: >> commit 80d496be89ed ("perf report: Add support for profiling JIT >> generated code") added support for profiling JIT generated code. >> This patch handles dso's of form "/tmp/perf-$PID.map".

Re: [PATCH] tools/perf: Handle perftool-testsuite_probe testcases fail when kernel debuginfo is not present

2024-06-17 Thread Athira Rajeev
> On 17 Jun 2024, at 8:30 PM, James Clark wrote: > > > > On 17/06/2024 13:21, Athira Rajeev wrote: >> Running "perftool-testsuite_probe" fails as below: >> >> ./perf test -v "perftool-testsuite_probe" >> 83: perftool-testsuite_probe : FAILED >> >> There are three fails: >> >> 1. Regexp n

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Uladzislau Rezki
On Mon, Jun 17, 2024 at 06:33:23PM +0200, Jason A. Donenfeld wrote: > On Mon, Jun 17, 2024 at 6:30 PM Uladzislau Rezki wrote: > > Here if an "err" is less then "0" means there are still objects > > whereas "is_destroyed" is set to "true" which is not correlated > > with a comment: > > > > "Destruc

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Vlastimil Babka
On 6/17/24 6:33 PM, Jason A. Donenfeld wrote: > On Mon, Jun 17, 2024 at 6:30 PM Uladzislau Rezki wrote: >> Here if an "err" is less then "0" means there are still objects >> whereas "is_destroyed" is set to "true" which is not correlated >> with a comment: >> >> "Destruction happens when no object

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Jason A. Donenfeld
On Mon, Jun 17, 2024 at 6:30 PM Uladzislau Rezki wrote: > Here if an "err" is less then "0" means there are still objects > whereas "is_destroyed" is set to "true" which is not correlated > with a comment: > > "Destruction happens when no objects" The comment is just poorly written. But the logic

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Uladzislau Rezki
On Mon, Jun 17, 2024 at 04:56:17PM +0200, Jason A. Donenfeld wrote: > On Mon, Jun 17, 2024 at 03:50:56PM +0200, Uladzislau Rezki wrote: > > On Fri, Jun 14, 2024 at 09:33:45PM +0200, Jason A. Donenfeld wrote: > > > On Fri, Jun 14, 2024 at 02:35:33PM +0200, Uladzislau Rezki wrote: > > > > + /*

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-17 Thread Piotr Wojtaszczyk
On Mon, Jun 17, 2024 at 5:48 PM Krzysztof Kozlowski wrote: > > On 17/06/2024 16:04, Piotr Wojtaszczyk wrote: > >> > >>> It's used by snd_soc_dai_init_dma_data() in [PATCH v3 4/4] to give the > >>> dmaengine a > >>> hint which dma config to use. The LPC32xx doesn't have yet a dmamux > >>> driver l

Re: [PATCH v5.10] powerpc/uaccess: Fix build errors seen with GCC 13/14

2024-06-17 Thread Segher Boessenkool
On Fri, Jun 14, 2024 at 09:27:14PM +1000, Michael Ellerman wrote: > commit 2d43cc701b96f910f50915ac4c2a0cae5deb734c upstream. > The 'std' instruction requires a 4-byte aligned displacement because > it is a DS-form instruction, and as the assembler says, 18 is not a > multiple of 4. You learn some

Re: [PATCH] powerpc: Fixed duplicate copying in the early boot.

2024-06-17 Thread Segher Boessenkool
Hi! On Mon, Jun 17, 2024 at 10:35:09AM +0800, Jinglin Wen wrote: > + cmplwi cr0,r4,0/* runtime base addr is zero */ Just write cmpwi r4,0 cr0 is the default, also implicit in many other instructions, please don't clutter the source code. All the extra stuff makes you miss the th

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Paul E. McKenney
On Mon, Jun 17, 2024 at 05:10:50PM +0200, Vlastimil Babka wrote: > On 6/13/24 2:22 PM, Jason A. Donenfeld wrote: > > On Wed, Jun 12, 2024 at 08:38:02PM -0700, Paul E. McKenney wrote: > >> o Make the current kmem_cache_destroy() asynchronously wait for > >>all memory to be returned, then comple

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-17 Thread Krzysztof Kozlowski
On 17/06/2024 16:04, Piotr Wojtaszczyk wrote: >> >>> It's used by snd_soc_dai_init_dma_data() in [PATCH v3 4/4] to give the >>> dmaengine a >>> hint which dma config to use. The LPC32xx doesn't have yet a dmamux driver >>> like >> >> and if I change driver platform data to foo and bar, does the DT

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Vlastimil Babka
On 6/13/24 2:22 PM, Jason A. Donenfeld wrote: > On Wed, Jun 12, 2024 at 08:38:02PM -0700, Paul E. McKenney wrote: >> oMake the current kmem_cache_destroy() asynchronously wait for >> all memory to be returned, then complete the destruction. >> (This gets rid of a valuable debugging te

Re: [PATCH v4 17/29] arm64: implement PKEYS support

2024-06-17 Thread Szabolcs Nagy
The 06/17/2024 15:40, Florian Weimer wrote: > >> A user can still set it by interacting with the register directly, but I > >> guess > >> we want something for the glibc interface.. > >> > >> Dave, any thoughts here? > > > > adding Florian too, since i found an old thread of his that tried > > to

Re: [PATCH] tools/perf: Handle perftool-testsuite_probe testcases fail when kernel debuginfo is not present

2024-06-17 Thread James Clark
On 17/06/2024 13:21, Athira Rajeev wrote: > Running "perftool-testsuite_probe" fails as below: > > ./perf test -v "perftool-testsuite_probe" > 83: perftool-testsuite_probe : FAILED > > There are three fails: > > 1. Regexp not found: "\s*probe:inode_permission(?:_\d+)?\s+\(on > i

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Jason A. Donenfeld
On Mon, Jun 17, 2024 at 03:50:56PM +0200, Uladzislau Rezki wrote: > On Fri, Jun 14, 2024 at 09:33:45PM +0200, Jason A. Donenfeld wrote: > > On Fri, Jun 14, 2024 at 02:35:33PM +0200, Uladzislau Rezki wrote: > > > + /* Should a destroy process be deferred? */ > > > + if (s->flags & SLAB_DEFER_DESTROY

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Vlastimil Babka
On 6/14/24 9:33 PM, Jason A. Donenfeld wrote: > On Fri, Jun 14, 2024 at 02:35:33PM +0200, Uladzislau Rezki wrote: >> +/* Should a destroy process be deferred? */ >> +if (s->flags & SLAB_DEFER_DESTROY) { >> +list_move_tail(&s->list, &slab_caches_defer_destroy); >> +sc

Re: [PATCH 26/26] block: move the bounce flag into the features field

2024-06-17 Thread Keith Busch
On Mon, Jun 17, 2024 at 08:04:53AM +0200, Christoph Hellwig wrote: > @@ -352,7 +355,6 @@ enum blk_bounce { No more users of "enum blk_bounce" after this, so you can delete that too. > struct queue_limits { > unsigned intfeatures; > unsigned intflags; > - e

Re: [kvm-unit-tests PATCH v10 12/15] scripts/arch-run.bash: Fix run_panic() success exit status

2024-06-17 Thread Andrew Jones
On Wed, Jun 12, 2024 at 03:23:17PM GMT, Nicholas Piggin wrote: > run_qemu_status() looks for "EXIT: STATUS=%d" if the harness command > returned 1, to determine the final status of the test. In the case of > panic tests, QEMU should terminate before successful exit status is > known, so the run_pan

Re: [kvm-unit-tests PATCH v10 12/15] scripts/arch-run.bash: Fix run_panic() success exit status

2024-06-17 Thread Andrew Jones
On Fri, Jun 14, 2024 at 10:56:02AM GMT, Nicholas Piggin wrote: > On Wed Jun 12, 2024 at 5:26 PM AEST, Andrew Jones wrote: > > On Wed, Jun 12, 2024 at 03:23:17PM GMT, Nicholas Piggin wrote: > > > run_qemu_status() looks for "EXIT: STATUS=%d" if the harness command > > > returned 1, to determine the

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-17 Thread Piotr Wojtaszczyk
On Mon, Jun 17, 2024 at 2:14 PM Krzysztof Kozlowski wrote: > > On 17/06/2024 11:33, Piotr Wojtaszczyk wrote: > > On Sat, Jun 15, 2024 at 12:01 PM Krzysztof Kozlowski > > wrote: > >> Do not attach (thread) your patchsets to some other threads (unrelated > >> or older versions). This buries them d

[PATCH v3] powerpc/eeh: avoid possible crash when edev->pdev changes

2024-06-17 Thread Ganesh Goudar
If a PCI device is removed during eeh_pe_report_edev(), edev->pdev will change and can cause a crash, hold the PCI rescan/remove lock while taking a copy of edev->pdev->bus. Signed-off-by: Ganesh Goudar --- v2: Hold rescan lock till we get the bus address. v3: Now that we are taking copy of bus,

Re: [PATCH V2 2/3] tools/perf: Use is_perf_pid_map_name helper function to check dso's of pattern /tmp/perf-%d.map

2024-06-17 Thread James Clark
On 17/06/2024 14:03, Athira Rajeev wrote: > commit 80d496be89ed ("perf report: Add support for profiling JIT > generated code") added support for profiling JIT generated code. > This patch handles dso's of form "/tmp/perf-$PID.map". > > Some of the references doesn't check exactly for same patt

Re: [PATCH 00/14] replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-17 Thread Uladzislau Rezki
On Fri, Jun 14, 2024 at 09:33:45PM +0200, Jason A. Donenfeld wrote: > On Fri, Jun 14, 2024 at 02:35:33PM +0200, Uladzislau Rezki wrote: > > + /* Should a destroy process be deferred? */ > > + if (s->flags & SLAB_DEFER_DESTROY) { > > + list_move_tail(&s->list, &slab_caches_defer_destro

Re: [PATCH v4 17/29] arm64: implement PKEYS support

2024-06-17 Thread Florian Weimer
* Szabolcs Nagy: >> A user can still set it by interacting with the register directly, but I >> guess >> we want something for the glibc interface.. >> >> Dave, any thoughts here? > > adding Florian too, since i found an old thread of his that tried > to add separate PKEY_DISABLE_READ and PKEY_D

Re: [PATCH] Documentation: Remove the unused "topology_updates" from kernel-parameters.txt

2024-06-17 Thread Nathan Lynch
Thomas Huth writes: > The "topology_updates" switch has been removed four years ago in commit > c30f931e891e ("powerpc/numa: remove ability to enable topology updates"), > so let's remove this from the documentation, too. > > Signed-off-by: Thomas Huth Acked-by: Nathan Lynch Thanks!

[PATCH V2 3/3] tools/perf: Fix parallel-perf python script to replace new python syntax ":=" usage

2024-06-17 Thread Athira Rajeev
perf test "perf script tests" fails as below in systems with python 3.6 File "/home/athira/linux/tools/perf/tests/shell/../../scripts/python/parallel-perf.py", line 442 if line := p.stdout.readline(): ^ SyntaxError: invalid syntax --- Cleaning up ---

[PATCH V2 2/3] tools/perf: Use is_perf_pid_map_name helper function to check dso's of pattern /tmp/perf-%d.map

2024-06-17 Thread Athira Rajeev
commit 80d496be89ed ("perf report: Add support for profiling JIT generated code") added support for profiling JIT generated code. This patch handles dso's of form "/tmp/perf-$PID.map". Some of the references doesn't check exactly for same pattern. some uses "if (!strncmp(dso_name, "/tmp/perf-", 10

[PATCH V2 1/3] tools/perf: Fix the string match for "/tmp/perf-$PID.map" files in dso__load

2024-06-17 Thread Athira Rajeev
Perf test for perf probe of function from different CU fails as below: ./perf test -vv "test perf probe of function from different CU" 116: test perf probe of function from different CU: --- start --- test child forked, pid 2679 Failed to find symbol foo in

Re: [PATCH v2] PowerPC: Replace kretprobe with rethook

2024-06-17 Thread Naveen N Rao
Hi Abhishek, On Mon, Jun 10, 2024 at 11:45:09AM GMT, Abhishek Dubey wrote: > This is an adaptation of commit f3a112c0c40d ("x86,rethook,kprobes: > Replace kretprobe with rethook on x86") to PowerPC. > > Replaces the kretprobe code with rethook on Power. With this patch, > kretprobe on Power uses

Re: [PATCH] Documentation: Remove the unused "topology_updates" from kernel-parameters.txt

2024-06-17 Thread Michael Ellerman
Thomas Huth writes: > The "topology_updates" switch has been removed four years ago in commit > c30f931e891e ("powerpc/numa: remove ability to enable topology updates"), > so let's remove this from the documentation, too. > > Signed-off-by: Thomas Huth > --- > Documentation/admin-guide/kernel-pa

Re: [PATCH v5.10] powerpc/uaccess: Fix build errors seen with GCC 13/14

2024-06-17 Thread Greg KH
On Fri, Jun 14, 2024 at 09:27:14PM +1000, Michael Ellerman wrote: > commit 2d43cc701b96f910f50915ac4c2a0cae5deb734c upstream. > > Building ppc64le_defconfig with GCC 14 fails with assembler errors: > All backports now queued up,t hanks! greg k-h

[PATCH] tools/perf: Handle perftool-testsuite_probe testcases fail when kernel debuginfo is not present

2024-06-17 Thread Athira Rajeev
Running "perftool-testsuite_probe" fails as below: ./perf test -v "perftool-testsuite_probe" 83: perftool-testsuite_probe : FAILED There are three fails: 1. Regexp not found: "\s*probe:inode_permission(?:_\d+)?\s+\(on inode_permission(?:[:\+][0-9A-Fa-f]+)?@.+\)" -- [ FAIL ]

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-17 Thread Krzysztof Kozlowski
On 17/06/2024 11:33, Piotr Wojtaszczyk wrote: > On Sat, Jun 15, 2024 at 12:01 PM Krzysztof Kozlowski wrote: >> Do not attach (thread) your patchsets to some other threads (unrelated >> or older versions). This buries them deep in the mailbox and might >> interfere with applying entire sets. > > I

Re: [PATCH] powerpc: Fixed duplicate copying in the early boot.

2024-06-17 Thread Michael Ellerman
Jinglin Wen writes: > According to the code logic, when the kernel is loaded to address 0, > no copying operation should be performed, but it is currently being > done. > > This patch fixes the issue where the kernel code was incorrectly > duplicated to address 0 when booting from address 0. > > S

Re: [PATCH 26/26] block: move the bounce flag into the features field

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the bounce flag into the features field to reclaim a little bit of space. Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal --- block/blk-settings.c| 1 - block/blk.h | 2 +- drivers/scsi/scsi_lib.c | 2 +- include

Re: [PATCH 25/26] block: move the skip_tagset_quiesce flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the skip_tagset_quiesce flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal --- block/blk-mq-debugfs.c | 1 - drivers/nvme/host/core.c

Re: [PATCH 24/26] block: move the pci_p2pdma flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the pci_p2pdma flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal --- block/blk-mq-debugfs.c | 1 - drivers/nvme/host/core.c | 8 +++--

Re: [PATCH 23/26] block: move the zone_resetall flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the zone_resetall flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal --- block/blk-mq-debugfs.c | 1 - drivers/block/null_blk/zo

Re: [PATCH 22/26] block: move the zoned flag into the features field

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the zoned flags into the features field to reclaim a little bit of space. Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal --- block/blk-settings.c | 5 ++--- drivers/block/null_blk/zoned.c | 2 +- drivers/block/ublk_d

Re: [PATCH 21/26] block: move the poll flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the poll flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Stacking drivers are simplified in that they now can simply set the flag, and blk_stack_limits will clear it when the features is not supporte

Re: [PATCH 20/26] block: move the dax flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the dax flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal --- block/blk-mq-debugfs.c | 1 - drivers/md/dm-table.c| 4 ++--

Re: [PATCH 19/26] block: move the nowait flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the nowait flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Stacking drivers are simplified in that they now can simply set the flag, and blk_stack_limits will clear it when the features is not suppor

Re: [PATCH 18/26] block: move the synchronous flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the synchronous flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal --- block/blk-mq-debugfs.c| 1 - drivers/block/brd.c

Re: [PATCH 17/26] block: move the stable_writes flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the stable_writes flag into the queue_limits feature field so that it can be set atomically with the queue frozen. The flag is now inherited by blk_stack_limits, which greatly simplifies the code in dm, and fixed md which previously did not pass on

Re: [PATCH 16/26] block: move the io_stat flag setting to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the io_stat flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Simplify md and dm to set the flag unconditionally instead of avoiding setting a simple flag for cases where it already is set by other mea

Re: [PATCH 15/26] block: move the add_random flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the add_random flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Note that this also removes code from dm to clear the flag based on the underlying devices, which can't be reached as dm devices will al

Re: [PATCH] powerpc/pseries: Whitelist dtl slub object for copying to userspace

2024-06-17 Thread Srikar Dronamraju
> Commit 6d07d1cd300f ("usercopy: Restrict non-usercopy caches to size 0") > requires that only whitelisted areas in slab/slub objects can be copied to > userspace when usercopy hardening is enabled using CONFIG_HARDENED_USERCOPY. > Dtl contains hypervisor dispatch events which are expected to be r

Re: [PATCH 14/26] block: move the nonrot flag to queue_limits

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the nonrot flag into the queue_limits feature field so that it can be set atomically with the queue frozen. Use the chance to switch to defaulting to non-rotational and require the driver to opt into rotational, which matches the polarity of the sy

Re: [PATCH 13/26] block: move cache control settings out of queue->flags

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move the cache control settings into the queue_limits so that the flags can be set atomically with the device queue frozen. Add new features and flags field for the driver set flags, and internal (usually sysfs-controlled) flags in the block layer. Not

Re: [PATCH 03/26] sd: move zone limits setup out of sd_read_block_characteristics

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: Move a bit of code that sets up the zone flag and the write granularity into sd_zbc_read_zones to be with the rest of the zoned limits. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 21 + drivers/scsi/sd_zbc.c | 9

Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail

2024-06-17 Thread Hannes Reinecke
On 6/17/24 08:04, Christoph Hellwig wrote: blkfront always had a robust negotiation protocol for detecting a write cache. Stop simply disabling cache flushes in the block layer as the flags handling is moving to the atomic queue limits API that needs user context to freeze the queue for that. I

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-17 Thread Piotr Wojtaszczyk
On Sat, Jun 15, 2024 at 12:01 PM Krzysztof Kozlowski wrote: > Do not attach (thread) your patchsets to some other threads (unrelated > or older versions). This buries them deep in the mailbox and might > interfere with applying entire sets. I'm sorry about that, it won't happen again. > > + dma

Re: [PATCH 2/2] tools/perf: Fix parallel-perf python script to replace new python syntax ":=" usage

2024-06-17 Thread Athira Rajeev
> On 16 Jun 2024, at 8:33 PM, Adrian Hunter wrote: > > On 14/06/24 20:27, Athira Rajeev wrote: >> perf test "perf script tests" fails as below in systems >> with python 3.6 >> >> File >> "/home/athira/linux/tools/perf/tests/shell/../../scripts/python/parallel-perf.py", >> line 442 >> if lin

Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail

2024-06-17 Thread Roger Pau Monné
On Mon, Jun 17, 2024 at 08:04:28AM +0200, Christoph Hellwig wrote: > blkfront always had a robust negotiation protocol for detecting a write > cache. Stop simply disabling cache flushes in the block layer as the > flags handling is moving to the atomic queue limits API that needs > user context to

[PATCH v2 0/1] Parallel EEH recovery between PHBs

2024-06-17 Thread Ganesh Goudar
This change is based on Sam Bobroff's patches which aimed to allow recovery to happen in parallel between PHBs and PEs, Due to various reasons the patches did not get in. But having parallel recovery between PHBs is fairly simple and gives significant improvement on powervm, Since powervm maintain

[PATCH v2 1/1] powerpc/eeh: Enable PHBs to recovery in parallel

2024-06-17 Thread Ganesh Goudar
Currnetly, with a single event queue EEH recovery is entirely serialized and takes place within a single kernel thread. This can cause recovery to take a long time when there are many devices. Have the recovery event queue per PHB and allow the recovery to happen in parallel for all the PHBs. Sig