On Wed, Jun 17, 2009 at 11:29 AM, Grant Likely wrote:
> On Wed, Jun 17, 2009 at 7:34 AM, Stephen Rothwell
> wrote:
>> On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell
>> wrote:
>>>
>>> Hi Kumar,
>>>
>>> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala
>>> wrote:
>>> >
>>> >
>>> > I'm confused
On Wed, Jun 17, 2009 at 7:34 AM, Stephen Rothwell wrote:
> On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell
> wrote:
>>
>> Hi Kumar,
>>
>> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala
>> wrote:
>> >
>> >
>> > I'm confused by the proposed fix as we already have *mdio & *ph
>> > defined in th
On Jun 17, 2009, at 8:34 AM, Stephen Rothwell wrote:
On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell > wrote:
Hi Kumar,
On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala > wrote:
I'm confused by the proposed fix as we already have *mdio & *ph
defined in this function:
Which tree are you
On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell
wrote:
>
> Hi Kumar,
>
> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala
> wrote:
> >
> >
> > I'm confused by the proposed fix as we already have *mdio & *ph
> > defined in this function:
>
> Which tree are you looking at? Linus' tree, and
Hi Kumar,
On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala wrote:
>
>
> I'm confused by the proposed fix as we already have *mdio & *ph
> defined in this function:
Which tree are you looking at? Linus' tree, and linux-next, do not have
those local variables ...
--
Cheers,
Stephen Rothwell
: assignment discards
qualifiers
from pointer target type
ph should be declared const phandle *. Look at other uses of
of_get_property.
Ok fine. Here is a revised patch again.
Subject: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64
randconfig [drivers/net/ucc_geth.o]
Refer
; > CC [M] drivers/net/ucc_geth.o
> > > > drivers/net/ucc_geth.c: In function bucc_geth_probeb:
> > > > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers
> > > > from pointer target type
> > >
> > > ph should be decla
> >
> > > Stephen,
> > >
> > > True. But without this gcc complains:
> > >
> > > CC [M] drivers/net/ucc_geth.o
> > > drivers/net/ucc_geth.c: In function bucc_geth_probeb:
> > > drivers/net/ucc_geth.c:3824: warning: assignment disc
t/ucc_geth.c: In function âucc_geth_probeâ:
> > drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers
> > from pointer target type
>
> ph should be declared const phandle *. Look at other uses of
> of_get_property.
>
Ok fine. Here is a revised patch a
