Re: [PATCH] net: of/phy: fix build error when phylib is built as a module

2012-05-11 Thread Randy Dunlap
On 05/11/2012 08:47 AM, Bjørn Mork wrote: > CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use > IS_ENABLED macro to prevent build error: > > ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! > > Reported-by: Randy Dunlap > Cc: David Daney > Signed-off-by: Bjørn Mo

Re: [PATCH] net: of/phy: fix build error when phylib is built as a module

2012-05-11 Thread David Miller
From: David Daney Date: Fri, 11 May 2012 10:58:06 -0700 > On 05/11/2012 08:47 AM, Bjørn Mork wrote: >> CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use >> IS_ENABLED macro to prevent build error: >> >> ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! >> >> Reporte

Re: [PATCH] net: of/phy: fix build error when phylib is built as a module

2012-05-11 Thread David Daney
On 05/11/2012 08:47 AM, Bjørn Mork wrote: CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use IS_ENABLED macro to prevent build error: ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! Reported-by: Randy Dunlap Cc: David Daney Signed-off-by: Bjørn Mork I was able

[PATCH] net: of/phy: fix build error when phylib is built as a module

2012-05-11 Thread Bjørn Mork
CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use IS_ENABLED macro to prevent build error: ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! Reported-by: Randy Dunlap Cc: David Daney Signed-off-by: Bjørn Mork --- I wonder if this could be as banal as this? Not ev

Re: [PATCH] net: of/phy: fix build error when phylib is built as a module

2012-05-11 Thread David Miller
From: Bjørn Mork Date: Fri, 11 May 2012 17:47:01 +0200 > Should be wrapped into commit 25106022 if it works, to ensure > bisectability. Wrapped into? Commits made to my net-next tree are permanent and irreversible, so we cannot go back and change a commit. I never rebase my tree, too many peop