Re: [PATCH] powerpc/mpic: supply a .disable callback

2014-01-07 Thread Benjamin Herrenschmidt
: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org > > Subject: Re: [PATCH] powerpc/mpic: supply a .disable callback > > > > On Tue, 2014-01-07 at 13:38 +0800, Dongsheng Wang wrote: > > > From: Wang Dongsheng > > > > > > Currently MPIC provides .mask, but no

Re: [PATCH] powerpc/mpic: supply a .disable callback

2014-01-07 Thread Scott Wood
21; linuxppc-dev@lists.ozlabs.org > > Subject: Re: [PATCH] powerpc/mpic: supply a .disable callback > > > > On Tue, 2014-01-07 at 13:38 +0800, Dongsheng Wang wrote: > > > From: Wang Dongsheng > > > > > > Currently MPIC provides .mask, but not .disable. Th

RE: [PATCH] powerpc/mpic: supply a .disable callback

2014-01-07 Thread dongsheng.w...@freescale.com
> -Original Message- > From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] > Sent: Tuesday, January 07, 2014 1:50 PM > To: Wang Dongsheng-B40534 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH] powerpc/mpic: supply a .disable ca

RE: [PATCH] powerpc/mpic: supply a .disable callback

2014-01-07 Thread dongsheng.w...@freescale.com
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, January 07, 2014 2:39 PM > To: Wang Dongsheng-B40534 > Cc: b...@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH] powerpc/mpic: supply a .disable callback > > On Tue, 2

Re: [PATCH] powerpc/mpic: supply a .disable callback

2014-01-06 Thread Scott Wood
On Tue, 2014-01-07 at 13:38 +0800, Dongsheng Wang wrote: > From: Wang Dongsheng Why did you change the author field? -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/mpic: supply a .disable callback

2014-01-06 Thread Benjamin Herrenschmidt
On Tue, 2014-01-07 at 13:38 +0800, Dongsheng Wang wrote: > From: Wang Dongsheng > > Currently MPIC provides .mask, but not .disable. This means that > effectively disable_irq() soft-disables the interrupt, and you get > a .mask call if an interrupt actually occurs. > > I'm not sure if this was

[PATCH] powerpc/mpic: supply a .disable callback

2014-01-06 Thread Dongsheng Wang
From: Wang Dongsheng Currently MPIC provides .mask, but not .disable. This means that effectively disable_irq() soft-disables the interrupt, and you get a .mask call if an interrupt actually occurs. I'm not sure if this was intended as a performance benefit (it seems common to omit .disable on