Re: [PATCH] powerpc/powernv: Read opal error log and export it through sysfs interface.

2014-02-25 Thread Stewart Smith
Mahesh Jagannath Salgaonkar writes: >> I think we could provide a better interface with instead having a file >> per log message appear in sysfs. We're never going to have more than 128 >> of these at any one time on the Linux side, so it's not going to bee too >> many files. > > It is not jus

Re: [PATCH] powerpc/powernv: Read opal error log and export it through sysfs interface.

2014-02-24 Thread Mahesh Jagannath Salgaonkar
On 02/21/2014 05:41 AM, Stewart Smith wrote: > Mahesh J Salgaonkar writes: > > This patch adds support to read error logs from OPAL and export them > > to userspace through sysfs interface /sys/firmware/opa/opal-elog. Hi Stewart, Thanks for the review. This code definitely needs improvement.

Re: [PATCH] powerpc/powernv: Read opal error log and export it through sysfs interface.

2014-02-20 Thread Stewart Smith
Mahesh J Salgaonkar writes: > This patch adds support to read error logs from OPAL and export them > to userspace through sysfs interface /sys/firmware/opa/opal-elog. I think we could provide a better interface with instead having a file per log message appear in sysfs. We're never going to

[PATCH] powerpc/powernv: Read opal error log and export it through sysfs interface.

2013-12-16 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar This patch adds support to read error logs from OPAL and export them to userspace through sysfs interface /sys/firmware/opa/opal-elog. This patch buffers 128 error log records until it is consumed by userspace tool. This patch provides an sysfs interface '/sys/firmware/op