[PATCH] sound: aoa: printk replacement

2014-09-10 Thread Sudip Mukherjee
as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros. this patch will generate warning from checkpatch as it only did printk replacement and didnot fixed the other warning of : Alignment should match open parenthesis and Possible unnecessary 'out of memo

Re: [PATCH] sound: aoa: printk replacement

2014-09-10 Thread Johannes Berg
On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: > as pr_* macros are more preffered over printk, so printk replaced > with corresponding pr_* macros. Are you simply running checkpatch on every file and decided to do something about it? :) I'll let Takashi decide whether to take this or

Re: [PATCH] sound: aoa: printk replacement

2014-09-10 Thread Sudip Mukherjee
On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: > On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: > > as pr_* macros are more preffered over printk, so printk replaced > > with corresponding pr_* macros. > > Are you simply running checkpatch on every file and decided to do

Re: [PATCH] sound: aoa: printk replacement

2014-09-10 Thread Takashi Iwai
At Wed, 10 Sep 2014 20:02:04 +0530, Sudip Mukherjee wrote: > > On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: > > On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: > > > as pr_* macros are more preffered over printk, so printk replaced > > > with corresponding pr_* macros.

Re: [PATCH] sound: aoa: printk replacement

2014-09-10 Thread Sudip Mukherjee
On Wed, Sep 10, 2014 at 04:43:03PM +0200, Takashi Iwai wrote: > At Wed, 10 Sep 2014 20:02:04 +0530, > Sudip Mukherjee wrote: > > > > On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: > > > On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: > > > > as pr_* macros are more preffe

Re: [PATCH] sound: aoa: printk replacement

2014-09-10 Thread Takashi Iwai
At Wed, 10 Sep 2014 20:37:50 +0530, Sudip Mukherjee wrote: > > On Wed, Sep 10, 2014 at 04:43:03PM +0200, Takashi Iwai wrote: > > At Wed, 10 Sep 2014 20:02:04 +0530, > > Sudip Mukherjee wrote: > > > > > > On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: > > > > On Wed, 2014-09-10 at

Re: [PATCH] sound: aoa: printk replacement

2014-09-10 Thread Sudip Mukherjee
On Wed, Sep 10, 2014 at 05:38:10PM +0200, Takashi Iwai wrote: > At Wed, 10 Sep 2014 20:37:50 +0530, > Sudip Mukherjee wrote: > > > > On Wed, Sep 10, 2014 at 04:43:03PM +0200, Takashi Iwai wrote: > > > At Wed, 10 Sep 2014 20:02:04 +0530, > > > Sudip Mukherjee wrote: > > > > > > > > On Wed, Sep 10,