Re: [PATCH 1/2] powerpc/64s: Fix THP PMD collapse serialisation

2019-06-11 Thread Michael Ellerman
On Fri, 2019-06-07 at 03:56:35 UTC, Nicholas Piggin wrote: > Commit 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian conversion > in pte helpers") changed the actual bitwise tests in pte_access_permitted > by using pte_write() and pte_present() helpers rather than raw bitwise > testing _PAGE_

Re: [PATCH 1/2] powerpc/64s: Fix THP PMD collapse serialisation

2019-06-06 Thread Nicholas Piggin
Christophe Leroy's on June 7, 2019 3:34 pm: > > > Le 07/06/2019 à 05:56, Nicholas Piggin a écrit : >> Commit 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian conversion >> in pte helpers") changed the actual bitwise tests in pte_access_permitted >> by using pte_write() and pte_present() hel

Re: [PATCH 1/2] powerpc/64s: Fix THP PMD collapse serialisation

2019-06-06 Thread Aneesh Kumar K.V
Nicholas Piggin writes: > Commit 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian conversion > in pte helpers") changed the actual bitwise tests in pte_access_permitted > by using pte_write() and pte_present() helpers rather than raw bitwise > testing _PAGE_WRITE and _PAGE_PRESENT bits. > >

Re: [PATCH 1/2] powerpc/64s: Fix THP PMD collapse serialisation

2019-06-06 Thread Christophe Leroy
Le 07/06/2019 à 05:56, Nicholas Piggin a écrit : Commit 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian conversion in pte helpers") changed the actual bitwise tests in pte_access_permitted by using pte_write() and pte_present() helpers rather than raw bitwise testing _PAGE_WRITE and _PA

[PATCH 1/2] powerpc/64s: Fix THP PMD collapse serialisation

2019-06-06 Thread Nicholas Piggin
Commit 1b2443a547f9 ("powerpc/book3s64: Avoid multiple endian conversion in pte helpers") changed the actual bitwise tests in pte_access_permitted by using pte_write() and pte_present() helpers rather than raw bitwise testing _PAGE_WRITE and _PAGE_PRESENT bits. The pte_present change now returns t