Re: [PATCH v3] powerpc: gpio driver for mpc8349/8572/8610 and compatible with OF bindings

2008-09-22 Thread Peter Korsgaard
> "Anton" == Anton Vorontsov <[EMAIL PROTECTED]> writes: Anton> On Mon, Sep 22, 2008 at 08:32:34AM +0200, Peter Korsgaard wrote: >> Structured similar to the existing QE GPIO support. >> >> Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Anton> Looks good to me, thanks. Anton> Few

Re: [PATCH v3] powerpc: gpio driver for mpc8349/8572/8610 and compatible with OF bindings

2008-09-22 Thread Anton Vorontsov
On Mon, Sep 22, 2008 at 08:32:34AM +0200, Peter Korsgaard wrote: > Structured similar to the existing QE GPIO support. > > Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Looks good to me, thanks. Few comments below, might want to consider some of them if you want to. > --- > Changes since

[PATCH v3] powerpc: gpio driver for mpc8349/8572/8610 and compatible with OF bindings

2008-09-21 Thread Peter Korsgaard
Structured similar to the existing QE GPIO support. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Changes since v2: - Clarified documentation as requested by Kumar. Changes since v1: Incorporated feedback from Anton and Kumar: - Core is also used on 8572/8610 so s/83xx/8xxx/ - Use