Re: [alsa-devel] [PATCH v4 resent 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
On Wed, Aug 14, 2013 at 02:19:37PM +0200, Sascha Hauer wrote: > Yes, since the clk names are not an API. Exposing them to the devicetree > is not an option. The fact that the names are defined in > arch/arm/mach-imx/clk-imx6q.c and are used in the spdif driver makes > this really clear. > > The sp

Re: [alsa-devel] [PATCH v4 resent 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Sascha Hauer
On Wed, Aug 14, 2013 at 06:23:46PM +0800, Nicolin Chen wrote: > Hi, > > > > Surely, if I misunderstand your point, please correct me. And > > > if you have any sage idea, please guide me. > > > > Something like this: > > > > clocks = <&clks 197>, <&clks 3>, <&clks 197>, <&clks 107>, <&clks > >

Re: [alsa-devel] [PATCH v4 resent 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
Hi, On Wed, Aug 14, 2013 at 11:56:52AM +0200, Sascha Hauer wrote: > > I think I should first explain to you what this part is doing: > > The driver needs to set Clk_source bit for TX/RX to select the > > clock from a clock mux. The names listed above are those of the > > clocks connecting to the

Re: [alsa-devel] [PATCH v4 resent 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Sascha Hauer
On Wed, Aug 14, 2013 at 04:48:02PM +0800, Nicolin Chen wrote: > Hi Sascha, > > On Wed, Aug 14, 2013 at 09:50:17AM +0200, Sascha Hauer wrote: > > > + - tx-clksrc-names : The names for all available clock sources for tx, > > > which > > > + is also being listed in SoC reference manual, ClkSrc_Sel