I just acked a similar patch from Peter because his addition of nitems
looked needed and I didn't have time to think in depth about earlier
patch that caused issue.
- if (unset_prop)
+ if (unset_prop || nitems > 0)
XChangeDeviceProperty(dpy, dev, prop, XA_INTEGER, 32,
I just noticed I was unable to map button presses to keys and after
some investigation (yay git bisect!) found the following commit
caused the bug:
22bc3028effbdc79d426c0b3dcf586734d4c7532
It appears the original comment accompaning the argc check was wrong.
The original 'if' statement was "if (a
Hi Eduard,
Do you mind testing the patch and sending a "Tested-by" to the list if it
does the job for you?
Thank you for reporting and testing the issue.
Ping
On Wed, Mar 9, 2011 at 4:20 PM, Peter Hutterer wrote:
> test/Makefile.am included src/Makefile.am for the driver sources. However,
> th
We remove the case sensitivity requirement for off/on and also
allow the use of "true" and "false"
Signed-off-by: Jason Gerecke
---
tools/xsetwacom.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index ee353fa..d867982 100644
Some basic tests to ensure booleans and non-booleans act like we
want them to.
Signed-off-by: Jason Gerecke
---
tools/xsetwacom.c | 43 +++
1 files changed, 43 insertions(+), 0 deletions(-)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index d86798
atoi provides only the most basic string conversion capabilities,
and makes determining if conversion was successful difficult (both
"abc" and "0" would return 0). We use strtol and checks to ensure
that it converted the entire string sucessfully before returning True.
Signed-off-by: Jason Gerecke
Have it return true/false to indicate conversion success/failure.
Note that in its current state the function cannot tell if there
was a conversion failure...
Signed-off-by: Jason Gerecke
---
tools/xsetwacom.c | 47 +++
1 files changed, 39 insertions
Properties with PROP_FLAG_BOOLEAN set can only take on a restricted
set of values. We detect if the string matches any of the allowed
values and convert if possible. If not possible, the caller is notified.
Signed-off-by: Jason Gerecke
---
tools/xsetwacom.c |9 +++--
1 files changed, 7 i
This patch set breaks apart the referenced patch into its component
changes as requested by Peter.
--
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today an
On Thu, Mar 10, 2011 at 7:45 PM, Peter Hutterer wrote:
> On Thu, Mar 10, 2011 at 05:51:34PM -0800, Ping Cheng wrote:
> > On Wed, Mar 2, 2011 at 10:06 PM, Peter Hutterer <
> peter.hutte...@who-t.net>wrote:
> >
> > > There is a small time window where a device may try to send an event
> even
> > > t
Hi Chris,
My fault. Yes the Toshiba Portege M700 and M750's are serial
tabletPCs with 1FGT. So good guess. I believe the M750's can have
2FGT also, depending on what was ordered.
I suggested your change. Hopefully he'll want to try it.
Dave
On Fri, Mar 11, 2011 at 10:30 AM, Chris Bagwell w
On Fri, Mar 11, 2011 at 8:39 AM, Jason Gerecke wrote:
> XWACOM_MAX_SAMPLES is a duplicate of MAX_SAMPLES, and appears to have
> no reason to be included in the Xwacom.h header. We remove it and
> retarget all references.
>
> Signed-off-by: Jason Gerecke
>
Reviewed-by: Ping Cheng
Ping
> ---
Reviewed-by: Chris Bagwell
On Thu, Mar 10, 2011 at 5:30 PM, Peter Hutterer
wrote:
> Unused since ba77b532e6c2a0b7b05ab129009c1f614b089c37
>
> Signed-off-by: Peter Hutterer
> ---
> tools/xsetwacom.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/tools/xsetwacom.c
This looks needed:
Acked-by: Chris Bagwell
On Thu, Mar 10, 2011 at 5:12 PM, Peter Hutterer
wrote:
> Introduced in 22bc3028effbdc79d426c0b3dcf586734d4c7532, changed logic caused
> the property not to update in all cases.
>
> Signed-off-by: Peter Hutterer
> ---
> tools/xsetwacom.c | 2 +-
>
XWACOM_MAX_SAMPLES is a duplicate of MAX_SAMPLES, and appears to have
no reason to be included in the Xwacom.h header. We remove it and
retarget all references.
Signed-off-by: Jason Gerecke
---
include/Xwacom.h|2 --
src/wcmValidateDevice.c |4 ++--
src/wcmXCommand.c |2
On Thu, Mar 10, 2011 at 2:26 PM, Favux ... wrote:
> Hi Chris,
>
> BackBONE7 reports the patch didn't work for his stylus issue. Sounds
> more like jumps than jitters.
>
> He sees:
> (WW) Serial Wacom Tablet stylus: bad data at 7 v=91 l=9
> (WW) Serial Wacom Tablet stylus: bad data at 7 v=91
16 matches
Mail list logo
