Re: [Lldb-commits] [PATCH] D14226: Fix to solve Bug 23139 & Bug 23560

2015-11-11 Thread Jason Molenda via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Hi Abhishek, I apologize for the long delay in reviewing this one, I needed to find a solid 30-45 minute block to review the changes and the current state of the unwinder code befo

[Lldb-commits] [lldb] r252831 - [test] Fix comment.

2015-11-11 Thread Dawn Perchik via lldb-commits
Author: dperchik Date: Wed Nov 11 18:43:22 2015 New Revision: 252831 URL: http://llvm.org/viewvc/llvm-project?rev=252831&view=rev Log: [test] Fix comment. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/options/TestExprOptions.py Modified: lldb/trunk/packages/Python/

[Lldb-commits] LLVM buildmaster will be restarted tonight

2015-11-11 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be updated restarted after 7 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D14591: Implement register context for mini dump debugging

2015-11-11 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. The old RegisterContextWinMiniDump stub is replaced with x86 and x64 implementations that derive from the common windows register contexts. ProcessWindowsMiniDump grabs the WinAPI CONTE

[Lldb-commits] [lldb] r252803 - Remove `FindSessionDictionary` and rely on PythonDataObjects.

2015-11-11 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Nov 11 15:07:29 2015 New Revision: 252803 URL: http://llvm.org/viewvc/llvm-project?rev=252803&view=rev Log: Remove `FindSessionDictionary` and rely on PythonDataObjects. This had been relegated to a simple forwarding function, so just delete it in preparation of migratin

[Lldb-commits] [lldb] r252788 - Convert python-wrapper.swig to use PythonDataObjects.

2015-11-11 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Nov 11 13:42:35 2015 New Revision: 252788 URL: http://llvm.org/viewvc/llvm-project?rev=252788&view=rev Log: Convert python-wrapper.swig to use PythonDataObjects. This only begins to port python-wrapper.swig over. Since this code can be pretty hairy, I plan to do this in

[Lldb-commits] [lldb] r252787 - Create `PythonTuple` and `PythonCallable` wrapper classes.

2015-11-11 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Nov 11 13:42:27 2015 New Revision: 252787 URL: http://llvm.org/viewvc/llvm-project?rev=252787&view=rev Log: Create `PythonTuple` and `PythonCallable` wrapper classes. This adds PythonTuple and PythonCallable classes to PythonDataObjects. Additionally, unit tests are prov

Re: [Lldb-commits] [PATCH] D14549: Use uniqueness of C++ fully-qualified names to resolve conflicts

2015-11-11 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! http://reviews.llvm.org/D14549 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D14536: Add empty symbols to symtab for skipped symbols

2015-11-11 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Symbols are the #1 most expensive item memory wise in LLDB right now. We remove many symbols in Mach-O and we set the m_uid of each symbol to the original symbol table index. The

[Lldb-commits] [lldb] r252767 - Python 3 - Use six in our embedded Python glue code.

2015-11-11 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Nov 11 11:59:57 2015 New Revision: 252767 URL: http://llvm.org/viewvc/llvm-project?rev=252767&view=rev Log: Python 3 - Use six in our embedded Python glue code. Modified: lldb/trunk/scripts/interface/SBData.i lldb/trunk/scripts/lldb.swig Modified: lldb/trunk/scr

[Lldb-commits] [lldb] r252764 - Symlink the `six` module during swig generation.

2015-11-11 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Nov 11 11:59:34 2015 New Revision: 252764 URL: http://llvm.org/viewvc/llvm-project?rev=252764&view=rev Log: Symlink the `six` module during swig generation. Modified: lldb/trunk/scripts/CMakeLists.txt lldb/trunk/scripts/Python/finishSwigPythonLLDB.py Modified: l

[Lldb-commits] [lldb] r252765 - Add a `PythonModule` class, and a root-level method for resolving names.

2015-11-11 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Nov 11 11:59:49 2015 New Revision: 252765 URL: http://llvm.org/viewvc/llvm-project?rev=252765&view=rev Log: Add a `PythonModule` class, and a root-level method for resolving names. Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp

Re: [Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

2015-11-11 Thread Dawn Perchik via lldb-commits
dawn added a subscriber: dawn. dawn accepted this revision. dawn added a reviewer: dawn. dawn added a comment. Patch is correct - without it we loop through the same decl context again. I've tested it locally - there are no new regressions. http://reviews.llvm.org/D14542 ___

Re: [Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

2015-11-11 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Te test case looks good to me. Thanks for adding it. For the actual code change I don' know enough about this area to say anything so please wait for a feedback from Greg. http://r

[Lldb-commits] [PATCH] Avoid Python "UnboundedLocalError: local variable 'strErrMsgProgFail' referenced before assignment"

2015-11-11 Thread Stephan Bergmann via lldb-commits
An attempt at building lldb from recent trunk source failed for me with a Python error UnboundedLocalError: local variable 'strErrMsgProgFail' referenced before assignment in tools/lldb/scripts/Python/buildSwigPython.py. I have not much of an idea about Python, but from

Re: [Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

2015-11-11 Thread Eugene Leviant via lldb-commits
evgeny777 updated this revision to Diff 39893. evgeny777 added a comment. Added test case http://reviews.llvm.org/D14542 Files: packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespace.py packages/Python/lldbsuite/test/lang/cpp/namespace/main.cpp source/Symbol/ClangASTContext.cpp