[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

2021-01-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 315655. wallace added a comment. improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 Files:

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

2021-01-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 315652. wallace added a comment. Addressed all comments: - Now using a single file for all the communication. Did indeed simplified a lot of code - Now adding timeouts to Send operations. This will help prevent the adaptor from undefinitely waiting for the

[Lldb-commits] [PATCH] D93649: [lldb/Lua] add support for Lua function breakpoint

2021-01-09 Thread Pedro Tammela via Phabricator via lldb-commits
tammela added inline comments. Comment at: lldb/test/Shell/ScriptInterpreter/Lua/breakpoint_function_callback.test:15 +r +# CHECK: +breakpoint command add -s lua -o "abc(frame, bp_loc, ...)" JDevlieghere wrote: > Can we unpack the SBStructuredData and check

[Lldb-commits] [PATCH] D94357: [NFC] Add some additional, unconditional, logging to debugserver mostly related to app launching/attaching

2021-01-09 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda created this revision. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. It can be tricky to find the important error messages when debugserver tries to launch or attach to a process in the system console