davrec added a comment.
I like the late changes, just need to add comments to the public methods, and
maybe move `getReplacedTemplateParameterList` over to `Decl`.
Comment at: clang/include/clang/AST/DeclTemplate.h:3427
+TemplateParameterList *getReplacedTemplateParameterLis
davrec added inline comments.
Comment at: clang/include/clang/AST/DeclTemplate.h:3427
+TemplateParameterList *getReplacedTemplateParameterList(Decl *D);
+
davrec wrote:
> I don't object with making this public, and I can see the argument for making
> this its
mizvekov added inline comments.
Comment at: clang/include/clang/AST/DeclTemplate.h:3427
+TemplateParameterList *getReplacedTemplateParameterList(Decl *D);
+
davrec wrote:
> davrec wrote:
> > I don't object with making this public, and I can see the argument for
mizvekov added inline comments.
Comment at: clang/include/clang/AST/DeclTemplate.h:3427
+TemplateParameterList *getReplacedTemplateParameterList(Decl *D);
+
mizvekov wrote:
> davrec wrote:
> > davrec wrote:
> > > I don't object with making this public, and I ca
davrec added inline comments.
Comment at: clang/include/clang/AST/DeclTemplate.h:3427
+TemplateParameterList *getReplacedTemplateParameterList(Decl *D);
+
mizvekov wrote:
> mizvekov wrote:
> > davrec wrote:
> > > davrec wrote:
> > > > I don't object with making
Author: Kazu Hirata
Date: 2022-10-15T12:11:56-07:00
New Revision: 921a4d5be4bbe3c337419dfcc313b3eb892c2870
URL:
https://github.com/llvm/llvm-project/commit/921a4d5be4bbe3c337419dfcc313b3eb892c2870
DIFF:
https://github.com/llvm/llvm-project/commit/921a4d5be4bbe3c337419dfcc313b3eb892c2870.diff
L
Author: Kazu Hirata
Date: 2022-10-15T12:32:20-07:00
New Revision: 39f01240e76678fa6385d36e7a96670677a26d65
URL:
https://github.com/llvm/llvm-project/commit/39f01240e76678fa6385d36e7a96670677a26d65
DIFF:
https://github.com/llvm/llvm-project/commit/39f01240e76678fa6385d36e7a96670677a26d65.diff
L
dblaikie added a comment.
I think the place where this will go wrong is in terms of how lldb renders
`char` values on non-default-char-signedness programs (it'll render them as the
default-char-signedness, which might be confusing to a user - since they'll be
looking at literals, etc, that are
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
The default switch has happened, so unblocking this.
Comment at: clang/test/CodeGenOpenCL/overload.cl:23
generic int *local *genloc;
generic int *global *genglob;
+ // C
wallace created this revision.
wallace added reviewers: persona0220, jj10306.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The JSON dumper is very minimalistic. It pretty much only shows the
delimitin
10 matches
Mail list logo