[Lldb-commits] [libcxx] [clang] [lldb] [lld] [mlir] [flang] [llvm] [compiler-rt] [clang] Fix unexpected `-Wconstant-logical-operand` in C23 (PR #80724)

https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/80724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [lld] [mlir] [llvm] [libcxx] [lldb] [compiler-rt] [clang] [clang] Fix unexpected `-Wconstant-logical-operand` in C23 (PR #80724)

Fznamznon wrote: Windows failure in CI seems unrelated. https://github.com/llvm/llvm-project/pull/80724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [flang] [libcxx] [llvm] [lldb] [clang] [mlir] [lld] [clang] Fix unexpected `-Wconstant-logical-operand` in C23 (PR #80724)

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/80724 >From dd81e1aa3de2c38be91140b57d2c277a56e899bf Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Mon, 5 Feb 2024 10:43:56 -0800 Subject: [PATCH 1/2] [clang] Fix unexpected `-Wconstant-logical-operan

[Lldb-commits] [lldb] [openmp] [mlir] [flang] [clang] [libunwind] [lld] [compiler-rt] [clang-tools-extra] [libcxxabi] [llvm] [libc] [libcxx] [C23] Implement N3018: The constexpr specifier for object d

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/73099 >From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 19 Sep 2023 08:37:18 -0700 Subject: [PATCH 01/10] [C23] Implement N3018: The constexpr specifier

[Lldb-commits] [libunwind] [llvm] [flang] [libcxxabi] [mlir] [openmp] [lldb] [libc] [clang] [lld] [compiler-rt] [libcxx] [clang-tools-extra] [C23] Implement N3018: The constexpr specifier for object d

Fznamznon wrote: Ping. https://github.com/llvm/llvm-project/pull/73099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [lld] [clang] [flang] [compiler-rt] [llvm] [libc] [lldb] [libcxx] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

Fznamznon wrote: Given the problem in https://github.com/llvm/llvm-project/pull/77753#issuecomment-1912258038 , @cor3ntin , @AaronBallman WDYT about adding new flags to `CXXRecordDecl`, saying that constructor/destructor is not really `constexpr` before C++23? https://github.com/llvm/llvm-pro

[Lldb-commits] [lld] [llvm] [clang] [libcxx] [lldb] [libc] [flang] [compiler-rt] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

Fznamznon wrote: > Oh gosh, I'm an idiot, i meant true That makes it a little bit challenging to preserve old warnings for older versions of the language, without additional flags and options, in some cases like: ``` struct A { ~A(); }; struct B : A { }; struct C { B a; co

[Lldb-commits] [libcxx] [lldb] [clang-tools-extra] [libc] [compiler-rt] [llvm] [clang] [flang] [lld] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

Fznamznon wrote: > So I guess we should set the DefaultedDestructorIsConstexpr to false and only > use it for warning? I'm not sure? Switching all constexpr-related errors to warnings doesn't seem right, even though almost all functions now can be marked constexpr, they still can't be called

[Lldb-commits] [lld] [clang] [compiler-rt] [flang] [lldb] [libcxx] [llvm] [libc] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

Fznamznon wrote: > Line 551 in > [99cae9a](https://github.com/llvm/llvm-project/commit/99cae9a44fca4cfbd6ee82f196051cbdf6571fa1) will set DefaultedDestructorIsConstexpr regardless of language mode, which it should not. @cor3ntin , I wonder, since we want to claim it as an extension in earlier

[Lldb-commits] [lld] [libcxx] [flang] [clang] [libc] [compiler-rt] [lldb] [llvm] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/77753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [libcxx] [flang] [clang] [libc] [compiler-rt] [lldb] [llvm] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

@@ -356,14 +356,7 @@ C++23 implementation status Relaxing some constexpr restrictions https://wg21.link/P2448R2";>P2448R2 - -Clang 17 (Partial) - We do not support outside of defaulted special memeber functions the change that constexpr f

[Lldb-commits] [lld] [libcxx] [flang] [clang] [libc] [compiler-rt] [lldb] [llvm] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

@@ -9108,7 +9123,8 @@ bool Sema::CheckExplicitlyDefaultedComparison(Scope *S, FunctionDecl *FD, // declaration, it is implicitly considered to be constexpr. // FIXME: Only applying this to the first declaration seems problematic, as // simple reorderings can affect the

[Lldb-commits] [libc] [lld] [flang] [clang] [libcxx] [compiler-rt] [llvm] [clang-tools-extra] [lldb] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

@@ -9108,7 +9123,8 @@ bool Sema::CheckExplicitlyDefaultedComparison(Scope *S, FunctionDecl *FD, // declaration, it is implicitly considered to be constexpr. // FIXME: Only applying this to the first declaration seems problematic, as // simple reorderings can affect the

[Lldb-commits] [flang] [libc] [lldb] [compiler-rt] [llvm] [clang-tools-extra] [libcxx] [lld] [clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

@@ -9108,7 +9123,8 @@ bool Sema::CheckExplicitlyDefaultedComparison(Scope *S, FunctionDecl *FD, // declaration, it is implicitly considered to be constexpr. // FIXME: Only applying this to the first declaration seems problematic, as // simple reorderings can affect the

[Lldb-commits] [flang] [libc] [lldb] [compiler-rt] [llvm] [clang-tools-extra] [libcxx] [lld] [clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

@@ -356,14 +356,7 @@ C++23 implementation status Relaxing some constexpr restrictions https://wg21.link/P2448R2";>P2448R2 - -Clang 17 (Partial) - We do not support outside of defaulted special memeber functions the change that constexpr f

[Lldb-commits] [compiler-rt] [lld] [clang] [llvm] [libc] [libcxx] [lldb] [flang] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

Fznamznon wrote: > CheckConstexprFunctionDefinition will return false for a destructor if > defaultedDestructorIsConstexpr returns false (unless we want to emit a > diagnostic)` I see. So defaulted special members now *actually* constexpr. I've made that change. I confused everything with fun

[Lldb-commits] [compiler-rt] [lldb] [lld] [llvm] [flang] [clang-tools-extra] [libcxx] [clang] [libc] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/78316 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [lldb] [lld] [llvm] [flang] [clang-tools-extra] [libcxx] [clang] [libc] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

Fznamznon wrote: Driver failure seems unrelated. https://github.com/llvm/llvm-project/pull/78316 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [llvm] [compiler-rt] [lld] [libcxx] [flang] [clang-tools-extra] [libc] [lldb] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/78316 >From cf33d7ce01aafe0fa29b8a38a9824a0b03d24f05 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 16 Jan 2024 09:16:10 -0800 Subject: [PATCH 1/4] [clang] Fix assertion failure with deleted overl

[Lldb-commits] [compiler-rt] [llvm] [clang] [lld] [libcxx] [clang-tools-extra] [lldb] [libc] [flang] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/78316 >From cf33d7ce01aafe0fa29b8a38a9824a0b03d24f05 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 16 Jan 2024 09:16:10 -0800 Subject: [PATCH 1/4] [clang] Fix assertion failure with deleted overl

[Lldb-commits] [clang] [lldb] [libcxx] [llvm] [compiler-rt] [libc] [flang] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

@@ -14310,8 +14310,8 @@ Sema::CreateOverloadedUnaryOp(SourceLocation OpLoc, UnaryOperatorKind Opc, PartialDiagnosticAt(OpLoc, PDiag(diag::err_ovl_deleted_oper) << UnaryOperator::getOpcodeStr(Opc)

[Lldb-commits] [libcxx] [flang] [compiler-rt] [lldb] [llvm] [clang] [libc] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

@@ -14306,12 +14306,17 @@ Sema::CreateOverloadedUnaryOp(SourceLocation OpLoc, UnaryOperatorKind Opc, return ExprError(); case OR_Deleted: +// CreateOverloadedUnaryOp fills first element of ArgsArray with the object +// whose method was called. Later in NoteCandi

[Lldb-commits] [compiler-rt] [lldb] [flang] [llvm] [libcxx] [clang] [libc] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/78316 >From cf33d7ce01aafe0fa29b8a38a9824a0b03d24f05 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 16 Jan 2024 09:16:10 -0800 Subject: [PATCH 1/4] [clang] Fix assertion failure with deleted overl

[Lldb-commits] [clang] [libc] [libcxx] [flang] [compiler-rt] [llvm] [lldb] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/78316 >From cf33d7ce01aafe0fa29b8a38a9824a0b03d24f05 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 16 Jan 2024 09:16:10 -0800 Subject: [PATCH 1/3] [clang] Fix assertion failure with deleted overl

[Lldb-commits] [flang] [openmp] [clang] [libcxx] [lld] [llvm] [compiler-rt] [mlir] [libunwind] [lldb] [clang-tools-extra] [libcxxabi] [libc] [C23] Implement N3018: The constexpr specifier for object d

Fznamznon wrote: Ping. https://github.com/llvm/llvm-project/pull/73099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [flang] [llvm] [libc] [libunwind] [lldb] [openmp] [libcxxabi] [libcxx] [mlir] [compiler-rt] [clang] [lld] [C23] Implement N3018: The constexpr specifier for object d

Fznamznon wrote: Adding more reviewers since Aaron is on vacation... https://github.com/llvm/llvm-project/pull/73099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [clang-tools-extra] [libcxx] [llvm] [libunwind] [lldb] [openmp] [libcxxabi] [flang] [mlir] [clang] [libc] [lld] [C23] Implement N3018: The constexpr specifier for object d

@@ -0,0 +1,287 @@ +// RUN: %clang_cc1 -std=c2x -verify -triple x86_64 -pedantic -Wno-conversion -Wno-constant-conversion -Wno-div-by-zero %s + +// Check that constexpr only applies to variables. +constexpr void f0() {} // expected-error {{'constexpr' can only be used in variable

[Lldb-commits] [compiler-rt] [clang-tools-extra] [libcxx] [llvm] [libunwind] [lldb] [openmp] [libcxxabi] [flang] [mlir] [clang] [libc] [lld] [C23] Implement N3018: The constexpr specifier for object d

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/73099 >From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 19 Sep 2023 08:37:18 -0700 Subject: [PATCH 1/9] [C23] Implement N3018: The constexpr specifier f

[Lldb-commits] [compiler-rt] [clang-tools-extra] [libcxx] [lldb] [llvm] [openmp] [flang] [mlir] [clang] [libc] [lld] fix issue 73559. (PR #74926)

@@ -641,6 +641,8 @@ Bug Fixes in This Version Fixes (`#67317 `_) - Clang now properly diagnoses use of stand-alone OpenMP directives after a label (including ``case`` or ``default`` labels). +- Fix crash when using C++ only

[Lldb-commits] [llvm] [openmp] [lld] [mlir] [lldb] [flang] [libc] [compiler-rt] [clang] [libcxx] [clang-tools-extra] fix issue 73559. (PR #74926)

https://github.com/Fznamznon commented: The PR can be landed after a formal approval. Please see https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted . I gave a couple of NITs otherwise the patch looks ok to me. I'm a bit new here, so someone else should approve. I added more fol

[Lldb-commits] [flang] [llvm] [mlir] [openmp] [clang-tools-extra] [clang] [lldb] [libc] [lld] [compiler-rt] [libcxx] fix issue 73559. (PR #74926)

https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/74926 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [clang] [lld] [llvm] [openmp] [clang-tools-extra] [libcxx] [lldb] [libc] [flang] [mlir] fix issue 73559. (PR #74926)

@@ -3,3 +3,4 @@ // PR9137 void f0(int x) : {}; // expected-error{{expected function body after function declarator}} void f1(int x) try {}; // expected-error{{expected function body after function declarator}} +::; // expected-error{{expected identifier or '('}} -

[Lldb-commits] [flang] [llvm] [libcxx] [libcxxabi] [compiler-rt] [lldb] [libunwind] [mlir] [clang-tools-extra] [lld] [libc] [openmp] [clang] [C23] Implement N3018: The constexpr specifier for object d

@@ -1914,6 +1914,17 @@ class StringLiteral final llvm_unreachable("Unsupported character width!"); } + // Get code unit but preserve sign info. + int64_t getCodeUnitS(size_t I, uint64_t ByteWidth) const { Fznamznon wrote: It is a number of bits in byt

[Lldb-commits] [flang] [llvm] [libcxx] [libcxxabi] [compiler-rt] [lldb] [libunwind] [mlir] [clang-tools-extra] [lld] [libc] [openmp] [clang] [C23] Implement N3018: The constexpr specifier for object d

@@ -14270,6 +14318,113 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S, SourceLocation IdentLoc, : IdentLoc); } +static ImplicitConversionKind GetConversionKind(QualType FromType, +

[Lldb-commits] [flang] [llvm] [libcxx] [libcxxabi] [compiler-rt] [lldb] [libunwind] [mlir] [clang-tools-extra] [lld] [libc] [openmp] [clang] [C23] Implement N3018: The constexpr specifier for object d

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/73099 >From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 19 Sep 2023 08:37:18 -0700 Subject: [PATCH 1/8] [C23] Implement N3018: The constexpr specifier f

[Lldb-commits] [lldb] [lld] [libc] [compiler-rt] [mlir] [libcxx] [openmp] [llvm] [clang-tools-extra] [libunwind] [flang] [clang] [libcxxabi] [C23] Implement N3018: The constexpr specifier for object d

@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S, SourceLocation IdentLoc, : IdentLoc); } +static ImplicitConversionKind getConversionKind(QualType FromType, +

[Lldb-commits] [lldb] [lld] [libc] [compiler-rt] [mlir] [libcxx] [openmp] [llvm] [clang-tools-extra] [libunwind] [flang] [clang] [libcxxabi] [C23] Implement N3018: The constexpr specifier for object d

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/73099 >From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 19 Sep 2023 08:37:18 -0700 Subject: [PATCH 1/7] [C23] Implement N3018: The constexpr specifier f

[Lldb-commits] [clang-tools-extra] [libunwind] [openmp] [compiler-rt] [flang] [libcxxabi] [lld] [llvm] [mlir] [libc] [libcxx] [lldb] [clang] [C23] Implement N3018: The constexpr specifier for object d

@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S, SourceLocation IdentLoc, : IdentLoc); } +static ImplicitConversionKind getConversionKind(QualType FromType, +

[Lldb-commits] [compiler-rt] [mlir] [llvm] [lld] [openmp] [lldb] [clang-tools-extra] [libunwind] [flang] [libcxxabi] [clang] [libc] [libcxx] [C23] Implement N3018: The constexpr specifier for object d

@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S, SourceLocation IdentLoc, : IdentLoc); } +static ImplicitConversionKind getConversionKind(QualType FromType, +

[Lldb-commits] [compiler-rt] [libcxx] [libunwind] [clang] [openmp] [llvm] [clang-tools-extra] [libcxxabi] [lld] [flang] [lldb] [mlir] [libc] [C23] Implement N3018: The constexpr specifier for object d

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/73099 >From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 19 Sep 2023 08:37:18 -0700 Subject: [PATCH 1/6] [C23] Implement N3018: The constexpr specifier f

[Lldb-commits] [mlir] [clang] [compiler-rt] [llvm] [lldb] [libcxxabi] [libcxx] [clang-tools-extra] [flang] [lld] [libunwind] [libc] [openmp] [C23] Implement N3018: The constexpr specifier for object d

@@ -2485,12 +2485,12 @@ bool VarDecl::mightBeUsableInConstantExpressions(const ASTContext &C) const { // In C++, const, non-volatile variables of integral or enumeration types // can be used in constant expressions. - if (getType()->isIntegralOrEnumerationType()) + if (

[Lldb-commits] [mlir] [lldb] [lld] [llvm] [flang] [libcxx] [libc] [clang-tools-extra] [compiler-rt] [openmp] [clang] [libcxxabi] [libunwind] [C23] Implement N3018: The constexpr specifier for object d

https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/73099 >From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 19 Sep 2023 08:37:18 -0700 Subject: [PATCH 1/6] [C23] Implement N3018: The constexpr specifier f

[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

https://github.com/Fznamznon approved this pull request. https://github.com/llvm/llvm-project/pull/67373 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 42ae055 - [NFC] Fix potential for use-after-free in DumpModuleInfoAction

Author: Mariya Podchishchaeva Date: 2023-03-30T06:44:23-04:00 New Revision: 42ae055b4c9282050636dd11198cad500424adf2 URL: https://github.com/llvm/llvm-project/commit/42ae055b4c9282050636dd11198cad500424adf2 DIFF: https://github.com/llvm/llvm-project/commit/42ae055b4c9282050636dd11198cad500424ad