This revision was automatically updated to reflect the committed changes.
Closed by commit rL252624: LLDBStandalone: Report nice errors on missing vars
(authored by artagnon).
Changed prior to commit:
http://reviews.llvm.org/D13819?vs=37616&id=39822#toc
Repository:
rL LLVM
http://reviews.ll
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Okay, this seems reasonable.
http://reviews.llvm.org/D13819
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
artagnon added a comment.
Okay, so run this on the current HEAD:
$ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug ../lldb
-- The C compiler identification is AppleClang 6.1.0.6020053
-- The CXX compiler identification is AppleClang 6.1.0.6020053
-- Check for working C compiler using: Ninja
-- C
tfiala added a comment.
I'll have a look. How do I test it, @artagnon?
http://reviews.llvm.org/D13819
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem added a comment.
This looks reasonable to me as well, but I also have never built standalone.
http://reviews.llvm.org/D13819
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg resigned from this revision.
clayborg edited reviewers, added: tfiala; removed: clayborg.
clayborg added a comment.
I don't build cmake either, I am probably not a great person to ask. Todd Fiala
might be a good person.
http://reviews.llvm.org/D13819
chaoren resigned from this revision.
chaoren removed a reviewer: chaoren.
chaoren added a comment.
Seems legit. But I've never built standalone, so I probably shouldn't be a
reviewer for this.
http://reviews.llvm.org/D13819
___
lldb-commits mailing
artagnon created this revision.
artagnon added reviewers: chaoren, brucem.
artagnon added a subscriber: lldb-commits.
http://reviews.llvm.org/D13819
Files:
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalone.cmake
=
