https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91931
>From 361cd689e3900c5ab542a5158807eb532879677e Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 11:26:03 +0400
Subject: [PATCH] [lldb] Fixed the test TestGdbRemoteLaunch
Install `a.out` to
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
@DavidSpickett Please look at #91944.
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
Surprised we haven't needed this before, but I didn't see any existing function
for it.
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
@@ -78,6 +93,7 @@ def test_launch_via_vRun_no_args(self):
self.expect_gdbremote_sequence()
@add_test_categories(["llgs"])
+@skipIfRemote
DavidSpickett wrote:
Ah, because we need to open the file while we attempt to run it, and doing that
on
@@ -78,6 +93,7 @@ def test_launch_via_vRun_no_args(self):
self.expect_gdbremote_sequence()
@add_test_categories(["llgs"])
+@skipIfRemote
DavidSpickett wrote:
Why is only this test skipped?
https://github.com/llvm/llvm-project/pull/91931
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Install `a.out` to the remote target (after handshake) if necessary and use the
remote path to call `vRun`.
---
Full diff: https://github.com/llvm/llvm-project/pull/91931.diff
1 Files Affected:
-
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91931
Install `a.out` to the remote target (after handshake) if necessary and use the
remote path to call `vRun`.
>From cbc183bd78c26ca3777cc4a81797d57ab3fa945d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: