This revision was automatically updated to reflect the committed changes.
Closed by commit rL271899: Don't remove PIE executables when using svr4 packets
(authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D20990?vs=59637&id=59723#toc
Repository:
rL LLVM
http://reviews.l
sas added a comment.
Nit: Adding a comment explaining why we special-case the main executable (i.e.:
because it is never included in `libraries-svr4` packets) might be useful here.
http://reviews.llvm.org/D20990
___
lldb-commits mailing list
lldb-c
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D20990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
fjricci updated this revision to Diff 59637.
fjricci added a comment.
Refactor to remove unnecessary object file type checking
http://reviews.llvm.org/D20990
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
==
fjricci updated this revision to Diff 59633.
fjricci added a comment.
Fix curly-brace style
http://reviews.llvm.org/D20990
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
=
fjricci created this revision.
fjricci added reviewers: clayborg, ADodds, tfiala.
fjricci added a subscriber: lldb-commits.
Because PIE executables have an e_type of llvm::ELF::ET_DYN,
they are not of type eTypeExecutable, and were being removed
when svr4 packets were used.
http://reviews.llvm.or
