https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aabhinavg updated
https://github.com/llvm/llvm-project/pull/91882
>From 9b4160975efe059f39a842689b1f750a10453203 Mon Sep 17 00:00:00 2001
From: aabhinavg
Date: Sun, 12 May 2024 12:42:59 +0530
Subject: [PATCH 1/2] Fix redundant condition in Target.cpp
This commit addresses is
https://github.com/aabhinavg updated
https://github.com/llvm/llvm-project/pull/91882
>From 9b4160975efe059f39a842689b1f750a10453203 Mon Sep 17 00:00:00 2001
From: aabhinavg
Date: Sun, 12 May 2024 12:42:59 +0530
Subject: [PATCH] Fix redundant condition in Target.cpp
This commit addresses issue
https://github.com/DavidSpickett requested changes to this pull request.
I think this function got a bit confused when we changed the return type to an
optional, thanks for taking a look at it.
https://github.com/llvm/llvm-project/pull/91882
___
lldb-
@@ -841,12 +841,14 @@ static bool CheckIfWatchpointsSupported(Target *target,
Status &error) {
if (!num_supported_hardware_watchpoints)
return true;
- if (num_supported_hardware_watchpoints == 0) {
-error.SetErrorStringWithFormat(
-"Target supports (%u) har
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 63224d717108d927e998da8a67050a6cc5dd74a2
9b4160975efe059f39a842689b1f750a10453203 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (aabhinavg)
Changes
This commit addresses issue #87244, where a redundant condition was
found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the
Target.cpp file
fix #87244
---
Full diff: https://github.com/llv
https://github.com/aabhinavg created
https://github.com/llvm/llvm-project/pull/91882
This commit addresses issue #87244, where a redundant condition was found in
the Target.cpp file. Static analyzer cppcheck flagged the issue in the
Target.cpp file
fix #87244
>From 9b4160975efe059f39a842689b
10 matches
Mail list logo