[lng-odp] [PATCHv2] test/performance:Avoid possible out-of-bounds memory access

2016-04-04 Thread Balakrishna Garapati
Signed-off-by: Balakrishna Garapati --- v1: Fix for the https://bugs.linaro.org/show_bug.cgi?id=2136 v2: comments from v1 test/performance/odp_crypto.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/performance/odp_crypto.c b/test/performance/odp_crypto.c

[lng-odp] [PATCH] linux-generic: pktio_run_tap: failure to setup tap != test fail

2016-04-04 Thread Zi Shen Lim
When we fail to setup tap for any reason, simply report TEST_SKIPPED and move on. It is not an actual test failure. Signed-off-by: Zi Shen Lim --- platform/linux-generic/test/pktio/pktio_run_tap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/test/pktio

Re: [lng-odp] [PATCH] linux-generic: make x86 cpuinfo parser more robust

2016-04-04 Thread Bill Fischofer
This patch seems stale and needs a rebase. I get this trying to apply it: bill@Ubuntu15:~/linaro/hongbo$ git am --reject ~/Mail/Incoming/Hongbo/1 Applying: linux-generic: make x86 cpuinfo parser more robust Checking patch platform/linux-generic/arch/x86/odp_sysinfo_parse.c... error: while searchi

Re: [lng-odp] [PATCHv2] configure: remove separate so_version file

2016-04-04 Thread Ricardo Salveti
On Fri, Apr 1, 2016 at 5:31 PM, Anders Roxell wrote: > Set versioning in configure.ac directly, folks familiar with autotools > will expect it to be set there. > > Suggested-by: Fathi Boudra > Signed-off-by: Anders Roxell > --- > .so_version | 1 - > Makefile.am | 2 +- > configure.

Re: [lng-odp] [PATCH 1/2] configure: support out-of-tree CUnit

2016-04-04 Thread Ricardo Salveti
On Mon, Apr 4, 2016 at 11:08 AM, Anders Roxell wrote: > On 26 March 2016 at 02:06, Brian Brooks wrote: >> On 04/01 22:15:34, Anders Roxell wrote: >>> On 25 March 2016 at 20:25, Brian Brooks wrote: >>> > If --with-cunit-path=DIR is used, skip the AC_CHECK_LIB and modify the >>> > linker >>> > fl

Re: [lng-odp] [PATCHv2] linux-generic: pktio: handle transient output queue nonempty conditions

2016-04-04 Thread Maxim Uvarov
In other termination code we have ODP_ERR(). For mostly all things which is called from odp_term_global. But I like current ASSERT() more but it's more easy to debug that code and clean up such things then follow bunch of error debug prints. If no objections I'm going to apply this simple patch

Re: [lng-odp] [PATCH] test/performance:Avoid possible out-of-bounds memory access

2016-04-04 Thread Maxim Uvarov
On 04/04/16 12:11, Balakrishna Garapati wrote: Resolving https://bugs.linaro.org/show_bug.cgi?id=2136 by initializing definite number of worker threads. Signed-off-by: Balakrishna Garapati --- test/performance/odp_crypto.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) dif

[lng-odp] plan to release 1.9 at April 15

2016-04-04 Thread Maxim Uvarov
Hello team, It looks like we have good number of changes for next point release. There is initial plan to release next (1.9) point release in 2 weeks, about April 15. Main changes will be port of patches from api-next branch for pktio (checksum, timestamps), as well as rw try locks and other

Re: [lng-odp] [PATCH] linux-generic: test: shmem: coverity fix

2016-04-04 Thread Bill Fischofer
On Mon, Apr 4, 2016 at 4:29 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Fixes: https://bugs.linaro.org/show_bug.cgi?id=2148 (CID 159393) > The if statement introduced here is redundant with the previous > CU_ASSERT_FATAL, but avoids the coverity warning. > (coverity probably mis

Re: [lng-odp] [PATCHv4] linux-generic: pktio: avoid coverity issues by adding explicit rc check

2016-04-04 Thread Bill Fischofer
OK, v5 sent with that suggested change. On Mon, Apr 4, 2016 at 10:26 AM, Maxim Uvarov wrote: > On 04/04/16 17:42, Bill Fischofer wrote: > >> Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an >> explicit rc check for odp_pktio_capability(). >> >> Signed-off-by: Bill Fischofer

[lng-odp] [PATCHv5] linux-generic: pktio: avoid coverity issues by adding explicit rc check

2016-04-04 Thread Bill Fischofer
Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an explicit rc check for odp_pktio_capability(). Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet_io.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/platform/linux-generi

Re: [lng-odp] [PATCH] linux-generic: test: shmem: string size fix

2016-04-04 Thread Maxim Uvarov
Merged, Maxim. On 04/04/16 18:04, Mike Holmes wrote: On 4 April 2016 at 08:11, Christophe Milard mailto:christophe.mil...@linaro.org>> wrote: Fixes: https://bugs.linaro.org/show_bug.cgi?id=2149 (CID 159392) Signed-off-by: Christophe Milard mailto:christophe.mil...@linaro.org>> R

Re: [lng-odp] [PATCHv4] linux-generic: test: shmem: atomic check+open fifo

2016-04-04 Thread Maxim Uvarov
On 04/04/16 13:31, Christophe Milard wrote: Fixes: https://bugs.linaro.org/show_bug.cgi?id=2146 (CID 159395) The open system call is directely used to check the presence of the fifo and open it at the same time. Signed-off-by: Christophe Milard --- since v3: nb_sec incremented in loop rather

Re: [lng-odp] [PATCH 2/2] doc: install docs

2016-04-04 Thread Maxim Uvarov
Merged, Maxim. On 04/04/16 16:39, Christophe Milard wrote: On 2016-03-30 14:34, Mike Holmes wrote: Signed-off-by: Mike Holmes Reviewed-by: Christophe Milard --- doc/implementers-guide/Makefile.am | 1 + doc/process-guide/Makefile.am | 2 ++ doc/users-guide/Makefile.am| 1 +

Re: [lng-odp] [PATCHv4] linux-generic: pktio: avoid coverity issues by adding explicit rc check

2016-04-04 Thread Maxim Uvarov
On 04/04/16 17:42, Bill Fischofer wrote: Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an explicit rc check for odp_pktio_capability(). Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet_io.c | 24 ++-- 1 file changed, 18 insertions(+

Re: [lng-odp] [PATCH] linux-generic: test: shmem: string size fix

2016-04-04 Thread Mike Holmes
On 4 April 2016 at 08:11, Christophe Milard wrote: > Fixes: https://bugs.linaro.org/show_bug.cgi?id=2149 (CID 159392) > > Signed-off-by: Christophe Milard > Reviewed-by: Mike Holmes > --- > platform/linux-generic/test/shmem/shmem_linux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

[lng-odp] [Bug 2138] CID 158518: CID 158519: Unchecked return value: odp_packet_io.c

2016-04-04 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2138 --- Comment #3 from Bill Fischofer --- v4 submitted at http://patches.opendataplane.org/patch/5478/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp mailing list lng-od

[lng-odp] [PATCHv4] linux-generic: pktio: avoid coverity issues by adding explicit rc check

2016-04-04 Thread Bill Fischofer
Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an explicit rc check for odp_pktio_capability(). Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet_io.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/platform/linu

Re: [lng-odp] [PATCHv2] linux-generic: pktio: avoid coverity issues by adding explicit cast

2016-04-04 Thread Bill Fischofer
OK. I realized the commit message was wrong so ignore the just submitted v3 as well. v4 coming up. :) On Mon, Apr 4, 2016 at 9:36 AM, Maxim Uvarov wrote: > On 04/04/16 17:29, Bill Fischofer wrote: > >> Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an >> explicit rc check

[lng-odp] [PATCHv3] linux-generic: pktio: avoid coverity issues by adding explicit rc check

2016-04-04 Thread Bill Fischofer
Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an explicit rc check for odp_pktio_capability(). Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet_io.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/platform/linux-generic/odp_p

Re: [lng-odp] [PATCHv2] linux-generic: pktio: avoid coverity issues by adding explicit cast

2016-04-04 Thread Maxim Uvarov
On 04/04/16 17:29, Bill Fischofer wrote: Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an explicit rc check for odp_pktio_capability(). Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet_io.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(

[lng-odp] [Bug 2138] CID 158518: CID 158519: Unchecked return value: odp_packet_io.c

2016-04-04 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2138 --- Comment #2 from Bill Fischofer --- v2 of patch submitted at http://patches.opendataplane.org/patch/5476/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp mailing li

[lng-odp] [PATCHv2] linux-generic: pktio: avoid coverity issues by adding explicit cast

2016-04-04 Thread Bill Fischofer
Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an explicit rc check for odp_pktio_capability(). Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet_io.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/platform/linux-generic/odp_p

Re: [lng-odp] [PATCH 1/2] configure: support out-of-tree CUnit

2016-04-04 Thread Mike Holmes
On 4 April 2016 at 10:08, Anders Roxell wrote: > On 26 March 2016 at 02:06, Brian Brooks wrote: > > On 04/01 22:15:34, Anders Roxell wrote: > >> On 25 March 2016 at 20:25, Brian Brooks > wrote: > >> > If --with-cunit-path=DIR is used, skip the AC_CHECK_LIB and modify > the linker > >> > flags a

Re: [lng-odp] [PATCH 1/2] configure: support out-of-tree CUnit

2016-04-04 Thread Anders Roxell
On 26 March 2016 at 02:06, Brian Brooks wrote: > On 04/01 22:15:34, Anders Roxell wrote: >> On 25 March 2016 at 20:25, Brian Brooks wrote: >> > If --with-cunit-path=DIR is used, skip the AC_CHECK_LIB and modify the >> > linker >> > flags accordingly. >> >> Why should we skip the AC_CHECK_LIB and

Re: [lng-odp] [PATCH 2/2] doc: install docs

2016-04-04 Thread Christophe Milard
On 2016-03-30 14:34, Mike Holmes wrote: > Signed-off-by: Mike Holmes Reviewed-by: Christophe Milard > --- > doc/implementers-guide/Makefile.am | 1 + > doc/process-guide/Makefile.am | 2 ++ > doc/users-guide/Makefile.am| 1 + > 3 files changed, 4 insertions(+) > > diff --git a/do

Re: [lng-odp] [PATCH 1/2] doc: rebuild only when required

2016-04-04 Thread Christophe Milard
On 2016-03-30 14:34, Mike Holmes wrote: > Signed-off-by: Mike Holmes Reviewed-by: Christophe Milard > --- > doc/Makefile.inc | 3 +++ > doc/implementers-guide/Makefile.am | 3 +-- > doc/process-guide/Makefile.am | 2 -- > doc/users-guide/Makefile.am| 3 +-- > 4 f

Re: [lng-odp] [PATCH] linux-generic: pktio: avoid coverity issues by adding explicit cast

2016-04-04 Thread Bill Fischofer
Added to today's ARCH call to discuss this. On Mon, Apr 4, 2016 at 1:13 AM, Maxim Uvarov wrote: > On 04/03/16 15:38, Bill Fischofer wrote: > >> >> >> On Fri, Apr 1, 2016 at 11:02 AM, Maxim Uvarov > > wrote: >> >> On 03/27/16 00:21, Bill Fischofer wrote: >> >>

[lng-odp] [PATCH] linux-generic: test: shmem: string size fix

2016-04-04 Thread Christophe Milard
Fixes: https://bugs.linaro.org/show_bug.cgi?id=2149 (CID 159392) Signed-off-by: Christophe Milard --- platform/linux-generic/test/shmem/shmem_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/test/shmem/shmem_linux.c b/platform/linux-generic/test

[lng-odp] [PATCHv4] linux-generic: test: shmem: atomic check+open fifo

2016-04-04 Thread Christophe Milard
Fixes: https://bugs.linaro.org/show_bug.cgi?id=2146 (CID 159395) The open system call is directely used to check the presence of the fifo and open it at the same time. Signed-off-by: Christophe Milard --- since v3: nb_sec incremented in loop rather then at test time. (Maxim) since v2: bug URL a

[lng-odp] [PATCH] test/performance:Avoid possible out-of-bounds memory access

2016-04-04 Thread Balakrishna Garapati
Resolving https://bugs.linaro.org/show_bug.cgi?id=2136 by initializing definite number of worker threads. Signed-off-by: Balakrishna Garapati --- test/performance/odp_crypto.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/performance/odp_crypto.c b/test/perf

[lng-odp] [Bug 2161] New: Configure script fails in Cunit check

2016-04-04 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2161 Bug ID: 2161 Summary: Configure script fails in Cunit check Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: Other OS: Linux Status: UNCONFIRMED

[lng-odp] [PATCH] linux-generic: test: shmem: coverity fix

2016-04-04 Thread Christophe Milard
Fixes: https://bugs.linaro.org/show_bug.cgi?id=2148 (CID 159393) The if statement introduced here is redundant with the previous CU_ASSERT_FATAL, but avoids the coverity warning. (coverity probably misses the longjump in CU_ASSERT_FATAL) Signed-off-by: Christophe Milard --- NOTE: to be applied o