[lxc-devel] [PATCH] doc: Update Japanese man pages

2014-01-15 Thread KATOH Yasufumi
* lxc-unshare(1): Update for commit c1bb25a831fdd568fb8c899b67a7be63c21f4a10 and 13d8bde96f0a21da92bcf353ad5db3f6f83172c2 * lxc.conf(5): Update for commit 04a243f11d5d4891b427107774d30d058bb191e7 Signed-off-by: KATOH Yasufumi --- doc/ja/lxc-unshare.sgml.in | 93 +

[lxc-devel] [PATCH] lxc_init.c: error handing for sigaction and sigprocmask

2014-01-15 Thread Qiang Huang
Look through all LXC code and seems like only here are missed. Signed-off-by: Qiang Huang --- Maybe this bug can be marked resolved: https://github.com/lxc/lxc/issues/83 --- src/lxc/lxc_init.c | 46 +++--- 1 file changed, 31 insertions(+), 15 deletions(-)

[lxc-devel] State of templates (wrt lxc-download)

2014-01-15 Thread Stéphane Graber
Hey everyone, So I just did a few tests on a standard Ubuntu system, trying to create a container for each distro that LXC supports, results are: alpine FAILED (signature validation failure) altlinuxBROKEN (blows up in a few interesting ways) archlinux BROKEN (r

Re: [lxc-devel] [PATCH 1/1] Initial support for cgmanager

2014-01-15 Thread S . Çağlar Onur
Hi Serge, On Wed, Jan 15, 2014 at 12:19 PM, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): >> On Tue, Jan 14, 2014 at 04:41:36PM -0600, Serge Hallyn wrote: >> > This patch splits out most of the cgroupfs-specific code, so that >> > cgroup-manager versions can be plugged in.

[lxc-devel] [PATCH] skip rootfs pinning for unprivileged containers

2014-01-15 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur --- src/lxc/start.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/lxc/start.c b/src/lxc/start.c index 6c07e43..fbdfc05 100644 --- a/src/lxc/start.c +++ b/src/lxc/start.c @@ -782,11 +782,14 @@ static int lxc_spawn(struct lxc_handle

[lxc-devel] [lxc/lxc] d4ef7c: Initial support for cgmanager

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: d4ef7c50ae980d13f6e7a44c595228a8cba9d8f2 https://github.com/lxc/lxc/commit/d4ef7c50ae980d13f6e7a44c595228a8cba9d8f2 Author: Serge Hallyn Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M configure.ac

[lxc-devel] [lxc/lxc] 3fefd6: ubuntu: Don't fail on invalid locale

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 3fefd6e6d5bdd38a0e29587896b9b8bb6db6af2e https://github.com/lxc/lxc/commit/3fefd6e6d5bdd38a0e29587896b9b8bb6db6af2e Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M templates/l

Re: [lxc-devel] CLONE_PARENT after setns(CLONE_NEWPID)

2014-01-15 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Eric W. Biederman writes: > >So hmm. > > > >Because it can do no harm, and because it is a regression let's remove > >the CLONE_PARENT check and send it stable. > > > >diff --git a/kernel/fork.c b/kernel/fork.c > >index 086fe73..c447fbc 100644 > >---

Re: [lxc-devel] [PATCH] ubuntu: Don't fail on invalid locale

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > templates/lxc-ubuntu.in | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in > index d9bb8a4..74d6eb4

Re: [lxc-devel] [PATCH] lxc-ubuntu-cloud: Fix cache and lock location

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Oh. Drat. Thanks, I shoulda done that yesterday. Acked-by: Serge E. Hallyn > --- > templates/lxc-ubuntu-cloud.in | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/templates/lxc-ubun

[lxc-devel] [lxc/lxc] 19668d: lxc-create: Don't print the help message twice

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 19668d8b0798d4078f17f83241b6c113a0ed1bb0 https://github.com/lxc/lxc/commit/19668d8b0798d4078f17f83241b6c113a0ed1bb0 Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M src/lxc/lxc

Re: [lxc-devel] [PATCH] lxc-create: Don't print the help message twice

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > The forking logic was wrong, causing both the child and the parent to > call the template with -h. > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > src/lxc/lxc_create.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 d

[lxc-devel] [PATCH] lxc-ubuntu-cloud: Fix cache and lock location

2014-01-15 Thread Stéphane Graber
Signed-off-by: Stéphane Graber --- templates/lxc-ubuntu-cloud.in | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/templates/lxc-ubuntu-cloud.in b/templates/lxc-ubuntu-cloud.in index 2cf86c9..7a3c8c3 100644 --- a/templates/lxc-ubuntu-cloud.in +++ b/templates/lxc-ubuntu-clo

[lxc-devel] [PATCH] lxc-create: Don't print the help message twice

2014-01-15 Thread Stéphane Graber
The forking logic was wrong, causing both the child and the parent to call the template with -h. Signed-off-by: Stéphane Graber --- src/lxc/lxc_create.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_create.c b/src/lxc/lxc_create.c index 6d94709..058dc43

[lxc-devel] [PATCH] ubuntu: Don't fail on invalid locale

2014-01-15 Thread Stéphane Graber
Signed-off-by: Stéphane Graber --- templates/lxc-ubuntu.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in index d9bb8a4..74d6eb4 100644 --- a/templates/lxc-ubuntu.in +++ b/templates/lxc-ubuntu.in @@ -87,11 +87,11 @@ EO

[lxc-devel] [Passed] lxc/lxc#80 (lxc-1.0.0.beta2 - deccacf)

2014-01-15 Thread Travis CI
Build Update for lxc/lxc - Build: #80 Status: Passed Duration: 2 minutes and 39 seconds Commit: deccacf (lxc-1.0.0.beta2) Author: Stéphane Graber Message: change version to 1.0.0.beta2 in configure.ac Signed-off-by: Stéphane Graber View the changeset: https:

[lxc-devel] [lxc/lxc] 09ec76: Add missing entry to dist target

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 09ec76ceec35921a5fa992ba981c9dfdeab6f204 https://github.com/lxc/lxc/commit/09ec76ceec35921a5fa992ba981c9dfdeab6f204 Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M doc/Makefil

[lxc-devel] [lxc/lxc] deccac: change version to 1.0.0.beta2 in configure.ac

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: deccacff34d31fef8fd6c2c30d40faa354aefa32 https://github.com/lxc/lxc/commit/deccacff34d31fef8fd6c2c30d40faa354aefa32 Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M configure.a

[lxc-devel] [lxc/lxc]

2014-01-15 Thread GitHub
Branch: refs/tags/lxc-1.0.0.beta2 Home: https://github.com/lxc/lxc ___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel

[lxc-devel] [lxc/lxc] 7a4016: Add local definition of sethostname to lxc_unshare

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 7a401679393f160322820efa683197f8d589ccc9 https://github.com/lxc/lxc/commit/7a401679393f160322820efa683197f8d589ccc9 Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M src/lxc/lxc

[lxc-devel] [Fixed] lxc/lxc#77 (master - 31a1209)

2014-01-15 Thread Travis CI
Build Update for lxc/lxc - Build: #77 Status: Fixed Duration: 2 minutes and 14 seconds Commit: 31a1209 (master) Author: Serge Hallyn Message: lxc-unshare: uid_t is unsigned. so we can't use uid==-1 as "don't do setuid" Signed-off-by: Serge Hallyn View the c

[lxc-devel] [lxc/lxc] 31a120: lxc-unshare: uid_t is unsigned.

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 31a1209de9633c9ac235e46fcd913f04ea629ca4 https://github.com/lxc/lxc/commit/31a1209de9633c9ac235e46fcd913f04ea629ca4 Author: Serge Hallyn Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M src/lxc/lxc_un

[lxc-devel] [Broken] lxc/lxc#76 (master - c1bb25a)

2014-01-15 Thread Travis CI
Build Update for lxc/lxc - Build: #76 Status: Broken Duration: 2 minutes and 16 seconds Commit: c1bb25a (master) Author: Seth Robertson Message: Teach lxc_unshare about interfaces, mounts, hostname, daemonize lxc_unshare now takes one or more '-i interfacename

[lxc-devel] [lxc/lxc] 13d8bd: lxc_unshare -u argument useful even with USER name...

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 13d8bde96f0a21da92bcf353ad5db3f6f83172c2 https://github.com/lxc/lxc/commit/13d8bde96f0a21da92bcf353ad5db3f6f83172c2 Author: Seth Robertson Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M doc/lxc-unsh

[lxc-devel] Fwd: Re: CLONE_PARENT after setns(CLONE_NEWPID)

2014-01-15 Thread Christian Seiler
Sorry, forgot to change the lxc-devel mailing list address when replying to this old thread... Original-Nachricht Betreff: Re: CLONE_PARENT after setns(CLONE_NEWPID) Datum: Wed, 15 Jan 2014 22:11:18 +0100 Von: Christian Seiler An: Eric W. Biederman , Oleg Nesterov Kopie (CC)

[lxc-devel] [lxc/lxc] 00fe5e: debian: Switch to config includes

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 00fe5e1d19def221951c1bfcb631b47a2403c951 https://github.com/lxc/lxc/commit/00fe5e1d19def221951c1bfcb631b47a2403c951 Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M config/temp

Re: [lxc-devel] [PATCH] debian: Switch to config includes

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > config/templates/Makefile.am | 2 ++ > config/templates/debian.common.conf.in | 62 > ++ > config/templates/debian.userns.conf.in | 9 +

[lxc-devel] [PATCH] debian: Switch to config includes

2014-01-15 Thread Stéphane Graber
Signed-off-by: Stéphane Graber --- config/templates/Makefile.am | 2 ++ config/templates/debian.common.conf.in | 62 ++ config/templates/debian.userns.conf.in | 9 + configure.ac | 2 ++ templates/lxc-debian.in

[lxc-devel] [PATCH 3/1] stop cmd callback: unfreeze by path only

2014-01-15 Thread Serge Hallyn
in particular, regular unfreeze uses the cmd api to request the cgroup of the container. If we are already in the lxc-start monitor, we can't use the cmd api. (I knew when I started this would be a problem but then as it didn't reliably crash, I forgot to handle it) Signed-off-by: Serge Hallyn

[lxc-devel] [lxc/lxc] ceceea: Disable logpath for unprivileged containers

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: ceceea1e967453d513484516aab4593f21cdbd89 https://github.com/lxc/lxc/commit/ceceea1e967453d513484516aab4593f21cdbd89 Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M src/lxc/log

Re: [lxc-devel] [PATCH] Disable logpath for unprivileged containers

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > src/lxc/log.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/lxc/log.c b/src/lxc/log.c > index b09885c..4a2b7eb 100644 > --- a/src/lxc/log.c > +++ b/src/lxc/log

[lxc-devel] [PATCH] Disable logpath for unprivileged containers

2014-01-15 Thread Stéphane Graber
Signed-off-by: Stéphane Graber --- src/lxc/log.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/lxc/log.c b/src/lxc/log.c index b09885c..4a2b7eb 100644 --- a/src/lxc/log.c +++ b/src/lxc/log.c @@ -318,6 +318,11 @@ extern int lxc_log_init(const char *name, const char *file,

[lxc-devel] [lxc/lxc] 0ce294: oracle: Fix running template unprivileged

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 0ce2946360098f936d525ceabd8cb7c60207c005 https://github.com/lxc/lxc/commit/0ce2946360098f936d525ceabd8cb7c60207c005 Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M config/temp

Re: [lxc-devel] [PATCH] oracle: Fix running template unprivileged

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Without this /dev/console won't exist and upstart will fail to start any > job marking as "console output" including the rather important rcS. > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > config/templates/oracle.userns.c

[lxc-devel] [PATCH] oracle: Fix running template unprivileged

2014-01-15 Thread Stéphane Graber
Without this /dev/console won't exist and upstart will fail to start any job marking as "console output" including the rather important rcS. Signed-off-by: Stéphane Graber --- config/templates/oracle.userns.conf.in | 1 + 1 file changed, 1 insertion(+) diff --git a/config/templates/oracle.usern

[lxc-devel] [PATCH 2/1] implement cgmanager_remove_cgroup

2014-01-15 Thread Serge Hallyn
Signed-off-by: Serge Hallyn --- src/lxc/cgmanager.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/lxc/cgmanager.c b/src/lxc/cgmanager.c index 92745dc..53a1802 100644 --- a/src/lxc/cgmanager.c +++ b/src/lxc/cgmanager.c @@ -130,10 +130,15 @@ struct cgm_data {

Re: [lxc-devel] [PATCH 1/1] Initial support for cgmanager

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 11:19:41AM -0600, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > On Tue, Jan 14, 2014 at 04:41:36PM -0600, Serge Hallyn wrote: > > > This patch splits out most of the cgroupfs-specific code, so that > > > cgroup-manager versions can be plugged in.

[lxc-devel] [lxc/lxc] 9e6997: oracle template: convert to common.conf style

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 9e69977fa6fe9273cbe166cbb7f9cbbd427b5a01 https://github.com/lxc/lxc/commit/9e69977fa6fe9273cbe166cbb7f9cbbd427b5a01 Author: Dwight Engen Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M config/templat

Re: [lxc-devel] [PATCH 3/3] oracle template: default to 6.5 when no release given or detected

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 12:21:57PM -0500, Dwight Engen wrote: > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber > --- > templates/lxc-oracle.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in > index 6df328d.

Re: [lxc-devel] [PATCH 2/3] oracle template: don't sed /etc/init/tty.conf on older releases

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 12:21:52PM -0500, Dwight Engen wrote: > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber > --- > templates/lxc-oracle.in | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in > index ccc746a..

Re: [lxc-devel] [PATCH] plamo: Update template to use wget when download packages

2014-01-15 Thread Stéphane Graber
On Thu, Jan 16, 2014 at 01:55:52AM +0900, KATOH Yasufumi wrote: > Signed-off-by: TAMUKI Shoichi > Signed-off-by: KATOH Yasufumi Thanks for that! Acked-by: Stéphane Graber > --- > templates/lxc-plamo.in | 94 > -- > 1 file changed, 45 insertion

Re: [lxc-devel] [PATCH 1/3] oracle template: convert to common.conf style

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 12:21:44PM -0500, Dwight Engen wrote: > Signed-off-by: Dwight Engen I'll apply this with the small change listed below. Acked-by: Stéphane Graber > --- > config/templates/Makefile.am | 2 ++ > config/templates/oracle.common.conf.in | 45 > ++

[lxc-devel] [lxc/lxc] 8adef7: plamo: Update template to use wget when download p...

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 8adef7614d4340b4ee44a4441fadd530f48515ed https://github.com/lxc/lxc/commit/8adef7614d4340b4ee44a4441fadd530f48515ed Author: KATOH Yasufumi Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M templates/lx

[lxc-devel] [PATCH 3/3] oracle template: default to 6.5 when no release given or detected

2014-01-15 Thread Dwight Engen
Signed-off-by: Dwight Engen --- templates/lxc-oracle.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in index 6df328d..80c2df2 100644 --- a/templates/lxc-oracle.in +++ b/templates/lxc-oracle.in @@ -713,8 +713,8 @@ else

[lxc-devel] [PATCH 2/3] oracle template: don't sed /etc/init/tty.conf on older releases

2014-01-15 Thread Dwight Engen
Signed-off-by: Dwight Engen --- templates/lxc-oracle.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in index ccc746a..6df328d 100644 --- a/templates/lxc-oracle.in +++ b/templates/lxc-oracle.in @@ -245,7 +245,9 @@ EOF e

[lxc-devel] [PATCH 1/3] oracle template: convert to common.conf style

2014-01-15 Thread Dwight Engen
Signed-off-by: Dwight Engen --- config/templates/Makefile.am | 2 ++ config/templates/oracle.common.conf.in | 45 ++ config/templates/oracle.userns.conf.in | 17 + configure.ac | 2 ++ templates/lxc-oracle.in

Re: [lxc-devel] [PATCH 1/1] Initial support for cgmanager

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Tue, Jan 14, 2014 at 04:41:36PM -0600, Serge Hallyn wrote: > > This patch splits out most of the cgroupfs-specific code, so that > > cgroup-manager versions can be plugged in. The case I did > > not handle is cgroup_enter at lxc_attach. I'm hopi

Re: [lxc-devel] [PATCH 1/1] lxc.conf: note the 'lxc.network.type = none' option

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 11:13:39AM -0600, Serge Hallyn wrote: > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber > --- > doc/lxc.conf.sgml.in | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/doc/lxc.conf.sgml.in b/doc/lxc.conf.sgml.in > index ba10939..cadcc66 100644 > --

[lxc-devel] [PATCH 1/1] lxc.conf: note the 'lxc.network.type = none' option

2014-01-15 Thread Serge Hallyn
Signed-off-by: Serge Hallyn --- doc/lxc.conf.sgml.in | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/lxc.conf.sgml.in b/doc/lxc.conf.sgml.in index ba10939..cadcc66 100644 --- a/doc/lxc.conf.sgml.in +++ b/doc/lxc.conf.sgml.in @@ -230,6 +230,15 @@ Foundation, Inc., 51 Franklin Stre

[lxc-devel] [PATCH] plamo: Update template to use wget when download packages

2014-01-15 Thread KATOH Yasufumi
Signed-off-by: TAMUKI Shoichi Signed-off-by: KATOH Yasufumi --- templates/lxc-plamo.in | 94 -- 1 file changed, 45 insertions(+), 49 deletions(-) diff --git a/templates/lxc-plamo.in b/templates/lxc-plamo.in index a40bec7..9af29e4 100644 --- a/temp

[lxc-devel] Bug reports

2014-01-15 Thread Stéphane Graber
Hey everyone, So as you noticed, between yesterday and today, I caught up a bit on all our pending pull requests, patches and some bug reports. We however still have quite a few reports, both actual bugs and minor features that I think would be worthwhile to get into LXC 1.0. The current list is

Re: [lxc-devel] Last minute template addition - universal image based template

2014-01-15 Thread KATOH Yasufumi
Hi, >>> On Wed, 15 Jan 2014 10:13:08 -0500 in message "Re: [lxc-devel] Last minute template addition - universal image based template" Stephane Graber-san wrote: > It may also be worth having lxc-plamo run with -e and have a cleanup > trap handler (look at lxc-download for

Re: [lxc-devel] [PATCH 1/1] Initial support for cgmanager

2014-01-15 Thread Stéphane Graber
On Tue, Jan 14, 2014 at 04:41:36PM -0600, Serge Hallyn wrote: > This patch splits out most of the cgroupfs-specific code, so that > cgroup-manager versions can be plugged in. The case I did > not handle is cgroup_enter at lxc_attach. I'm hoping that case can > be greatly simplified, but will worr

[lxc-devel] [lxc/lxc] 28bb93: cgroup.c: redefine the valid cgroup name

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 28bb9321e2c55aa93097487e41c3aca95e0c106c https://github.com/lxc/lxc/commit/28bb9321e2c55aa93097487e41c3aca95e0c106c Author: Qiang Huang Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M src/lxc/cgroup.

[lxc-devel] [lxc/lxc] 959dd8: Fix small mistake with squid-deb-proxy hook

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 959dd8f250a49bd8b3503a7b5f90a242ece5843d https://github.com/lxc/lxc/commit/959dd8f250a49bd8b3503a7b5f90a242ece5843d Author: Chris Glass Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M hooks/squid-deb

Re: [lxc-devel] [PATCH 1/2] cgroup.c: add static keywords as they declared

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 11:32:29PM +0800, Qiang Huang wrote: > From: Qiang Huang > > Signed-off-by: Qiang Huang Acked-by: Stéphane Graber > --- > src/lxc/cgroup.c | 47 +-- > 1 file changed, 29 insertions(+), 18 deletions(-) > > diff --git a/src/l

Re: [lxc-devel] [PATCH 2/2] cgroup.h: unify the nameing and comments

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 11:32:30PM +0800, Qiang Huang wrote: > From: Qiang Huang > > Signed-off-by: Qiang Huang Acked-by: Stéphane Graber > --- > src/lxc/cgroup.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lxc/cgroup.h b/src/lxc/cgroup.h > index 3aab12d..a2

Re: [lxc-devel] [PATCH] cgroup.c: redefine the valid cgroup name

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 12:09:26PM +0800, Qiang Huang wrote: > > Signed-off-by: Qiang Huang Acked-by: Stéphane Graber > --- > src/lxc/cgroup.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup.c > index 6d837f9..69910cc 100644 > -

[lxc-devel] [lxc/lxc] b408e7: Trailing whitespace

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: b408e70daff7b36ac1f0ef4c86f70072c2f38480 https://github.com/lxc/lxc/commit/b408e70daff7b36ac1f0ef4c86f70072c2f38480 Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M templates/l

[lxc-devel] [PATCH 1/2] cgroup.c: add static keywords as they declared

2014-01-15 Thread Qiang Huang
From: Qiang Huang Signed-off-by: Qiang Huang --- src/lxc/cgroup.c | 47 +-- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup.c index 6d837f9..8030a8b 100644 --- a/src/lxc/cgroup.c +++ b/src/lxc/cgroup.c

[lxc-devel] [PATCH 2/2] cgroup.h: unify the nameing and comments

2014-01-15 Thread Qiang Huang
From: Qiang Huang Signed-off-by: Qiang Huang --- src/lxc/cgroup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/cgroup.h b/src/lxc/cgroup.h index 3aab12d..a252123 100644 --- a/src/lxc/cgroup.h +++ b/src/lxc/cgroup.h @@ -155,7 +155,7 @@ extern int lxc_cgroup_get(con

Re: [lxc-devel] [PATCH] Always try to create lxcpath

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 08:53:52AM -0600, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > Signed-off-by: Stéphane Graber > > Acked-by: Serge E. Hallyn > > (An error msg there might save some frustration in the future though) I didn't put one because mkdir_p will raise

Re: [lxc-devel] Last minute template addition - universal image based template

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 06:40:17PM +0900, KATOH Yasufumi wrote: > Hi, > > I checked rootfs.tar.xz of plamo. But this rootfs is not build > correctly. > > configure_plamo() in lxc-plamo edits $rootfs/etc/rc.d/rc.S,rc.M, but a > part of it was not performed. I guess that a part of editing rc.S,M i

[lxc-devel] [lxc/lxc] 040f1c: Always try to create lxcpath

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 040f1c4008a6ffcc8c5553e947bb645a8d233371 https://github.com/lxc/lxc/commit/040f1c4008a6ffcc8c5553e947bb645a8d233371 Author: Stéphane Graber Date: 2014-01-15 (Wed, 15 Jan 2014) Changed paths: M src/lxc/lxc

Re: [lxc-devel] [PATCH] lxc-download: POSIX doesn't specify -f for chown

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 08:48:52AM -0600, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > Signed-off-by: Stéphane Graber > > and you were already sending output to /dev/null anyway :) > > Acked-by: Serge E. Hallyn > > Though I would also point out that the man page sho

Re: [lxc-devel] [PATCH] doc: Update Japanese lxc.conf(5)

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 06:50:43PM +0900, KATOH Yasufumi wrote: > Update for commit df2d4205073d3f57543951ca7ffabf891b230634 > > Signed-off-by: KATOH Yasufumi Acked-by: Stéphane Graber > --- > doc/ja/lxc.conf.sgml.in | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/do

Re: [lxc-devel] [PATCH] install only lxc-user-nic setuid

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 08:36:28AM -0500, Dwight Engen wrote: > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber > --- > lxc.spec.in | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/lxc.spec.in b/lxc.spec.in > index b1bc649..a4a9e13 100644 > --- a/lxc.sp

Re: [lxc-devel] [PATCH] Always try to create lxcpath

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn (An error msg there might save some frustration in the future though) > --- > src/lxc/lxc_create.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/lxc/lxc_create.c b/src/

Re: [lxc-devel] [PATCH] lxc-download: Fix undefined DOWNLOAD_FORCE_CACHE

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > templates/lxc-download.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/templates/lxc-download.in b/templates/lxc-download.in > index aa93b59..d1d1e5b 100644 > --- a/te

Re: [lxc-devel] [PATCH] lxc-download: Fix wrong option parsing

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > templates/lxc-download.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/templates/lxc-download.in b/templates/lxc-download.in > index 04f5846..aa93b59 1

Re: [lxc-devel] [PATCH] lxc-download: POSIX doesn't specify -f for chown

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber and you were already sending output to /dev/null anyway :) Acked-by: Serge E. Hallyn Though I would also point out that the man page shows options coming before the [OWNER][:[GROUP]], which implies there might be i

Re: [lxc-devel] [PATCH 2/2] ubuntu: Fix path to openssh-server's postinst

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > The path isn't relative to @LOCALSTATEDIR@ > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > templates/lxc-ubuntu.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/templates/lxc-ubuntu.in b/temp

Re: [lxc-devel] [PATCH 1/2] debian: Support ssh host keys regeneration

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > templates/lxc-debian.in | 24 > 1 file changed, 24 insertions(+) > > diff --git a/templates/lxc-debian.in b/templates/lxc-debian.in > index d6f07b9..f399c

[lxc-devel] [PATCH] install only lxc-user-nic setuid

2014-01-15 Thread Dwight Engen
Signed-off-by: Dwight Engen --- lxc.spec.in | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lxc.spec.in b/lxc.spec.in index b1bc649..a4a9e13 100644 --- a/lxc.spec.in +++ b/lxc.spec.in @@ -126,15 +126,7 @@ rm -rf %{buildroot} %files %defattr(-,root,root) %{_bindir}

[lxc-devel] [PATCH] doc: Update Japanese lxc.conf(5)

2014-01-15 Thread KATOH Yasufumi
Update for commit df2d4205073d3f57543951ca7ffabf891b230634 Signed-off-by: KATOH Yasufumi --- doc/ja/lxc.conf.sgml.in | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/ja/lxc.conf.sgml.in b/doc/ja/lxc.conf.sgml.in index 5e1b410..1140c7f 100644 --- a/doc/ja/lxc.conf.sgml.in +

Re: [lxc-devel] Last minute template addition - universal image based template

2014-01-15 Thread KATOH Yasufumi
Hi, I checked rootfs.tar.xz of plamo. But this rootfs is not build correctly. configure_plamo() in lxc-plamo edits $rootfs/etc/rc.d/rc.S,rc.M, but a part of it was not performed. I guess that a part of editing rc.S,M is doesn't performed. "ed" command is installed on jenkins host? -- ka...@jaz

Re: [lxc-devel] Pull request: make ubuntu templates apt proxy aware

2014-01-15 Thread Chris Glass
Thanks for merging this in! As suggested, here's a trivial commit adding a commented hook to the common Ubuntu template: https://github.com/lxc/lxc/pull/137 - Chris On Tue, Jan 14, 2014 at 6:21 PM, Stéphane Graber wrote: > On Tue, Jan 14, 2014 at 06:07:32PM +0100, Chris Glass wrote: >> Should I