Re: [lxc-devel] [PATCH 2/2] daemon: remove pidfile when daemon container is stopped

2014-01-19 Thread Qiang Huang
On 2014/1/19 8:57, Stéphane Graber wrote: > On Sat, Jan 18, 2014 at 03:00:00PM +0800, Qiang Huang wrote: >> This is for bug: https://github.com/lxc/lxc/issues/89 >> >> When start container with daemon model, the daemon process's >> father will return back to main in start time, and pidfile >> is re

Re: [lxc-devel] about LXC's coding style

2014-01-19 Thread Qiang Huang
On 2014/1/20 1:54, Serge Hallyn wrote: > Quoting Qiang Huang (h.huangqi...@huawei.com): >> Hi Serge and Stéphane and list, >> >> I'm sorry but I need to complain about this :( >> >> I saw LXC's CONTRIBUTING file, it says: >> "The coding style follows the Linux kernel coding style" >> >> But after r

[lxc-devel] [PATCH 2/2] Add Japanese lxc-usernsexec(1) and fix typo English lxc-usernsexec(1)

2014-01-19 Thread KATOH Yasufumi
Signed-off-by: KATOH Yasufumi --- configure.ac | 1 + doc/ja/Makefile.am| 1 + doc/ja/lxc-usernsexec.sgml.in | 194 ++ doc/lxc-usernsexec.sgml.in| 2 +- 4 files changed, 197 insertions(+), 1 deletion(-) create mode 10

[lxc-devel] [PATCH 1/2] doc: Remove the description of lxc-kill in Japanese lxc-execute(1)

2014-01-19 Thread KATOH Yasufumi
Update for commit 33ddfc2adef00e3571137ef60d20de328e32d299 Signed-off-by: KATOH Yasufumi --- doc/ja/lxc-execute.sgml.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/ja/lxc-execute.sgml.in b/doc/ja/lxc-execute.sgml.in index cf89deb..db73b7e 100644 --- a/doc/ja/lxc-execute.sgml.in +++

Re: [lxc-devel] [PATCH RFC] api_start: don't get a container reference for the daemonized case

2014-01-19 Thread Qiang Huang
On 2014/1/20 2:17, Serge Hallyn wrote: > In the daemonized case we will fork, so the anonymous container memlock > will not be shared between parent and child. I'm basically agree with this patch. And I'm also confused about why we need this lxc_container_get in the first place. Seems like it onl

Re: [lxc-devel] [PATCH 1/2] lxc-start: fix the container leak when daemonize

2014-01-19 Thread Qiang Huang
On 2014/1/20 1:26, Serge Hallyn wrote: > Quoting Qiang Huang (h.huangqi...@huawei.com): >> When start container with daemon model, we'll have a new daemon >> process in lxcapi_start, whose c->numthreads is 2, inherited >> from his father. Even his father return to main(), the >> lxc_container_put w

[lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v3)

2014-01-19 Thread S . Çağlar Onur
Return an error if the function is not supposed to be called by an unprivileged user. Otherwise those calls fail in the middle of their execution with different reasons. changes since v2: - am_unpriv is now a simple geteuid check, - API functions are now providing error messages, - lxc-info, lxc

[lxc-devel] [PATCH RFC] api_start: don't get a container reference for the daemonized case

2014-01-19 Thread Serge Hallyn
In the daemonized case we will fork, so the anonymous container memlock will not be shared between parent and child. Please review. Signed-off-by: Serge Hallyn --- src/lxc/lxccontainer.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/lxc/lxccontainer.c b/sr

Re: [lxc-devel] [PATCH 1/2] lxc-start: fix the container leak when daemonize

2014-01-19 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Quoting Qiang Huang (h.huangqi...@huawei.com): > > When start container with daemon model, we'll have a new daemon > > process in lxcapi_start, whose c->numthreads is 2, inherited > > from his father. Even his father return to main(), the > > lxc_co

Re: [lxc-devel] about LXC's coding style

2014-01-19 Thread Serge Hallyn
Quoting Qiang Huang (h.huangqi...@huawei.com): > Hi Serge and Stéphane and list, > > I'm sorry but I need to complain about this :( > > I saw LXC's CONTRIBUTING file, it says: > "The coding style follows the Linux kernel coding style" > > But after reading code these days, there are too many ver

[lxc-devel] [lxc/lxc] 05e5d7: Revert "lxc-start: fix the container leak when dae...

2014-01-19 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 05e5d7dc9b911b9f1da125fb554de4611d2d1d9b https://github.com/lxc/lxc/commit/05e5d7dc9b911b9f1da125fb554de4611d2d1d9b Author: Stéphane Graber Date: 2014-01-19 (Sun, 19 Jan 2014) Changed paths: M src/lxc/lxc

Re: [lxc-devel] [PATCH 1/2] lxc-start: fix the container leak when daemonize

2014-01-19 Thread Serge Hallyn
Quoting Qiang Huang (h.huangqi...@huawei.com): > When start container with daemon model, we'll have a new daemon > process in lxcapi_start, whose c->numthreads is 2, inherited > from his father. Even his father return to main(), the > lxc_container_put won't affect son's numthreads. The memlock is

[lxc-devel] [lxc/lxc] ecc357: cgmanager: &existed for remove+create now returns ...

2014-01-19 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: ecc357ca0834b7e72381bbe1bfba06c2893c614b https://github.com/lxc/lxc/commit/ecc357ca0834b7e72381bbe1bfba06c2893c614b Author: Serge Hallyn Date: 2014-01-19 (Sun, 19 Jan 2014) Changed paths: M src/lxc/cgmana

Re: [lxc-devel] Sending discover loop

2014-01-19 Thread Ranjib Dey
how you have configured netwrok for the container? are you running dnsmasq on the host? On Sun, Jan 19, 2014 at 12:02 AM, group PICT MANY wrote: > Hi, > Trying to run lxc-start on ubuntu,getting following error: > *Sending discover is looping* > > > > > > > > > > > *yashu@yashu-pc:~$ sudo lxc-st

[lxc-devel] Sending discover loop

2014-01-19 Thread group PICT MANY
Hi, Trying to run lxc-start on ubuntu,getting following error: *Sending discover is looping* *yashu@yashu-pc:~$ sudo lxc-start -n yashuinit started: BusyBox v1.18.5 (Ubuntu 1:1.18.5-1ubuntu4.1)starting pid 2, tty '': '/etc/init.d/rcS' udhcpc (v1.18.5) startedSending discover...Sending dis