D3587: pathencode: fix importing hashlib on Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG92ac9cf78dba: pathencode: fix importing hashlib on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3589: pathencode: improve error messages slightly

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9aaa74f9eb87: pathencode: improve error messages slightly (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3589?vs=8751=8760

D3588: pathencode: hashlib.sha1() takes bytes not str on Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4fccc73ce2f6: pathencode: hashlib.sha1() takes bytes not str on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3585: context: fix %-formatting on Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc0f8fa74d8c2: context: fix %-formatting on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3585?vs=8747=8757

D3584: patch: fix import-time syntax error in test-check-module-imports.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHG468797392cc6: patch: fix import-time syntax error in test-check-module-imports.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3580: py3: use .startswith() instead of bytes[0]

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb403e87df069: py3: use .startswith() instead of bytes[0] (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3580?vs=8741=8752

D3583: py3: whitelist two more passing tests observed by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHGcab398cb9b49: py3: whitelist two more passing tests observed by buildbot (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3582: py3: use stringutil.pprint() to format a list to print

This revision was automatically updated to reflect the committed changes. Closed by commit rHG558e5504a4f8: py3: use stringutil.pprint() to format a list to print (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3582?vs=8743=8754#toc REPOSITORY

D3581: py3: fix kwargs handling in qgurad in hgext/mq.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG88c2d0e639b1: py3: fix kwargs handling in qgurad in hgext/mq.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3587: pathencode: fix importing hashlib on Python 3

yuja added a comment. Queued, thanks. > if (name == NULL) > return -1; > > > - hashlib = PyImport_Import(name); +hashlib = PyImport_ImportModule("hashlib"); Py_DECREF(name); Nit: `name` is no longer used.

Re: D3586: patch: use slicing to check patch line prefixes

This appears to conflict with D3580. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D3586: patch: use slicing to check patch line prefixes

yuja added a comment. This appears to conflict with https://phab.mercurial-scm.org/D3580. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3586 To: durin42, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel

Re: D3587: pathencode: fix importing hashlib on Python 3

Queued, thanks. > if (name == NULL) > return -1; > > - hashlib = PyImport_Import(name); > + hashlib = PyImport_ImportModule("hashlib"); > Py_DECREF(name); Nit: `name` is no longer used.

D3589: pathencode: improve error messages slightly

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Both of these are conditions we should never hit, so we can afford to be more verbose to make debugging less baffling. REPOSITORY rHG Mercurial REVISION

D3587: pathencode: fix importing hashlib on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm curious why PyImport_Import is returning NULL, but PyImport_ImportModule bypasses some of the regular import path, probably including demandimport, which I

D3588: pathencode: hashlib.sha1() takes bytes not str on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3588 AFFECTED FILES mercurial/cext/pathencode.c CHANGE DETAILS diff --git

D3585: context: fix %-formatting on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY changeid could be an int or a bytestr, so use our pycompat wrapper. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3585 AFFECTED

D3586: patch: use slicing to check patch line prefixes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes some regressed Python 3 tests, though I'm not sure when they regressed. REPOSITORY rHG Mercurial REVISION DETAIL

D3584: patch: fix import-time syntax error in test-check-module-imports.t

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is more correct, though we were getting lucky in practice with our rewriter saving us. 1. skip-blame just a b prefix REPOSITORY rHG Mercurial

D3583: py3: whitelist two more passing tests observed by buildbot

durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3583 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D3559: narrow: only wrap dirstate functions once, instead of per-reposetup

spectral updated this revision to Diff 8744. spectral edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3559?vs=8682=8744 REVISION DETAIL https://phab.mercurial-scm.org/D3559 AFFECTED FILES hgext/narrow/__init__.py

D3579: state: write the version number in plain text on top of state files

martinvonz requested changes to this revision. martinvonz added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > state.py:60-62 > +try: > +iv = int(version) > +except ValueError: why not `if not isinstance(version, int):`? REPOSITORY

D3582: py3: use stringutil.pprint() to format a list to print

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3582 AFFECTED FILES hgext/mq.py CHANGE DETAILS diff --git a/hgext/mq.py b/hgext/mq.py ---

D3581: py3: fix kwargs handling in qgurad in hgext/mq.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just r'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3581 AFFECTED FILES hgext/mq.py CHANGE

D3580: py3: use .startswith() instead of bytes[0]

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY bytes[0] returns the ascii value of character at 0 index. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3580 AFFECTED FILES

D3577: crecord: fallback to text mode if diffs are too big for curses mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdabc2237963c: crecord: fallback to text mode if diffs are too big for curses mode (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 6 of 6] lfs: enable the final download count status message

On Thu, May 17, 2018 at 4:48 AM Matt Harbison wrote: > On Fri, 20 Apr 2018 11:01:30 -0400, Pulkit Goyal <7895pul...@gmail.com> > wrote: > > > On Sun, Apr 15, 2018 at 12:14 PM, Matt Harbison > > wrote: > > > >> # HG changeset patch > >> # User Matt

[Bug 5891] New: Subrepo remapping doesn't appear to work

https://bz.mercurial-scm.org/show_bug.cgi?id=5891 Bug ID: 5891 Summary: Subrepo remapping doesn't appear to work Product: Mercurial Version: 4.6 Hardware: All OS: All Status: UNCONFIRMED Severity: bug

D3576: narrow: filter copies in core

This revision was automatically updated to reflect the committed changes. Closed by commit rHGee7b6fa52d9d: narrow: filter copies in core (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3576?vs=8730=8739 REVISION

D3574: narrow: filter merge actions in core

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8f37b5fc5abf: narrow: filter merge actions in core (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3574?vs=8728=8737

D3573: hgweb: extract code for emitting multiple changelist records

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5989261a8356: hgweb: extract code for emitting multiple changelist records (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3575: narrow: filter set of files to check for case-folding to core

This revision was automatically updated to reflect the committed changes. Closed by commit rHG18e6ea9ba81d: narrow: filter set of files to check for case-folding to core (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2874: remotenames: synchronise remotenames after push also

pulkit added a comment. Irrespective of https://phab.mercurial-scm.org/D2873 and https://phab.mercurial-scm.org/D2875, this should be non-controversial and good to go. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2874 To: pulkit, #hg-reviewers, indygreg Cc:

D2874: remotenames: synchronise remotenames after push also

pulkit updated this revision to Diff 8735. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2874?vs=7287=8735 REVISION DETAIL https://phab.mercurial-scm.org/D2874 AFFECTED FILES mercurial/exchange.py tests/test-logexchange.t CHANGE DETAILS diff

[Bug 5890] New: name persistent branch same as bookmark

https://bz.mercurial-scm.org/show_bug.cgi?id=5890 Bug ID: 5890 Summary: name persistent branch same as bookmark Product: Mercurial Version: 4.5.3 Hardware: PC OS: Windows Status: UNCONFIRMED Severity: bug

Re: [PATCH V2] phabricator: register config settings

On Thu, 17 May 2018 21:56:12 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1526525067 14400 > # Wed May 16 22:44:27 2018 -0400 > # Node ID a2ed1f916bba51cb5d1fec26a97c9668810c6588 > # Parent

D3572: state: don't have a dict like interface for cmdstate class

pulkit updated this revision to Diff 8732. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3572?vs=8721=8732 REVISION DETAIL https://phab.mercurial-scm.org/D3572 AFFECTED FILES mercurial/state.py CHANGE DETAILS diff --git a/mercurial/state.py

D3579: state: write the version number in plain text on top of state files

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We will soon be using CBOR format to write the data in state files. But we should not write the version number of the state files in CBOR format and we should

[Bug 5889] New: Random IOError with hgweb since 4.6 upgrade

https://bz.mercurial-scm.org/show_bug.cgi?id=5889 Bug ID: 5889 Summary: Random IOError with hgweb since 4.6 upgrade Product: Mercurial Version: 4.6 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: bug

Re: [PATCH 2 of 2] test-http-branchmap: fix stdio mode on Windows

On Sun, May 13, 2018 at 7:57 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1526177393 -32400 > # Sun May 13 11:09:53 2018 +0900 > # Node ID 74982ab8ca762a3cfe3648740dae27555232476b > # Parent

D3577: crecord: fallback to text mode if diffs are too big for curses mode

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY crecord uses curses.newpad to create a region that we can then scroll around in by moving the main 'screen' as a veiwport into the (probably larger than the