This revision was automatically updated to reflect the committed changes.
Closed by commit rHG623193ef691b: remotenames: work around move of ABCs in
collections (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
In https://phab.mercurial-scm.org/D2847#45947, @yuja wrote:
> Could be either `import collections.abc` or adding `collections.abc` to
> `list_stdlib_modules`.
Sadly, neither worked :(
The import checker currently bans /all/ `from ... import ...`
durin42 updated this revision to Diff 7037.
durin42 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2847?vs=7021=7037
REVISION DETAIL
https://phab.mercurial-scm.org/D2847
AFFECTED FILES
hgext/remotenames.py
CHANGE
yuja added a comment.
Could be either `import collections.abc` or adding `collections.abc` to
`list_stdlib_modules`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2847
To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel
durin42 updated this revision to Diff 7021.
durin42 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2847?vs=7004=7021
REVISION DETAIL
https://phab.mercurial-scm.org/D2847
AFFECTED FILES
hgext/remotenames.py
CHANGE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This starts warning in Python 3.7, and will break in 3.8.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2847
AFFECTED FILES