yuja added inline comments.
INLINE COMMENTS
> wireprotocol.txt:486
> ++---+
> +| Flags (4) |
> ++===+===|
Nit: The order of Type and Flags seems a bit confusing. I read it as
`flags << 4 | type` since this is a little-en
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG40206e227412: wireproto: define and implement protocol for
issuing requests (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D
indygreg updated this revision to Diff 7199.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2851?vs=7139&id=7199
REVISION DETAIL
https://phab.mercurial-scm.org/D2851
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
indygreg updated this revision to Diff 7139.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2851?vs=7047&id=7139
REVISION DETAIL
https://phab.mercurial-scm.org/D2851
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
indygreg updated this revision to Diff 7047.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2851?vs=7017&id=7047
REVISION DETAIL
https://phab.mercurial-scm.org/D2851
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
indygreg planned changes to this revision.
indygreg added inline comments.
INLINE COMMENTS
> wireprotoframing.py:99-100
> +offset = 0
> +ARGUMENT_FRAME_HEADER.pack_into(payload, offset, len(k), len(v))
> +payload[offset:offset + len(k)] = k
> +offset += len(k)
We
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The existing HTTP and SSH wire protocols suffer from a host of flaws
and shortcomings. I've been wanting to rewrite the protocol for a while
now. Supporting par