D7900: merge: avoid a negation in the definition of updatedirstate

2020-01-24 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGfaec51c76b7b: merge: avoid a negation in the definition of updatedirstate (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7900?vs=19554&i

D7900: merge: avoid a negation in the definition of updatedirstate

2020-01-24 Thread martinvonz (Martin von Zweigbergk)
martinvonz marked an inline comment as done. martinvonz updated this revision to Diff 19554. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7900?vs=19336&id=19554 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7900/new/ REVI

D7900: merge: avoid a negation in the definition of updatedirstate

2020-01-24 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. martinvonz marked an inline comment as done. INLINE COMMENTS > pulkit wrote in merge.py:2291 > This comment now looks misplaced. I'll insert another patch before this one to help with that. Unrelated to your comment, I'll also reorder D7901

D7900: merge: avoid a negation in the definition of updatedirstate

2020-01-24 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > merge.py:2291 > ) > # If we're doing a partial update, we need to skip updating > # the dirstate, so make a note of any partial-ness to the This comment now looks misplaced. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACT

D7900: merge: avoid a negation in the definition of updatedirstate

2020-01-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We only use `partial` in one place: the definition of `updatedirstate`. Let's simplify that a little. REPOSITORY rHG Mercurial BRANCH default REVISION DE