Due to the destination register width of 1 or 2, these instructions get
ExecSize 1 or 2. But dir and offset (used as src0) are both registers
of width 4, violating the execsize >= width assertion.
I honestly don't think this could have ever worked.
Fixes Piglit's polygon-offset and polygon-mode-
Am 06.08.2014 04:02, schrieb Ilia Mirkin:
> On Tue, Aug 5, 2014 at 5:25 PM, Roland Scheidegger wrote:
>> From a gallium perspective, indirect temp regs are already working - so
>> something like
>> MOV TEMP[0], TEMP[TEMP[1].x] should work.
>> Indirect registers are supported for inputs, outputs, t
On Tue, Aug 5, 2014 at 5:25 PM, Roland Scheidegger wrote:
> From a gallium perspective, indirect temp regs are already working - so
> something like
> MOV TEMP[0], TEMP[TEMP[1].x] should work.
> Indirect registers are supported for inputs, outputs, temps, constants,
> and immediates even, but the
From: Roland Scheidegger
If the vertex shader has no position but the gs has, the clipvertex output
was -1 (because it's the same as vs position in this case if there's no
explicit clipvertex output). This caused crashes (or assertion failures) in
clipping since in the end position (which came fr
So, primitive id in llvmpipe doesn't really work, or rather it works but
it can't do much useful with the way mesa/st sets this up at least for
some tests. In particular all of piglit
glsl-1.50-geometry-primitive-id-restart fail (result is always 0).
We actually have both system value prim id and o
On 6 August 2014 02:21, Brian Paul wrote:
> On 08/05/2014 10:16 AM, Roland Scheidegger wrote:
>>
>> Am 04.08.2014 18:08, schrieb Brian Paul:
>>>
>>> Specify the quad's Z position in clip coordinate space, not
>>> normalized Z space. Use viewport scale, translation = 0.5, 0.5.
>>>
>>> Before, we w
On 6 August 2014 09:08, wrote:
> From: Roland Scheidegger
Reviewed-by: Dave Airlie
I attempted to track this down briefly before with softpipe and failed,
Regards,
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesk
The GLSL Language Specification (version 4.30.6) is quite clear about the GLSL
character set and the expected behavior for other characters:
Section 3.1 Character Set
The source character set used for the OpenGL shading languages, outside of
comments, is a subset of UTF-8. It includes
This mostly-exhaustive test ensures that the illegal-character error
implemented in the previous commit is actually generated for most every
illegal character.
---
src/glsl/glcpp/tests/141-illegal-characters.c | 99 +
.../glcpp/tests/141-illegal-characters.c.expected | 165 +
Here, each legal character (as defined by GLSL Language Specification version
4.30.6, section 3.1) appears at least once in the input file. Obviously,
characters with special meaning (like '#' and '\') aren't treated exhaustively
with respect to all their possible uses. We have many other tests for
Some of the existing tests were using '@' and '"' incidentally within the test
body. Neither of these characters are actually legal for GLSL. And since we
are planning to start generating errors for illegal characters, we need to
first make the test suite clean.
---
src/glsl/glcpp/tests/082-invali
GCC's preprocessor accepts a macro definition where there is no space between
the macro's identifier name and the replacementlist. (GCC does emit a "missing
space" warning that we don't, but that's fine.)
This is an exhaustive test that verifies that all legal GLSL characters that
could possibly b
Of course, these aren't really useful for anything, but the GLSL language
specification does allow them:
The source character set used for the OpenGL shading languages,
outside of comments, is a subset of UTF-8. It includes the following
characters:
...
Whi
On Tue, 2014-08-05 at 13:45 +0300, Francisco Jerez wrote:
> Jan Vesely writes:
>
> > This is needed for OpenCL
> >
> > CC: Francisco Jerez
> > CC: Tom Stellard
> >
> > Signed-off-by: Jan Vesely
> > ---
> >
> > I tried to find another way how to get the information, but in the end
> > there is
On Monday, August 04, 2014 08:17:13 PM Ian Romanick wrote:
> On 08/03/2014 11:07 PM, Kenneth Graunke wrote:
> > On Sunday, June 22, 2014 03:59:01 AM Marek Olšák wrote:
> >> That's right. A uniform won't work with ARB_draw_indirect unless
> >> you lower it to direct draws, which would be very bad if
From: Roland Scheidegger
The clip stage may crash if there's no position output, for this reason
code was added to avoid running the pipeline stages in this case
(c7c7186045ec617c53f7899280cbe12e59503e4d). However, this failed to actually
work when there was a geometry shader, since unlike the ve
Kenneth Graunke writes:
> I agree that this is pretty bogus.
I'm coming around to thinking it's totally bogus.
> How about emitting a warning in the RETURN_TOKEN ('#') case?
Thanks for the review, and thanks for suggesting the warning. I added
the warning, then decided it needed some additional
From a gallium perspective, indirect temp regs are already working - so
something like
MOV TEMP[0], TEMP[TEMP[1].x] should work.
Indirect registers are supported for inputs, outputs, temps, constants,
and immediates even, but the indirect reg itself must come from a temp
or address reg (I am not 10
On Tue, Aug 5, 2014 at 11:24 AM, Ilia Mirkin wrote:
> On Tue, Aug 5, 2014 at 2:23 PM, Jason Ekstrand
> wrote:
> > Signed-off-by: Jason Ekstrand
> > ---
> > src/gallium/drivers/r300/Makefile.am | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/src/gallium/drivers/r300/Makefile.am
>
On Tue, Aug 5, 2014 at 3:23 PM, Ilia Mirkin wrote:
> On Tue, Aug 5, 2014 at 4:14 PM, Bryan Cain wrote:
> > On Mon, Aug 4, 2014 at 11:54 PM, Ilia Mirkin
> wrote:
> >>
> >> Another apporach I've tried is to just use a TEMP register as the
> >> indirect offset here. Unfortunately this gets destroy
https://bugs.freedesktop.org/show_bug.cgi?id=50604
sacrediou changed:
What|Removed |Added
CC|sacred...@yahoo.fr |
--
You are receiving this mail because:
Yo
https://bugs.freedesktop.org/show_bug.cgi?id=50604
vmer...@april.org changed:
What|Removed |Added
CC||vmer...@april.org
--
You are receivi
Using TEMPs instead of address registers seems to be the best choice
here. It will need a CAP though, because some drivers will never
support it. It might be quite a lot of work though.
Marek
On Tue, Aug 5, 2014 at 10:10 PM, Ilia Mirkin wrote:
> *needed*? No, I can't. However without changing a
On Tue, Aug 5, 2014 at 4:14 PM, Bryan Cain wrote:
> On Mon, Aug 4, 2014 at 11:54 PM, Ilia Mirkin wrote:
>>
>> Another apporach I've tried is to just use a TEMP register as the
>> indirect offset here. Unfortunately this gets destroyed by
>> st_glsl_to_tgsi's various optimizations which assume tha
On Mon, Aug 4, 2014 at 11:54 PM, Ilia Mirkin wrote:
> Another apporach I've tried is to just use a TEMP register as the
> indirect offset here. Unfortunately this gets destroyed by
> st_glsl_to_tgsi's various optimizations which assume that temp
> registers can't be reladdr's and so messes up the
*needed*? No, I can't. However without changing a bunch of stuff
around, doing something like
TEX TEMP[ADDR[0].x], SAMP[reladdr], coord, etc
Is going to be tricky. It'd be a little dangerous to use ADDR[1] there
since it's meant to be the dimension, and you could easily have, with
tessellation,
Could you please show us an example in TGSI where a 3rd address
register is needed?
Thanks,
Marek
On Tue, Aug 5, 2014 at 6:54 AM, Ilia Mirkin wrote:
> Hello,
>
> I'm in the process of working out the details of adding dynamic
> sampler support to mesa/st as part of ARB_gpu_shader5. Unfortunatel
Signed-off-by: Anuj Phogat
---
src/mesa/main/glformats.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 0fb25ba..37cb9ec 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glformats.c
@@ -1187,17 +1187,33 @
On 05/08/14 18:26, Kenneth Graunke wrote:
> On Tuesday, August 05, 2014 03:37:07 PM Emil Velikov wrote:
>> - Build it only once.
>> - Cleanup the CPPFLAGS.
>> - Add .gitignore.
>>
>> Signed-off-by: Emil Velikov
>> ---
[snip]
>
> We could also just delete it, if you prefer - there's basically n
These values are supposed to be the minimum/maximum index values used to
read from the vertex buffers. This code either copies index values out of
the old IB (so, same min/max as the original draw call), or generates a
new IB (using index values between the start and the start + count of the
old a
On Tue, Aug 5, 2014 at 2:23 PM, Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand
> ---
> src/gallium/drivers/r300/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/r300/Makefile.am
> b/src/gallium/drivers/r300/Makefile.am
> index ae6e8d2..628574a 1006
Signed-off-by: Jason Ekstrand
---
src/gallium/drivers/r300/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/r300/Makefile.am
b/src/gallium/drivers/r300/Makefile.am
index ae6e8d2..628574a 100644
--- a/src/gallium/drivers/r300/Makefile.am
+++ b/src/gallium/driver
On Thu, Jul 24, 2014 at 07:54:12PM -0700, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_cfg.h | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h
> b/src/mesa/drivers/dri/i965/brw_cfg.h
> index a5d2df5..913a1ed 100644
> --- a/src/mesa/d
This patch is
Reviewed-by: Ian Romanick
On 08/03/2014 08:18 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/mesa/main/version.c | 274
> ++--
> src/mesa/main/version.h | 4 +
> 2 files changed, 152 insertions(+), 126 deletions(-)
>
> di
On 08/03/2014 08:18 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/mesa/main/version.c | 25 ++---
> src/mesa/main/version.h | 8 +---
> 2 files changed, 23 insertions(+), 10 deletions(-)
>
> diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
> ind
This patch is
Reviewed-by: Ian Romanick
On 08/03/2014 08:18 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/mesa/main/context.c | 202
>
> src/mesa/main/context.h | 3 +
> 2 files changed, 104 insertions(+), 101 deletions(-)
>
> di
This patch is
Reviewed-by: Ian Romanick
On 08/03/2014 08:18 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/mesa/main/context.c| 2 +-
> src/mesa/main/extensions.c | 8
> src/mesa/main/extensions.h | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --gi
This patch is
Reviewed-by: Ian Romanick
On 08/03/2014 08:18 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/glsl/glsl_parser_extras.cpp | 2 +-
> src/glsl/link_varyings.cpp | 2 +-
> src/glsl/linker.cpp | 4 ++--
> src/glsl/s
This patch is
Reviewed-by: Ian Romanick
On 08/03/2014 08:18 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/mesa/drivers/dri/i915/intel_extensions.c | 2 +-
> src/mesa/drivers/dri/i965/intel_extensions.c | 2 +-
> src/mesa/main/context.c | 2 +-
> src/mesa/main/v
On Thu, Jul 24, 2014 at 07:54:16PM -0700, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_cfg.cpp | 58
> +--
> src/mesa/drivers/dri/i965/brw_cfg.h | 4 ++-
> 2 files changed, 58 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/
On Thu, Jul 24, 2014 at 07:54:17PM -0700, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_cfg.h | 1 +
> src/mesa/drivers/dri/i965/brw_shader.cpp | 32
>
> src/mesa/drivers/dri/i965/brw_shader.h | 4
> 3 files changed, 37 insertions(+)
>
>
From: Christian König
Not completely implemented, cause we need DMA copy support for every hw
generation.
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/r600_buffer_common.c | 2 +-
src/gallium/drivers/radeon/r600_pipe_common.c | 2 +-
src/gallium/drivers/radeon/r600_text
From: Christian König
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/r600_pipe_common.c | 9 ++
src/gallium/drivers/radeon/r600_pipe_common.h | 11 +++
src/gallium/drivers/radeon/r600_texture.c | 41 +--
3 files changed, 59 insertions(+), 2 de
From: Christian König
v2: fix a couple of typos and bugs
Signed-off-by: Christian König
---
src/gallium/drivers/radeonsi/si_dma.c | 85 +++
src/gallium/drivers/radeonsi/sid.h| 1 +
2 files changed, 68 insertions(+), 18 deletions(-)
diff --git a/src/gallium
From: Christian König
Signed-off-by: Christian König
---
src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 102 ++
src/gallium/winsys/radeon/drm/radeon_winsys.h | 11 +++
2 files changed, 113 insertions(+)
diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c
b/src
On Thu, Jul 24, 2014 at 07:54:15PM -0700, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_cfg.cpp | 24
> src/mesa/drivers/dri/i965/brw_cfg.h | 2 ++
> 2 files changed, 26 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_cfg.cpp
> b/src/mesa/drive
On Tuesday, August 05, 2014 03:37:07 PM Emil Velikov wrote:
> - Build it only once.
> - Cleanup the CPPFLAGS.
> - Add .gitignore.
>
> Signed-off-by: Emil Velikov
> ---
> configure.ac | 2 +-
> src/util/Makefile.am | 28 ---
> src/
I suppose the commit message could also tell that the iteration is now
two-fold, over all the blocks and over each instruction in a block instead
of over the plain list of all instructions. Anyway:
Reviewed-by: Topi Pohjolainen
___
mesa-dev mailing lis
Am 30.07.2014 19:08, schrieb Brian Paul:
> Compute the bitmask of supported array types once instead of every
> time we call a GL vertex array function.
> ---
> src/mesa/main/mtypes.h |3 ++
> src/mesa/main/varray.c | 86
> +++-
> 2 files changed,
On 08/05/2014 10:16 AM, Roland Scheidegger wrote:
Am 04.08.2014 18:08, schrieb Brian Paul:
Specify the quad's Z position in clip coordinate space, not
normalized Z space. Use viewport scale, translation = 0.5, 0.5.
Before, we were specifying the quad's Z position in [0,1] and using
viewport sc
fixes piglit glean "do-loop with continue and break" on RS690
It's based on Tom Stellard patch and improved to handle CMP instruction.
[v2] handle CMP instruction
Signed-off-by: David Heidelberger
---
.../drivers/r300/compiler/radeon_emulate_loops.c | 34
+++---
1 file cha
Am 04.08.2014 18:08, schrieb Brian Paul:
> Specify the quad's Z position in clip coordinate space, not
> normalized Z space. Use viewport scale, translation = 0.5, 0.5.
>
> Before, we were specifying the quad's Z position in [0,1] and using
> viewport scale=1.0, translate=0.0. That works fine, u
---
src/gallium/state_trackers/clover/api/program.cpp | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/gallium/state_trackers/clover/api/program.cpp
b/src/gallium/state_trackers/clover/api/program.cpp
index b81ce69..05f3840 100644
--- a/src/gallium/state_trackers/clover
On Tue, Aug 5, 2014 at 6:36 AM, Emil Velikov
wrote:
> On 05/08/14 01:42, Jason Ekstrand wrote:
> > Forgot to mention in the commit message, but this fixes bug #82159
> >
> Can you please use the format
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82159
>
> This way our scripts will fe
Looks good!
Reviewed-by: Matthew McClure
From: mesa-dev on behalf of Brian Paul
Sent: Wednesday, July 30, 2014 10:08 AM
To: mesa-dev@lists.freedesktop.org
Subject: [Mesa-dev] [PATCH] mesa: make vertex array type error checking a
little more effi
On Tue, Aug 5, 2014 at 10:28 AM, Roland Scheidegger wrote:
> Am 05.08.2014 06:54, schrieb Ilia Mirkin:
>> Hello,
>>
>> I'm in the process of working out the details of adding dynamic
>> sampler support to mesa/st as part of ARB_gpu_shader5. Unfortunately
>> I've run into a bit of a roadblock.
>>
>
On 31.07.2014 15:05, Michel Dänzer wrote:
> On 30.07.2014 20:11, Tapani Pälli wrote:
>> Current version can create ir_expression where operands have
>> different base type, patch adds support for unsigned type.
>>
>> Signed-off-by: Tapani Pälli
>> https://bugs.freedesktop.org/show_bug.cgi?id=80880
https://bugs.freedesktop.org/show_bug.cgi?id=81834
Michel Dänzer changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
- Build it only once.
- Cleanup the CPPFLAGS.
- Add .gitignore.
Signed-off-by: Emil Velikov
---
configure.ac | 2 +-
src/util/Makefile.am | 28 ---
src/util/tests/Makefile.am| 42 ---
sr
Am 05.08.2014 06:54, schrieb Ilia Mirkin:
> Hello,
>
> I'm in the process of working out the details of adding dynamic
> sampler support to mesa/st as part of ARB_gpu_shader5. Unfortunately
> I've run into a bit of a roadblock.
>
> One approach I've tried is to load the indirect sampler index int
On Tue, Aug 5, 2014 at 7:00 AM, Brian Paul wrote:
> -GLAPI void APIENTRY glVertex2bOES (GLbyte x);
> +GLAPI void APIENTRY glVertex2bOES (GLbyte x, GLbyte y);
Whoa, what a bug fix.
These look good to me:
Reviewed-by: Matt Turner
___
mesa-dev mailing l
---
include/GL/wglext.h | 1282 ---
1 file changed, 607 insertions(+), 675 deletions(-)
diff --git a/include/GL/wglext.h b/include/GL/wglext.h
index e60c652..5860c86 100644
--- a/include/GL/wglext.h
+++ b/include/GL/wglext.h
@@ -1,13 +1,13 @@
#ifnd
---
include/GL/glext.h | 324 +---
1 file changed, 209 insertions(+), 115 deletions(-)
diff --git a/include/GL/glext.h b/include/GL/glext.h
index a626580..5e67830 100644
--- a/include/GL/glext.h
+++ b/include/GL/glext.h
@@ -33,7 +33,7 @@ extern "C"
---
include/GL/glxext.h | 37 -
1 file changed, 32 insertions(+), 5 deletions(-)
diff --git a/include/GL/glxext.h b/include/GL/glxext.h
index 826fda5..b96133e 100644
--- a/include/GL/glxext.h
+++ b/include/GL/glxext.h
@@ -33,10 +33,10 @@ extern "C" {
** used
On Tuesday, August 05, 2014 03:38:48 PM Francisco Jerez wrote:
> EdB writes:
> > Hello
> >
> > I'm done with the clCompile part of OpenCL 1.2.
> >
> > As you can see I use char* data to transfert data from core to llvm.
> >
> > At first I was thinking of using std class but we need to be binary
On 05/08/14 01:42, Jason Ekstrand wrote:
> Forgot to mention in the commit message, but this fixes bug #82159
>
Can you please use the format
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82159
This way our scripts will fetch the summary and add a correct link in the
release notes :)
>
On Tue, 2014-08-05 at 12:59 +0900, Michel Dänzer wrote:
> On 05.08.2014 07:50, Jan Vesely wrote:
> > Signed-off-by: Jan Vesely
>
> I came up with exactly the same patches independently, so I pushed both
> your patches. :)
thanks
>
>
--
Jan Vesely
signature.asc
Description: This is a digi
On 08/05/2014 12:34 AM, Michel Dänzer wrote:
From: Michel Dänzer
This was a regression introduced by commit
f4b0ab7afd83c811329211eae8167c9bf238870c ('st/mesa: fix incorrect size
of UBO declarations') which caused an assertion failure while compiling
shaders of e.g. UE4 demos.
Bugzilla: https:
EdB writes:
> add a simple compat::pair
> ---
> src/gallium/state_trackers/clover/util/compat.hpp | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/gallium/state_trackers/clover/util/compat.hpp
> b/src/gallium/state_trackers/clover/util/compat.hpp
> index 50e1c7d..c5d1b39 10064
EdB writes:
> Hello
>
> I'm done with the clCompile part of OpenCL 1.2.
>
> As you can see I use char* data to transfert data from core to llvm.
>
> At first I was thinking of using std class but we need to be binary safe
> when data are transfert beetween c++98/c++11 compiled code.
>
> Then I tr
Jan Vesely writes:
> This is needed for OpenCL
>
> CC: Francisco Jerez
> CC: Tom Stellard
>
> Signed-off-by: Jan Vesely
> ---
>
> I tried to find another way how to get the information, but in the end
> there is no way to distinguish between <1,1,1> dim 1, and <1,1,1> dim 2 (or
> 3).
> So pas
Reviewed-by: Marek Olšák
Marek
On Tue, Aug 5, 2014 at 8:34 AM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> This was a regression introduced by commit
> f4b0ab7afd83c811329211eae8167c9bf238870c ('st/mesa: fix incorrect size
> of UBO declarations') which caused an assertion failure while comp
On Mon, Aug 04, 2014 at 09:03:23PM +0100, Neil Roberts wrote:
> According to the GL spec the only fragment operations that should affect
> glBlitFramebuffer are ???the pixel ownership test, the scissor test, and sRGB
> conversion???. That implies that dithering should not be performed so we need
>
73 matches
Mail list logo
