[Mesa-dev] [PATCH 7/9] i965/nir: Lower nir compute shader shared variables

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + src/mesa/drivers/dri/i965/brw_nir.c | 8 src/mesa/drivers/dri/i965/brw_nir.h | 1 + 3 files changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH] llvmpipe: fix lp_rast_plane alignment on 32bit

On 15/03/16 04:41, srol...@vmware.com wrote: From: Roland Scheidegger Some rasterization code relies (for sse) on the first and third planes (but not the second for now) being 128bit aligned, and we didn't get that on 32bit - I mistakenly thought the 64bit number in the struct would get the thi

Re: [Mesa-dev] [PATCH] draw: fix line stippling

On 13/03/16 20:40, srol...@vmware.com wrote: From: Roland Scheidegger The logic was comparing actual ints, not true/false values. This meant that it was emitting always multiple line segments instead of just one even if the stipple test had the same result, which looks inefficient, and the segm

Re: [Mesa-dev] [PATCH] softpipe: fix misleading TGSI_QUAD_SIZE usage

On 13/03/16 18:42, srol...@vmware.com wrote: From: Roland Scheidegger All these img filter loops iterate through NUM_CHANNELS, not QUAD_SIZE. In practice both are of course the same unchangeable value (4), but it makes the code look a bit confusing. Moreover, some of the functions were actually

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

On Mon, 2016-03-14 at 17:33 -0700, Jason Ekstrand wrote: > > > On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez > wrote: > From: Connor Abbott > > When we replace an expresion we have to compute bitsize > information for the > replacement. We d

[Mesa-dev] [PATCH] meta: Make BlitFramebuffer() do sRGB encoding in ES 3.x.

According to the ES 3.0 and GL 4.4 specifications, glBlitFramebuffer is supposed to perform sRGB decoding and encoding whenever sRGB formats are in use. The ES 3.0 specification is completely clear, and has always stated this. However, the GL specification has changed behavior in 4.1, 4.2, and 4.

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

On Tue, Mar 15, 2016 at 07:44:43AM +0100, Iago Toral wrote: > On Mon, 2016-03-14 at 11:15 -0700, Mark Janes wrote: > > Iago Toral writes: > > > > > On Wed, 2016-03-09 at 09:54 +0200, Pohjolainen, Topi wrote: > > >> On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez > > >> wrote:

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

On Tue, 2016-03-15 at 11:04 +0200, Pohjolainen, Topi wrote: > On Tue, Mar 15, 2016 at 07:44:43AM +0100, Iago Toral wrote: > > On Mon, 2016-03-14 at 11:15 -0700, Mark Janes wrote: > > > Iago Toral writes: > > > > > > > On Wed, 2016-03-09 at 09:54 +0200, Pohjolainen, Topi wrote: > > > >> On Mon, Ma

Re: [Mesa-dev] [PATCH 06/14] nir: handle different bit sizes when constant folding

On Mon, 2016-03-14 at 16:48 -0700, Jason Ekstrand wrote: > > > On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez > wrote: > From: Connor Abbott > > v2: Use the bit-size information from the opcode information > if defined (Iago) > > Sig

Re: [Mesa-dev] [PATCH 06/14] nir: handle different bit sizes when constant folding

On Mon, 2016-03-14 at 20:05 -0400, Connor Abbott wrote: > On Mon, Mar 14, 2016 at 7:48 PM, Jason Ekstrand wrote: > > > > > > On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez > > wrote: > >> > >> From: Connor Abbott > >> > >> v2: Use the bit-size information from the opcode information

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #7 from comicfans44 --- (In reply to Stephane Marchesin from comment #6) > It is an alignment problem in the code. I fixed it with: > > https://chromium-review.googlesource.com/#/c/332681/2/media-libs/mesa/files/ > 10.5-lp_rast-Remov

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #8 from comicfans44 --- (In reply to Roland Scheidegger from comment #4) > So, it crashed in the jit fragment shader code. > Could you tell what the fb size was (the values from scene->fb in > lp_rast_shade_tile, possibly the ones fro

Re: [Mesa-dev] [PATCH 3/4] docs: Renormalize some extensions.

Hmm... I thought that was what it meant. I can add a new status like "paused" for instance. 2016-03-14 22:40 GMT-04:00 Ilia Mirkin : > "In progress" would seem to imply someone is working on it, which, AFAIK, is > not the case. > > On Mar 14, 2016 7:35 PM, "Romain Failliot" > wrote: >> >> This fi

[Mesa-dev] ARB_enhanced_layouts tranform feedback layouts

This series adds support for the xfb_* layout qualifiers and API support for querying them. It applies on top of my component packing series https://patchwork.freedesktop.org/series/3897/ but can likely be rebased without it if this get reviewed first. Most piglit test have been pushed to master.

[Mesa-dev] [PATCH 01/37] glsl: Fix segfault when lhs is error_type TCS

It seem expected that both lhs and rhs could be of type error_type in this code however the TCS wasn't expecting it. Fixes segfault in an enhanced layouts GL CTS test. --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to

[Mesa-dev] [PATCH 03/37] glsl: add transform feedback built-in constants

These are new built-ins added by ARB_enhanced_layouts. --- src/compiler/glsl/builtin_variables.cpp | 7 +++ src/compiler/glsl/glsl_parser_extras.cpp | 4 src/compiler/glsl/glsl_parser_extras.h | 4 3 files changed, 15 insertions(+) diff --git a/src/compiler/glsl/builtin_variables

[Mesa-dev] [PATCH 06/37] glsl: relax stage restrictions on layout defaults for outputs

The new xfb_buffer and xfb_stride global qualifiers are allowed in geom, tess and vertex stages. --- src/compiler/glsl/ast_type.cpp | 5 +++-- src/compiler/glsl/glsl_parser_extras.cpp | 9 - 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/ast_type

[Mesa-dev] [PATCH 08/37] glsl: add IR fields for transform feedback layout qualifiers

Adds xfb_buffer/stride fields and adds comment to offset field which is reused for xfb_offset. --- src/compiler/glsl/ir.h | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h index 930a6de..0c319ea 100644 --

[Mesa-dev] [PATCH 04/37] glsl: move process_qualifier_constant() to ast_type.cpp

We will make use of this function being here in the following patch. --- src/compiler/glsl/ast.h | 6 ++ src/compiler/glsl/ast_to_hir.cpp | 41 src/compiler/glsl/ast_type.cpp | 41 3 files changed, 47

[Mesa-dev] [PATCH 09/37] glsl: add xfb_* qualifiers to glsl_struct_field

These will be used to hold qualifier values for interface and struct members. Support is added to the struct/interface constructors to copy these fields upon creation. We also update record_compare() to ensure we don't reuse a glsl_type with the wrong xfb_* qualifier values. --- src/compiler/gls

[Mesa-dev] [PATCH 05/37] glsl: parse new transform feedback layout qualifiers

We reuse the existing offset field for holding the xfb_offset expression but create a new flag as to avoid hitting the rules for the offset qualifier for UBOs. xfb_buffer qualifiers require extra processing when merging as they can be applied to global out defaults. We just apply the same rules as

[Mesa-dev] [PATCH 02/37] glsl: generate named interface block names correctly

Firstly this updates the named interface lowing pass to store the interface without the arrays removed. Note we need to remove the arrays in the interface/varying matching code to not regress things but in future this should be fixed futher as it would seem we currently successfully match interfac

[Mesa-dev] [PATCH 07/37] glsl: add validation for out layout qualifiers

This adds validation for all qualifiers as allowed by the table in Section 4.4 (Layout Qualifiers) of the GLSL 4.5 spec. --- src/compiler/glsl/ast_type.cpp | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/co

[Mesa-dev] [PATCH 11/37] glsl: add xfb_buffer compile time rules

Also copies the qualifier values to GLSL IR. From the ARB_enhanced_layouts spec: "The *xfb_buffer* qualifier can be applied to the qualifier out, to output variables, to output blocks, and to output block members. Shaders in the transform feedback capturing mode have an initial

[Mesa-dev] [PATCH 17/37] glsl: add helper for counting varyings

This will be used to get a count of the number of varying name strings we are required to generate for use with the query api. --- src/compiler/glsl_types.cpp | 32 src/compiler/glsl_types.h | 6 ++ 2 files changed, 38 insertions(+) diff --git a/src/compile

[Mesa-dev] [PATCH 22/37] glsl: sort xfb varyings in offset/buffer order

The existing transform feedback code expects to receive the list of varyings in increasing buffer order. --- src/compiler/glsl/link_varyings.cpp | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index

[Mesa-dev] [PATCH 21/37] glsl: basic linking support for xfb qualifiers

This adds the initial infrastructure for enabling transform feedback mode via in shader qualifiers and adds initial buffer support. --- src/compiler/glsl/link_varyings.cpp | 22 - src/compiler/glsl/link_varyings.h | 5 +++-- src/compiler/glsl/linker.cpp| 38 +

[Mesa-dev] [PATCH 14/37] glsl: apply xfb_stride to implicit offsets for ifc block members

When we have an interface block like: layout (xfb_buffer = 0, xfb_offset = 0) out Block { vec4 var1; layout (xfb_stride = 32) vec4 var2; vec4 var3; }; We take into account the stride of var2 when calculating the offset for var3. --- s

[Mesa-dev] [PATCH 23/37] glsl: use bitmask of active xfb buffer indices

This allows us to print the correct binding point when not all buffers declared in the shader are bound. For example if we use a single buffer: layout(xfb_buffer=2, offset=0) out vec4 v; We now print '2' when the buffer is not bound rather than '0'. --- src/compiler/glsl/link_varyings.cpp | 11

[Mesa-dev] [PATCH 19/37] glsl: add helper to process xfb qualifiers during linking

This function checks for any xfb_* qualifiers which will enable transform feedback mode and cause any API defined xfb varyings to be ignored. It also counts the number of varyings that have an xfb_offset qualifier and finally it calls the create_xfb_varying_names() helper to generate the names of

[Mesa-dev] [PATCH 32/37] mesa: rename tranform feeback varying macro XFB to XFV

A latter patch will use XFB for buffers. --- src/mesa/main/shader_query.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index f63ffd8..f2d4332 100644 --- a/src/mesa/main/shader_query.cpp +++ b/src/

[Mesa-dev] [PATCH 27/37] glsl: generate link error when implicit stride is to large

This moves the check until after we have done the stride calculation and applies it to the xfb_* qualifiers. --- src/compiler/glsl/link_varyings.cpp | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/sr

[Mesa-dev] [PATCH 34/37] mesa: add support to query GL_TRANSFORM_FEEDBACK_BUFFER_INDEX

--- src/compiler/glsl/link_varyings.cpp | 15 +-- src/compiler/glsl/link_varyings.h | 4 ++-- src/mesa/main/mtypes.h | 1 + src/mesa/main/shader_query.cpp | 6 ++ 4 files changed, 18 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/link_varyings.

[Mesa-dev] [PATCH 31/37] glsl: always enable transform feedback mode when xfb_stride defined

This enables in shader defined transform feedback mode even if the only place xfb_stride is defined is on the global out. We don't worry about xfb_buffer since Issue 22 c) in the spec says: "If the shader has an "xfb_buffer" qualifier identifying a buffer, but doesn't declare "xfb_offset"

[Mesa-dev] [PATCH 20/37] glsl: add xfb helpers and fields to the tfeedback_decl class

We also apply any array/struct offsets. --- src/compiler/glsl/link_varyings.cpp | 12 ++-- src/compiler/glsl/link_varyings.h | 20 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.c

[Mesa-dev] [PATCH 37/37] docs: mark xfb_* qualifiers as DONE

--- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 3d52084..a52be9d 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -183,7 +183,7 @@ GL 4.4, GLSL 4.40: - explicit byte offsets for blocks DONE - forced align

[Mesa-dev] [PATCH 15/37] glsl: add xfb qualifiers to has_layout helper

--- src/compiler/glsl/ast_type.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp index 611f048..593d8a9 100644 --- a/src/compiler/glsl/ast_type.cpp +++ b/src/compiler/glsl/ast_type.cpp @@ -80,7 +80,10 @@ ast_

[Mesa-dev] [PATCH 12/37] glsl: add xfb_offset compile time rules

We also copy the qualifier values to the IR in this step. --- src/compiler/glsl/ast_to_hir.cpp | 125 ++- 1 file changed, 123 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 118e921..8a13369 1

[Mesa-dev] [PATCH 13/37] glsl: add xfb_stride compile time rules

From the ARB_enhanced_layouts spec: "The *xfb_stride* qualifier specifies how many bytes are consumed by each captured vertex. It applies to the transform feedback buffer for that declaration, whether it is inherited or explicitly declared. It can be applied to variables, blocks, bloc

[Mesa-dev] [PATCH 16/37] glsl: add xfb qualifier lowering support for named blocks

--- src/compiler/glsl/lower_named_interface_blocks.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compiler/glsl/lower_named_interface_blocks.cpp b/src/compiler/glsl/lower_named_interface_blocks.cpp index 434cea9..2c36199 100644 --- a/src/compiler/glsl/lower_named_interface_blo

[Mesa-dev] [PATCH 24/37] mesa: split transform feedback buffer into its own struct

This will be used in a following patch to implement interface query support for TRANSFORM_FEEDBACK_BUFFER. --- src/compiler/glsl/link_varyings.cpp| 11 ++- src/mesa/drivers/dri/i965/gen6_sol.c | 4 ++-- src/mesa/drivers/dri/i965/gen7_sol_state.c | 2 +- src/mesa/drivers/dri

[Mesa-dev] [PATCH 10/37] glsl: add field to track if xfb_buffer is an explicit or implicit value

Since any of the xfb_* qualifiers trigger the shader to be in transform feedback mode we need an extra field to track if the xfb_buffer on interface members was set explicitly since xfb_buffer will always have a default value. --- src/compiler/glsl/ast_to_hir.cpp| 2 ++ src/compiler/glsl/b

[Mesa-dev] [PATCH 28/37] glsl: reset current stream tracker

When we move to the next buffer we need to reset the stream so that we don't generate an error message about streams not matching. --- src/compiler/glsl/link_varyings.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varying

[Mesa-dev] [PATCH 26/37] glsl: add xfb_stride link time validation

From the ARB_enhanced_layous spec: "It is a compile-time or link-time error to have any *xfb_offset* that overflows *xfb_stride*, whether stated on declarations before or after the *xfb_stride*, or in different compilation units. ... When no *xfb_stride* is specified for a buf

[Mesa-dev] [PATCH 29/37] glsl: when lowering named interface set assigned flag

This will be used when checking if xfb should attempt to capture a varying. --- src/compiler/glsl/lower_named_interface_blocks.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/compiler/glsl/lower_named_interface_blocks.cpp b/src/compiler/glsl/lower_named_interface_blocks.c

[Mesa-dev] [PATCH 25/37] glsl: validate global out xfb_stride qualifiers and set stride on empty buffers

Here we use the built-in validation in ast_layout_expression::process_qualifier_constant() to check for mismatching global out strides on buffers in a single shader. From the ARB_enhanced_layouts spec: "While *xfb_stride* can be declared multiple times for the same buffer, it is a compile-t

[Mesa-dev] [PATCH 18/37] glsl: add helper to generate xfb varying names

--- src/compiler/glsl/link_varyings.cpp | 43 + 1 file changed, 43 insertions(+) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 1044cba..fbf7626 100644 --- a/src/compiler/glsl/link_varyings.cpp +++ b/src/compiler/g

[Mesa-dev] [PATCH 30/37] glsl: handle varyings that are not written to but have an xfb_offset

--- src/compiler/glsl/link_varyings.cpp | 34 -- src/compiler/glsl/link_varyings.h | 13 + 2 files changed, 37 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index ac14815..c3f6c3

[Mesa-dev] [PATCH 33/37] mesa: add support to query GL_OFFSET for GL_TRANSFORM_FEEDBACK_VARYING

--- src/compiler/glsl/link_varyings.cpp | 1 + src/mesa/main/mtypes.h | 1 + src/mesa/main/shader_query.cpp | 14 +++--- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index a97d

[Mesa-dev] [PATCH 36/37] mesa: add query support for GL_TRANSFORM_FEEDBACK_BUFFER interface

--- src/compiler/glsl/link_varyings.cpp | 1 + src/mesa/main/mtypes.h | 2 ++ src/mesa/main/program_resource.c| 16 +++- src/mesa/main/shader_query.cpp | 35 ++- 4 files changed, 52 insertions(+), 2 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 35/37] glsl: add transform feedback buffers to resource list

--- src/compiler/glsl/linker.cpp | 14 +- src/compiler/glsl/program.h| 3 ++- src/mesa/drivers/dri/i965/brw_link.cpp | 2 +- src/mesa/program/ir_to_mesa.cpp| 2 +- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 5 files changed, 18 i

[Mesa-dev] [PATCH v2] st/mesa: honour sized internal formats in st_choose_format (v2)

From: Nicolai Hähnle The bitcasting which is possible with shader images (and texture views?) requires that when the user specifies a sized internal format for a texture, we really allocate that format. To this end: (1) find_exact_format should ignore sized internal formats and (2) some of the

Re: [Mesa-dev] [PATCH 06/14] nir: handle different bit sizes when constant folding

On Tue, Mar 15, 2016 at 5:53 AM, Iago Toral wrote: > On Mon, 2016-03-14 at 16:48 -0700, Jason Ekstrand wrote: >> >> >> On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez >> wrote: >> From: Connor Abbott >> >> v2: Use the bit-size information from the opcode information >>

Re: [Mesa-dev] [PATCH 06/14] nir: handle different bit sizes when constant folding

On Tue, Mar 15, 2016 at 10:43 AM, Connor Abbott wrote: > On Tue, Mar 15, 2016 at 5:53 AM, Iago Toral wrote: >> On Mon, 2016-03-14 at 16:48 -0700, Jason Ekstrand wrote: >>> >>> >>> On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez >>> wrote: >>> From: Connor Abbott >>> >>>

Re: [Mesa-dev] [PATCH v2] st/mesa: honour sized internal formats in st_choose_format (v2)

On Mar 15, 2016 7:23 AM, "Nicolai Hähnle" wrote: > > From: Nicolai Hähnle > > The bitcasting which is possible with shader images (and texture views?) > requires that when the user specifies a sized internal format for a > texture, we really allocate that format. To this end: > > (1) find_exact_f

Re: [Mesa-dev] [PATCH 06/14] nir: handle different bit sizes when constant folding

On Mar 15, 2016 7:48 AM, "Connor Abbott" wrote: > > On Tue, Mar 15, 2016 at 10:43 AM, Connor Abbott wrote: > > On Tue, Mar 15, 2016 at 5:53 AM, Iago Toral wrote: > >> On Mon, 2016-03-14 at 16:48 -0700, Jason Ekstrand wrote: > >>> > >>> > >>> On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsá

Re: [Mesa-dev] [PATCH v2] st/mesa: honour sized internal formats in st_choose_format (v2)

On Tue, Mar 15, 2016 at 3:53 PM, Ilia Mirkin wrote: > > On Mar 15, 2016 7:23 AM, "Nicolai Hähnle" wrote: >> >> From: Nicolai Hähnle >> >> The bitcasting which is possible with shader images (and texture views?) >> requires that when the user specifies a sized internal format for a >> texture, we

Re: [Mesa-dev] About the usage of the "flat" interpolation qualifier with input (unsigned) integers and doubles in fragment shaders

Hi, I haven't had any input on this and I will welcome opinions from more knowledgeable developers :) Do you think my approach in this case would be the best? * To enforce the usage of the "flat" qualifier when in a member of an input block interface in a fragment shader for (unsign

Re: [Mesa-dev] [PATCH] draw: fix line stippling

Am 15.03.2016 um 08:20 schrieb Jose Fonseca: > On 13/03/16 20:40, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The logic was comparing actual ints, not true/false values. >> This meant that it was emitting always multiple line segments instead >> of just >> one even if the stipple t

[Mesa-dev] About border values in fp64 conversion tests

Hi, as complementary work to the one done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. One of the topics we have been creating tests for is

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #9 from Roland Scheidegger --- (In reply to comicfans44 from comment #8) > (In reply to Roland Scheidegger from comment #4) > > So, it crashed in the jit fragment shader code. > > Could you tell what the fb size was (the values from s

Re: [Mesa-dev] About border values in fp64 conversion tests

Not really an answer to your question, but you may be interested in this model of the NVIDIA Tesla FPU that mwk RE'd, including fp64 (which was available on the G200 only in that series). I have no reason to believe that Fermi+ are substantially different: https://github.com/envytools/envytools/bl

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #10 from Roland Scheidegger --- Actually the asm snipped might be something different. You could try printing the whole jit prog (from the address from the caller, or use GALLIVM_DEBUG=asm). Using valgrind could possibly tell you some

Re: [Mesa-dev] [PATCH] mesa: Fix error condition for 1d array texture

On Sat, Mar 12, 2016 at 3:08 PM, Jason Ekstrand wrote: > > On Mar 11, 2016 12:33 PM, "Alejandro Piñeiro" > wrote: > > > > On 11/03/16 20:15, Anuj Phogat wrote: > > > yoffset is also applicable to 1d array textures. > > > > > > Signed-off-by: Anuj Phogat > > > --- > > > I don't know if it fixes

Re: [Mesa-dev] [PATCH 13/14] nir: propagate bitsize information in nir_search

On Tue, Mar 15, 2016 at 12:41 AM, Iago Toral wrote: > On Mon, 2016-03-14 at 17:33 -0700, Jason Ekstrand wrote: > > > > > > On Mon, Mar 7, 2016 at 12:46 AM, Samuel Iglesias Gonsálvez > > wrote: > > From: Connor Abbott > > > > When we replace an expresion we have to compute bitsiz

[Mesa-dev] [PATCH 05/20] gallium/radeon: make r600_texture_disable_dcc externally accessible

From: Nicolai Hähnle We will need it in radeonsi for shader images. --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 ++ src/gallium/drivers/radeon/r600_texture.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.h b/sr

[Mesa-dev] [PATCH 09/20] radeonsi: Lower TGSI_OPCODE_RESQ down to LLVM op

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 129 +++ 1 file changed, 129 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index a4352f1..373d4b4 100644 --- a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 00/20] radeonsi: ARB_shader_image_load_store support

Hi, finally: ARB_shader_image_load_store (and ARB_shader_image_size) for radeonsi! You can also find this series at https://cgit.freedesktop.org/~nh/mesa/log/?h=images-radeonsi You will need bleeding edge LLVM for this to work correctly, and not all required LLVM changes have been pushed upstream

[Mesa-dev] [PATCH 11/20] radeonsi: Lower TGSI_OPCODE_LOAD down to LLVM op

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 141 +++ 1 file changed, 141 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index b655e34..e2ae39e 100644 --- a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 07/20] radeonsi: decompress shader images

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_blit.c | 36 +++--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index f9a6de4..e0dbec5 100644 --- a/src/gallium

[Mesa-dev] [PATCH 13/20] radeonsi: Lower TGSI_OPCODE_ATOM* down to LLVM op

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 121 +-- 1 file changed, 113 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 374afac..deeda30 100644 --- a/src/ga

[Mesa-dev] [PATCH 15/20] radeonsi: implement coherent memory access

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index fcbab5f..22296fe 100644 --- a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 10/20] radeonsi: extract the LLVM type name construction into its own function

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 373d4b4..b655e34 100644 --- a/src/gallium/d

[Mesa-dev] [PATCH 20/20] docs: mark GL_ARB_shader_image_load_store/_size as done for radeonsi

From: Nicolai Hähnle --- docs/GL3.txt | 4 ++-- docs/relnotes/11.3.0.html | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index ee7faca..08ca8db 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -139,7 +139,7 @@ GL 4.2, GLSL 4.20:

[Mesa-dev] [PATCH 01/20] gallium: add additional PIPE_BARRIER_* bits

From: Nicolai Hähnle --- src/gallium/include/pipe/p_defines.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index bdd76ab..90af7a7 100644 --- a/src/gallium/include/pipe/p_defines.h +++ b/src/gallium/include

[Mesa-dev] [PATCH 18/20] radeonsi: force the DCC enable bit off in image descriptors for writing

From: Nicolai Hähnle This avoids a lockup at least on Tonga. --- src/gallium/drivers/radeonsi/si_shader.c | 53 +++- 1 file changed, 45 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c ind

[Mesa-dev] [PATCH 04/20] tgsi/scan: track which shader images are really buffers

From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 3 +++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 4 2 files changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index dee6884..65bdab5 100644 --- a/src/galliu

[Mesa-dev] [PATCH 17/20] radeonsi: implement MemoryBarrier

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_state.c | 36 + 1 file changed, 36 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 0c3fbdc..6dcd532 100644 --- a/src/gallium/drivers/radeo

[Mesa-dev] [PATCH 02/20] st/mesa: translate additional flags in MemoryBarrier

From: Nicolai Hähnle Re-order flags in the order in which they appear in the OpenGL spec in the description of MemoryBarrier(). --- src/mesa/state_tracker/st_cb_texturebarrier.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_c

[Mesa-dev] [PATCH 14/20] radeonsi: Lower TGSI_OPCODE_MEMBAR down to LLVM op

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index deeda30..fcbab5f 100644 --- a/src/gallium/drivers/rade

[Mesa-dev] [PATCH 12/20] radeonsi: Lower TGSI_OPCODE_STORE down to LLVM op

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 83 ++-- 1 file changed, 80 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index e2ae39e..374afac 100644 --- a/src/gal

[Mesa-dev] [PATCH 19/20] radeonsi: Set PIPE_SHADER_CAP_MAX_SHADER_IMAGES

From: Edward O'Callaghan This enables ARB_shader_image_load_store and ARB_shader_image_size. Signed-off-by: Edward O'Callaghan [allow the same number of images for all shader stages and require LLVM 3.9] --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 del

[Mesa-dev] [PATCH 03/20] tgsi/scan: add images_writemask

From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 18 -- src/gallium/auxiliary/tgsi/tgsi_scan.h | 5 + 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 8e24c

[Mesa-dev] [PATCH 08/20] radeonsi: extract TXQ buffer size computation into its own function

From: Nicolai Hähnle This will allow it to be reused for RESQ. --- src/gallium/drivers/radeonsi/si_shader.c | 55 1 file changed, 35 insertions(+), 20 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 16/20] radeonsi: implement volatile memory access

From: Nicolai Hähnle Prevent loads from being re-ordered or coalesced. Atomics don't need special handling by definition, and stores don't need special handling because LLVM is unable to detect dead image or buffer stores. --- src/gallium/drivers/radeonsi/si_shader.c | 4 1 file changed, 4

[Mesa-dev] [PATCH 06/20] radeonsi: implement set_shader_images

From: Nicolai Hähnle Whether DCC is disabled depends on the access flags with which the image is bound: image_load supports DCC, but store and atomic don't. --- src/gallium/drivers/radeonsi/si_descriptors.c | 206 -- src/gallium/drivers/radeonsi/si_pipe.h| 7 +

[Mesa-dev] [PATCH] mesa: Ignore glPointSize when GL_POINT_SIZE_ARRAY_OES is enabled

When a user defines a point size array and enables it, the point size value set via glPointSize should be ignored. To achieve this, we can simply omit point size when creating a batch inside upload_sf_state for brw, gen6, gen7 and gen8. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42187

Re: [Mesa-dev] [PATCH 04/20] tgsi/scan: track which shader images are really buffers

Patches 1-4 are Reviewed-by: Ilia Mirkin On Tue, Mar 15, 2016 at 2:28 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/auxiliary/tgsi/tgsi_scan.c | 3 +++ > src/gallium/auxiliary/tgsi/tgsi_scan.h | 4 > 2 files changed, 7 insertions(+) > > diff --git a/src/gallium/a

[Mesa-dev] [Bug 94481] softpipe - access violation in img_filter_2d_nearest

https://bugs.freedesktop.org/show_bug.cgi?id=94481 Roland Scheidegger changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 94193] [llvmpipe] Line antialiasing looks different when GL_LINE_STIPPLE is enabled with pattern 0xffff

https://bugs.freedesktop.org/show_bug.cgi?id=94193 Roland Scheidegger changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 94522] llvmpipe crash in rendering on Atom

https://bugs.freedesktop.org/show_bug.cgi?id=94522 --- Comment #11 from Roland Scheidegger --- FWIW the bug Stephane mentioned (which you'd hit near certainly too, unless you built without sse2 enabled, and the compositor itself might not hit it) is fixed by bb2c5e657b5f4c55bcec49a8d96f352ed4c1e0

[Mesa-dev] [PATCH] meta: Use ARB_explicit_attrib_location in the rest of the meta shaders.

This is cleaner than using glBindAttribLocation(). Not all drivers support the extension, but I don't think those drivers use GLSL in the first place. Apparently some Meta shaders already use GL_ARB_explicit_attrib_location, so I think it should be okay. Honestly, I'm not sure how the old code w

[Mesa-dev] [PATCH] i965: Account for TES in is_drawing_points().

Now that we implement tessellation shaders, the TES might be the last stage enabled. If it's outputting points, then the primitive type reaching the SF is points. We need to account for this. Caught by Ilia Mirkin. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen6_sf_state.c |

Re: [Mesa-dev] [PATCH 05/10] i965/vec4: Mark TCS_OPCODE_SRC0_010_IS_ZERO as writing the flag.

On Mon, Mar 14, 2016 at 9:32 PM, Kenneth Graunke wrote: > On Monday, March 14, 2016 5:25:58 PM PDT Matt Turner wrote: >> On Mon, Mar 14, 2016 at 5:22 PM, Matt Turner wrote: >> > On Mon, Mar 14, 2016 at 5:10 PM, Francisco Jerez > wrote: >> >> Matt Turner writes: >> >> >> >>> Missing this causes

Re: [Mesa-dev] [PATCH] meta: Use ARB_explicit_attrib_location in the rest of the meta shaders.

Indeed, none of nouveau_vieux, radeon, or r200 support GLSL. Of course, no classic driver except i965 supports #version 130, so those are clear. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.

Re: [Mesa-dev] [PATCH 3/4] docs: Renormalize some extensions.

Thanks for taking the time to clean up the patches! On 15.03.2016 07:45, Romain Failliot wrote: Hmm... I thought that was what it meant. I can add a new status like "paused" for instance. "not started" is probably more accurate. AFAIU, ARB_robustness is implemented, and that represents 90% of

[Mesa-dev] [PATCH 0/7] nv50: rework compute/3d validation path

From: Samuel Pitoiset Hi, This is loosely based on what I did for nvc0 few weeks ago. I have not tested this series because I don't have access to a Tesla card, but this should not break anything. By the way, doing almost the same series twice is not so cool but... refactoring nv50 and nvc0 driv

[Mesa-dev] [PATCH 1/7] nv50: rename nv50_context::dirty to nv50_context::dirty_3d

From: Samuel Pitoiset Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_compute.c| 2 +- src/gallium/drivers/nouveau/nv50/nv50_context.c| 10 +++--- src/gallium/drivers/nouveau/nv50/nv50_context.h| 2 +- .../drivers/nouveau/nv50/nv50_shader_state.c | 1

[Mesa-dev] [PATCH 6/7] nv50: rework nv50_compute_validate_program()

From: Samuel Pitoiset Reduce the amount of duplicated code by re-using nv50_program_validate(). While we are at it, change the prototype to return void. We don't check anymore if the translation fails but improving the state validation is a long process. Signed-off-by: Samuel Pitoiset --- src/

[Mesa-dev] [PATCH 5/7] nv50: rework the validation path for 3D

From: Samuel Pitoiset This exposes an interface for state validation that will be also used to rework the compute validation path. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_context.h| 10 +- .../drivers/nouveau/nv50/nv50_state_validate.c | 36

  1   2   >