[Mesa-dev] [PATCH] freedreno/a2xx: silence missing case 'SHADER_COMPUTE' warning (v2)

2016-07-21 Thread Francesco Ansanelli
v2: no need for break after an unreachable (Matt Turner) Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c b/src/gallium/drivers/freedreno/a2xx/disasm-a

[Mesa-dev] Possible typo in commit 5ec140c1 - mapi: Massage code to allow clang to compile.

2016-07-21 Thread Alexandre Demers
Hi Matt, I saw your commit 5ec140c1 pass by and I think there is a typo in it. You use "HAVE_FUNC_ATTRIBUTE_VISIBIITY" thrice in the patch and I suspect there is a missing "L" to form "HAVE_FUNC_ATTRIBUTE_VISIBILITY" instead. Cheers -- Alexandre Demers _

Re: [Mesa-dev] [PATCH 2/2] i965: Fix shared atomic intrinsics to pay attention to base.

2016-07-21 Thread Jason Ekstrand
On Jul 18, 2016 3:49 PM, "Kenneth Graunke" wrote: > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 2/2] i965: Fix shared atomic intrinsics to pay attention to base.

2016-07-21 Thread Kenneth Graunke
On Tuesday, July 19, 2016 10:23:03 AM PDT Timothy Arceri wrote: > On Mon, 2016-07-18 at 15:49 -0700, Kenneth Graunke wrote: > So this fixes a bug with indirects right? Is there a piglit test for > this? Not exactly. Right now, GLSL lowers shared variable access at the GLSL IR level, and when we t

Re: [Mesa-dev] [PATCH 00/16] Various Vulkan/SPIR-V fixes (mostly SPIR-V)

2016-07-21 Thread Jason Ekstrand
Please ignore the N/9 patches. They've already been merged but somehow got sent by git-send-email. On Thu, Jul 21, 2016 at 9:21 PM, Jason Ekstrand wrote: > I pulled the latest version of the Vulkan CTS and gave it a run. One of > the major aditions was a pile of tests for different texturing o

[Mesa-dev] [PATCH 02/16] spirv/nir: Add support for shadow samplers that return vec4

2016-07-21 Thread Jason Ekstrand
While SPIR-V technically doesn't support "old style" shadow, the shadow-compare gather instruction does return a vec4 so we need to be able to set the old_style_shadow bit in NIR. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 3 ++- 1 file changed, 2 insertion

[Mesa-dev] [PATCH 15/16] spirv/nir: Handle texture projectors

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 6ebf951..20ff472 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/s

[Mesa-dev] [PATCH 16/16] spirv/nir: Add support for ImageQuerySamples

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 20ff472..4d74e88 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/sp

[Mesa-dev] [PATCH 7/9] anv/pipeline: Silently pass tests if depth or stencil is missing

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Ian Romanick --- src/intel/vulkan/gen7_pipeline.c | 12 ++-- src/intel/vulkan/gen8_pipeline.c | 12 ++-- src/intel/vulkan/genX_pipeline_util.h | 30 +- 3 files changed, 49 insertions(+), 5 deletio

[Mesa-dev] [PATCH 12/16] spirv/nir/: Move opcode selection higher up in handle_texture

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 96 +++ 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 6654f5f..a0aeadf 100644 --- a/

[Mesa-dev] [PATCH 3/9] anv/pipeline: Refactor specialization constant handling a bit

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Jordan Justen --- src/intel/vulkan/anv_pipeline.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 789bc1a..372feeb 100644 --- a/src/intel/vulkan/anv_

[Mesa-dev] [PATCH 5/9] genxml/gen6,7,75: s/BackFace/Backface

2016-07-21 Thread Jason Ekstrand
This is more consistent with gen8+ Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Jordan Justen --- src/intel/genxml/gen6.xml | 4 ++-- src/intel/genxml/gen7.xml | 4 ++-- src/intel/genxml/gen75.xml | 4 ++-- src/intel/vulkan/gen7_cmd_buffer.c | 2 +- src/intel/vulkan/g

[Mesa-dev] [PATCH 09/16] i965: Get rid of the do_lower_unnormalized_offsets pass

2016-07-21 Thread Jason Ekstrand
We can do this in NIR now. No need to keep a GLSL pass lying around for it. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_context.h| 1 - src/mesa/drivers/dri/i965/brw_link.cpp |

[Mesa-dev] [PATCH 6/9] anv/pipeline: Unify gen7/8 emit_ds_state

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Jordan Justen --- src/intel/vulkan/gen7_pipeline.c | 37 +- src/intel/vulkan/gen8_pipeline.c | 49 - src/intel/vulkan/genX_pipeline_util.h | 59 +++ 3 files cha

[Mesa-dev] [PATCH 4/9] anv/pipeline: Add support for early depth stencil

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Jordan Justen --- src/intel/vulkan/gen7_pipeline.c | 8 +++- src/intel/vulkan/gen8_pipeline.c | 7 ++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 2

[Mesa-dev] [PATCH 08/16] i965/nir: Enable NIR lowering of txf and rect offsets

2016-07-21 Thread Jason Ekstrand
This fixes the following piglit tests on gen6+: tex-miplevel-selection textureProjGradOffset 2DRect tex-miplevel-selection textureGradOffset 2DRect tex-miplevel-selection textureGradOffset 2DRectShadow tex-miplevel-selection textureProjGradOffset 2DRect_ProjVec4 tex-miplevel-selection textureProjG

[Mesa-dev] [PATCH 03/16] spirv/nir: Properly handle gather components

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index c32dfaa..b1bb48b 100644 --- a/src/compiler/spirv/spirv_to_n

[Mesa-dev] [PATCH 14/16] nir/spirv: Refactor coordinate handling in handle_texture

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 57 +++ 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 284a2c8..6ebf951 100644 --- a/

[Mesa-dev] [PATCH 04/16] anv/pipeline: Set binding_table.gather_texture_start

2016-07-21 Thread Jason Ekstrand
This should get texture gather working on gen8+ and mostly working on gen7. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/intel/vulkan/anv_pipeline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 3723423..57e1bdd 1

[Mesa-dev] [PATCH 11/16] anv/image: Assert that the image format is actually supported

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/intel/vulkan/anv_image.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index e467e87..dff51bc 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan

[Mesa-dev] [PATCH 2/9] nir/lower_indirect_derefs: Use the direct array deref for recursion

2016-07-21 Thread Jason Ekstrand
This fixes about 100 of the new Vulkan CTS tests. Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Connor Abbott Cc: Ian Romanick Cc: Kenneth Graunke --- src/compiler/nir/nir_lower_indirect_derefs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_in

[Mesa-dev] [PATCH 06/16] nir/lower_tex: Add some helpers for working with tex sources

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/nir/nir_lower_tex.c | 46 ++-- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/src/compiler/nir/nir_lower_tex.c b/src/compiler/nir/nir_lower_tex.c index 195cb1d..0cf1071 100644 --- a/src

[Mesa-dev] [PATCH 10/16] spirv/nir: Don't increment coord_components for array lod queries

2016-07-21 Thread Jason Ekstrand
For lod query instructions, we really don't care whether or not the sampler is an array type because that doesn't factor into the LOD. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/

[Mesa-dev] [PATCH 13/16] spirv/nir: Refactor type handling in handle_texture

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index a0aeadf..284a2c8 100644 --- a/src/compiler/spirv/spirv_to_

[Mesa-dev] [PATCH 9/9] nir/spirv: Handle the WorkgroupSize builtin decoration

2016-07-21 Thread Jason Ekstrand
This fixes the 7 dEQP-VK.pipeline.spec_constant.compute.local_size.* tests in the latest dev version of the Vulkan CTS. Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Ian Romanick --- src/compiler/spirv/spirv_to_nir.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/sr

[Mesa-dev] [PATCH 07/16] nir/lower_tex: Add support for lowering coordinate offsets

2016-07-21 Thread Jason Ekstrand
On i965, we can't support coordinate offsets for texelFetch or rectangle textures. Previously, we were doing this with a GLSL pass but we need to do it in NIR if we want those workarounds for SPIR-V. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/nir/nir.h | 10 s

[Mesa-dev] [PATCH 8/9] nir/spirv: Use breaks instead of returns in constant handling

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Ian Romanick --- src/compiler/spirv/spirv_to_nir.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 4061b8a..bb7aba4 100644 --- a/src/compiler/spir

[Mesa-dev] [PATCH 05/16] nir: Add a helper for determining the type of a texture source

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/nir/nir.h | 44 1 file changed, 44 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 2873c15..d0f52b0 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/

[Mesa-dev] [PATCH 01/16] spirv/nir: Fix some texture opcode asserts

2016-07-21 Thread Jason Ekstrand
We can't get an lod with txf_ms and SPIR-V considers textureGrad to be an explicit-LOD texturing instruction. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c

[Mesa-dev] [PATCH 1/9] anv/clear: Handle ClearImage on 3-D images

2016-07-21 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Nanley Chery --- src/intel/vulkan/anv_meta_clear.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_meta_clear.c b/src/intel/vulkan/anv_meta_clear.c index 18dfae8..fe750c8 100644 --- a/src/intel/vulkan/a

[Mesa-dev] [PATCH 00/16] Various Vulkan/SPIR-V fixes (mostly SPIR-V)

2016-07-21 Thread Jason Ekstrand
I pulled the latest version of the Vulkan CTS and gave it a run. One of the major aditions was a pile of tests for different texturing operations. This demonstrated that our texturing support was, well, sub-par. These patches get it most of the way fixed up. As a nice side-benifit, it also fixes

Re: [Mesa-dev] [PATCH] egl/dri2: Add reference count for dri2_egl_display

2016-07-21 Thread Nicolas Boichat
On Thu, Jul 21, 2016 at 10:51 PM, Emil Velikov wrote: > On 21 July 2016 at 01:44, Nicolas Boichat wrote: >> On Wed, Jul 20, 2016 at 11:52 PM, Emil Velikov >> wrote: >>> On 20 July 2016 at 15:42, Emil Velikov wrote: On 20 July 2016 at 09:26, Nicolas Boichat wrote: > android.opengl.cts

[Mesa-dev] [PATCH v2] egl/dri2: Add reference count for dri2_egl_display

2016-07-21 Thread Nicolas Boichat
android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls eglTerminate, followed by eglReleaseThread. A similar case is observed in this bug: https://bugs.freedesktop.org/show_bug.cgi?id=69622, where the test calls eglTerminate, then eglMakeCurrent(dpy, NULL, NULL, NULL). With the current cod

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Add GL_BGRA_EXT to the list of GenerateMipmap internal formats.

2016-07-21 Thread Ian Romanick
On 07/21/2016 05:44 PM, Kenneth Graunke wrote: > The GL_EXT_texture_format_BGRA extension specification defines a > GL_BGRA_EXT unsized internal format (which is a little odd - usually > BGRA is a pixel transfer format). The extension is written against > the ES 1.0 specification, so it's a li

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-21 Thread Rob Clark
On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: > On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: >> LLVM and Mesa both define the DEBUG macro in incompatible ways. As a >> general practice, we should avoid using such generic names when it is >> possible to do so. >> >> This patch rename

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-21 Thread Rob Clark
On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: > LLVM and Mesa both define the DEBUG macro in incompatible ways. As a > general practice, we should avoid using such generic names when it is > possible to do so. > > This patch renames all occurrences of the DEBUG macro to MESA_DEBUG, > and

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

2016-07-21 Thread Rob Clark
On Thu, Jul 21, 2016 at 6:07 PM, Stéphane Marchesin wrote: > On Tue, Jul 19, 2016 at 6:36 AM, Rob Clark wrote: >> On Tue, Jul 19, 2016 at 6:54 AM, Emil Velikov >> wrote: >>> On 19 July 2016 at 04:21, Tomasz Figa wrote: On Tue, Jul 19, 2016 at 2:35 AM, Emil Velikov wrote: > On 1

[Mesa-dev] [PATCH] mesa: Add GL_BGRA_EXT to the list of GenerateMipmap internal formats.

2016-07-21 Thread Kenneth Graunke
The GL_EXT_texture_format_BGRA extension specification defines a GL_BGRA_EXT unsized internal format (which is a little odd - usually BGRA is a pixel transfer format). The extension is written against the ES 1.0 specification, so it's a little hard to map, but I believe it's effectively adding

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

2016-07-21 Thread Zhang, Boyuan
Hi Andy, I just submitted another patch set. 1. Fixed previously reported regression when using ffmpeg to encode. 2. Fixed I420 "width=720,height=480" garbage output issue. Please give a try from your side. Regards, Boyuan Hi Christian, As stated above, this new patch set just submitted fixe

[Mesa-dev] [PATCH 6/9] st/va: add preset values for VAAPI encode

2016-07-21 Thread Boyuan Zhang
Add some hardcoded values hardware needs mainly for rate control purpose. With previously hardcoded values for OMX, the rate control result is not correct. This change fixed the rate control result by setting correct values for Vaapi. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/

[Mesa-dev] [PATCH 3/9] st/va: add conversion for yv12 to nv12in putimage

2016-07-21 Thread Boyuan Zhang
For putimage call, if image format is yv12 (or IYUV with U V field swap) and surface format is nv12, then we need to convert yv12 to nv12 and then copy the converted data from image to surface. We can't use the existing logic where surface is destroyed and re-created with yv12 format. Signed-of

[Mesa-dev] [PATCH 4/9] st/va: get rate control method from configattrib

2016-07-21 Thread Boyuan Zhang
Rate control method is passed from app to driver through config attrib list. That is why we need to store this rate control method to config. And later on, we will pass this value to context->desc.h264enc.rate_ctrl.rate_ctrl_method. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va

[Mesa-dev] [PATCH 5/9] st/va: add functions for VAAPI encode

2016-07-21 Thread Boyuan Zhang
Add necessary functions/changes for VAAPI encoding to buffer and picture. These changes will allow driver to handle all Vaapi encode related operations. This patch doesn't change the Vaapi decode behaviour. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/buffer.c | 6 + src

[Mesa-dev] [PATCH 7/9] st/va: add enviromental variable to disable interlace

2016-07-21 Thread Boyuan Zhang
Add environmental variable to disable interlace mode. At VAAPI decoding stage, driver can not distinguish b/w pure decoding case and transcoding case. And since interlace encoding is not supported, we have to disable interlace for transcoding case. The temporary solution is to use enviromental v

[Mesa-dev] [PATCH 8/9] st/va: add function to handle misc param type frame rate

2016-07-21 Thread Boyuan Zhang
Frame rate can be passed to driver either through VAEncSequenceParameterBufferType or VAEncMiscParameterTypeFrameRate. Previous code only implement the former one, which is used by Gstreamer-Vaapi. Now adding implementation for VAEncMiscParameterTypeFrameRate. Also adding default frame rate as

[Mesa-dev] [PATCH 9/9] st/va: enable h264 VAAPI encode

2016-07-21 Thread Boyuan Zhang
Enable H.264 VAAPI encoding through config. Currently only H.264 baseline is supported. Encode entrypoint is not accepted by driver. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/config.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-)

[Mesa-dev] [PATCH 2/9] vl/util: add copy func for yv12image to nv12surface

2016-07-21 Thread Boyuan Zhang
Add function to copy from yv12 image to nv12 surface for VAAPI putimage call. We need this function in VaPutImage call where copying from yv12 image to nv12 surface for encoding. Existing function can't be used because it only work for copying from yv12 surface to nv12 image in Vaapi. Signed-of

[Mesa-dev] [PATCH 1/9] st/va: add encode entrypoint

2016-07-21 Thread Boyuan Zhang
VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We will save this encode entry point in config. config_id was used as profile previously. Now, config has both profile and entrypoint field, and config_id is used to get the config object. Later on, we pass this entrypoi

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

2016-07-21 Thread Stéphane Marchesin
On Tue, Jul 19, 2016 at 6:36 AM, Rob Clark wrote: > On Tue, Jul 19, 2016 at 6:54 AM, Emil Velikov > wrote: >> On 19 July 2016 at 04:21, Tomasz Figa wrote: >>> On Tue, Jul 19, 2016 at 2:35 AM, Emil Velikov >>> wrote: On 18 July 2016 at 16:38, Tomasz Figa wrote: > On Mon, Jul 18, 2016

Re: [Mesa-dev] [PATCH] nvc0/mme: fix offsets used for indirect draws

2016-07-21 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Jul 21, 2016 at 4:15 PM, Samuel Pitoiset wrote: > This fixes a regression introduced in > 1da704a94c57aa0b0cf8faaa3236fe47dfb8f88c because the offset has moved > from 0x180 to 0x1a0, and the macros have to be re-compiled. > > Fixes: 1da704a ("nvc0: increase the t

Re: [Mesa-dev] [PATCH] nvc0: fix offsets of MP perf counters input parameters

2016-07-21 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Jul 21, 2016 at 4:15 PM, Samuel Pitoiset wrote: > This fixes a regression introduced in > 1da704a94c57aa0b0cf8faaa3236fe47dfb8f88c because the offset has moved > from 0x600 to 0x620, and the kernels used for reading MP perf counters > have to be re-assembled. > >

[Mesa-dev] [PATCH 6/9] st/mesa: remove excessive shader state dirtying

2016-07-21 Thread Marek Olšák
From: Marek Olšák This just needs to be done by st_validate_state. v2: add "shaders_may_be_dirty" flags for not skipping st_validate_state on _NEW_PROGRAM to detect real shader changes --- src/mesa/state_tracker/st_atom.c | 13 + src/mesa/state_tracker/st_cb_bitmap.c | 3 +-

[Mesa-dev] [Bug 89599] symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89599 --- Comment #14 from Tomasz Paweł Gajc --- (In reply to Matt Turner from comment #11) > I sent a modified version of Tomasz's patch last week to mesa-dev. > > Would anyone like to test it? > > [PATCH] mapi: Massage code to allow clang to compil

[Mesa-dev] [PATCH] nvc0/mme: fix offsets used for indirect draws

2016-07-21 Thread Samuel Pitoiset
This fixes a regression introduced in 1da704a94c57aa0b0cf8faaa3236fe47dfb8f88c because the offset has moved from 0x180 to 0x1a0, and the macros have to be re-compiled. Fixes: 1da704a ("nvc0: increase the tex handles area size in the driver") Signed-off-by: Samuel Pitoiset --- src/gallium/drivers

[Mesa-dev] [PATCH] nvc0: fix offsets of MP perf counters input parameters

2016-07-21 Thread Samuel Pitoiset
This fixes a regression introduced in 1da704a94c57aa0b0cf8faaa3236fe47dfb8f88c because the offset has moved from 0x600 to 0x620, and the kernels used for reading MP perf counters have to be re-assembled. This also fixes amd_performance_monitor_measure piglit. Fixes: 1da704a ("nvc0: increase the t

Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

2016-07-21 Thread Dave Airlie
> On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: >> subroutine variables are to be used just in the way functions are >> called. Although the spec doesn't say it explicitely, this means that >> these variables are not to be used in any other way than those left >> for function calls. Theref

Re: [Mesa-dev] [PATCH] glsl/ast: don't allow subroutine uniform comparisons

2016-07-21 Thread Ian Romanick
On 07/19/2016 01:45 PM, Ian Romanick wrote: > On 07/19/2016 06:54 AM, Andres Gomez wrote: >> Hi, >> >> Just dropped: >> https://lists.freedesktop.org/archives/mesa-dev/2016-July/123485.html >> >> I didn't realize there was already this thread open. >> >> On Tue, 2016-06-07 at 09:59 -0700, Ian Roman

[Mesa-dev] [PATCH] mesa: Use AC_HEADER_MAJOR to include correct header for major().

2016-07-21 Thread Matt Turner
Gentoo has been smoke testing an upcoming change to glibc. Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=580392 --- configure.ac | 1 + src/gallium/winsys/svga/drm/vmw_screen.c | 7 ++- src/gbm/main/gbm.c | 7 ++- src/loader/loader.c

Re: [Mesa-dev] [PATCH 1/7] glsl: Separate overlapping sentinel nodes in exec_list.

2016-07-21 Thread Matt Turner
ping ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] os: add pipe_mutex_assert_locked()

2016-07-21 Thread Rob Clark
Would be nice if we could also have lockdep, like in the linux kernel. But this is better than nothing. Signed-off-by: Rob Clark --- src/gallium/auxiliary/os/os_thread.h | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/auxiliary/os/os_thread.h b/src/gallium/auxi

[Mesa-dev] [Bug 89599] symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89599 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 89599] symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89599 --- Comment #13 from Matt Turner --- Thanks all. I've pushed the patch: commit 5ec140c17b54c25920091501b665b9aa809cc5e8 Author: Matt Turner Date: Mon Jul 11 10:44:25 2016 -0700 mapi: Massage code to allow clang to compile. -- You are r

Re: [Mesa-dev] [PATCH] freedreno/a2xx: silence missing case 'SHADER_COMPUTE' warning

2016-07-21 Thread Matt Turner
On Tue, Jul 19, 2016 at 5:06 AM, Francesco Ansanelli wrote: > --- > src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c > b/src/gallium/drivers/freedreno/a2xx/disasm-a2xx.c > index f00d5d

Re: [Mesa-dev] [PATCH] i965: Include VUE handles for GS with invocations > 1.

2016-07-21 Thread Ian Romanick
On my oes_shader_io_blocks branch (which enables GL_OES_geometry_shader), this fixes deqp-gles31.functional.geometry_shading.instanced.draw_2_instances_geometry_2_invocations deqp-gles31.functional.geometry_shading.instanced.draw_2_instances_geometry_8_invocations deqp-gles31.functional.geometry_s

Re: [Mesa-dev] [PATCH 8/8] egldevice: implement eglQueryDisplayAttribEXT

2016-07-21 Thread Adam Jackson
On Thu, 2016-07-21 at 16:18 +0100, Daniel Stone wrote: > On 21 July 2016 at 15:11, Emil Velikov wrote: > > I'd suggest opting for the drmDevice libdrm API. It can provide a list > > of devices with all the nodes and other misc info. Thus we could use > > the render/card/other node as any point as

[Mesa-dev] [Bug 96903] Hoard renders thick white fog

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96903 --- Comment #2 from Ilia Mirkin --- BTW, I believe the correct solution here is to add a "force_glsl_version" option to drirc. Should be easy to do with the executable name (hopefully it's not "wine"). Can you test adding something like

Re: [Mesa-dev] [PATCH 06/10] egl/android: Fix support for pbuffers

2016-07-21 Thread Rob Herring
On Thu, Jul 21, 2016 at 12:35 AM, Tomasz Figa wrote: > On Thu, Jul 21, 2016 at 6:19 AM, Rob Herring wrote: >> On Fri, Jul 15, 2016 at 2:53 AM, Tomasz Figa wrote: >>> From: Nicolas Boichat >>> >>> Existing image loader code supports creating images only for window >>> surfaces. Moreover droid_cr

[Mesa-dev] [Bug 96979] Mesa 10.5.7 implementation error: Trying to disable permanently enabled extensions

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96979 --- Comment #9 from Ian Romanick --- (In reply to Ruslan Kabatsayev from comment #4) > Trying this with Mesa 11.0.2 doesn't crash glxinfo, but I still get the > following discrepancy: > > $ glxinfo | grep GL_APPLE_texture_max_level > $ MESA_EXTE

[Mesa-dev] [Bug 96979] Mesa 10.5.7 implementation error: Trying to disable permanently enabled extensions

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96979 --- Comment #8 from Ian Romanick --- (In reply to Eero Tamminen from comment #7) > Btw. If you're just testing whether Mesa would flip out on given HW and have > an automated way of running your test-case (e.g. apitrace trace), you can > override

Re: [Mesa-dev] [PATCH 03/36] isl/state: Use a valid alignment for 1-D textures

2016-07-21 Thread Nanley Chery
On Wed, Jun 29, 2016 at 05:37:22PM -0700, Jason Ekstrand wrote: > The alignment we use doesn't matter (see the comment) but it should at > least be an alignment we can represent with the enums. This patch is, Reviewed-by: Nanley Chery > --- > src/intel/isl/isl_surface_state.c | 2 +- > 1 file c

Re: [Mesa-dev] [PATCH 8/8] egldevice: implement eglQueryDisplayAttribEXT

2016-07-21 Thread Daniel Stone
Hi, On 21 July 2016 at 15:11, Emil Velikov wrote: > On 21 July 2016 at 14:57, Adam Jackson wrote: >>> + device_name = drv->QueryDeviceName(disp); >> >> This is /dev/dri/renderD128... >> >>> + mtx_lock(_eglGlobal.Mutex); >>> + >>> + assert(info->got_devices); >>> + >>> + for (dev = info->

Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint

2016-07-21 Thread Zhang, Boyuan
And I forgot to say, all the patches I submitted for code review is based on the latest Master. And confirmed from my side, all patches can be applied to the latest Master without any problem. Regards, Boyuan -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.o

Re: [Mesa-dev] [PATCH] egl/dri2: Add reference count for dri2_egl_display

2016-07-21 Thread Emil Velikov
On 21 July 2016 at 01:44, Nicolas Boichat wrote: > On Wed, Jul 20, 2016 at 11:52 PM, Emil Velikov > wrote: >> On 20 July 2016 at 15:42, Emil Velikov wrote: >>> On 20 July 2016 at 09:26, Nicolas Boichat wrote: android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls eglTerminate

Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint

2016-07-21 Thread Zhang, Boyuan
>> @@ -150,7 +167,18 @@ vlVaCreateConfig(VADriverContextP ctx, VAProfile >> profile, VAEntrypoint entrypoin >> if (entrypoint != VAEntrypointVLD) >> return VA_STATUS_ERROR_UNSUPPORTED_ENTRYPOINT; >> >> - *config_id = p; >> +#if 0 >> + if (entrypoint == VAEntrypointEncSlice || en

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

2016-07-21 Thread Christian König
Am 21.07.2016 um 16:05 schrieb Nayan Deshmukh: Hi Christian, Yes, that is for pixel center adjustment. let me give you an example, for lanczos I need frac(x) where x is the original coordinate before scaling. To calculate that first I subtract half_pixel and then multiply by the original surf

Re: [Mesa-dev] [PATCH 8/8] egldevice: implement eglQueryDisplayAttribEXT

2016-07-21 Thread Emil Velikov
On 21 July 2016 at 14:57, Adam Jackson wrote: > On Fri, 2015-07-24 at 16:20 +0200, Jonny Lamb wrote: >> This adds a new vfunc to _EGLDriver, QueryDeviceName, which should >> return a const string of the device name (usually in the format >> '/dev/dri/cardN'). >> >> The EGLDevice could perhaps be c

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

2016-07-21 Thread Nayan Deshmukh
Hi Christian, Yes, that is for pixel center adjustment. let me give you an example, for lanczos I need frac(x) where x is the original coordinate before scaling. To calculate that first I subtract half_pixel and then multiply by the original surface size, which gives me the original coordinate.

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

2016-07-21 Thread Christian König
This seems to be the reason for the artifacts. + ureg_SUB(shader, ureg_writemask(t_array[0], TGSI_WRITEMASK_XY), +i_vtex, half_pixel); On debugging I found that after removing this ^^^ instruction the artifacts are gone. Not sure why is this happening bu

Re: [Mesa-dev] [PATCH 8/8] egldevice: implement eglQueryDisplayAttribEXT

2016-07-21 Thread Adam Jackson
On Fri, 2015-07-24 at 16:20 +0200, Jonny Lamb wrote: > This adds a new vfunc to _EGLDriver, QueryDeviceName, which should > return a const string of the device name (usually in the format > '/dev/dri/cardN'). > > The EGLDevice could perhaps be cached in the EGLDisplay but there > usually aren't lo

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

2016-07-21 Thread Andy Furniss
Zhang, Boyuan wrote: Hi Andy, Thanks very much for providing all the information. The I420 U V swapping issue still can't be reproduced from my side, I will try it again later. CQP issue is fixed in the new patch set I just submitted. Please use " ... vaapiencodeh264 rate-control=cqp init-qp=x

[Mesa-dev] [Bug 96979] Mesa 10.5.7 implementation error: Trying to disable permanently enabled extensions

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96979 --- Comment #7 from Eero Tamminen --- Btw. If you're just testing whether Mesa would flip out on given HW and have an automated way of running your test-case (e.g. apitrace trace), you can override what PCI ID libdrm reports. When underlying HW

[Mesa-dev] [Bug 97019] [clover] build failure in llvm/codegen/native.cpp:129:52

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97019 Bug ID: 97019 Summary: [clover] build failure in llvm/codegen/native.cpp:129:52 Product: Mesa Version: git Hardware: All OS: Linux (All) Status:

Re: [Mesa-dev] [PATCH 1/8] nir: Add a pass for lowering away constant initializers

2016-07-21 Thread Iago Toral
I dropped a few minor comments in patches 1, 2, 4 and 5, I don't think any of them are very relevant, so feel free to ignore them. Otherwise: Patches 1-5 and 7-8 are: Reviewed-by: Iago Toral Quiroga On Wed, 2016-07-20 at 15:28 -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- >

[Mesa-dev] [Bug 96979] Mesa 10.5.7 implementation error: Trying to disable permanently enabled extensions

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96979 --- Comment #6 from Ruslan Kabatsayev --- (In reply to Emil Velikov from comment #5) > Note that MESA_EXTENSION_OVERRIDE is aimed for development/workarounds and > {en,dis}abling extension X does not magically {give,remove} all the > functionalit

Re: [Mesa-dev] [PATCH 5/8] nir: Simplify nir_lower_gs_intrinsics

2016-07-21 Thread Iago Toral
On Wed, 2016-07-20 at 15:28 -0700, Jason Ekstrand wrote: > It's only ever called on single-function shaders.  At this point, > there are > a lot of helpers that can make it all much simpler. This is a nice clean-up. I wonder if for passes like this that have the implicit requirement that all func

[Mesa-dev] [Bug 96979] Mesa 10.5.7 implementation error: Trying to disable permanently enabled extensions

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96979 --- Comment #5 from Emil Velikov --- With 12.0 (commit 21d43fe51ab5bcbc89ad5c61a51d3517c4243298) one should be able to disable permanently enabled extensions in a way that glGetString{,i} honours it. IIRC the above patch depends it depends on ot

Re: [Mesa-dev] [PATCH 4/8] nir/lower_returns: Stop using constant initializers

2016-07-21 Thread Iago Toral
I guess this isn't really necessary since we are going to lower constant initializers away eventually, right? I have no objections to saving the pass some work of course, just wondering if that's really all there is to this change or if I am missing something else. Iago On Wed, 2016-07-20 at 15:2

Re: [Mesa-dev] [PATCH 1/8] nir: Add a pass for lowering away constant initializers

2016-07-21 Thread Iago Toral
On Wed, 2016-07-20 at 15:28 -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- >  src/compiler/Makefile.sources  |   1 + >  src/compiler/nir/nir.h |   2 + >  src/compiler/nir/nir_lower_constant_initializers.c | 102 > +

Re: [Mesa-dev] [PATCH 2/8] anv/pipeline: Call nir_lower_constant_initializers

2016-07-21 Thread Iago Toral
On Wed, 2016-07-20 at 15:28 -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- >  src/intel/vulkan/anv_pipeline.c | 13 + >  1 file changed, 13 insertions(+) > > diff --git a/src/intel/vulkan/anv_pipeline.c > b/src/intel/vulkan/anv_pipeline.c > index 3723423..df57182 10

Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint

2016-07-21 Thread Christian König
Am 20.07.2016 um 20:00 schrieb Zhang, Boyuan: >Makes sense, but I suggest that in this case we should add at least a comment why this is still disabled. >And it would look better if we have an "#if 0" or something like this in the code which gets explicitly removed with the last patch. Sur

Re: [Mesa-dev] Mesa (master): Revert "radeon/llvm: Use alloca instructions for larger arrays"

2016-07-21 Thread Matt Arsenault
> On Jul 21, 2016, at 01:03, Michel Dänzer wrote: > > On 21.07.2016 00:04, Michel Dänzer wrote: >> On 15.07.2016 05:15, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: >>> Module: Mesa >>> Branch: master >>> Commit: f84e9d749fbb6da73a60fb70e6725db773c9b8f8 >>> URL: >>> http://cgit.freedesktop.org/me

Re: [Mesa-dev] [PATCH] vl/dri3: fix a memory leak from front buffer

2016-07-21 Thread Christian König
Am 14.07.2016 um 17:02 schrieb Leo Liu: Inspired by fix for mem leak of vdpau interop, resource_from_handle set texture reference count, that need to be decreased and released, recall there is a similar case for DRI3, that is with VA-API glx extension, there is temporary TFP(texture from pixmap),

Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint

2016-07-21 Thread Christian König
Am 21.07.2016 um 00:13 schrieb Boyuan Zhang: VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We will save this encode entry point in config. config_id was used as profile previously. Now, config has both profile and entrypoint field, and config_id is used to get the

Re: [Mesa-dev] VAAPI egl interop on radeon

2016-07-21 Thread Christian König
Hi Jan, I don't think we have implemented EGL interop on VA-API to this extend. All that is supported is exporting the handle of RGBA images, not directly decoded YUV data. If you need decoding support with OpenGL/EGL interop on AMD hardware please use VDPAU instead. Regards, Christian. A

[Mesa-dev] [Bug 96979] Mesa 10.5.7 implementation error: Trying to disable permanently enabled extensions

2016-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96979 --- Comment #4 from Ruslan Kabatsayev --- Trying this with Mesa 11.0.2 doesn't crash glxinfo, but I still get the following discrepancy: $ glxinfo | grep GL_APPLE_texture_max_level $ MESA_EXTENSION_OVERRIDE=-GL_APPLE_texture_max_level glxinfo >/