Re: [Mesa-dev] [PATCH] android: mesa: revert "Enable asm unconditionally"

2019-07-18 Thread Chih-Wei Huang
_mesa.mk > +++ b/src/mesa/Android.libmesa_st_mesa.mk > @@ -42,9 +42,11 @@ LOCAL_GENERATED_SOURCES := \ > $(MESA_GEN_GLSL_H) \ > $(MESA_GEN_NIR_H) > > +ifeq ($(strip $(MESA_ENABLE_ASM)),true) > ifeq ($(TARGET_ARCH),x86) > LOCAL_SRC_FILES += $(X86_F

Re: [Mesa-dev] [PATCH 1/3] android: radeonsi/gfx10: generate gfx10_format_table.h (v2)

2019-07-07 Thread Chih-Wei Huang
Mauro Rossi 於 2019年7月7日 週日 上午4:17寫道: > > Fix Android building rules for gfx10_format_table.h generated header > > (v2) Add LOCAL_C_INCLUDES += $(intermediates)/radeonsi to fix error: > > external/mesa/src/gallium/drivers/radeonsi/si_state.c:46:10: > fatal error: 'gfx10_format_table.h' file not

[Mesa-dev] [PATCH] android: vulkan/util: fix generating vk_enum_to_str.*

2019-07-05 Thread Chih-Wei Huang
with empty recipe to avoid the issue. Signed-off-by: Chih-Wei Huang --- src/vulkan/Android.mk | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/vulkan/Android.mk b/src/vulkan/Android.mk index c3230d8..71aa5e5 100644 --- a/src/vulkan/Android.mk +++ b/src/vulkan/Android.mk

[Mesa-dev] [PATCH 4/8] android: radv: fix improper use of LOCAL_WHOLE_STATIC_LIBRARIES

2019-06-25 Thread Chih-Wei Huang
The libmesa_git_sha1 is a dummy library. There is no reason to put it into LOCAL_WHOLE_STATIC_LIBRARIES. Move libmesa_vulkan_util to the vulkan.radv which really needs it. Signed-off-by: Chih-Wei Huang --- src/amd/vulkan/Android.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[Mesa-dev] [PATCH 8/8] android: radv: import include paths from used libraries

2019-06-25 Thread Chih-Wei Huang
It's unnecessary to manually add these include paths since they could be imported automatically. Signed-off-by: Chih-Wei Huang --- src/amd/vulkan/Android.mk | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan

[Mesa-dev] [PATCH 5/8] android: vulkan/util: fix export path

2019-06-25 Thread Chih-Wei Huang
Export the correct include path so that the libraries use it can get it automatically. Signed-off-by: Chih-Wei Huang --- src/amd/vulkan/Android.mk | 1 - src/intel/Android.vulkan.mk | 1 - src/vulkan/Android.mk | 3 +-- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 1/8] android: anv: remove unused LOCAL_EXPORT_C_INCLUDE_DIRS

2019-06-25 Thread Chih-Wei Huang
The vulkan module is the final HAL. No need to export its headers since none will import it. Signed-off-by: Chih-Wei Huang --- src/intel/Android.vulkan.mk | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/intel/Android.vulkan.mk b/src/intel/Android.vulkan.mk index 3c257e5..8d978c3 100644

[Mesa-dev] [PATCH 6/8] android: anv: eliminate libmesa_anv_entrypoints

2019-06-25 Thread Chih-Wei Huang
The dummy library libmesa_anv_entrypoints is totally unnecessary. The four VULKAN_GENERATED_FILES could be generated and built in libmesa_vulkan_common directly. The libraries using the generated headers should get it via the exported include path. Signed-off-by: Chih-Wei Huang --- src/intel

[Mesa-dev] [PATCH 0/8] Android makefiles clean up

2019-06-25 Thread Chih-Wei Huang
library to generate headers * Add include paths which could be imported automatically This is a series of patches to clean up these issues. Chih-Wei Huang (8): android: anv: remove unused LOCAL_EXPORT_C_INCLUDE_DIRS android: radv: remove unused LOCAL_EXPORT_C_INCLUDE_DIRS android: anv: fix

[Mesa-dev] [PATCH 7/8] android: anv: import include path of libmesa_nir

2019-06-25 Thread Chih-Wei Huang
Add libmesa_nir to a common LOCAL_STATIC_LIBRARIES defined by ANV_STATIC_LIBRARIES so that its include path can be imported automatically. Then ANV_INCLUDES is unnecessary and could be eliminated. Signed-off-by: Chih-Wei Huang --- src/intel/Android.vulkan.mk | 36

[Mesa-dev] [PATCH 2/8] android: radv: remove unused LOCAL_EXPORT_C_INCLUDE_DIRS

2019-06-25 Thread Chih-Wei Huang
The vulkan module is the final HAL. No need to export its headers since none will import it. Signed-off-by: Chih-Wei Huang --- src/amd/vulkan/Android.mk | 4 1 file changed, 4 deletions(-) diff --git a/src/amd/vulkan/Android.mk b/src/amd/vulkan/Android.mk index 0725fea..a7c31d4 100644

[Mesa-dev] [PATCH 3/8] android: anv: fix improper use of LOCAL_WHOLE_STATIC_LIBRARIES

2019-06-25 Thread Chih-Wei Huang
The libmesa_anv_entrypoints and libmesa_genxml are dummy libraries. There is no reason to put them into LOCAL_WHOLE_STATIC_LIBRARIES. Move libmesa_vulkan_util to the vulkan HAL which really needs it. Signed-off-by: Chih-Wei Huang --- src/intel/Android.vulkan.mk | 18 +- 1 file

Re: [Mesa-dev] [PATCH] android: virgl: fix libmesa_virgil_common build and dependencies

2019-06-25 Thread Chih-Wei Huang
Mauro Rossi 於 2019年6月25日 週二 下午5:52寫道: > > Hi, > > On Mon, Jun 24, 2019 at 8:55 AM Chih-Wei Huang > wrote: >> >> Mauro Rossi 於 2019年6月15日 週六 下午1:39寫道: >> > >> > Fixes the following building errors and resolves Bug 110922 >> &g

Re: [Mesa-dev] [PATCH] android: virgl: fix libmesa_virgil_common build and dependencies

2019-06-24 Thread Chih-Wei Huang
Mauro Rossi 於 2019年6月15日 週六 下午1:39寫道: > > Fixes the following building errors and resolves Bug 110922 > Fixes gallium_dri target missing symbols at linking. > > external/mesa/src/gallium/winsys/virgl/drm/Android.mk: > error: libmesa_winsys_virgl (STATIC_LIBRARIES android-x86_64) missing >

[Mesa-dev] [PATCH] android: fix typo LOCAL_EXPORT_C_INCLUDES

2019-06-24 Thread Chih-Wei Huang
Should be LOCAL_EXPORT_C_INCLUDE_DIRS. Signed-off-by: Chih-Wei Huang --- src/gallium/winsys/virgl/common/Android.mk | 2 +- src/mapi/Android.mk| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/virgl/common/Android.mk b/src/gallium

Re: [Mesa-dev] [PATCH] android: virgl: fix generated virgl_driinfo.h building rules

2019-06-23 Thread Chih-Wei Huang
GALLIUM_VIRGL),) > GALLIUM_TARGET_DRIVERS += virtio_gpu > $(eval GALLIUM_LIBS += $(LOCAL_MODULE) libmesa_winsys_virgl_common > libmesa_winsys_virgl libmesa_winsys_virgl_vtest) > -- I suggest to use := instead of += in LOCAL_GENERATED_SOURCES and LOCAL_EXPORT_C_INCLUDE_DIRS since

Re: [Mesa-dev] [PATCH 1/2] android: anv: fix generated files depedencies

2019-03-05 Thread Chih-Wei Huang
Tapani Pälli 於 2019年3月5日 週二 下午4:48寫道: > > On 3/5/19 9:26 AM, Chih-Wei Huang wrote: > > Mauro Rossi 於 2019年3月4日 週一 上午3:58寫道: > >> > >> Fix anv_extrypoints.{c,h} and anv_extensions.{c,h} missing dependencies > >> Rename the variable labels according t

Re: [Mesa-dev] [PATCH 1/2] android: anv: fix generated files depedencies

2019-03-04 Thread Chih-Wei Huang
Mauro Rossi 於 2019年3月4日 週一 上午3:58寫道: > > Fix anv_extrypoints.{c,h} and anv_extensions.{c,h} missing dependencies > Rename the variable labels according to targets and python scripts > Align the building rules as per Automake for simplification > > Fixes building errors during rebuils due to

[Mesa-dev] [PATCH] Android: fix a missing nir_intrinsics.h error

2018-05-24 Thread Chih-Wei Huang
esa/src/compiler/nir/nir.h:966:10: fatal error: 'nir_intrinsics.h' file not found ^~ 1 error generated. Fixes: 76dfed8ae2d5 ("nir: mako all the intrinsics") Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- src/compiler/Android.nir.gen.mk

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-27 Thread Chih-Wei Huang
2018-04-27 1:34 GMT+08:00 Rob Herring <r...@kernel.org>: > On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 26 April 2018 at 03:30, Chih-Wei Huang <cwhu...@linux.org.tw> wrote: >>> 2018-04-25 19:55 GMT+08:00 Robert Fos

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-27 Thread Chih-Wei Huang
2018-04-27 2:19 GMT+08:00 Robert Foss : > > I've spent some time today preparing a #ifdef version of what robher > submitted. > > It's fine, but there is no way automatically enable the HAVE_DRM_GRALLOC > #define through the build tools. So a small simple patch adding

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Chih-Wei Huang
2018-04-25 19:55 GMT+08:00 Robert Foss : > Hey Emil & Chih-Wei, > > On 04/24/2018 01:59 PM, Emil Velikov wrote: >> >> On 24 April 2018 at 12:28, Emil Velikov wrote: >> >>> On the topic of keeping the old code behind a #define or just removing

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-22 Thread Chih-Wei Huang
What's the impact to drm_gralloc? 2018-04-20 5:09 GMT+08:00 Rob Herring : > Maintaining both flink names and prime fd support which are provided by > 2 different gralloc implementations is problematic because we have a > dependency on a specific gralloc implementation header. >

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-03-26 Thread Chih-Wei Huang
2018-03-22 16:23 GMT+08:00 Tomasz Figa <tf...@chromium.org>: > Hi Chih-Wei, > > On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang <cwhu...@linux.org.tw> wrote: >> 2018-02-21 3:03 GMT+08:00 Rob Herring <r...@kernel.org>: >>> >>> Perhaps worth revi

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-22 Thread Chih-Wei Huang
2018-02-21 3:03 GMT+08:00 Rob Herring : > > Perhaps worth revisiting. Given we've failed to progress at all since > then may change opinions some. We already have to handle multiple > opens share the same pipe_screen, so I don't think reusing the fd buys > us anything. > > Maybe

Re: [Mesa-dev] [PATCH] Android: update CleanSpec.mk

2017-11-06 Thread Chih-Wei Huang
2017-11-03 19:02 GMT+08:00 Tapani Pälli <tapani.pa...@intel.com>: > On 11/03/2017 12:30 PM, Chih-Wei Huang wrote: >> 2017-11-03 15:47 GMT+08:00 Tapani Pälli <tapani.pa...@intel.com>: >>> Hi Chih-Wei; >>> This looks good to me. Only thing that c

Re: [Mesa-dev] [PATCH] Android: update CleanSpec.mk

2017-11-03 Thread Chih-Wei Huang
2017-11-03 15:47 GMT+08:00 Tapani Pälli : > Hi Chih-Wei; > > This looks good to me. Only thing that causes a bit of headache is ... what > is the difference between PRODUCT_OUT, OUT_DIR and TARGET_OUT? OUT_DIR is also set to "out" if it's not already set. PRODUCT_OUT is

[Mesa-dev] [PATCH] Android: update CleanSpec.mk

2017-11-03 Thread Chih-Wei Huang
The libraries are moved to /vendor since commit c3f75d48. Clean all old files for incremental builds. Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- CleanSpec.mk | 7 +++ 1 file changed, 7 insertions(+) diff --git a/CleanSpec.mk b/CleanSpec.mk index d08b0def7d..eca3845354

[Mesa-dev] [PATCH] Android: fix undeclared identifier 'gfx9d_reg_table'

2017-09-09 Thread Chih-Wei Huang
ot updated. However, it's not spotted since gfx9d_reg_table is not really used until commit 552aaa11 was landed. Fixes: 552aaa11 (ac/debug: take ASIC generation into account when printing registers) Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- src/amd/Android.common.mk | 2 +- 1

[Mesa-dev] [PATCH] Android: fix radeonsi building errors on Android O

2017-09-05 Thread Chih-Wei Huang
ed symbols linking for N and M") Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- Android.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Android.mk b/Android.mk index e03eb71..4ab6725 100644 --- a/Android.mk +++ b/Android.mk @@ -96,6 +96,7 @@ define mesa-build

Re: [Mesa-dev] [PATCH] ac/debug: use util_strchrnul() to fix android build error

2017-08-25 Thread Chih-Wei Huang
2017-08-25 5:52 GMT+08:00 Mauro Rossi : > Similar to e09d04cd56 "radeonsi: use util_strchrnul() to fix android build > error" > > Android Bionic does not support strchrnul() string function, This is not entirely true. Bionic has strchrnul() since Android 7.0. But I think

Re: [Mesa-dev] [PATCH mesa] egl/android: add missing include

2017-08-25 Thread Chih-Wei Huang
2017-08-24 22:22 GMT+08:00 Eric Engestrom : > Cc: Rob Herring > Signed-off-by: Eric Engestrom > --- > This needs to land before [1], otherwise the latter will break android. > > [1]

Re: [Mesa-dev] [PATCH 2/2] Android: EGL: fix missing nativewindow.h include on O

2017-08-24 Thread Chih-Wei Huang
2017-08-24 22:02 GMT+08:00 Rob Herring <r...@kernel.org>: > On Thu, Aug 24, 2017 at 4:08 AM, Chih-Wei Huang <cwhu...@android-x86.org> > wrote: >> 2017-08-24 1:25 GMT+08:00 Rob Herring <r...@kernel.org>: >> >> I'm also trying to fix it. >

Re: [Mesa-dev] [PATCH 2/2] Android: EGL: fix missing nativewindow.h include on O

2017-08-24 Thread Chih-Wei Huang
2017-08-24 1:25 GMT+08:00 Rob Herring : > The build against AOSP master and O is broken: > > external/mesa3d/include/EGL/eglplatform.h:100:10: fatal error: > 'android/native_window.h' file not found > > native_window.h has moved and is now part of libnativewindow library, so >

Re: [Mesa-dev] [PATCH 1/2] Android: fix Android O version check for LLVM

2017-08-24 Thread Chih-Wei Huang
VERSION_PATCH=0)) \ > - $(if $(filter O,$(MESA_ANDROID_MAJOR_VERSION)), \ > + $(if $(filter 8,$(MESA_ANDROID_MAJOR_VERSION)), \ > $(eval LOCAL_CFLAGS += -DHAVE_LLVM=0x0309 -DMESA_LLVM_VERSION_PATCH=0)) \ >$(eval LOCAL_SHARED_LIBRARIES += libLLVM) > endef > -- Looks go

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-18 Thread Chih-Wei Huang
2017-08-19 8:27 GMT+08:00 Emil Velikov : > On 18 August 2017 at 20:46, Rob Herring wrote: >> Both statically linking libLLVMCore and dynamically linking libLLVM causes >> duplicated symbols in gallium_dri.so and it fails to dlopen. We don't >> really

Re: [Mesa-dev] [PATCH] android: export intermediates from libmesa_util

2017-08-01 Thread Chih-Wei Huang
GENERATED_FILES)) > LOCAL_GENERATED_SOURCES := $(UTIL_GENERATED_SOURCES) > > -- Looks good to me. I suggest to add this to commit message Fixes: 601093f9 (xmlconfig: move into src/util) (yes, I believe it causes the issue) Review-by: Chih-Wei Huang <cwhu...@linux.org.tw> --

Re: [Mesa-dev] [PATCH] android: add libmesa_util include path to MESA_DRI_C_INCLUDES

2017-08-01 Thread Chih-Wei Huang
2017-08-01 15:51 GMT+08:00 Tapani Pälli : > It is required by libmesa_dri_common and i965_dri modules which both > already use MESA_DRI_C_INCLUDES. Fixes following build errors: > > In file included from >

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-31 Thread Chih-Wei Huang
2017-08-01 0:18 GMT+08:00 Rob Herring <r...@kernel.org>: > On Fri, Jul 28, 2017 at 6:06 AM, Chih-Wei Huang <cwhu...@android-x86.org> > wrote: >> Hi Rob, >> I'm testing this patch on an AMD radeon chip (PALM) now. >> I use our legacy drm_gralloc since the rad

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-30 Thread Chih-Wei Huang
Hi Rob, Sorry to bother you again. This patch also breaks the srwast/llvmpipe on Android since the red and blue are just swapped. I guess nouveau has the same issue but I'm waiting Mauro's confirmation. Any comment? -- Chih-Wei Android-x86 project http://www.android-x86.org

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-30 Thread Chih-Wei Huang
2017-07-28 22:59 GMT+08:00 Marek Olšák : > Hi, > > I've sent a request to revert this commit in 17.2. I'll keep it in > master, but I'll add a fix not to expose the new formats for GLX. I thought it doesn't break GLX according to the commit message (investigation by Chad

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-28 Thread Chih-Wei Huang
Hi Rob, I'm testing this patch on an AMD radeon chip (PALM) now. I use our legacy drm_gralloc since the radeon driver doesn't support atomic api required by drm_hwcomposer. On SurfaceFlinger started, the screen just messed up. If reverting this patch, it becomes normal as before. Does the radeon

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-28 Thread Chih-Wei Huang
2017-07-26 23:34 GMT+08:00 Rob Herring <r...@kernel.org>: > On Tue, Jul 25, 2017 at 10:16 PM, Chih-Wei Huang > <cwhu...@android-x86.org> wrote: >> 2017-07-26 1:24 GMT+08:00 Rob Herring <r...@kernel.org>: >>> >>> I double checked and I get 8-8-8

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-25 Thread Chih-Wei Huang
2017-07-26 1:24 GMT+08:00 Rob Herring <r...@kernel.org>: > On Tue, Jul 25, 2017 at 10:15 AM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> On 25 July 2017 at 03:46, Chih-Wei Huang <cwhu...@android-x86.org> wrote: >>> On Tue 11 Jul 2017, Rob Herring w

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-24 Thread Chih-Wei Huang
On Tue 11 Jul 2017, Rob Herring wrote: >> From: Marek Olšák >> >> Add support for 32-bit RGBX/RGBA formats which are required for Android. >> >> The original patch (commit ccdcf91104a5) was reverted (commit >> c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors.

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-20 Thread Chih-Wei Huang
2017-07-20 18:02 GMT+08:00 Chih-Wei Huang <cwhu...@android-x86.org>: > > OK. I see the real problem. > The rules to build spirv_info.c are incorrectly > to use $(LOCAL_PATH). > Basically speaking, $(LOCAL_PATH) can't be used > in the recipes[1] since it is always changing.

[Mesa-dev] [PATCH] Android: fix spirv_info.c generation

2017-07-20 Thread Chih-Wei Huang
. Fixes: 2dd4e2ec (spirv: Generate spirv_info.c) Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- src/compiler/Android.nir.gen.mk | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/compiler/Android.nir.gen.mk b/src/compiler/Android.nir.gen.mk index 4507ac4..e

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-20 Thread Chih-Wei Huang
2017-07-19 15:12 GMT+08:00 Tapani Pälli : > Depending on build order, LOCAL_PATH maybe set or not (and can't > be trusted to have assumed path), change modifies all occurences > of LOCAL_PATH as locally defined COMPILER_PATH instead. > > Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH v1 3/7] gallium: os_process fixes for Android

2017-06-15 Thread Chih-Wei Huang
2017-06-16 4:47 GMT+08:00 Robert Foss : > From: Rob Herring > > Signed-off-by: Rob Herring > --- > src/gallium/auxiliary/os/os_process.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] Android: define PIPE_OS_BSD

2017-06-07 Thread Chih-Wei Huang
2017-06-07 22:47 GMT+08:00 Jonathan Gray <j...@jsg.id.au>: > On Wed, Jun 07, 2017 at 10:30:49PM +0800, Chih-Wei Huang wrote: >> 2017-06-07 21:54 GMT+08:00 Jonathan Gray <j...@jsg.id.au>: >> > On Wed, Jun 07, 2017 at 02:45:15PM +0100, Emil Velikov wrote: >>

Re: [Mesa-dev] [PATCH] Android: define PIPE_OS_BSD

2017-06-07 Thread Chih-Wei Huang
2017-06-07 21:54 GMT+08:00 Jonathan Gray <j...@jsg.id.au>: > On Wed, Jun 07, 2017 at 02:45:15PM +0100, Emil Velikov wrote: >> On 6 June 2017 at 07:30, Chih-Wei Huang <cwhu...@android-x86.org> wrote: >> >>> These are are due to program_invocation_short_name/ge

Re: [Mesa-dev] [PATCH] Android: define PIPE_OS_BSD

2017-06-06 Thread Chih-Wei Huang
2017-06-06 13:06 GMT+08:00 Chih-Wei Huang <cwhu...@android-x86.org>: > 2017-06-05 21:04 GMT+08:00 Emil Velikov <emil.l.veli...@gmail.com>: >> On 4 June 2017 at 04:31, Chih-Wei Huang <cwhu...@android-x86.org> wrote: >>> Android bionic is derived from OpenBSD. S

Re: [Mesa-dev] [PATCH 0/3] Fix missing initializer errors in generated tables

2017-06-05 Thread Chih-Wei Huang
2017-06-05 3:57 GMT+08:00 Marek Olšák : > NAK. > > In C/C++, the initializer is used to clear the memory to 0s, thus, > adding 0s to the initializer is redundant and unnecessary. Empty > initializer {} is also commonly used instead of memset. Commonly used doesn't mean it's the

Re: [Mesa-dev] [PATCH] Android: use bionic pthread_barrier_* if possible

2017-06-05 Thread Chih-Wei Huang
2017-06-05 21:15 GMT+08:00 Emil Velikov <emil.l.veli...@gmail.com>: > On 5 June 2017 at 09:27, Tapani Pälli <tapani.pa...@intel.com> wrote: >> that seems the case >> >> Acked-by: Tapani Pälli <tapani.pa...@intel.com> >> >> On 06/04/2017 07:53 AM,

[Mesa-dev] [PATCH] Android: use bionic pthread_barrier_* if possible

2017-06-03 Thread Chih-Wei Huang
The pthread_barrier_* functions were introduced to bionic since Nougat. Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- Android.common.mk| 1 + src/gallium/auxiliary/os/os_thread.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] Android: define PIPE_OS_BSD

2017-06-03 Thread Chih-Wei Huang
: warning: unexpected platform in os_process.c [-W#warnings] ^ 2 warnings generated. Actually it's the only affected file by the change. Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- src/gallium/include/pipe/p_config.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/g

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

2017-05-17 Thread Chih-Wei Huang
2017-05-18 12:01 GMT+08:00 Xu, Randy : > >> -Original Message- >> From: Palli, Tapani >> > >> > It's just applied. Isn't it? >> > Yesterday without this patch >> > the color format is mismatch apparently. >> >> Yeah we do need this. TBH I don't quite understand why but

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

2017-05-17 Thread Chih-Wei Huang
2017-05-18 11:26 GMT+08:00 Xu, Randy <randy...@intel.com>: > >> -Original Message- >> From: Chih-Wei Huang [mailto:cwhu...@android-x86.org] >> Sent: Thursday, May 18, 2017 11:04 AM >> To: Xu, Randy <randy...@intel.com> >> Cc: Emil Veliko

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

2017-05-17 Thread Chih-Wei Huang
2017-05-12 12:04 GMT+08:00 Xu, Randy : > Thanks, Emil > > dEQP has patch to exclude 565 blend cases (commit named "Exclude RGB565 > blending cases from the must-pass"), so we don’t need any patches now. Hi Randy, Tapani, I think we still need a patch. Right? I see the similar

Re: [Mesa-dev] [PATCH] Android: correct libz dependency

2017-05-17 Thread Chih-Wei Huang
2017-05-17 21:11 GMT+08:00 Emil Velikov <emil.l.veli...@gmail.com>: > On 17 May 2017 at 13:45, Rob Herring <r...@kernel.org> wrote: >> On Wed, May 17, 2017 at 12:10 AM, Chih-Wei Huang >> <cwhu...@android-x86.org> wrote: >>> Commit 6facb0c0 ("

[Mesa-dev] [PATCH] Android: correct libz dependency

2017-05-16 Thread Chih-Wei Huang
ix Android Lollipop build by adding the include path of zlib to libmesa_util explicitly instead of getting the path implicitly from zlib since it doesn't export the include path in Lollipop. Fixes: 6facb0c0 "android: fix libz dynamic library dependencies" Signed-off-by: Chih-Wei Huang &

Re: [Mesa-dev] [PATCH] android: fix libz dynamic library dependencies

2017-05-16 Thread Chih-Wei Huang
2017-03-05 5:11 GMT+08:00 Mauro Rossi : > Fixes a series of libz related building errors: > > target SharedLib: gallium_dri_32 > (out/target/prod...SHARED_LIBRARIES/gallium_dri_intermediates/LINKED/gallium_dri.so) > external/elfutils/libelf/elf_compress.c:117: error:

Re: [Mesa-dev] [PATCH] egl: fix android logger compilation

2017-05-12 Thread Chih-Wei Huang
2017-05-12 14:15 GMT+08:00 Tapani Pälli <tapani.pa...@intel.com>: > > > On 05/12/2017 09:13 AM, Chih-Wei Huang wrote: >> >> 2017-05-12 13:37 GMT+08:00 Tapani Pälli <tapani.pa...@intel.com>: >>> >>> this patch is a partial revert of 1ce

Re: [Mesa-dev] [PATCH] egl: fix android logger compilation

2017-05-12 Thread Chih-Wei Huang
2017-05-12 13:37 GMT+08:00 Tapani Pälli : > this patch is a partial revert of 1ce5853 that break compilation > since LOG_ERROR etc are not defined and also macro expansion won't > work as planned (expands to 'ANDROID_egl2alog[level]') > > Fixes: 1ce5853 ("egl: simplify the

Re: [Mesa-dev] [PATCH 00/12] Android build cleanup/fixes

2017-04-27 Thread Chih-Wei Huang
_dricore.mk | 4 -- > src/mesa/Android.libmesa_st_mesa.mk | 4 -- > src/mesa/drivers/dri/Android.mk | 11 + > 28 files changed, 149 insertions(+), 216 deletions(-) > > -- First of all, thank you for these patches. Patches 1, 2, 3, 4, 5, 6, 7,

Re: [Mesa-dev] [PATCH 10/12] Android: default to building all drivers

2017-04-27 Thread Chih-Wei Huang
A typo in the subject? (s/building/build/) 2017-04-28 3:43 GMT+08:00 Rob Herring : > If BOARD_GPU_DRIVERS is empty, build all the drivers. This doesn't > enable building mesa as that is controlled by including libGLES_mesa in > the product. > > Signed-off-by: Rob Herring

Re: [Mesa-dev] [PATCH 07/12] Android: remove needless conditional including of child makefiles

2017-04-27 Thread Chih-Wei Huang
2017-04-28 3:43 GMT+08:00 Rob Herring : > It is not necessary to filter driver and winsys directories based on the > list of enabled drivers. Selecting the included driver libraries or not is > sufficient to control what is built. Hmm.. The benefit is faster parsing time. Though

Re: [Mesa-dev] [PATCH 4/5] Android: drop Android 4.4 (KitKat) support

2017-03-19 Thread Chih-Wei Huang
2017-03-20 9:33 GMT+08:00 Rob Herring : > Any users of KitKat are likely using an older version of Mesa and > KitKat support adds complexity to the make files. Dropping support > allows removing the MESA_LOLLIPOP_BUILD make variable in various make > files. > > Signed-off-by: Rob

Re: [Mesa-dev] [PATCH] android: avoid using libdrm with host modules

2017-02-16 Thread Chih-Wei Huang
2016-11-02 23:42 GMT+08:00 Emil Velikov : > > Skimming through the outstanding patches for yours [1] I've tagged > some [2] as superseded since the functionality has already landed. Let > me know the status of the rest when you've got the chance. Sorry I forgot to reply.

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

2016-10-30 Thread Chih-Wei Huang
2016-10-28 22:09 GMT+08:00 Rob Herring : > +Mauro, Chih-Wei > > On Fri, Oct 28, 2016 at 7:22 AM, Rob Clark wrote: >> On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: >>> On 10/27/2016 01:48 PM, Rob Clark wrote: On Thu,

[Mesa-dev] [PATCH] android: avoid using libdrm with host modules

2016-10-28 Thread Chih-Wei Huang
by 'out/host/linux-x86/obj32/EXECUTABLES/mesa_gen_matypes_intermediates/import_includes', missing and no known rule to make it No reason to use libdrm with host modules. Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- Android.common.mk | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Mesa-dev] [PATCH] mesa_glinterop: allow building without X and related headers

2016-10-12 Thread Chih-Wei Huang
As anyone uses the mesa interop header they ensure that the X (or others > in terms of EGL) headers are included, which ensures that everything is > resolved within the compilation unit. > > Cc: Vinson Lee <v...@freedesktop.org> > Cc: "12.0" <mesa-sta...@lists.freedesktop.or

Re: [Mesa-dev] [PATCH] Revert "mesa_glinterop: remove inclusion of GLX header"

2016-10-12 Thread Chih-Wei Huang
2016-10-04 7:03 GMT+08:00 Vinson Lee : > This reverts commit 8472045b16b3e4621553fe451a20a9ba9f0d44b6. > > Conflicts: > > include/GL/mesa_glinterop.h > > This patch fixes this build error with GCC 4.4. > > Compiling src/glx/dri_common_interop.c ... > In file

Re: [Mesa-dev] [PATCH] android: fix a build issue with libmesa_st_mesa_32

2016-09-06 Thread Chih-Wei Huang
2016-08-29 16:52 GMT+08:00 Tapani Pälli : > make sure nir_opcodes.h is in LOCAL_GENERATED_SOURCES otherwise > build fails with: > > "In file included from > external/mesa/src/mesa/state_tracker/st_glsl_to_nir.cpp:44: > external/mesa/src/compiler/nir/nir.h:42:10: fatal

Re: [Mesa-dev] Android: apps crashed on Intel Gen9 GPU

2016-05-14 Thread Chih-Wei Huang
2016-05-13 15:30 GMT+08:00 Pohjolainen, Topi <topi.pohjolai...@intel.com>: > On Thu, May 12, 2016 at 12:25:25AM +0800, Chih-Wei Huang wrote: >> Testing android-x86 with mesa 11.2.2, >> I found the Google Play crashed forever on >> a device with Intel Gen9 GPU (e.g., Skyl

[Mesa-dev] Android: apps crashed on Intel Gen9 GPU

2016-05-11 Thread Chih-Wei Huang
Testing android-x86 with mesa 11.2.2, I found the Google Play crashed forever on a device with Intel Gen9 GPU (e.g., Skylake). After analyzing, the i965 driver seems to assume irb->mt is not null. For example in brw_meta_fast_clear of brw_meta_fast_clear.c: struct intel_renderbuffer *irb =

Re: [Mesa-dev] [android-x86-devel] [PATCH] isl: add support for Android libisl static

2016-05-10 Thread Chih-Wei Huang
Hi Mauro, I think you should put your name on the Copyright section of the Android.*.mk. I understand these files are copied. But it's you who created and modified these files. So it's better to use your name instead of Intel, LunarG, ... 2016-05-11 8:31 GMT+08:00 Rob Herring

Re: [Mesa-dev] [android-x86-devel] [RFC 0/7] android: enable llvmpipe for software rendering

2016-04-29 Thread Chih-Wei Huang
2016-04-29 2:50 GMT+08:00 Rob Herring : >> >> I suppose if it's possible to set up some build bot for it which sends >> out emails complaining when it breaks that would help with the build >> failures. > > I have that in my plans, but it is not there yet. I'm updating to > master

Re: [Mesa-dev] [android-x86-devel] [RFC 0/7] android: enable llvmpipe for software rendering

2016-04-28 Thread Chih-Wei Huang
2016-04-28 22:22 GMT+08:00 Emil Velikov <emil.l.veli...@gmail.com>: > Hi Chih-Wei, > > Thanks for getting these out to the community. > > On 28 April 2016 at 08:34, Chih-Wei Huang <cwhu...@android-x86.org> wrote: >> This is a series of patches developed by Jide Tec

[Mesa-dev] [RFC 4/7] android: print debug info to logcat

2016-04-28 Thread Chih-Wei Huang
From: WuZhen <wuz...@jidemail.com> Redirect logs printed to stderr to logcat. NO_REF_TASK tested: local run Change-Id: I58e3966a608af361b86c54b4c95a92561b711968 Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- src/gallium/auxiliary/os/os_misc.c | 12 ++--

[Mesa-dev] [RFC 3/7] gallium/swrast: fix dri_sw_dt->data free func not matching alloc func

2016-04-28 Thread Chih-Wei Huang
From: WuZhen <wuz...@jidemail.com> The old code causes crashes when using software rendering. NO_REF_TASK tested: local run Change-Id: Ib1d7f36b9f25ccc13afdd28d1e34f76162d3 Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- src/gallium/winsys/sw/dri/dri_sw_winsys.c |

[Mesa-dev] [RFC 6/7] android: enable x86 asm and sse4 for x86 and x86_64

2016-04-28 Thread Chih-Wei Huang
From: WuZhen <wuz...@jidemail.com> Support multilib compilation use runtime feature selection. NO_REF_TASK tested: local run Change-Id: Iee7961effdecde09cfbdaf09455bfb0912699ae3 Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- Android.common.mk

[Mesa-dev] [RFC 2/7] tgsi: fix stack allocated struct may not be initialized

2016-04-28 Thread Chih-Wei Huang
From: WuZhen <wuz...@jidemail.com> NO_REF_TASK tested: local run Change-Id: Ied449126c2059d2654afebdf68972cb00862a4ce Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/galli

[Mesa-dev] [RFC 1/7] st/dri: fix double free of dri_drawable

2016-04-28 Thread Chih-Wei Huang
do not. wonder why no body else ran into this. NO_REF_TASK tested: local run Change-Id: Ibe82d82d2e34b162e64bf0b8805f8a4553d362d5 Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- src/gallium/state_trackers/dri/dri_drawable.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/ga

[Mesa-dev] [RFC 5/7] android: enable dlopen

2016-04-28 Thread Chih-Wei Huang
From: WuZhen <wuz...@jidemail.com> NO_REF_TASK tested: local run Change-Id: I7c3c03f844ba6fc7ee3d6817d9ee1e806b92aed7 Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- Android.common.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Android

[Mesa-dev] [RFC 7/7] android: support swrast

2016-04-28 Thread Chih-Wei Huang
From: WuZhen <wuz...@jidemail.com> System boots up with gles_mesa/softpipe/llvmpipe. NO_REF_TASK tested: local run Change-Id: I629ed0ca9fad12e32270eb8e8bfa9f7681b68474 Signed-off-by: Chih-Wei Huang <cwhu...@linux.org.tw> --- Android.mk | 2 +-

[Mesa-dev] [RFC 0/7] android: enable llvmpipe for software rendering

2016-04-28 Thread Chih-Wei Huang
This is a series of patches developed by Jide Technolody to enable the llvmpipe for software rendering of Android. It makes a device without a Mesa supported GPU could run most modern Android apps. These patches are mainly developed and tested on the 11.0 and 11.2 branches. They might not work

Re: [Mesa-dev] [PATCH 0/3] Support for Android RGBX/RGBA formats

2016-04-24 Thread Chih-Wei Huang
lt;mar...@gmail.com> wrote: >>>> On Fri, Apr 22, 2016 at 12:41 PM, Chih-Wei Huang >>>> <cwhu...@android-x86.org> wrote: >>>>> 2016-04-21 21:42 GMT+08:00 Emil Velikov <emil.l.veli...@gmail.com>: >>>>>> >>>>>> On 1

Re: [Mesa-dev] [PATCH 0/3] Support for Android RGBX/RGBA formats

2016-04-22 Thread Chih-Wei Huang
2016-04-21 21:42 GMT+08:00 Emil Velikov : > > On 19 April 2016 at 20:38, Rob Herring wrote: >> The RGBX/RGBA pixel formats used in the Android EGL don't get configs >> created due to the missing formats in the DRI state tracker. This series >> adds the

Re: [Mesa-dev] [PATCH 0/3] Support for Android RGBX/RGBA formats

2016-04-20 Thread Chih-Wei Huang
2016-04-20 3:38 GMT+08:00 Rob Herring : > The RGBX/RGBA pixel formats used in the Android EGL don't get configs > created due to the missing formats in the DRI state tracker. This series > adds the necessary formats for configs and DRI images. Support in GBM is > also added as it

[Mesa-dev] Latest Mesa is broken on Android-x86?

2016-04-19 Thread Chih-Wei Huang
I just tried the commit d3c98c73d on i965 GPU but it became black screen on surfaceflinger starting. Just hope to know if anyone has tested and can confirm that. Or it's a stupid mistake I made. -- Chih-Wei Android-x86 project http://www.android-x86.org

Re: [Mesa-dev] [PATCH 1/2] glsl: android: add back missing generated glcpp include path

2016-04-18 Thread Chih-Wei Huang
ilation terminated. make: *** [out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_glsl_intermediates/glsl/glcpp/glcpp-lex.o] Error 1 The series of patches are Tested-by: Chih-Wei Huang <cwhu...@linux.org.tw> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-08 Thread Chih-Wei Huang
2016-04-07 13:30 GMT+08:00 Rob Herring <robherri...@gmail.com>: > On Wed, Apr 6, 2016 at 11:12 AM, Chih-Wei Huang <cwhu...@android-x86.org> > wrote: > >> I guess the first supported GPU is virgl. Right? > > Yes. Any gallium driver really. The classic mesa driver

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-06 Thread Chih-Wei Huang
2016-04-04 6:25 GMT+08:00 Rob Herring <robherri...@gmail.com>: > On Sun, Apr 3, 2016 at 12:29 PM, Chih-Wei Huang <cwhu...@android-x86.org> > wrote: >> Besides, the module name is still gralloc.drm. >> How about call it gralloc.gbm? > > Eventually yes, but

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-03 Thread Chih-Wei Huang
2016-04-04 0:53 GMT+08:00 Chih-Wei Huang <cwhu...@android-x86.org>: > 2016-04-02 4:42 GMT+08:00 Rob Herring <r...@kernel.org>: >> >> Here's an initial gralloc implementation based on my GBM map/unmap support: >> >> https://github.com/robherring/gbm_

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-04-03 Thread Chih-Wei Huang
2016-04-02 4:42 GMT+08:00 Rob Herring : > > Here's an initial gralloc implementation based on my GBM map/unmap support: > > https://github.com/robherring/gbm_gralloc > > It's based on drm_gralloc, but heavily re-written to collapse some > unnecessary layers. Thank you for it.

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-31 Thread Chih-Wei Huang
2016-04-01 2:40 GMT+08:00 Jaap Jan Meijer <jjmeije...@gmail.com>: > Op donderdag 31 maart 2016 13:02:36 UTC+2 schreef Chih-Wei Huang: > Thanks for the patch, I tested it on both x86 and x64 kernels and it doesn't > crash anymore, previously it did on both. > >> Thanks

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-31 Thread Chih-Wei Huang
2016-03-31 0:09 GMT+08:00 Rob Herring : > On Tue, Mar 29, 2016 at 2:49 PM, Jaap Jan Meijer wrote: >> >> First of all, thanks for the hard work! >> >> Only one problem I noticed so far: when enabling virgl in drm_gralloc but >> without support in MESA, MESA /

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-23 Thread Chih-Wei Huang
2016-03-24 8:51 GMT+08:00 Rob Clark : [deleted] > > [*] the caveat there is vmwgfx stuff which seems to want to do blits.. > although I'm not entirely sure why or if that is even still requires > w/ newer vmware players. But if vmwgfx still really needs the blit > path, I

Re: [Mesa-dev] LLVMInitializeAMDGPU* undefined?

2016-03-13 Thread Chih-Wei Huang
2016-03-11 11:50 GMT+08:00 Jan Vesely <jan.ves...@rutgers.edu>: > On Fri, 2016-03-11 at 10:09 +0800, Chih-Wei Huang wrote: >> cc1: some warnings being treated as errors >> >> >> But I'm still not sure whether if it should be fixed on the mesa >> side. >&

  1   2   >