Re: [Mesa-dev] [PATCH 14/20] radeonsi: reserve a parameter slot for FMASK resources in shaders

2013-08-09 Thread Tom Stellard
On Fri, Aug 09, 2013 at 07:35:02AM -0700, Tom Stellard wrote: > On Fri, Aug 09, 2013 at 07:54:11AM +0200, Michel Dänzer wrote: > > On Don, 2013-08-08 at 11:32 -0700, Tom Stellard wrote: > > > On Thu, Aug 08, 2013 at 05:36:09PM +0200, Michel Dänzer wrote: > > > > On

Re: [Mesa-dev] [PATCH 1/2] R600/SI: Add FMA pattern

2013-08-09 Thread Tom Stellard
On Fri, Aug 09, 2013 at 02:59:07PM +0200, Niels Ole Salscheider wrote: > --- This series is: Reviewed-by: Tom Stellard Your implementation of SITargetLowering::isFMAFasterThanFMulAndFAdd() is correct for SI, not sure about Sea Islands, but we can always fix it later. Feel free to com

[Mesa-dev] Patches: R600: Merge R600 and SI vector op expansions

2013-08-12 Thread Tom Stellard
Hi, The attached patches expand a few more vector operations and also move the expansion code into AMDGPUISelLowering.cpp so it can be shared between R600 and SI. -Tom >From a519e387c262ecc0282eb8cb1e2c8802725591b4 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Fri, 2 Aug 2013 11:30

Re: [Mesa-dev] [PATCH 3/4] R600/SI: Allow conversion between v32i8 and v8i32

2013-08-12 Thread Tom Stellard
On Sat, Aug 10, 2013 at 08:50:31PM +0200, Marek Olšák wrote: > Signed-off-by: Marek Olšák You will need to add a test case to this commit, but otherwise the whole series is: Reviewed-by: Tom Stellard Do you have commit access yet? -Tom > --- > lib/Target/R600/SIInstructio

Re: [Mesa-dev] [PATCH] r600g/llvm: Add missing "%s" format string to fprintf.

2013-08-13 Thread Tom Stellard
On Sun, Aug 11, 2013 at 07:37:01PM +0200, Jon Severinsson wrote: > This fixes a compilation warning with -Wformat-security. > > CC: "9.2" Reviewed-by: Tom Stellard I've pushed this patch, thanks. -Tom > --- > src/gallium/drivers/radeon/radeon_llvm_emit.

Re: [Mesa-dev] [PATCH] radeon/llvm: fix compile error with -Werror=format-security

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 06:25:28PM +0200, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst An identical patch was sent to the list a few days ago, and I've just pushed it now. -Tom > --- > diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c > b/src/gallium/drivers/radeon/rade

Re: [Mesa-dev] [PATCH] configure: link against -lLLVM to determine build type

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 05:53:52PM +0200, Maarten Lankhorst wrote: > Fixes a build failure of 9.2 on ubuntu, because libLLVM-3.3.so is not present > in /usr/lib/llvm-3.2/lib. > I'm trying to understand the problem here, could you give a little more information about how Ubuntu packages LLVM? Whe

Re: [Mesa-dev] [PATCH 3/4] r600/radeonsi: implement new float comparison instructions

2013-08-13 Thread Tom Stellard
On Tue, Aug 13, 2013 at 07:04:56PM +0200, srol...@vmware.com wrote: > From: Roland Scheidegger > > Also use ordered comparisons for old cmp instructions. Untested. This patch looks good to me, but I would like to do a piglit run on radeonsi before you commit. I will try to do this tomorrow. -T

Re: [Mesa-dev] [PATCH v2 1/2] radeonsi: Don't leave gaps between position exports from vertex shader

2013-08-13 Thread Tom Stellard
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66974 > > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Michel Dänzer I took a look through the LLVM calls in these patches and they look OK to me. Reviewed-by: Tom Stellard > --- > > v2: No need to export unused posit

Re: [Mesa-dev] [PATCH] configure: link against -lLLVM to determine build type

2013-08-14 Thread Tom Stellard
On Wed, Aug 14, 2013 at 09:08:55AM +0200, Maarten Lankhorst wrote: > Op 14-08-13 04:37, Tom Stellard schreef: > > On Tue, Aug 13, 2013 at 05:53:52PM +0200, Maarten Lankhorst wrote: > >> Fixes a build failure of 9.2 on ubuntu, because libLLVM-3.3.so is not > >> prese

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-08-15 Thread Tom Stellard
On Thu, Aug 15, 2013 at 11:55:36AM +0200, Michel Dänzer wrote: > On Fre, 2013-08-02 at 17:58 +0200, Michel Dänzer wrote: > > On Mit, 2013-07-31 at 08:42 -0700, Tom Stellard wrote: > > > On Wed, Jul 31, 2013 at 01:04:01PM +0200, Michel Dänzer wrote: > > > > > >

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-08-15 Thread Tom Stellard
On Thu, Aug 15, 2013 at 08:22:39AM -0700, Tom Stellard wrote: > On Thu, Aug 15, 2013 at 11:55:36AM +0200, Michel Dänzer wrote: > > On Fre, 2013-08-02 at 17:58 +0200, Michel Dänzer wrote: > > > On Mit, 2013-07-31 at 08:42 -0700, Tom Stellard wrote: > > > > On Wed, Ju

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-08-15 Thread Tom Stellard
On Thu, Aug 15, 2013 at 07:50:10PM +0200, Michel Dänzer wrote: > On Don, 2013-08-15 at 09:16 -0700, Tom Stellard wrote: > > On Thu, Aug 15, 2013 at 08:22:39AM -0700, Tom Stellard wrote: > > > On Thu, Aug 15, 2013 at 11:55:36AM +0200, Michel Dänzer wrote: > > > > On

Re: [Mesa-dev] radeonsi: LLVM r187139 broke some piglit tests

2013-08-16 Thread Tom Stellard
On Fri, Aug 16, 2013 at 03:36:38PM +0200, Michel Dänzer wrote: > On Don, 2013-08-15 at 13:50 -0700, Tom Stellard wrote: > > On Thu, Aug 15, 2013 at 07:50:10PM +0200, Michel Dänzer wrote: > > > On Don, 2013-08-15 at 09:16 -0700, Tom Stellard wrote: > > > > On Thu, Au

Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for xor of i1

2013-08-16 Thread Tom Stellard
On Fri, Aug 16, 2013 at 04:04:37PM +0200, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes two recent piglit regressions with radeonsi. > > Signed-off-by: Michel Dänzer Reviewed-by: Tom Stellard > --- > lib/Target/R600/SIInstructions.td | 4 +++- > test/CodeGen/R

[Mesa-dev] [PATCH] radeonsi/compute: Let the state tracker do all the flushing

2013-08-16 Thread Tom Stellard
From: Tom Stellard It shouldn't be necessary to call radeon_winsys::cs_flush() from radeonsi_launch_grid(), because the state tracker is responsible for flushing the pipeline at the appropriate time. The current behavior is also wrong, because radeonsi_launch_grid() submits packets t

Re: [Mesa-dev] [PATCH] clover: Fix linkage of libOpenCL

2013-08-16 Thread Tom Stellard
On Wed, Aug 07, 2013 at 05:48:48PM +0200, Niels Ole Salscheider wrote: > Clover needs the option component of llvm. > Pushed, thanks! -Tom > Signed-off-by: Niels Ole Salscheider > --- > configure.ac | 4 > 1 Datei geändert, 4 Zeilen hinzugefügt(+) > > diff --git a/configure.ac b/configu

[Mesa-dev] [PATCH] R600/SI: Fix another case of illegal VGPR to SGPR copy

2013-08-21 Thread Tom Stellard
From: Tom Stellard This fixes a crash in Unigine Tropics. --- lib/Target/R600/SIFixSGPRCopies.cpp | 2 +- test/CodeGen/R600/sgpr-copy.ll | 145 +++- 2 files changed, 143 insertions(+), 4 deletions(-) diff --git a/lib/Target/R600/SIFixSGPRCopies.cpp b/lib

[Mesa-dev] PATCH: R600 + SI: Add support for lds atomic add

2013-08-21 Thread Tom Stellard
Hi, The attached patches fix some LDS bugs on SI and add support for atomic add for R600 and SI. Please Review. -Tom >From 0447b0918efca9000e66414e9ff1bd291936f702 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 21 Aug 2013 11:35:27 -0400 Subject: [PATCH 1/4] R600/SI: Don

[Mesa-dev] [PATCH] R600: Fix segfault in R600TextureIntrinsicReplacer

2013-08-21 Thread Tom Stellard
From: Tom Stellard This pass was segfaulting when it ran into a non-intrinsic function call. Function calls are not supported, so now instead of segfaulting, we will get an assertion failure with a nice error message. I'm not sure how to test this using lit. --- lib/Target

[Mesa-dev] [PATCH] radeonsi/compute: Fix LDS size calculation

2013-08-22 Thread Tom Stellard
From: Tom Stellard We need to include the number of LDS bytes allocated by the state tracker. --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b/src/gallium/drivers

Re: [Mesa-dev] PATCH: R600 + SI: Add support for lds atomic add

2013-08-22 Thread Tom Stellard
On Thu, Aug 22, 2013 at 10:03:56AM +0200, Michel Dänzer wrote: > On Mit, 2013-08-21 at 11:30 -0700, Tom Stellard wrote: > > > > The attached patches fix some LDS bugs on SI and add support for atomic > > add for R600 and SI. > > > > Please Review. > >

Re: [Mesa-dev] [PATCH] radeonsi/compute: Fix LDS size calculation

2013-08-22 Thread Tom Stellard
On Thu, Aug 22, 2013 at 05:42:34PM +0200, Michel Dänzer wrote: > On Don, 2013-08-22 at 11:25 -0400, Tom Stellard wrote: > > From: Tom Stellard > > > > We need to include the number of LDS bytes allocated by the state tracker. > > --- > > src/gallium/driver

Re: [Mesa-dev] [PATCH] [RFC] r600g: enable SB backend by default

2013-08-22 Thread Tom Stellard
On Thu, Aug 22, 2013 at 08:20:38PM +0400, Vadim Girlin wrote: > Signed-off-by: Vadim Girlin This is fine with me. Nice work! Reviewed-by: Tom Stellard > --- > src/gallium/drivers/r600/r600_asm.c| 3 ++- > src/gallium/drivers/r600/r600_pipe.c | 4 ++-- > src/galli

Re: [Mesa-dev] [PATCH 1/6] st/clover: Profiling support

2013-08-23 Thread Tom Stellard
On Fri, Aug 09, 2013 at 11:59:25AM +0200, Niels Ole Salscheider wrote: I've pushed the radeonsi patches, I think Francisco is still trying to review the clover patches. -Tom > Signed-off-by: Niels Ole Salscheider > --- > src/gallium/state_trackers/clover/api/event.cpp | 26 - > src/galli

Re: [Mesa-dev] [PATCH 2/2] r600g: texture buffer object + glsl 1.40 enable support

2012-12-19 Thread Tom Stellard
On Sun, Dec 16, 2012 at 08:33:23PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This adds TBO support to r600g, and with GLSL 1.40 enabled, > we now get 3.1 core profiles advertised for r600g. > > This code is evergreen only so far, but I don't think there is > much to make it work on r600/

Re: [Mesa-dev] [PATCH 2/2] r600g: texture buffer object + glsl 1.40 enable support

2012-12-19 Thread Tom Stellard
On Wed, Dec 19, 2012 at 02:07:22PM -0500, Jerome Glisse wrote: > On Wed, Dec 19, 2012 at 12:33 PM, Tom Stellard wrote: > > On Sun, Dec 16, 2012 at 08:33:23PM +1000, Dave Airlie wrote: > >> From: Dave Airlie > >> > >> This adds TBO support to r600g, and with GL

Re: [Mesa-dev] [PATCH] [RFC] R600: rework handling of the constants

2012-12-20 Thread Tom Stellard
On Thu, Dec 20, 2012 at 04:47:50PM +0400, Vadim Girlin wrote: > Remove Cxxx registers, add new special register - "ALU_CONST" and new > operand for each alu src - "sel". ALU_CONST is used to designate that the > new operand contains the value to override src.sel, src.kc_bank, src.chan > for constan

Re: [Mesa-dev] [PATCH] [RFC] r600g: rework handling of the constants

2012-12-20 Thread Tom Stellard
On Thu, Dec 20, 2012 at 04:47:51PM +0400, Vadim Girlin wrote: > Pack kc_bank, const_index and chan into the load.const operand, unpack > them in r600_alu_from_byte_stream and use to override sel, kc_bank and chan > for the constants. > > Expected operand value is (((512 + (kc_bank << 12) + const_i

Re: [Mesa-dev] [PATCH] r600g[WIP]: tgsi to llvm emits pointer to globaladdr load for constant buffer data

2012-12-20 Thread Tom Stellard
On Thu, Dec 20, 2012 at 07:37:27PM +0100, Vincent Lejeune wrote: > --- > src/gallium/drivers/r600/r600_llvm.c | 23 +-- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/src/gallium/drivers/r600/r600_llvm.c > b/src/gallium/drivers/r600/r600_llvm.c > index 2

Re: [Mesa-dev] [PATCH 1/2] r600g: rework handling of the constants

2012-12-31 Thread Tom Stellard
On Wed, Dec 26, 2012 at 05:38:27PM +0100, Vincent Lejeune wrote: > From Vadim Girlin patch > --- > src/gallium/drivers/r600/r600_llvm.c | 27 +++ > src/gallium/drivers/r600/r600_shader.c | 39 > -- > .../drivers/radeon/radeon_setup_tgsi_ll

Re: [Mesa-dev] r600g: RFC: ISA information tables and shader disassembler

2013-01-02 Thread Tom Stellard
activated with R600_DUMP_SHADERS=2. > > R600_DUMP_SHADERS=1 still uses old dump method, 3 - produces both > dumps for every shader. > This looks like a very nice improvement to me. Reviewed-by: Tom Stellard > Vadim > __

Re: [Mesa-dev] [PATCH 1/2] r600g: rework handling of the constants

2013-01-03 Thread Tom Stellard
On Tue, Jan 01, 2013 at 01:42:34AM +0400, Vadim Girlin wrote: > On 12/31/2012 10:39 PM, Vincent wrote: > >Le dimanche 30 décembre 2012 à 10:29 -0500, Tom Stellard a écrit : > >>On Wed, Dec 26, 2012 at 05:38:27PM +0100, Vincent Lejeune wrote: > >>> From Vadim Gi

Re: [Mesa-dev] [PATCH 1/4] R600: Factorise VTX_WORD0 and VTX_WORD1 in tblgen def

2013-01-03 Thread Tom Stellard
On Wed, Dec 26, 2012 at 05:37:18PM +0100, Vincent Lejeune wrote: > --- > lib/Target/AMDGPU/R600Instructions.td | 110 > -- > 1 file changed, 65 insertions(+), 45 deletions(-) > Reviewed-by: Tom Stellard > diff --git a/lib/Target/AMDGPU/R600In

Re: [Mesa-dev] [PATCH 3/4] R600: rework handling of the constants

2013-01-03 Thread Tom Stellard
tains the value to override src.sel, src.kc_bank, src.chan > for constants in the driver. > > v2[Vincent Lejeune]: > -Parse load const address space pointer semantic Just one coding style mistake I saw, otherwise: Reviewed-by: Tom Stellard > --- > lib/Target/AMDGPU/AMDGPU.h

Re: [Mesa-dev] [PATCH 2/4] R600: Add a CONST_ADDRESS node to model constant buf read

2013-01-03 Thread Tom Stellard
-) > Reviewed-by: Tom Stellard > diff --git a/lib/Target/AMDGPU/AMDGPUISelLowering.cpp > b/lib/Target/AMDGPU/AMDGPUISelLowering.cpp > index 910c2ff..df1a4d6 100644 > --- a/lib/Target/AMDGPU/AMDGPUISelLowering.cpp > +++ b/lib/Target/AMDGPU/AMDGPUISelLowering.cpp

Re: [Mesa-dev] [PATCH 4/4] R600: Fold CONST_ADDRESS when possible

2013-01-03 Thread Tom Stellard
On Wed, Dec 26, 2012 at 05:37:21PM +0100, Vincent Lejeune wrote: > --- > lib/Target/AMDGPU/AMDILISelDAGToDAG.cpp | 27 ++- > 1 file changed, 26 insertions(+), 1 deletion(-) > Reviewed-by: Tom Stellard > diff --git a/lib/Target/AMDGPU/AMDILISelDAGToD

[Mesa-dev] r600g/radeonsi LLVM dependencies for future Mesa releases

2013-01-04 Thread Tom Stellard
Hi, I have been getting a lot of questions lately about which LLVM tree to use for r600g and radeonsi, so I would like to give a summary of the current situation: ++ Plans for the next Mesa release 9.1 (it might also be called 10.0): The r600g and radeonsi drivers for this release will be compat

[Mesa-dev] [PATCH 1/2] drivers/radeon: Don't link against libgallium.la

2013-01-11 Thread Tom Stellard
From: Tom Stellard This fixes multiple symbol errors in pipe-loader --- src/gallium/drivers/radeon/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/Makefile.am b/src/gallium/drivers/radeon/Makefile.am index 091adc4..e6eb241 100644

[Mesa-dev] [PATCH 2/2] targets/opencl: Link against libgallium.la instead of libgallium.a

2013-01-11 Thread Tom Stellard
From: Tom Stellard --- src/gallium/targets/opencl/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/targets/opencl/Makefile.am b/src/gallium/targets/opencl/Makefile.am index 311363e..362d49d 100644 --- a/src/gallium/targets/opencl/Makefile.am +++ b/src

Re: [Mesa-dev] [PATCH] targets/*-r600: Add workaround for fixing multiple defined symbols

2013-01-11 Thread Tom Stellard
On Fri, Jan 11, 2013 at 03:38:48PM +, Andy Furniss wrote: > Andreas Boll wrote: > >Until we have jobermayr's shared libs patches, > >don't link libgallium.la twice. > > > >Fixes > >http://lists.freedesktop.org/archives/mesa-dev/2013-January/032515.html > > Thanks, I tested and it does fix buil

Re: [Mesa-dev] [PATCH] targets/*-r600: Add workaround for fixing multiple defined symbols

2013-01-11 Thread Tom Stellard
On Fri, Jan 11, 2013 at 09:05:23PM +, Andy Furniss wrote: > Tom Stellard wrote: > >On Fri, Jan 11, 2013 at 03:38:48PM +, Andy Furniss wrote: > >>Andreas Boll wrote: > >>>Until we have jobermayr's shared libs patches, > >>>don't

Re: [Mesa-dev] [PATCH 05/11] gallium/auxiliary: Build libgallium shared.

2013-01-12 Thread Tom Stellard
On Sat, Jan 12, 2013 at 11:34:04AM +0100, Johannes Obermayr wrote: > Am Samstag, 12. Januar 2013, 13:34:34 schrieb Chia-I Wu: > > On Sat, Jan 12, 2013 at 10:23 AM, Johannes Obermayr > > wrote: > > > diff --git a/src/gallium/auxiliary/Makefile.am > > > b/src/gallium/auxiliary/Makefile.am > > > ind

Re: [Mesa-dev] [PATCH 05/11] gallium/auxiliary: Build libgallium shared.

2013-01-12 Thread Tom Stellard
On Sat, Jan 12, 2013 at 10:04:16AM -0500, Tom Stellard wrote: > On Sat, Jan 12, 2013 at 11:34:04AM +0100, Johannes Obermayr wrote: > > Am Samstag, 12. Januar 2013, 13:34:34 schrieb Chia-I Wu: > > > On Sat, Jan 12, 2013 at 10:23 AM, Johannes Obermayr > > > wrote: >

Re: [Mesa-dev] [PATCH 10/11] radeon, clover: Make it compile on LLVM >= r171366.

2013-01-14 Thread Tom Stellard
On Sat, Jan 12, 2013 at 03:23:33AM +0100, Johannes Obermayr wrote: > --- > src/gallium/drivers/r600/Makefile.am |3 ++- > src/gallium/drivers/r600/llvm_wrapper.cpp |4 > src/gallium/drivers/radeon/radeon_llvm_emit.cpp | 10 -- > src/gallium

[Mesa-dev] [PATCH] Revert "targets/opencl: Link against libgallium.la instead of libgallium.a"

2013-01-14 Thread Tom Stellard
From: Tom Stellard This reverts commit 4148a29ed83d1d85bff3d4e40e847128011c3f20. This fixes bug: https://bugs.freedesktop.org/show_bug.cgi?id=59334 We really should be linking against libgallium.la instead of libgallium.a, but until we can figure why linking against libgallium.la causes

Re: [Mesa-dev] [PATCH] Revert "targets/opencl: Link against libgallium.la instead of libgallium.a"

2013-01-14 Thread Tom Stellard
On Mon, Jan 14, 2013 at 01:19:53PM -0600, Aaron Watry wrote: > > > >From: Tom Stellard ><http://lists.freedesktop.org/mailman/listinfo/mesa-dev>> > > > >This reverts commit 4148a29ed83d1d85bff3d4e40e847128011c3f20. > > > >This fixes bug:https://bugs

[Mesa-dev] [PATCH 1/3] configure.ac: Compute the required llvm static libraries only once

2013-01-18 Thread Tom Stellard
From: Tom Stellard In order to determine which static LLVM libraries are needed we pass a list of components to llvm-config and it generates the list of library dependencies for us. The advantage of only calling llvm-config one time is that it can determine if two components depend on the same

[Mesa-dev] [PATCH 2/3] configure.ac: Force use of LLVM shared libs with --enable-opencl

2013-01-18 Thread Tom Stellard
From: Tom Stellard If we build clover with LLVM static libraries, then clover and also each pipe_*.so driver that is built will contain their own static copy of LLVM. The recent automake changes have uncovered a problem where the pipe_*.so drivers try to use clover's LLVM symbols. This c

[Mesa-dev] [PATCH 3/3] Revert "Revert "targets/opencl: Link against libgallium.la instead of libgallium.a""

2013-01-18 Thread Tom Stellard
From: Tom Stellard This reverts commit 7824ab807050c03c6df01c44774914dcbef88248. Now that we force linking with LLVM shared libs when building clover, we can link against libgallium.la with no problems. --- src/gallium/auxiliary/Makefile.am | 6 -- src/gallium/targets/opencl

Re: [Mesa-dev] [PATCH 3/3] Revert "Revert "targets/opencl: Link against libgallium.la instead of libgallium.a""

2013-01-18 Thread Tom Stellard
te version of both Mesa and my LLVM tree: http://cgit.freedesktop.org/~tstellar/llvm/log/ The most recent commits to these trees depend on each other, so if you don't have the latest updates from both trees, nothing will work. -Tom > Cheers > > Mike > > > On 18 January 201

Re: [Mesa-dev] [PATCH 2/3] configure.ac: Force use of LLVM shared libs with --enable-opencl

2013-01-21 Thread Tom Stellard
On Mon, Jan 21, 2013 at 06:32:04PM +0100, Johannes Obermayr wrote: > Am Freitag, 18. Januar 2013, 17:58:27 schrieben Sie: > > From: Tom Stellard > > > > If we build clover with LLVM static libraries, then clover and also each > > pipe_*.so driver that is built will co

Re: [Mesa-dev] [PATCH 2/3] configure.ac: Force use of LLVM shared libs with --enable-opencl

2013-01-21 Thread Tom Stellard
On Mon, Jan 21, 2013 at 06:36:00PM +0100, Tom Stellard wrote: > On Mon, Jan 21, 2013 at 06:32:04PM +0100, Johannes Obermayr wrote: > > Am Freitag, 18. Januar 2013, 17:58:27 schrieben Sie: > > > From: Tom Stellard > > > > > > If we build clover with LLVM st

Re: [Mesa-dev] [PATCH] R600/SI: Add patterns for V_MAD(_LEGACY) instructions.

2013-01-21 Thread Tom Stellard
On Mon, Jan 21, 2013 at 04:40:47PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > I don't think we emit the int_AMDGPU_mul intrinsic anymore, but it probably doesn't hurt to keep it around until we sort out all of the legacy vs non-legacy instruction issues. Review

Re: [Mesa-dev] [PATCH 1/2] R600: Consider bitcast when folding const_address node.

2013-01-21 Thread Tom Stellard
On Mon, Jan 21, 2013 at 07:15:21PM +0100, Vincent Lejeune wrote: > --- > lib/Target/R600/AMDILISelDAGToDAG.cpp | 3 +++ > lib/Target/R600/R600ISelLowering.cpp | 6 ++ > 2 files changed, 9 insertions(+) > > diff --git a/lib/Target/R600/AMDILISelDAGToDAG.cpp > b/lib/Target/R600/AMDILISelDAGTo

Re: [Mesa-dev] [PATCH 2/2] R600: Fold clamp, neg, abs

2013-01-21 Thread Tom Stellard
On Mon, Jan 21, 2013 at 07:15:22PM +0100, Vincent Lejeune wrote: > --- > lib/Target/R600/AMDILISelDAGToDAG.cpp | 51 > --- > 1 file changed, 48 insertions(+), 3 deletions(-) > Reviewed-by: Tom Stellard > diff --git a/lib/Target/R600/AMDILISe

Re: [Mesa-dev] [PATCH] R600/SI: Add patterns for V_MAD(_LEGACY) instructions.

2013-01-22 Thread Tom Stellard
On Tue, Jan 22, 2013 at 04:06:05PM +0100, Michel Dänzer wrote: > On Mon, 2013-01-21 at 23:03 +0100, Tom Stellard wrote: > > > > I don't think we emit the int_AMDGPU_mul intrinsic anymore, but it probably > > doesn't hurt to keep it around until we sort out all o

Re: [Mesa-dev] [PATCH] radeon/llvm: Handle LP_CHAN_ALL in emit_fetch_immediate().

2013-01-22 Thread Tom Stellard
On Tue, Jan 22, 2013 at 06:33:37PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes piglit spec/ARB_sampler_objects/sampler-incomplete and > spec/EXT_texture_swizzle/depth_texture_mode_and_swizzle. > Reviewed-by: Tom Stellard > Signed-off-by: Michel Dänzer &g

Re: [Mesa-dev] [PATCH] R600/SI: Add patterns for fcos and fsin.

2013-01-22 Thread Tom Stellard
On Tue, Jan 22, 2013 at 08:14:42PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes 37 piglit tests and allows e.g. FlightGear to run with radeonsi. > Nice! Reviewed-by: Tom Stellard > Signed-off-by: Michel Dänzer > --- > lib/Target/R600/SIInstructions.td |

Re: [Mesa-dev] [PATCH 1/2] R600: handle loops to self in the structurizer v2

2013-01-22 Thread Tom Stellard
On Tue, Jan 22, 2013 at 09:33:46AM -0600, Aaron Watry wrote: > > Am 22.01.2013 13:08, schrieb Michel Dänzer: > >> On Mon, 2013-01-21 at 22:28 +0100, Christian König wrote: > >>> v2: don't mess up other loops > >>> > >>> Signed-off-by: Christian König > Series is > >> > Tested-by: Michel Dänze

[Mesa-dev] [PATCH 1/2] R600: Emit function name in the AsmPrinter

2013-01-22 Thread &quot;Tom Stellard
From: Tom Stellard Emitting the function name allows us to check for it in the FileCheck tests so we can make sure FileCheck is checking the output of the correct function. --- lib/Target/R600/AMDGPUAsmPrinter.cpp| 3 +++ test/CodeGen/R600/dagcombiner-bug-illegal-vec4

[Mesa-dev] [PATCH 2/2] R600: Add tests for instruction predicates

2013-01-22 Thread &quot;Tom Stellard
From: Tom Stellard --- test/CodeGen/R600/predicates.ll | 100 1 file changed, 100 insertions(+) create mode 100644 test/CodeGen/R600/predicates.ll diff --git a/test/CodeGen/R600/predicates.ll b/test/CodeGen/R600/predicates.ll new file mode 100644 index

[Mesa-dev] [PATCH 1/2] r600g: More robust checks for MOVA_INT instructions

2013-01-22 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/r600/r600_asm.c | 43 ++--- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c index 3aaea4a..809f85f 100644 --- a/src/gallium

[Mesa-dev] [PATCH 2/2] r600g: Add ar_chan member to struct r600_bytecode

2013-01-22 Thread Tom Stellard
From: Tom Stellard r600_bytecode::ar_chan stores the register channel for the value that will be loaded into the AR register. At the moment, this field is only used by the LLVM backend. The default backend always sets ar_chan = 0. --- src/gallium/drivers/r600/r600_asm.c| 2 ++ src/gallium

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: indirect array information

2013-01-22 Thread Tom Stellard
On Wed, Jan 23, 2013 at 02:20:21AM +0100, Christoph Bumiller wrote: > On 23.01.2013 02:07, Vadim Girlin wrote: > > On 01/23/2013 04:42 AM, Christoph Bumiller wrote: > >> On 23.01.2013 01:21, Vadim Girlin wrote: > >>> On 01/23/2013 03:59 AM, Vincent Lejeune wrote: > > > - Mail ori

Re: [Mesa-dev] [PATCH 1/2] R600: handle loops to self in the structurizer v2

2013-01-23 Thread Tom Stellard
On Mon, Jan 21, 2013 at 10:28:56PM +0100, Christian König wrote: > v2: don't mess up other loops > Hi Christian, This patch regresses the glsl1-do-loop test, this test worked fine with v1 of the patch, but the structurizer creates an infinite loop with v2. See attached LLVM IR. -Tom > Signed

Re: [Mesa-dev] [PATCH] R600: Consider bitcast when folding const_address node.

2013-01-23 Thread Tom Stellard
On Tue, Jan 22, 2013 at 10:19:14PM +0100, Vincent Lejeune wrote: Reviewed-by: Tom Stellard > --- > lib/Target/R600/AMDILISelDAGToDAG.cpp | 3 +++ > lib/Target/R600/R600ISelLowering.cpp | 8 > 2 files changed, 11 insertions(+) > > diff --git a/lib/Target/R600/AMD

Re: [Mesa-dev] [PATCH 1/2] R600: Fold remaining CONST_COPY after expand pseudo inst

2013-01-23 Thread Tom Stellard
On Wed, Jan 23, 2013 at 09:21:14PM +0100, Vincent Lejeune wrote: > v2:fix a bug with write masked inst I usually only version patches if I've already submitted a previous version to the mailiing list, so if you haven't submitted a version of this patch before you don't need this. If this is reall

Re: [Mesa-dev] [PATCH 2/2] R600: Do not fold vector inst

2013-01-23 Thread Tom Stellard
On Wed, Jan 23, 2013 at 09:23:03PM +0100, Vincent Lejeune wrote: > --- > lib/Target/R600/AMDILISelDAGToDAG.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Target/R600/AMDILISelDAGToDAG.cpp > b/lib/Target/R600/AMDILISelDAGToDAG.cpp > index 84223f6..2cc4724 100644

Re: [Mesa-dev] [PATCH] R600: improve inputs/interpolation handling

2013-01-23 Thread Tom Stellard
> Track liveness of special interpolation regs instead of reserving them - > this will allow to reuse those regs, lowering reg pressure. > > Signed-off-by: Vadim Girlin > > v2[Vincent Lejeune]: Rebased against current llvm master Reviewed-by: Tom Stellard > --- > lib/T

Re: [Mesa-dev] [PATCH] r600g: improve inputs/interpolation handling with llvm backend

2013-01-23 Thread Tom Stellard
rent master Reviewed-by: Tom Stellard > --- > src/gallium/drivers/r600/r600_llvm.c | 195 > +++ > src/gallium/drivers/r600/r600_shader.c | 159 - > src/gallium/drivers/r600/r600_shader.h | 3 +- > src/gallium/driver

Re: [Mesa-dev] [PATCH] R600: Do not fold vector inst

2013-01-24 Thread Tom Stellard
On Thu, Jan 24, 2013 at 01:15:19AM +0100, Vincent Lejeune wrote: Reviewed-by: Tom Stellard > --- > lib/Target/R600/AMDILISelDAGToDAG.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/Target/R600/AMDILISelDAGToDAG.cpp > b/lib/Target/R600/AMD

Re: [Mesa-dev] [PATCH] R600: Fold remaining CONST_COPY after expand pseudo inst

2013-01-24 Thread Tom Stellard
On Thu, Jan 24, 2013 at 01:16:35AM +0100, Vincent Lejeune wrote: > --- > lib/Target/R600/AMDGPUTargetMachine.cpp | 2 +- > lib/Target/R600/R600LowerConstCopy.cpp | 167 > +--- > 2 files changed, 157 insertions(+), 12 deletions(-) > > diff --git a/lib/Target/R600/AM

Re: [Mesa-dev] [PATCH] r600g/llvm: Fix for bug 59588 (llvm rv780 etqw gpu lock

2013-01-24 Thread Tom Stellard
Hi Vincent, For bug fixes, the Mesa convention is to use a normal commit message describing what the change does and then put a link to the bug at the end of the message. See for example: http://cgit.freedesktop.org/mesa/mesa/commit/?id=728bf86a23f6de137c0871ea87b09e75e55468a9 On Thu, Jan 24, 2

[Mesa-dev] [PATCH 1/2] r600g: Don't build llvm_wrapper.cpp when we aren't using LLVM

2013-01-25 Thread Tom Stellard
From: Tom Stellard We were using the NEED_RADEON_GALLIUM conditional to decide whether or not to build llvm_wrapper.cpp, which is required for using the LLVM backend. llvm_wrapper.cpp needs to be linked against the LLVM IPO libary and this library is only added to LLVM_LIBS if either opencl or

[Mesa-dev] [PATCH 2/2] configure.ac: Add components to LLVM_COMPONENTS when using llvm shared libs

2013-01-25 Thread Tom Stellard
From: Tom Stellard This is required when LLVM is built with CMake, which creates one shared library for each component. --- configure.ac | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index ccf95c5..90085de 100644 --- a

[Mesa-dev] [PATCH] configure.ac: Don't set LLVM_LIBS when llvm is disabled

2013-01-25 Thread Tom Stellard
From: Tom Stellard --- configure.ac | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/configure.ac b/configure.ac index ccf95c5..9cc5c4a 100644 --- a/configure.ac +++ b/configure.ac @@ -1898,21 +1898,23 @@ dnl by calling llvm-config --libs

[Mesa-dev] [PATCH] r600g: Handle SET*_DX10 instructions in r600_bytecode_get_num_operands()

2013-01-30 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/r600/r600_asm.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c index 1a501f6..f25c6aa 100644 --- a/src/gallium/drivers/r600/r600_asm.c +++ b/src

[Mesa-dev] [PATCH 1/3] R600: Fix assembly name for SETGT_INT

2013-01-30 Thread Tom Stellard
From: Tom Stellard --- lib/Target/R600/R600Instructions.td |2 +- test/CodeGen/R600/selectcc-icmp-select-float.ll |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Target/R600/R600Instructions.td b/lib/Target/R600/R600Instructions.td index 1080806

[Mesa-dev] [PATCH 2/3] R600: Add tests for unsupported condition codes.

2013-01-30 Thread Tom Stellard
From: Tom Stellard All of the le and lt variants are unsupported. --- test/CodeGen/R600/unsuported-cc.ll | 83 1 files changed, 83 insertions(+), 0 deletions(-) create mode 100644 test/CodeGen/R600/unsuported-cc.ll diff --git a/test/CodeGen/R600

[Mesa-dev] [PATCH 3/3] R600: Add support for SET*_DX10 instructions

2013-01-30 Thread Tom Stellard
From: Tom Stellard These instructions compare two floating point values and return an integer true (-1) or false (0) value. When compiling code generated by the Mesa GLSL frontend, the SET*_DX10 instructions save us four instructions for most branch decisions that use floating-point comparisons

Re: [Mesa-dev] [PATCH] configure.ac: Disable GLX if OpenGL is not enabled

2013-01-31 Thread Tom Stellard
On Thu, Jan 31, 2013 at 11:50:46AM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > GLX uses mapi/glapi/libglapi.la, which is only built for OpenGL. > This patch fixes https://bugs.freedesktop.org/show_bug.cgi?id=59364 Tested-by: Tom Stellard > Signed-off-by

[Mesa-dev] [PATCH 1/2] R600: Add an explicit default processor

2013-01-31 Thread Tom Stellard
From: Tom Stellard This is for the case when no processor is passed to the backend. This prevents the '' is not a recognized processor for this target (ignoring processor) warning from being generated by clang. --- lib/Target/R600/Processors.td |1 + 1 files changed, 1 insert

[Mesa-dev] [PATCH 2/2] R600: Fix 64-bit defines

2013-01-31 Thread Tom Stellard
From: Tom Stellard This fixes indirect addressing when on 32-bit systems. --- lib/Target/R600/AMDGPUInstrInfo.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Target/R600/AMDGPUInstrInfo.h b/lib/Target/R600/AMDGPUInstrInfo.h index bca3aa2..5220aa0 100644 --- a

[Mesa-dev] [PATCH] cl-program-tester: Fix parsing of vec16 types

2013-01-31 Thread Tom Stellard
From: Tom Stellard --- tests/cl/program/program-tester.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index 096cd2a..189b617 100644 --- a/tests/cl/program/program-tester.c +++ b/tests/cl

[Mesa-dev] R600 LLVM tree stablizing on Wednesday, Feb 6

2013-01-31 Thread Tom Stellard
Hi, On Wednesday, I will be stabilizing my LLVM tree in preparation for the Mesa 9.1 release. From that point on, I will only accept bug fixes for that tree. New feature development should be based off of the upstream LLVM SVN tree (If you don't like SVN you can use git svn, it works well for me

Re: [Mesa-dev] [PATCH 0/3] structurizer bugfixes

2013-02-01 Thread Tom Stellard
On Fri, Feb 01, 2013 at 04:05:51PM +0100, Christian König wrote: > Hi guys, > > I needed to rearrange the order of patches in this patchset, cause fixing one > bug lead to the discovery of a couple of other more nasty bugs. > > It now fixes four piglit tests with radeonsi and also survives the us

Re: [Mesa-dev] [PATCH 0/4] R600: SI sample intrinsic improvements

2013-02-04 Thread Tom Stellard
te sub register indices. > [PATCH 2/4] R600/SI: Add basic support for more integer vector > [PATCH 3/4] R600/SI: Make sample intrinsic address parameter type > [PATCH 4/4] R600/SI: Use proper instructions for array/shadow For the series: R

Re: [Mesa-dev] [PATCH 2/2] r300/compiler: copy-propagate saturate mode when possible

2013-02-04 Thread Tom Stellard
-by: Tom Stellard > .../drivers/r300/compiler/radeon_optimize.c| 21 > ++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/r300/compiler/radeon_optimize.c > b/src/gallium/drivers/r300/compiler/radeon_optim

Re: [Mesa-dev] [PATCH 1/4] R600: Use MULADD_IEEE instruction for mad pattern

2013-02-05 Thread Tom Stellard
On Sat, Feb 02, 2013 at 07:03:00PM +0100, Vincent Lejeune wrote: > --- Hi Vincent, Could you add a test case for this. Also, if the AMDGPUISD::MAD node isn't being used anymore, it should be removed. -Tom > lib/Target/R600/AMDGPUISelLowering.cpp | 6 +++--- > lib/Target/R600/AMDILISelLowering.

Re: [Mesa-dev] [PATCH 3/4] R600: Fold zero/one in export instructions

2013-02-05 Thread Tom Stellard
insertions(+), 79 deletions(-) Reviewed-by: Tom Stellard > > diff --git a/lib/Target/R600/R600ISelLowering.cpp > b/lib/Target/R600/R600ISelLowering.cpp > index 4dc6729..f796738 100644 > --- a/lib/Target/R600/R600ISelLowering.cpp > +++ b/lib/Target/R600/R600

Re: [Mesa-dev] [PATCH 2/4] R600: Do not fold modifier/litterals in vector inst

2013-02-05 Thread Tom Stellard
On Sat, Feb 02, 2013 at 07:03:01PM +0100, Vincent Lejeune wrote: > This fixes a couple of regressions on (probably not just) cayman > --- > lib/Target/R600/AMDILISelDAGToDAG.cpp | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Tom Stellard > >

Re: [Mesa-dev] [PATCH 4/4] R600: Export instructions are no longer terminator

2013-02-05 Thread Tom Stellard
On Sat, Feb 02, 2013 at 07:03:03PM +0100, Vincent Lejeune wrote: > This allows MachineInstScheduler to reorder them, and thus make scheduling > more > efficient. > --- > lib/Target/R600/R600Instructions.td | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewe

Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for flog2.

2013-02-05 Thread Tom Stellard
On Mon, Feb 04, 2013 at 04:04:25PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > 22 more little piglits with radeonsi. > Reviewed-by: Tom Stellard > Signed-off-by: Michel Dänzer > --- > lib/Target/R600/SIInstructions.td |4 +++- > 1 file changed, 3 i

Re: [Mesa-dev] [PATCH 1/2] R600/SI: add proper 64bit immediate support

2013-02-05 Thread Tom Stellard
On Mon, Feb 04, 2013 at 05:54:13PM +0100, Christian König wrote: > From: Christian König > Reviewed-by: Tom Stellard > Signed-off-by: Christian König > --- > lib/Target/R600/SIInstrInfo.td | 10 ++ > lib/Target/R600/SIInstructions.t

Re: [Mesa-dev] [PATCH 2/2] R600/SI: simplify and fix SMRD encoding

2013-02-05 Thread Tom Stellard
On Mon, Feb 04, 2013 at 05:54:14PM +0100, Christian König wrote: > From: Christian König > > The _SGPR variants where wrong. > *were* wrong. This looks good, it's nice to see so much of the c++ code disapear. Reviewed-by: Tom Stellard > Signed-off-by: Christian König

Re: [Mesa-dev] [PATCH 1/2] radeonsi: support constants as TEX coordinates

2013-02-05 Thread Tom Stellard
On Mon, Feb 04, 2013 at 05:56:32PM +0100, Christian König wrote: > From: Christian König > For both patches. Reviewed-by: Tom Stellard > Signed-off-by: Christian König > --- > src/gallium/drivers/radeonsi/radeonsi_shader.c |9 + > 1 file changed, 9 insertions(

Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for mul.

2013-02-05 Thread Tom Stellard
On Mon, Feb 04, 2013 at 07:14:22PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > 20 more little piglits with radeonsi. > Reviewed-by: Tom Stellard > Signed-off-by: Michel Dänzer > --- > lib/Target/R600/SIInstructions.td |4 > 1 file changed, 4 inser

Re: [Mesa-dev] [PATCH] R600/SI: Handle VGPR64 destination in copyPhysReg().

2013-02-05 Thread Tom Stellard
On Tue, Feb 05, 2013 at 09:03:47PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > Allows nexuiz to run with radeonsi. > Nice! Reviewed-by: Tom Stellard > Signed-off-by: Michel Dänzer > --- > lib/Target/R600/SIInstrInfo.cpp | 10 +- > 1 file cha

Re: [Mesa-dev] [PATCH] R600/SI: cleanup VGPR encoding

2013-02-06 Thread Tom Stellard
On Tue, Feb 05, 2013 at 11:16:05PM +0100, Christian König wrote: > From: Christian König > > Remove all the unused code. > Reviewed-by: Tom Stellard > Signed-off-by: Christian König > --- > lib/Target/R600/AMDGPUAsmPrinter.cpp |2 +- > lib/

<    1   2   3   4   5   6   7   8   9   10   >