Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Samuel Pitoiset
On 05/17/2017 08:06 PM, Ilia Mirkin wrote: On Wed, May 17, 2017 at 5:17 AM, Samuel Pitoiset wrote: @@ -695,6 +696,7 @@ struct tgsi_instruction_texture unsigned Texture : 8;/* TGSI_TEXTURE_ */ unsigned NumOffsets : 4; unsigned Padding : 20; +

Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Ilia Mirkin
On Wed, May 17, 2017 at 5:17 AM, Samuel Pitoiset wrote: > @@ -695,6 +696,7 @@ struct tgsi_instruction_texture > unsigned Texture : 8;/* TGSI_TEXTURE_ */ > unsigned NumOffsets : 4; > unsigned Padding : 20; > + unsigned ReturnType : 3; /*

Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Samuel Pitoiset
On 05/17/2017 06:02 PM, Roland Scheidegger wrote: Am 17.05.2017 um 11:17 schrieb Samuel Pitoiset: RadeonSI needs to do a special lowering for Gather4 with integer formats, but with bindless samplers we just can't access the index. Instead, store the return type in the instruction like the

Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Samuel Pitoiset
On 05/17/2017 02:21 PM, Samuel Pitoiset wrote: On 05/17/2017 02:02 PM, Nicolai Hähnle wrote: On 17.05.2017 11:17, Samuel Pitoiset wrote: RadeonSI needs to do a special lowering for Gather4 with integer formats, but with bindless samplers we just can't access the index. Instead, store the

Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Roland Scheidegger
Am 17.05.2017 um 11:17 schrieb Samuel Pitoiset: > RadeonSI needs to do a special lowering for Gather4 with integer > formats, but with bindless samplers we just can't access the index. > > Instead, store the return type in the instruction like the target. > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Samuel Pitoiset
On 05/17/2017 02:02 PM, Nicolai Hähnle wrote: On 17.05.2017 11:17, Samuel Pitoiset wrote: RadeonSI needs to do a special lowering for Gather4 with integer formats, but with bindless samplers we just can't access the index. Instead, store the return type in the instruction like the target.

Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Nicolai Hähnle
On 17.05.2017 11:17, Samuel Pitoiset wrote: RadeonSI needs to do a special lowering for Gather4 with integer formats, but with bindless samplers we just can't access the index. Instead, store the return type in the instruction like the target. Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Samuel Pitoiset
On 05/17/2017 12:28 PM, Nils Wallménius wrote: Hi Samuel, A comment below. Den 17 maj 2017 11:18 fm skrev "Samuel Pitoiset" >: RadeonSI needs to do a special lowering for Gather4 with integer formats, but with bindless

Re: [Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Nils Wallménius
Hi Samuel, A comment below. Den 17 maj 2017 11:18 fm skrev "Samuel Pitoiset" : RadeonSI needs to do a special lowering for Gather4 with integer formats, but with bindless samplers we just can't access the index. Instead, store the return type in the instruction

[Mesa-dev] [PATCH 2/3] tgsi: store the sampler view type directly in the instruction

2017-05-17 Thread Samuel Pitoiset
RadeonSI needs to do a special lowering for Gather4 with integer formats, but with bindless samplers we just can't access the index. Instead, store the return type in the instruction like the target. Signed-off-by: Samuel Pitoiset ---