Re: [Mesa-dev] [PATCH] i965: Don't use texture swizzling to force alpha to 1.0 if unnecessary.

2013-03-18 Thread Carl Worth
Kenneth Graunke writes: > This partially fixes a performance regression since commit 33599433c7. > More work is required to fully fix it in all cases. This at least helps > Warsow. Thanks, Ken. Reviewed-by: Carl Worth -Carl pgpEBf6hWs_2H.pgp Description: PGP signature __

Re: [Mesa-dev] [PATCH] i965: Don't use texture swizzling to force alpha to 1.0 if unnecessary.

2013-03-16 Thread Kenneth Graunke
On 03/16/2013 10:09 AM, Eric Anholt wrote: Kenneth Graunke writes: On 03/15/2013 04:54 PM, Eric Anholt wrote: Kenneth Graunke writes: Commit 33599433c7 began setting the texture swizzle mode to XYZ1 for RED, RG, and RGB textures in order to force alpha to 1.0 in case we actually stored the

Re: [Mesa-dev] [PATCH] i965: Don't use texture swizzling to force alpha to 1.0 if unnecessary.

2013-03-16 Thread Eric Anholt
Kenneth Graunke writes: > On 03/15/2013 04:54 PM, Eric Anholt wrote: >> Kenneth Graunke writes: >> >>> Commit 33599433c7 began setting the texture swizzle mode to XYZ1 for >>> RED, RG, and RGB textures in order to force alpha to 1.0 in case we >>> actually stored the texture as RGBA. >>> >>> Thi

Re: [Mesa-dev] [PATCH] i965: Don't use texture swizzling to force alpha to 1.0 if unnecessary.

2013-03-16 Thread Kenneth Graunke
On 03/15/2013 04:54 PM, Eric Anholt wrote: Kenneth Graunke writes: Commit 33599433c7 began setting the texture swizzle mode to XYZ1 for RED, RG, and RGB textures in order to force alpha to 1.0 in case we actually stored the texture as RGBA. This had a unforseen performance implication: the sh

Re: [Mesa-dev] [PATCH] i965: Don't use texture swizzling to force alpha to 1.0 if unnecessary.

2013-03-15 Thread Eric Anholt
Kenneth Graunke writes: > Commit 33599433c7 began setting the texture swizzle mode to XYZ1 for > RED, RG, and RGB textures in order to force alpha to 1.0 in case we > actually stored the texture as RGBA. > > This had a unforseen performance implication: the shader precompile > assumes that the te

Re: [Mesa-dev] [PATCH] i965: Don't use texture swizzling to force alpha to 1.0 if unnecessary.

2013-03-15 Thread Ian Romanick
On 03/15/2013 03:14 PM, Kenneth Graunke wrote: Commit 33599433c7 began setting the texture swizzle mode to XYZ1 for RED, RG, and RGB textures in order to force alpha to 1.0 in case we actually stored the texture as RGBA. This had a unforseen performance implication: the shader precompile assumes

[Mesa-dev] [PATCH] i965: Don't use texture swizzling to force alpha to 1.0 if unnecessary.

2013-03-15 Thread Kenneth Graunke
Commit 33599433c7 began setting the texture swizzle mode to XYZ1 for RED, RG, and RGB textures in order to force alpha to 1.0 in case we actually stored the texture as RGBA. This had a unforseen performance implication: the shader precompile assumes that the texture swizzle mode will be XYZW for n