Re: [Mesa-dev] [PATCH mesa] u_debug: do not compile asserts when they are disabled

2017-12-01 Thread Pekka Paalanen
On Thu, 30 Nov 2017 12:16:06 + Eric Engestrom wrote: > Commit f0ba7d897d1c22202531a added this code to expose asserts to the > compiler in an attempt to hide 'unused variable' warnings, incorrectly > claiming it was a no-op. This has two bad effects: > - any assert

Re: [Mesa-dev] [PATCH mesa] u_debug: do not compile asserts when they are disabled

2017-12-01 Thread Michel Dänzer
On 2017-11-30 01:16 PM, Eric Engestrom wrote: > Commit f0ba7d897d1c22202531a added this code to expose asserts to the > compiler in an attempt to hide 'unused variable' warnings, incorrectly > claiming it was a no-op. This has two bad effects: > - any assert with side-effects are executed when

Re: [Mesa-dev] [PATCH mesa] u_debug: do not compile asserts when they are disabled

2017-11-30 Thread Gert Wollny
There was actually some ping-pong about this issue: d885c9dad (Keith Whitwell) introduced it, 7a2271c65 (José Fonseca) removed it , and f0ba7d897 (Keith Whitwell) introduced it again. Given this I would give some preference to not to forward standard assert instead, but don't really see it

Re: [Mesa-dev] [PATCH mesa] u_debug: do not compile asserts when they are disabled

2017-11-30 Thread Eric Engestrom
On Thursday, 2017-11-30 12:16:06 +, Eric Engestrom wrote: > Commit f0ba7d897d1c22202531a added this code to expose asserts to the > compiler in an attempt to hide 'unused variable' warnings, incorrectly > claiming it was a no-op. This has two bad effects: > - any assert with side-effects are

[Mesa-dev] [PATCH mesa] u_debug: do not compile asserts when they are disabled

2017-11-30 Thread Eric Engestrom
Commit f0ba7d897d1c22202531a added this code to expose asserts to the compiler in an attempt to hide 'unused variable' warnings, incorrectly claiming it was a no-op. This has two bad effects: - any assert with side-effects are executed when they should be disabled - the whole content of the