[PATCH] www: remove "1\n" lines in $MSGID/t/ view

2022-09-29 Thread Eric Wong
Fixes: ab9c03ff4aa3 "www: use PerlIO::scalar (zfh) for buffering" --- lib/PublicInbox/View.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index 01c086bf..071a2093 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/

Re: [PATCH 0/4] CentOS 7 fixes + fix Gcf2 everywhere

2022-09-29 Thread Eric Wong
Konstantin Ryabitsev wrote: > On Thu, Sep 29, 2022 at 05:48:27PM +, Eric Wong wrote: > > A bunch of CentOS 7.x fixes noted by Konstantin > > I also just noticed I broke Gcf2 everywhere :x > > The tests pass now, thanks! > > I still noticed this error (master + this series): > > 1 at /ho

Re: [PATCH 0/4] CentOS 7 fixes + fix Gcf2 everywhere

2022-09-29 Thread Konstantin Ryabitsev
On Thu, Sep 29, 2022 at 05:48:27PM +, Eric Wong wrote: > A bunch of CentOS 7.x fixes noted by Konstantin > I also just noticed I broke Gcf2 everywhere :x The tests pass now, thanks! I still noticed this error (master + this series): 1 at /home/mricon/public-inbox/blib/lib/PublicInbox/Sys

Re: "make test" for 1.9.0 on centos-7

2022-09-29 Thread Eric Wong
Konstantin Ryabitsev wrote: > t/cmd_ipc.t .. 1/? sleeping on sendmsg: Too many > references: cannot splice (#1) > sleeping on sendmsg: Too many references: cannot splice (#2) > ... (repeats 49 times) ... > > t/cmd_ipc.t .. 24/? # sent 20971

[PATCH 3/4] gcf2: fix syntax error and require PublicInbox::Git

2022-09-29 Thread Eric Wong
I failed to notice these since I uninstalled libgit2 for benchmarking and kept it uninstalled since my git(1) install is faster. Fixes: 1c0ec857d041 "gcf2: support worktree $GIT_DIR" --- lib/PublicInbox/Gcf2.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/PublicIn

[PATCH 2/4] treewide: use --globoff with curl(1)

2022-09-29 Thread Eric Wong
curl 7.29.0 (on CentOS 7.x) seems to mishandle square-bracketed IPv6 addresses, at least. Furthermore, we don't actually need nor use the globbing in curl for lei when forwarding requests from the lei command-line. lei has its own globbing and `--globoff' behavior for externals and none of it is

[PATCH 4/4] tests: no IPv6 on old Net::NNTP, Mail::IMAPClient, HTTP::Tiny

2022-09-29 Thread Eric Wong
The versions of these modules which ship with CentOS 7.x did not support IPv6 properly. --- lib/PublicInbox/TestCommon.pm | 9 + t/extsearch.t | 4 ++-- t/nntpd.t | 3 +-- t/v2writable.t| 2 +- 4 files changed, 13 insertions(+), 5 deletio

[PATCH 1/4] syscall: initialize buffer for vec()

2022-09-29 Thread Eric Wong
This is needed for older Perls (tested perl 5.16.3 on CentOS 7). --- lib/PublicInbox/Syscall.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Syscall.pm b/lib/PublicInbox/Syscall.pm index 46496bca..412ca64f 100644 --- a/lib/PublicInbox/Syscall.pm +++ b/lib/Pub

[PATCH 0/4] CentOS 7 fixes + fix Gcf2 everywhere

2022-09-29 Thread Eric Wong
A bunch of CentOS 7.x fixes noted by Konstantin I also just noticed I broke Gcf2 everywhere :x I'd much rather support old enterprise distros directly than direct people towards bloated Docker containers and what-not. Eric Wong (4): syscall: initialize buffer for vec() treewide: use --globoff